6953477: review request for portability improvements to Hotspot

Kelly O'Hair kelly.ohair at oracle.com
Wed Jul 28 08:52:53 PDT 2010


Just did a very quick scan.

Something doesn't look right with the INTX_FORMAT, _UFM, and _DFM uses.
Macros will not be expanded inside string literals, and these macros  
are string literals.

Files agent/src/os/linux/ps_proc.c and src/os/linux/vm/os_linux.cpp

-kto

On Jul 28, 2010, at 7:40 AM, Bob Vandette wrote:

> Here are a set of changes that we're planning on pushing into the  
> openjdk hotspot repository.
>
> http://cr.openjdk.java.net/~bobv/6953477/webrev.00/
>
> They include:
>
> 1. Cross Compilation improvements
> 2. Shared code changes for ARM and PPC
> 3. Software floating point support
> 4. Improvements to the hotspot crash log
>
> There are a few areas that could use additional factoring but these  
> will be done under a seperate
> CR.
>
>
> Bob Vandette
> Oracle
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100728/27444581/attachment.html 


More information about the hotspot-dev mailing list