6953477: review request for portability improvements to Hotspot

[Tom Rodriguez]

INTX_FORMAT isn't available in the SA anyway so it won't compile if you fix it.  As is the changes break the code so they clearly aren't necessary, so can they be dropped?  Same with the os_linux.cpp changes with UFM.

tom

On Jul 28, 2010, at 9:13 AM, Bob Vandette wrote:

> Thanks for catching that Kelly.
> 
> On Jul 28, 2010, at 11:52 AM, Kelly O'Hair wrote:
> 
>> Just did a very quick scan.
>> 
>> Something doesn't look right with the INTX_FORMAT, _UFM, and _DFM uses.
>> Macros will not be expanded inside string literals, and these macros are string literals.
>> 
>> Files agent/src/os/linux/ps_proc.c and src/os/linux/vm/os_linux.cpp
>> 
>> -kto
>> 
>> On Jul 28, 2010, at 7:40 AM, Bob Vandette wrote:
>> 
>>> Here are a set of changes that we're planning on pushing into the openjdk hotspot repository.
>>> 
>>> http://cr.openjdk.java.net/~bobv/6953477/webrev.00/
>>> 
>>> They include:
>>> 
>>> 1. Cross Compilation improvements
>>> 2. Shared code changes for ARM and PPC
>>> 3. Software floating point support
>>> 4. Improvements to the hotspot crash log
>>> 
>>> There are a few areas that could use additional factoring but these will be done under a seperate
>>> CR.
>>> 
>>> 
>>> Bob Vandette
>>> Oracle
>>> 
>> 
>