Please review changes in hotspot source code

Christian Thalinger Christian.Thalinger at Sun.COM
Fri Mar 12 04:53:22 PST 2010


On Fri, 2010-03-12 at 13:48 +0100, Christian Thalinger wrote:
> On Fri, 2010-03-12 at 12:14 +0000, Andrew John Hughes wrote:
> > On 12 March 2010 11:07, Pavel Tisnovsky <ptisnovs at redhat.com> wrote:
> > > Hi,
> > >
> > > please review changes in hotspot source code. Webrev is available at:
> > > http://cr.openjdk.java.net/~ptisnovs/Gcc4.5Errors2/
> > >
> > > These are minor changes fixing compile failure when -Wall -Werror flags are
> > > used under gcc 4.5. In this case error message is "suggest parentheses
> > > around ...something..."
> > >
> > > Thanks in advance
> > > Pavel Tisnovsky
> > >
> > 
> > HotSpot changes should go to the HotSpot list as I mentioned on the last patch.
> 
> I created:
> 
> 6934483: GCC 4.5 errors "suggest parentheses around something..." when
> compiling with -Werror and -Wall
> 
> And the changes look good.

I forgot to ask, what HotSpot version is this patch against?  Does
current HS18, with this patch applied, build with GCC 4.5?

-- Christian



More information about the hotspot-dev mailing list