Request for approval: 6929067: Stack guard pages should be removed when thread is detached

[daniel.daugherty at oracle.com]

On 3/12/2010 12:35 PM, Coleen Phillimore wrote:
>
> Hi,
> I checked this into the hotspot-rt repository.  I thought I made aph 
> the author but the job came through with my name on it.

Since your user ID submitted the job, I'm pretty sure JPRT ignored
your "Author" setting. I recommend setting the "Contributed by" field
to aph at redhat.com for future submissions...

> It also has me as a reviewer, which I thought that jcheck would flag.

You had a second reviewer so "self review" is permitted...


> I don't know how to fix this, but I am willing to if someone tells me 
> how.

I don't think you can fix this. It is not as easy to tweak meta-data
in Mercurial as it is in Teamware...

Dan


>
> Coleen
>
> Andrew Haley wrote:
>> On 03/11/2010 09:06 PM, Coleen Phillimore wrote:
>>  
>>> I've added the test to the changeset and a script to run in our 
>>> harness.
>>>
>>> Also in os_linux.cpp, I changed the SYS_gettid call to go through our
>>> os::Linux::gettid() because on at least one linux, syscall() returns a
>>> long int which gets a compilation warning with %d.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/6929067/
>>> bug link at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6929067
>>>
>>> Andrew, please have a look since you're the contributor.
>>>     
>>
>> That's OK, but you don't need SYS_gettid.
>> Please look at 
>> http://cr.openjdk.java.net/~aph/6929067-jdk7-webrev-4/hotspot.patch
>> I changed to "/proc/self/maps", as you requested.  I think this is 
>> better.
>>
>> The copy of my webrev to cr.openjdk.java.net failed for some reason
>> I don't understand.
>>
>> Apologies,
>> Andrew.
>>   
>

-- 
Dan

Oracle <http://www.oracle.com>
Daniel Daugherty | Software Engineer
Phone: +17194811796 <tel:+17194811796> | Mobile: +17192375807 
<tel:+17192375807>
Oracle Java Serviceability
| Monument, Colorado 80132
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment