Please review 6938627: Make temporary directory use property java.io.tmpdir when specified
Coleen Phillimore
Coleen.Phillimore at Sun.COM
Sat Mar 27 11:05:23 PDT 2010
Sorry, I rushed out the review and skipped a step and didn't build on
linux. Thanks for catching this.
Coleen
David Schlosnagle wrote:
> Coleen,
>
> There seems to be a couple issues on line 469 of src/os/linux/vm/attachListener_linux.cpp:
> - It seems like there should be a slash in the format string to match the Solaris version.
> - The call to os::get_temp_directory() appears to be missing the 'y' at the end.
>
> src/os/linux/vm/attachListener_linux.cpp:
> 469 sprintf(fn, "%s.attach_pid%d", os::get_temp_director(),
> ^ ^^
> 470 os::current_process_id());
>
> src/os/solaris/vm/attachListener_solaris.cpp:
> 600 sprintf(fn, "%s/.attach_pid%d", os::get_temp_directory(),
> ^ ^^
> 601 os::current_process_id());
>
> Thanks,
> Dave
>
>
> On Mar 26, 2010, at 6:11 PM, Coleen Phillimore wrote:
>
>
>> Summary: Get java.io.tmpdir property in os::get_temp_directory() and call this instead of harcoding "/tmp". Don't assume trailing file_separator either.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/6938627/
>> bug link at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6938627
>>
>> Thanks,
>> Coleen
>>
>
>
More information about the hotspot-dev
mailing list