hs16 and hs17 differences

[Vladimir Kozlov]

 > In the hs17 master, there seems to be something odd going on.  The
 > version has been bumped to b14 (but not tagged) and this changeset has
 > been added:
 >
 > http://hg.openjdk.java.net/hsx/hsx17/master/rev/9d9e74a1628e
 >
 > which changes this code again.  Should we be include this fix?  For
 > now, I've only merged to the last tag (hs17-b13).

Yes, it is an other bug 6948602 and you need this fix.

Vladimir

On 5/16/10 8:56 AM, Andrew John Hughes wrote:
> On 14 May 2010 16:57, Vladimir Kozlov<vladimir.kozlov at oracle.com>  wrote:
>> HS17 has different (full) implementation of the fix (array pointer instead
>> of object pointer is passed to intrinsics).
>> The next changeset fixed it and an other bug:
>>
>> http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/62001a362ce9
>>
>> 6827605: new String intrinsics may prevent EA scalar replacement
>> 6875866: Intrinsic for String.indexOf() is broken on x86 with SSE4.2
>>
>> Vladimir
>>
>> Andrew John Hughes wrote:
>>>
>>> I've noticed a difference between the hs16 and hs17 (b13) master trees:
>>>
>>> 6827605: new String intrinsics may prevent EA scalar replacement
>>> Summary: don't use SSE42 string indexOf intrinsic if it is called for
>>> new object which could be scalar replaced.
>>> Reviewed-by: never
>>> http://hg.openjdk.java.net/hsx/hsx16/master/rev/e502d7524e3a
>>>
>>> is only in hs16 but not hs17.  Was this deliberate and is this fix no
>>> longer needed?
>>>
>>
>
> Ok, both those are in the merged OpenJDK6 repository.
>
> In the hs17 master, there seems to be something odd going on.  The
> version has been bumped to b14 (but not tagged) and this changeset has
> been added:
>
> http://hg.openjdk.java.net/hsx/hsx17/master/rev/9d9e74a1628e
>
> which changes this code again.  Should we be include this fix?  For
> now, I've only merged to the last tag (hs17-b13).