Request for review(XS): 6996136: VM crash in src/share/vm/runtime/virtualspace.cpp:424

[John Coomes]

Vladimir Kozlov (vladimir.kozlov at oracle.com) wrote:
> Looks good.

I agree--much better than the existing code.

-John

> Igor Veresov wrote:
> > I decided that it would be more fair to display an error message and 
> > bail out.
> > 
> > Here is the updated webrev with changes due to all reviews:
> > http://cr.openjdk.java.net/~iveresov/6996136/webrev.01/
> > 
> > igor
> > 
> > On 10/29/10 3:27 PM, Vladimir Kozlov wrote:
> >> Igor,
> >>
> >> Could you consolidate code which set UseCompressedOops in one separate
> >> method?
> >> Also we should print warning id user specified COOP:
> >>
> >> if (UseCompressedOops && FLAG_IS_CMDLINE(UseCompressedOops)) {
> >> warning("Can not use Compressed Oops with shared spaces");
> >> FLAG_SET_DEFAULT(UseCompressedOops, false);
> >> }
> >>
> >> Thanks,
> >> Vladimir
> >>
> >> Igor Veresov wrote:
> >>> Turn CDS off if compressed oops are used. Also move the checking code
> >>> after set_ergonomic_flags().
> >>>
> >>> Webrev: http://cr.openjdk.java.net/~iveresov/6996136/webrev.00/
> >>>
> >>> igor
> >