Request for review (XL) 6990754: Use native memory and reference counting to implement SymbolTable

[David Holmes]

On 5/11/2010 10:43 AM, Coleen Phillimore wrote:
> 6964458: Reimplement class meta-data storage to use native memory
> http://bugs.sun.com/view_bug.do?bug_id=6964468

FYI there is a typo in this URL, it should be

http://bugs.sun.com/view_bug.do?bug_id=6964458

David

> 6990754: Use native memory and reference counting to implement SymbolTable
> http://bugs.sun.com/view_bug.do?bug_id=6990754
>
> I've had 3 detailed code reviews and contribution from internal team members
> never, acorn, jmasa and apangin. If you are part of the openjdk java vm
> community we especially want to hear your comments and review. This is a
> very large change.
>
> The major changes are in the symbolTable.hpp and symbol.hpp. These files
> should be read FIRST. symbolOop has been replaced with Symbol* in many of
> the source files. Symbol* is now a reference counted type contained in the
> SymbolTable. Symbol* is no longer an oop and it is not in the Java heap. The
> symbolHandle uses are no longer applicable.
>
> Webrev:
> http://cr.openjdk.java.net/~coleenp/6990754_3/
>
> You can either send your comments to me directly or the whole email list. I
> am not going to be working Friday or this weekend but will carefully address
> all comments next week.
>
> Thanks,
> Coleen