review (S) for 6970683: improvements to hs_err output

Tom Rodriguez tom.rodriguez at oracle.com
Thu Oct 7 13:12:51 PDT 2010


http://cr.openjdk.java.net/~never/6970683

6970683: improvements to hs_err output
Reviewed-by:

There are a few things missing from the hs_err dump that would be
useful.  First we don't dump the sparc L and I registers.  Second some
information about the size and contents of the code cache would be
useful.  Third we should dump a larger region around the faulting
instruction.  Additionally the new register to memory mapping output
can crash which stops us from getting the stack and instructions at
the faulting pc, so I moved it into it's own section.  block_start
would assert in some cases so I augmented existing logic to just
return null.  I also changed the formatting to remove all the extra
whitespace and made some of the output more compact and eliminated
most of the useless whitespace.


More information about the hotspot-dev mailing list