review (S) for 6970683: improvements to hs_err output

[Tom Rodriguez]

On Oct 8, 2010, at 9:03 AM, Coleen Phillimore wrote:

> This change looks good to me.  I missed when print_location() was added for the registers, but it does a lot of things that we used to consider unsafe from the error handler.  And I didn't like all the white space. I wonder if you should check for Universe::is_initialized() in vmError before calling this?
> 
> Can you attach an "after" version of hs_err?  I guess I can get one of my own pretty easily after you check this in, but I'd like to see one first.

I forgot to send these out last week.  I put hs_errs from x86/sparc vs. 32/64 in http://cr.openjdk.java.net/~never/6970683/hse.

tom


> 
> Lastly, what sort of problems can you diagnose from the code cache bounds?
> 
> Thanks,
> Coleen
> 
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6970683
>> 
>> 6970683: improvements to hs_err output
>> Reviewed-by:
>> 
>> There are a few things missing from the hs_err dump that would be
>> useful.  First we don't dump the sparc L and I registers.  Second some
>> information about the size and contents of the code cache would be
>> useful.  Third we should dump a larger region around the faulting
>> instruction.  Additionally the new register to memory mapping output
>> can crash which stops us from getting the stack and instructions at
>> the faulting pc, so I moved it into it's own section.  block_start
>> would assert in some cases so I augmented existing logic to just
>> return null.  I also changed the formatting to remove all the extra
>> whitespace and made some of the output more compact and eliminated
>> most of the useless whitespace.
>>