[patch] fix hotspot build with small SC_ARG_MAX

[Daniel D. Daugherty]

On 9/2/2010 10:40 AM, Kelly O'Hair wrote:
>
> On Sep 2, 2010, at 1:06 AM, Matthias Klose wrote:
>
>> On 01.09.2010 20:58, Kelly O'Hair wrote:
>>> Looks fine, although I really hate all these $(QUIETLY) uses.
>>>
>>> Why would the "rm" in the clean rule not be quiet, but all these 
>>> critical build
>>> lines be quiet?
>>
>> I don't like quiet makes either, but I didn't want to change 
>> unrelated things in the patch. If the $(QUIETLY) rm is needed for 
>> consistencey, fine with me.
>
> It's ok, I'd rather leave it 'as is' than add more $(QUIETLY) uses.  I 
> was just making a point about
> quiet usage.  ;^)

Point made and understood!


>
> The changes looks fine.

Thanks! And thanks for the re-review!

Dan


>
> -kto
>
>>
>>> The RE and others have a hard time tracking down build failures when 
>>> the rules
>>> are quiet,
>>> makes the build logs less than useful.
>>>
>>> -kto
>>>
>>> On Sep 1, 2010, at 10:55 AM, Daniel D. Daugherty wrote:
>>>
>>>> I'm finally getting back to this thread. Since I'm also applying
>>>> Matthias' changes to the Solaris sa.makefile, I figured I would
>>>> send out a webrev:
>>>>
>>>> http://cr.openjdk.java.net/~dcubed/6561870-webrev/0/
>>>>
>>>> Kelly and Christian, can I get re-reviews from the two of you?
>>>>
>>>> Matthias, can you verify that I got the Solaris port of your
>>>> changes correct?
>>
>> this looks ok to me.
>>
>>>> Thanks, in advance, for any reviews...
>>>>
>>>> Dan
>>>>
>>>>
>>>> On 8/25/2010 10:22 AM, Daniel D. Daugherty wrote:
>>>>> On 8/25/2010 10:11 AM, Christian Thalinger wrote:
>>>>>> On Wed, 2010-08-25 at 10:00 -0600, Daniel D. Daugherty wrote:
>>>>>>
>>>>>>> Thanks for the reviews Kelly and Christian.
>>>>>>>
>>>>>>> Is there a reason to not apply these changes to the solaris and
>>>>>>> windows versions also? I haven't looked yet, but I figured I
>>>>>>> would ask...
>>>>>>>
>>>>>>
>>>>>> Yeah, I also thought about this for Solaris and it should work 
>>>>>> there as
>>>>>> on Linux. Don't know about Windows, though.
>>>>>>
>>>>>
>>>>> Looks like Windows already uses a "make" construct instead of running
>>>>> into the shell command line limitation:
>>>>>
>>>>>> $(GENERATED)\sa-jdi.jar: $(AGENT_FILES1:/=\) $(AGENT_FILES2:/=\)
>>>>> <snip>
>>>>>
>>>>>> @$(COMPILE_JAVAC) -source 1.4 -target 1.4 -classpath 
>>>>>> $(SA_CLASSPATH) -so
>>>>>> urcepath $(AGENT_SRC_DIR) -d $(SA_CLASSDIR) $(AGENT_FILES1:/=\)
>>>>>> @$(COMPILE_JAVAC) -source 1.4 -target 1.4 -classpath 
>>>>>> $(SA_CLASSPATH) -so
>>>>>> urcepath $(AGENT_SRC_DIR) -d $(SA_CLASSDIR) $(AGENT_FILES2:/=\)
>>>>>
>>>>> I also think this is an "nmake" Makefile instead of a GNU Makefile.
>>>>> I think I'll look at applying the changes to the Solaris Makefile and
>>>>> leave the Windows stuff alone :-)
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>>
>>>
>>
>