Review request 6981484: Update development launcher

[Staffan Larsen]

Christian,

The hardcoded ARCH should of course not be there, but rather it needs to be replaced (at build time) with the LIBARCH value. Will fix. Well spotted.

Since this launcher is based on similar code in JRockit, I choose the name "fusion". "Gamma" was already taken :-)

Thanks,
/Staffan

-----Original Message-----
From: Christian Thalinger 
Sent: den 20 september 2010 2:18
To: Staffan Larsen
Cc: hotspot-dev at openjdk.java.net
Subject: Re: Review request 6981484: Update development launcher

On Thu, 2010-09-16 at 11:47 -0700, Staffan Larsen wrote:
> http://cr.openjdk.java.net/~sla/6981484/webrev.00/
> 
> Update the development launcher (gamma) to 
>   1) not require env.sh to be sourced before launching
>   2) not require the current working directory to be the build directory
>   3) exist on windows platforms as well
>   4) support launching a debugger with -gdb/-gud (linux) or -dbx (solaris)
> 
> A few notes about the implementation:
> - I did not change the current gamma launcher, but chose to add a new "frontend" to it called "fusion". This is a script that sets up the necessary environment. This was to avoid changing something that works.
> - The launcher should really share code across platforms instead of being in os/<os>/launcher, but I wanted to keep the changes small.
> - The launcher code for Windows is a copy of the launcher found in 6u22 with changes (#ifndef GAMMA)

Just two comments:

1. Using a hardcoded ARCH in the launcher.script doesn't seem to be very
useful.

2. Why did you choose the name fusion (just to be part of history and to
be able to answer future questions :-)?

-- Christian