Review request 6981484: Update development launcher

[Coleen Phillimore]

Hi Staffan,
Is this file *src/os/windows/launcher/java.c**
*the same as ./os/linux/launcher/java.c and ./os/solaris/launcher/java.c
In fact, the sources in os/linux/launcher are almost exactly the same as 
os/solaris/launcher.
Can we have just one set?  Perhaps put it in directory 
src/share/tools/launcher and make the makefiles use these sources 
instead? Sorry to make more work but having the same 2000 lines of code 
somewhere else, guarantees one copy will always be wrong.

Thanks,
Coleen

On 09/22/10 08:38, Staffan Larsen wrote:
> Here we go again: http://cr.openjdk.java.net/~sla/6981484/webrev.03/
>
> Eventually, I'll get there...
>
> Thanks,
> /Staffan
>
> -----Original Message-----
> From: Christian Thalinger 
> Sent: den 22 september 2010 2:38
> To: Staffan Larsen
> Cc: hotspot-dev at openjdk.java.net
> Subject: RE: Review request 6981484: Update development launcher
>
> On Wed, 2010-09-22 at 05:23 -0700, Staffan Larsen wrote:
>   
>> Thanks Christian - I obviously have some things to learn as a new
>> committer - didn't think about the copyrights :-)
>>     
>
> Sure.  I was going the same route :-)
>
>   
>> http://cr.openjdk.java.net/~sla/6981484/webrev.02/
>>
>> Now with updated copyrights.
>>     
>
> As David already said.
>
> -- Christian
>
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100922/35f27161/attachment.html