review for 7082263: Reflection::resolve_field/field_get/field_set are broken

[Tom Rodriguez]

On Aug 25, 2011, at 9:32 PM, Vladimir Kozlov wrote:

> Looks good.
> 
> Why jsr292 methods were under #ifdef SUPPORT_OLD_REFLECTION in these files?

Do you mean JVM_DefineClassWithCP in jvm.h?  It wasn't under the ifdef but since it was neither defined nor exported I went ahead and deleted it.

Thanks!

tom

> 
> Thanks,
> Vladimir
> 
> On 8/25/11 8:35 PM, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/7082263
>> 1023 lines changed: 0 ins; 1017 del; 6 mod; 10236 unchg
>> 
>> 7082263: Reflection::resolve_field/field_get/field_set are broken
>> Reviewed-by:
>> 
>> The static field mirror changes missed some dead code in reflection.
>> Instead of fixing it I'm deleting it.  I've deleted all the reflection
>> code that's dead.  I confirmed that none of these JVM_ entry points
>> are referenced by any JDK since 1.5.  They also aren't mentioned by
>> the jvm.h in the JDK.  Tested with JPRT.
>>