review for 7082263: Reflection::resolve_field/field_get/field_set are broken

Tom Rodriguez tom.rodriguez at oracle.com
Fri Aug 26 07:39:58 PDT 2011


On Aug 26, 2011, at 12:54 AM, Stefan Karlsson wrote:

> Looks good.
> 
> If you want to, you could collapse this ifdef in make/solaris/makefiles/product.make:
> # Linker mapfiles
> ifdef USE_GCC
> MAPFILE = $(GAMMADIR)/make/solaris/makefiles/mapfile-vers
> else
> MAPFILE = $(GAMMADIR)/make/solaris/makefiles/mapfile-vers

Fixed.  Thanks!

tom


> 
> StefanK
> 
> On 08/26/2011 05:35 AM, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/7082263
>> 1023 lines changed: 0 ins; 1017 del; 6 mod; 10236 unchg
>> 
>> 7082263: Reflection::resolve_field/field_get/field_set are broken
>> Reviewed-by:
>> 
>> The static field mirror changes missed some dead code in reflection.
>> Instead of fixing it I'm deleting it.  I've deleted all the reflection
>> code that's dead.  I confirmed that none of these JVM_ entry points
>> are referenced by any JDK since 1.5.  They also aren't mentioned by
>> the jvm.h in the JDK.  Tested with JPRT.
>> 
> 



More information about the hotspot-dev mailing list