review for 7082263: Reflection::resolve_field/field_get/field_set are broken

[Tom Rodriguez]

On Aug 26, 2011, at 7:41 AM, Tom Rodriguez wrote:

> 
> On Aug 25, 2011, at 9:26 PM, David Holmes wrote:
> 
>> Hi Tom,
>> 
>> On 26/08/2011 1:35 PM, Tom Rodriguez wrote:
>>> http://cr.openjdk.java.net/~never/7082263
>>> 1023 lines changed: 0 ins; 1017 del; 6 mod; 10236 unchg
>>> 
>>> 7082263: Reflection::resolve_field/field_get/field_set are broken
>>> Reviewed-by:
>>> 
>>> The static field mirror changes missed some dead code in reflection.
>>> Instead of fixing it I'm deleting it.  I've deleted all the reflection
>>> code that's dead.  I confirmed that none of these JVM_ entry points
>>> are referenced by any JDK since 1.5.  They also aren't mentioned by
>>> the jvm.h in the JDK.  Tested with JPRT.
>> 
>> Seems the "old reflection" code is partly still the current reflection code! :)
> 
> Yes.  For quite a long time too.
> 
>> 
>> But the deletion looks good. Only thing I'd suggest is to run the jdk reflection tests in addition to JPRT testing.
> 
> I'll run them for completeness but these functions are mentioned neither by the sources nor the binaries so I think it's clear they dead.

They all passed.

tom

> 
> Thanks.
> 
> tom
> 
>> 
>> David
>> 
>