From volker.simonis at gmail.com Tue Feb 1 01:27:01 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 1 Feb 2011 10:27:01 +0100 Subject: Building HotSpot JVM In-Reply-To: References: Message-ID: Read the error message: /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/hotspot/agent/src/share/classes/sun/jvm/hotspot/debugger/win32/coff/COFFFileParser.java:333: error while writing sun.jvm.hotspot.debugger.win32.coff.COFFFileParser.COFFFileImpl.COFFHeaderImpl.OptionalHeaderWindowsSpecificFieldsImpl: /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/saclasses/sun/jvm/hotspot/debugger/win32/coff/COFFFileParser$COFFFileImpl$COFFHeaderImpl$OptionalHeaderWindowsSpecificFieldsImpl.class (Operation not permitted) Perhaps your file system is full or for some other reason the file "/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/saclasses/sun/jvm/hotspot/debugger/win32/coff/COFFFileParser$COFFFileImpl$COFFHeaderImpl$OptionalHeaderWindowsSpecificFieldsImpl.class" can not be written. You can use 'ALT_OUTPUTDIR= gmake' to build into another output direcotry. Regards, Volker On Tue, Feb 1, 2011 at 4:23 AM, Islam Atta wrote: > Hi all, > I'm a PhD student at UofT and I might be working on analysis of Java > programs using HotSpot JVM. I'm new to the OpenJDK and was trying to build > out the repository. Unfortuneatly I'm getting several errors, I've solved a > couple but now stuck! BTW I'm not a Linux or gcc expert. The command I used > to build is gmake "ALLOW_DOWNLOADS=true". Part of the build error is below: > gmake[6]: Entering directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > ../generated/adfiles/adlc -DLINUX -D_GNU_SOURCE -DIA32 -q -T -g -U_LP64 > ../generated/adfiles/linux_x86_32.ad ?\ > ?-c../generated/adfiles/mktmp342/ad_x86_32.cpp > -h../generated/adfiles/mktmp342/ad_x86_32.hpp > -a../generated/adfiles/mktmp342/dfa_x86_32.cpp > -v../generated/adfiles/mktmp342/adGlobals_x86_32.hpp \ > ? ?|| { rm -rf ../generated/adfiles/mktmp342; exit 1; } > ./adlc_updater ad_x86_32.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32.hpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32_clone.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32_expand.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32_format.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32_gen.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32_misc.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32_peephole.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater ad_x86_32_pipeline.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater adGlobals_x86_32.hpp ../generated/adfiles/mktmp342 > ../generated/adfiles > ./adlc_updater dfa_x86_32.cpp ../generated/adfiles/mktmp342 > ../generated/adfiles > [ -f ../generated/adfiles/mktmp342/made-change ] \ > || echo "Rescanned ../generated/adfiles/linux_x86_32.ad ?but encountered no > changes." > Rescanned ../generated/adfiles/linux_x86_32.ad ?but encountered no changes. > rm -rf ../generated/adfiles/mktmp342 > gmake[6]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > gmake[6]: Entering directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > gmake[6]: Nothing to be done for `all'. > gmake[6]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > gmake[6]: Entering directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > if [ -d > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/hotspot/agent -a > "x86" != "ia64" \ > ?? ? ? ? ? ? -a "x86" != "arm" \ > ?? ? ? ? ? ? -a "x86" != "ppc" \ > ?? ? ? ? ? ? -a "x86" != "zero" ] ; then \ > ? gmake -f sa.make > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/sa-jdi.jar; > \ > fi > gmake[7]: Entering directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > echo "Making > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/sa-jdi.jar" > Making > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/sa-jdi.jar > if [ "/usr/lib/jvm/java-openjdk" = "" ]; then \ > ?echo "ALT_BOOTDIR, BOOTDIR or JAVA_HOME needs to be defined to build SA"; \ > ?exit 1; \ > fi > if [ ! -f /usr/lib/jvm/java-openjdk/lib/tools.jar -a ! -d > /usr/lib/jvm/java-openjdk/lib/modules ] ; then \ > ?echo "Missing /usr/lib/jvm/java-openjdk/lib/tools.jar file. Use 1.6.0 or > later version of JDK";\ > ?echo ""; \ > ?exit 1; \ > fi > if [ ! -d > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/saclasses > ] ; then \ > ?mkdir -p > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/saclasses; > ? ? ? ?\ > fi > /usr/lib/jvm/java-openjdk/bin/javac -g -encoding ascii -source 6 -target 6 > -source 1.4 -target 1.4 -classpath /usr/lib/jvm/java-openjdk/lib/tools.jar > -sourcepath > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/hotspot/agent/src/share/classes > -d > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/saclasses > @/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/agent1.classes.list > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/hotspot/agent/src/share/classes/sun/jvm/hotspot/debugger/win32/coff/COFFFileParser.java:333: > error while writing > sun.jvm.hotspot.debugger.win32.coff.COFFFileParser.COFFFileImpl.COFFHeaderImpl.OptionalHeaderWindowsSpecificFieldsImpl: > /media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/saclasses/sun/jvm/hotspot/debugger/win32/coff/COFFFileParser$COFFFileImpl$COFFHeaderImpl$OptionalHeaderWindowsSpecificFieldsImpl.class > (Operation not permitted) > ?? ? ?class OptionalHeaderWindowsSpecificFieldsImpl implements > OptionalHeaderWindowsSpecificFields { > ?? ? ?^ > 1 error > gmake[7]: *** > [/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product/../generated/sa-jdi.jar] > Error 1 > gmake[7]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > gmake[6]: *** [all] Error 2 > gmake[6]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > gmake[5]: *** [sa_stuff] Error 2 > gmake[5]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir/linux_i486_compiler2/product' > gmake[4]: *** [product] Error 2 > gmake[4]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/build/linux-i586/hotspot/outputdir' > gmake[3]: *** [generic_build2] Error 2 > gmake[3]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/hotspot/make' > gmake[2]: *** [product] Error 2 > gmake[2]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk/hotspot/make' > gmake[1]: *** [hotspot-build] Error 2 > gmake[1]: Leaving directory > `/media/sf_UofT/Research/Tools_Benchmarks/openJDK/openjdk' > gmake: *** [build_product_image] Error 2 > > -- > Best regards, > Islam Atta, M.Sc., B.Sc. > Ph.D. student > The Edward S. Rogers Sr. department of Electrical & Computer Engineering > Faculty of Applied Science & Engineering > University of Toronto > Tel: +1 (647) 779-1186 > Email: islam.atta at utoronto.ca > From erik.trimble at oracle.com Tue Feb 1 19:25:49 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Wed, 02 Feb 2011 03:25:49 +0000 Subject: hg: hsx/hsx20/baseline: 3 new changesets Message-ID: <20110202032559.3F89A47337@hg.openjdk.java.net> Changeset: 907c1aed0f8c Author: cl Date: 2011-01-27 17:28 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/907c1aed0f8c Added tag jdk7-b127 for changeset 102466e70deb ! .hgtags Changeset: 9a5762f44859 Author: trims Date: 2011-02-01 18:57 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/9a5762f44859 Merge ! .hgtags - src/share/vm/gc_implementation/g1/concurrentZFThread.cpp - src/share/vm/gc_implementation/g1/concurrentZFThread.hpp Changeset: 2e85cdf72570 Author: trims Date: 2011-02-01 19:25 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/2e85cdf72570 Merge ! .hgtags From dmytro_sheyko at hotmail.com Wed Feb 2 01:34:48 2011 From: dmytro_sheyko at hotmail.com (Dmytro Sheyko) Date: Wed, 2 Feb 2011 16:34:48 +0700 Subject: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value In-Reply-To: References: Message-ID: Hi, Any updates on it? I don't want to be overly importunate, but the quite trivial fix was available year ago. Maybe I do something wrong, so please suggest what I should do to have this bug fixed. Thanks, Dmytro From: dmytro_sheyko at hotmail.com To: serviceability-dev at openjdk.java.net Subject: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value Date: Fri, 28 Jan 2011 15:05:45 +0700 Hi, I would like to find sponsor and discuss fix for bug#6853676 OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6853676 The idea is to use GlobalMemoryStatusEx instead of GlobalMemoryStatus. patch is available here: https://bugs.openjdk.java.net/show_bug.cgi?id=100077 Thanks, Dmytro -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110202/ff8b914c/attachment.html From David.Holmes at oracle.com Wed Feb 2 01:47:07 2011 From: David.Holmes at oracle.com (David Holmes) Date: Wed, 02 Feb 2011 19:47:07 +1000 Subject: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value In-Reply-To: References: Message-ID: <4D49281B.3020809@oracle.com> Dmytro, It looks like this was actually fixed under 6840305 back in July 2009: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8c79517a9300 This CR was not updated however. Does the problem still exist? David Holmes Dmytro Sheyko said the following on 02/02/11 19:34: > Hi, > > Any updates on it? > > I don't want to be overly importunate, but the quite trivial fix was > available year ago. > Maybe I do something wrong, so please suggest what I should do to have > this bug fixed. > > Thanks, > Dmytro > > ------------------------------------------------------------------------ > From: dmytro_sheyko at hotmail.com > To: serviceability-dev at openjdk.java.net > Subject: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has > incorrect value > Date: Fri, 28 Jan 2011 15:05:45 +0700 > > Hi, > > I would like to find sponsor and discuss fix for bug#6853676 > OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6853676 > > The idea is to use GlobalMemoryStatusEx instead of GlobalMemoryStatus. > > patch is available here: > https://bugs.openjdk.java.net/show_bug.cgi?id=100077 > > Thanks, > Dmytro > From Alan.Bateman at oracle.com Wed Feb 2 02:05:34 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 02 Feb 2011 10:05:34 +0000 Subject: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value In-Reply-To: <4D49281B.3020809@oracle.com> References: <4D49281B.3020809@oracle.com> Message-ID: <4D492C6E.4060308@oracle.com> David Holmes wrote: > Dmytro, > > It looks like this was actually fixed under 6840305 back in July 2009: > > http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8c79517a9300 > > This CR was not updated however. > > Does the problem still exist? > > David Holmes I think this is separate and 6853676 is about com.sun.management.OperatingSystemMXBean. The code for that is in jdk repo in src/windows/native/com/sun/management. It should be using GlobalMemoryStatusEx rather than GlobalMemoryStatus. Dmytro - to your question, serviceability-dev is the right place to bring it. -Alan From David.Holmes at oracle.com Wed Feb 2 02:09:59 2011 From: David.Holmes at oracle.com (David Holmes) Date: Wed, 02 Feb 2011 20:09:59 +1000 Subject: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value In-Reply-To: <4D492C6E.4060308@oracle.com> References: <4D49281B.3020809@oracle.com> <4D492C6E.4060308@oracle.com> Message-ID: <4D492D77.5070209@oracle.com> Alan Bateman said the following on 02/02/11 20:05: > David Holmes wrote: >> It looks like this was actually fixed under 6840305 back in July 2009: >> >> http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8c79517a9300 >> >> This CR was not updated however. >> >> Does the problem still exist? >> >> David Holmes > I think this is separate and 6853676 is about > com.sun.management.OperatingSystemMXBean. The code for that is in jdk > repo in src/windows/native/com/sun/management. It should be using > GlobalMemoryStatusEx rather than GlobalMemoryStatus. Thanks Alan, the comments in 6853676 led me astray. As a P4 it looks like this has just slipped through the cracks. David > Dmytro - to your question, serviceability-dev is the right place to > bring it. > > -Alan From vladimir.kozlov at oracle.com Thu Feb 3 16:05:13 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 03 Feb 2011 16:05:13 -0800 Subject: Request for reviews (M): 7017124: VM statistic use 32-bit values which may overflow Message-ID: <4D4B42B9.4050605@oracle.com> I am investigating native memory usage with EA and saw these problems. http://cr.openjdk.java.net/~kvn/7017124/webrev Fixed 7017124: VM statistic use 32-bit values which may overflow During long enough time (tens minutes) on modern processors some VM statistic 32-bit values overflow. We need to use longs. And when a value is long we still have a problem since it is incremented not atomically in 32-bit VM. Added new Atomic method inc_counter() to increment long values, it is not precise on MP (lock is not used) but it is fine. Fixed several output formats to use VM FORMAT macros. I have to remove v9 check assert from Atomic_move_long() since it is called before VM_Version is initialized and C2 is built for v9 only anyway. Removed unused Chunk::clean_chunk_pool(). I fixed only statistic which was interesting to me. From David.Holmes at oracle.com Thu Feb 3 18:07:59 2011 From: David.Holmes at oracle.com (David Holmes) Date: Fri, 04 Feb 2011 12:07:59 +1000 Subject: Request for reviews (M): 7017124: VM statistic use 32-bit values which may overflow In-Reply-To: <4D4B42B9.4050605@oracle.com> References: <4D4B42B9.4050605@oracle.com> Message-ID: <4D4B5F7F.5030601@oracle.com> Vladimir Kozlov said the following on 02/04/11 10:05: > Added new Atomic method inc_counter() to increment long values, > it is not precise on MP (lock is not used) but it is fine. I strongly disagree! At least it has no place being in the Atomic:: set of functions as it is not atomic. It is not even monotonic! It is extremely deceptive to do this. By all means change to julong where needed, but unless they are truly going to be atomic updates (I understand the overhead makes that prohibitive) then leave them as simply x+=i; statements. > Fixed several output formats to use VM FORMAT macros. > > I have to remove v9 check assert from Atomic_move_long() since > it is called before VM_Version is initialized and C2 is built > for v9 only anyway. > > Removed unused Chunk::clean_chunk_pool(). Used by CI. > I fixed only statistic which was interesting to me. So the CR is misleading. It purports to deal with 32-bit stat overflows but in fact only deals with some stats, and primarily you are using this to define PrintMallocStat - so the CR should reflect that: "Fix some VM stats to avoid 32-bit overflow" globals.hpp: + "print malloc/free statictics") \ Typo: statictics src/share/vm/opto/phase.cpp This change seems unrelated to the CR. David ----- From vladimir.kozlov at oracle.com Thu Feb 3 18:17:18 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 03 Feb 2011 18:17:18 -0800 Subject: Request for reviews (M): 7017124: VM statistic use 32-bit values which may overflow In-Reply-To: <4D4B5F7F.5030601@oracle.com> References: <4D4B42B9.4050605@oracle.com> <4D4B5F7F.5030601@oracle.com> Message-ID: <4D4B61AE.30009@oracle.com> David Holmes wrote: > Vladimir Kozlov said the following on 02/04/11 10:05: >> Added new Atomic method inc_counter() to increment long values, >> it is not precise on MP (lock is not used) but it is fine. > > I strongly disagree! At least it has no place being in the Atomic:: set > of functions as it is not atomic. It is not even monotonic! It is It is atomic since it loads and stores all 64 bits of julong atomically. Why we can call atomic methods Atomic::load() and Atomic::store() which are used by new method but not this method? And it is monotonic since value in memory only grows. > extremely deceptive to do this. By all means change to julong where > needed, but unless they are truly going to be atomic updates (I > understand the overhead makes that prohibitive) then leave them as > simply x+=i; statements. > >> Fixed several output formats to use VM FORMAT macros. >> >> I have to remove v9 check assert from Atomic_move_long() since >> it is called before VM_Version is initialized and C2 is built >> for v9 only anyway. >> >> Removed unused Chunk::clean_chunk_pool(). > > Used by CI. Restored. >> I fixed only statistic which was interesting to me. > > So the CR is misleading. It purports to deal with 32-bit stat overflows > but in fact only deals with some stats, and primarily you are using this > to define PrintMallocStat - so the CR should reflect that: "Fix some VM > stats to avoid 32-bit overflow" OK. > globals.hpp: > > + "print malloc/free statictics") \ > > Typo: statictics Fixed. > src/share/vm/opto/phase.cpp > > This change seems unrelated to the CR. I removed it from these changes. Thanks, Vladimir > > David > ----- From vladimir.kozlov at oracle.com Thu Feb 3 18:28:39 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 03 Feb 2011 18:28:39 -0800 Subject: Request for reviews (M): 7017124: VM statistic use 32-bit values which may overflow In-Reply-To: <4D4B61AE.30009@oracle.com> References: <4D4B42B9.4050605@oracle.com> <4D4B5F7F.5030601@oracle.com> <4D4B61AE.30009@oracle.com> Message-ID: <4D4B6457.6080604@oracle.com> Vladimir Kozlov wrote: > David Holmes wrote: >> Vladimir Kozlov said the following on 02/04/11 10:05: >>> Added new Atomic method inc_counter() to increment long values, >>> it is not precise on MP (lock is not used) but it is fine. >> >> I strongly disagree! At least it has no place being in the Atomic:: >> set of functions as it is not atomic. It is not even monotonic! It is > > It is atomic since it loads and stores all 64 bits of julong atomically. > Why we can call atomic methods Atomic::load() and Atomic::store() > which are used by new method but not this method? > And it is monotonic since value in memory only grows. OK, I am taking monotonic statement back. Yes, the value may decrease if a thread loads value before other threads but stores it after other threads already updated it. But I still want to use atomic load and store since otherwise the value will be garbage. Vladimir > >> extremely deceptive to do this. By all means change to julong where >> needed, but unless they are truly going to be atomic updates (I >> understand the overhead makes that prohibitive) then leave them as >> simply x+=i; statements. >> >>> Fixed several output formats to use VM FORMAT macros. >>> >>> I have to remove v9 check assert from Atomic_move_long() since >>> it is called before VM_Version is initialized and C2 is built >>> for v9 only anyway. >>> >>> Removed unused Chunk::clean_chunk_pool(). >> >> Used by CI. > > Restored. > >>> I fixed only statistic which was interesting to me. >> >> So the CR is misleading. It purports to deal with 32-bit stat >> overflows but in fact only deals with some stats, and primarily you >> are using this to define PrintMallocStat - so the CR should reflect >> that: "Fix some VM stats to avoid 32-bit overflow" > > OK. > >> globals.hpp: >> >> + "print malloc/free statictics") \ >> >> Typo: statictics > > Fixed. > >> src/share/vm/opto/phase.cpp >> >> This change seems unrelated to the CR. > > I removed it from these changes. > > Thanks, > Vladimir > >> >> David >> ----- > From David.Holmes at oracle.com Thu Feb 3 18:34:35 2011 From: David.Holmes at oracle.com (David Holmes) Date: Fri, 04 Feb 2011 12:34:35 +1000 Subject: Request for reviews (M): 7017124: VM statistic use 32-bit values which may overflow In-Reply-To: <4D4B61AE.30009@oracle.com> References: <4D4B42B9.4050605@oracle.com> <4D4B5F7F.5030601@oracle.com> <4D4B61AE.30009@oracle.com> Message-ID: <4D4B65BB.2050201@oracle.com> Vladimir Kozlov said the following on 02/04/11 12:17: > David Holmes wrote: >> Vladimir Kozlov said the following on 02/04/11 10:05: >>> Added new Atomic method inc_counter() to increment long values, >>> it is not precise on MP (lock is not used) but it is fine. >> >> I strongly disagree! At least it has no place being in the Atomic:: >> set of functions as it is not atomic. It is not even monotonic! It is > > It is atomic since it loads and stores all 64 bits of julong atomically. It is not atomic because it does not update the value atomically: value += add_value; Not atomic. > Why we can call atomic methods Atomic::load() and Atomic::store() > which are used by new method but not this method? Atomic::load and Atomic::store are required/expected to be atomic. > And it is monotonic since value in memory only grows. It should be monotonic but you need atomic updates for that to be true. A counter can be updated by multiple threads simultaneously and that can cause updates to appear out of order and hence the value can be seen to decrease. David ----- >> extremely deceptive to do this. By all means change to julong where >> needed, but unless they are truly going to be atomic updates (I >> understand the overhead makes that prohibitive) then leave them as >> simply x+=i; statements. >> >>> Fixed several output formats to use VM FORMAT macros. >>> >>> I have to remove v9 check assert from Atomic_move_long() since >>> it is called before VM_Version is initialized and C2 is built >>> for v9 only anyway. >>> >>> Removed unused Chunk::clean_chunk_pool(). >> >> Used by CI. > > Restored. > >>> I fixed only statistic which was interesting to me. >> >> So the CR is misleading. It purports to deal with 32-bit stat >> overflows but in fact only deals with some stats, and primarily you >> are using this to define PrintMallocStat - so the CR should reflect >> that: "Fix some VM stats to avoid 32-bit overflow" > > OK. > >> globals.hpp: >> >> + "print malloc/free statictics") \ >> >> Typo: statictics > > Fixed. > >> src/share/vm/opto/phase.cpp >> >> This change seems unrelated to the CR. > > I removed it from these changes. > > Thanks, > Vladimir > >> >> David >> ----- > From David.Holmes at oracle.com Thu Feb 3 18:37:10 2011 From: David.Holmes at oracle.com (David Holmes) Date: Fri, 04 Feb 2011 12:37:10 +1000 Subject: Request for reviews (M): 7017124: VM statistic use 32-bit values which may overflow In-Reply-To: <4D4B6457.6080604@oracle.com> References: <4D4B42B9.4050605@oracle.com> <4D4B5F7F.5030601@oracle.com> <4D4B61AE.30009@oracle.com> <4D4B6457.6080604@oracle.com> Message-ID: <4D4B6656.6090809@oracle.com> Vladimir Kozlov said the following on 02/04/11 12:28: > Vladimir Kozlov wrote: >> David Holmes wrote: >>> Vladimir Kozlov said the following on 02/04/11 10:05: >>>> Added new Atomic method inc_counter() to increment long values, >>>> it is not precise on MP (lock is not used) but it is fine. >>> >>> I strongly disagree! At least it has no place being in the Atomic:: >>> set of functions as it is not atomic. It is not even monotonic! It is >> >> It is atomic since it loads and stores all 64 bits of julong atomically. >> Why we can call atomic methods Atomic::load() and Atomic::store() >> which are used by new method but not this method? >> And it is monotonic since value in memory only grows. > > OK, I am taking monotonic statement back. Yes, the value may decrease > if a thread loads value before other threads but stores it after other > threads already updated it. But I still want to use atomic load and store > since otherwise the value will be garbage. I totally agree that you want the functionality of inc_counter, with atomic load and store, but that function is not itself atomic and so does not belong in the Atomic class. David > Vladimir > >> >>> extremely deceptive to do this. By all means change to julong where >>> needed, but unless they are truly going to be atomic updates (I >>> understand the overhead makes that prohibitive) then leave them as >>> simply x+=i; statements. >>> >>>> Fixed several output formats to use VM FORMAT macros. >>>> >>>> I have to remove v9 check assert from Atomic_move_long() since >>>> it is called before VM_Version is initialized and C2 is built >>>> for v9 only anyway. >>>> >>>> Removed unused Chunk::clean_chunk_pool(). >>> >>> Used by CI. >> >> Restored. >> >>>> I fixed only statistic which was interesting to me. >>> >>> So the CR is misleading. It purports to deal with 32-bit stat >>> overflows but in fact only deals with some stats, and primarily you >>> are using this to define PrintMallocStat - so the CR should reflect >>> that: "Fix some VM stats to avoid 32-bit overflow" >> >> OK. >> >>> globals.hpp: >>> >>> + "print malloc/free statictics") \ >>> >>> Typo: statictics >> >> Fixed. >> >>> src/share/vm/opto/phase.cpp >>> >>> This change seems unrelated to the CR. >> >> I removed it from these changes. >> >> Thanks, >> Vladimir >> >>> >>> David >>> ----- >> From vladimir.kozlov at oracle.com Thu Feb 3 18:36:33 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 03 Feb 2011 18:36:33 -0800 Subject: Request for reviews (M): 7017124: VM statistic use 32-bit values which may overflow In-Reply-To: <4D4B6656.6090809@oracle.com> References: <4D4B42B9.4050605@oracle.com> <4D4B5F7F.5030601@oracle.com> <4D4B61AE.30009@oracle.com> <4D4B6457.6080604@oracle.com> <4D4B6656.6090809@oracle.com> Message-ID: <4D4B6631.20501@oracle.com> David Holmes wrote: > Vladimir Kozlov said the following on 02/04/11 12:28: >> OK, I am taking monotonic statement back. Yes, the value may decrease >> if a thread loads value before other threads but stores it after other >> threads already updated it. But I still want to use atomic load and store >> since otherwise the value will be garbage. > > I totally agree that you want the functionality of inc_counter, with > atomic load and store, but that function is not itself atomic and so > does not belong in the Atomic class. OK. I will move it to other place. Vladimir From vladimir.kozlov at oracle.com Thu Feb 3 19:39:12 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 03 Feb 2011 19:39:12 -0800 Subject: Update: Request for reviews (M): 7017124: Fix some VM stats to avoid 32-bit overflow Message-ID: <4D4B74E0.7040907@oracle.com> Update after reviews. Renamed method and moved it outside Atomic class since it is not atomic. http://cr.openjdk.java.net/~kvn/7017124/webrev.01 Fixed 7017124: Fix some VM stats to avoid 32-bit overflow During long enough time (tens minutes) on modern processors some VM statistic 32-bit values overflow. We need to use longs. And when a value is long we still have a problem since it is incremented not atomically in 32-bit VM. Added new method inc_stat_counter() to increment long statistic values and use atomic long load and store. Fixed several output formats to use FORMAT macros. I have to remove v9 check assert from Atomic_move_long() since it is called before VM_Version is initialized and C2 is built for v9 only anyway. I fixed only statistic which was interesting to me. From john.coomes at oracle.com Thu Feb 3 20:33:17 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:33:17 +0000 Subject: hg: jdk7/hotspot: 11 new changesets Message-ID: <20110204043317.D0A48473D6@hg.openjdk.java.net> Changeset: f722c246ce71 Author: mchung Date: 2011-01-20 22:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/f722c246ce71 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/Makefile Changeset: 65e6601596e2 Author: lana Date: 2011-01-24 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/65e6601596e2 Merge Changeset: 61f181d43d9a Author: lana Date: 2011-01-28 10:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/61f181d43d9a Merge Changeset: 6db0e6f221bd Author: ohair Date: 2011-01-05 17:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/6db0e6f221bd 7009969: Remove SKIP_OPENJDK_BUILD from top Makefile Reviewed-by: robilad ! Makefile ! make/Defs-internal.gmk Changeset: 49c463695059 Author: ohair Date: 2011-01-10 10:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/49c463695059 Merge Changeset: 6d9bbcc0a8cb Author: ohair Date: 2011-01-13 17:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/6d9bbcc0a8cb Merge Changeset: 24900a58ab9f Author: ohair Date: 2011-01-14 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/24900a58ab9f 6950375: Remove msvcrt.dll from the Windows JRE bundles Reviewed-by: prr ! Makefile ! README-builds.html Changeset: 3a9f19cbf7f1 Author: ohair Date: 2011-01-26 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/3a9f19cbf7f1 Merge Changeset: a7a4f6db294d Author: ohair Date: 2011-01-27 18:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/a7a4f6db294d Merge Changeset: 57d702105b23 Author: ohair Date: 2011-02-02 09:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/57d702105b23 Merge Changeset: 904d7c7c44d9 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/904d7c7c44d9 Added tag jdk7-b128 for changeset 57d702105b23 ! .hgtags From john.coomes at oracle.com Thu Feb 3 20:33:24 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:33:24 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b128 for changeset 9baa8f94a11d Message-ID: <20110204043328.83559473D7@hg.openjdk.java.net> Changeset: 3ff9acc7cc06 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/3ff9acc7cc06 Added tag jdk7-b128 for changeset 9baa8f94a11d ! .hgtags From john.coomes at oracle.com Thu Feb 3 20:33:35 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:33:35 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b128 for changeset a42c6132c746 Message-ID: <20110204043335.66634473D8@hg.openjdk.java.net> Changeset: f5b60c5a310f Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/f5b60c5a310f Added tag jdk7-b128 for changeset a42c6132c746 ! .hgtags From john.coomes at oracle.com Thu Feb 3 20:33:42 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:33:42 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b128 for changeset 88d74afc5593 Message-ID: <20110204043342.25906473D9@hg.openjdk.java.net> Changeset: 0f7b39ad9024 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/0f7b39ad9024 Added tag jdk7-b128 for changeset 88d74afc5593 ! .hgtags From john.coomes at oracle.com Thu Feb 3 20:36:13 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:36:13 +0000 Subject: hg: jdk7/hotspot/jdk: 92 new changesets Message-ID: <20110204045146.8988C473DF@hg.openjdk.java.net> Changeset: 63f5c7704faa Author: prr Date: 2011-01-12 15:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/63f5c7704faa 6958221: java.awt.Font.getFamily() leads to JVM crash on Linux on JDK7 for "custom" fonts Reviewed-by: igor, jgodinez ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/headless/mapfile-vers ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11FontManager.java ! src/solaris/classes/sun/awt/motif/MToolkit.java ! src/solaris/native/sun/awt/fontpath.c + test/java/awt/FontClass/X11FontPathCrashTest.java Changeset: 5aae8b3162d0 Author: prr Date: 2011-01-13 10:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5aae8b3162d0 7001056: JDK 7 fails on to build on Solaris 10 update 9 - updated Xrender header files Reviewed-by: igor, jgodinez ! make/sun/xawt/Makefile ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 76b8fa7fd229 Author: prr Date: 2011-01-13 12:08 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/76b8fa7fd229 7012269: mapfile for headless awt needs getFontPathNative defined Reviewed-by: igor ! make/sun/headless/mapfile-vers Changeset: 9f3f38c150b5 Author: prr Date: 2011-01-13 14:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9f3f38c150b5 6917884: NPE in sun.font.FcFontConfiguration.getPlatformFontNames Reviewed-by: igor, jgodinez ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: 987aeabbfda3 Author: prr Date: 2011-01-14 11:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/987aeabbfda3 6951086: Excessive Local References in sun.font.SunLayoutEngine.nativeLayout Reviewed-by: igor, jgodinez ! src/share/native/sun/font/FontInstanceAdapter.cpp Changeset: 646c3cf1ba37 Author: prr Date: 2011-01-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/646c3cf1ba37 6989370: Windows platform fonts may be incorrectly marked as ineligible for the native rasteriser Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/SunFontManager.java ! src/windows/classes/sun/awt/Win32FontManager.java Changeset: 5cb6bb816a34 Author: prr Date: 2011-01-14 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5cb6bb816a34 6925760: Scaled graphics can cause overlapped LCD mode strings on Windows for pixel size > 48 Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/FileFontStrike.java + test/java/awt/FontClass/LCDScale.java Changeset: 8b33567d68b0 Author: jgodinez Date: 2011-01-14 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8b33567d68b0 6939417: ArrayIndexOutOfBoundsException in Win 7 on selected printers Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java ! test/javax/print/DialogMargins.java Changeset: c2fcb5530ba5 Author: prr Date: 2011-01-14 15:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c2fcb5530ba5 6930980: Disable TrueType hinting for fonts known not to hint well Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontScaler.java ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/classes/sun/font/NullFontScaler.java Changeset: 0bec5d506120 Author: dlila Date: 2011-01-19 09:44 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0bec5d506120 4724552: CubicCurve2D.contains(Rectangle2D) returns true when only partially contained. Summary: Now using subdivision code in sun.awt.geom.Curve. Reviewed-by: flar ! src/share/classes/java/awt/geom/CubicCurve2D.java Changeset: c8a10bfd2fcb Author: dlila Date: 2011-01-19 11:31 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c8a10bfd2fcb 4493128: CubicCurve2D intersects method fails Summary: Now using subdivision code in sun.awt.geom.Curve. Reviewed-by: flar ! src/share/classes/java/awt/geom/CubicCurve2D.java Changeset: 00cc1c09c6dd Author: prr Date: 2011-01-19 09:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/00cc1c09c6dd 6951501: EUDC character is not displayed on Swing Reviewed-by: igor, jgodinez ! src/windows/classes/sun/awt/Win32FontManager.java ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp Changeset: e58e9e32399a Author: prr Date: 2011-01-19 17:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e58e9e32399a 6983037: closed/java/awt/font/FontNames/Type1Fonts.java failed due to missed font Reviewed-by: igor ! src/share/classes/sun/font/SunFontManager.java ! src/solaris/classes/sun/awt/X11FontManager.java Changeset: fe1b5c15afab Author: prr Date: 2011-01-19 17:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fe1b5c15afab 7013109: windows application manifest problems 6820955: Update application manifests with new Windows 7 dpiAware section Reviewed-by: ohair, art ! make/common/Defs-windows.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! src/windows/resource/java.manifest Changeset: aa1825b1b69d Author: lana Date: 2011-01-19 19:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/aa1825b1b69d Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/security/krb5/auto/basic.sh Changeset: 0044e8e16a30 Author: prr Date: 2011-01-20 10:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0044e8e16a30 6980204: closed/java/awt/font/LogicalFonts/MappingTest.java fails Reviewed-by: jgodinez ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java Changeset: b1c41e0321a2 Author: prr Date: 2011-01-20 13:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b1c41e0321a2 7013646: remove obsolete fontconfig files for linux and solaris Reviewed-by: igor, jgodinez ! make/sun/awt/Makefile - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java ! src/solaris/classes/sun/font/FcFontConfiguration.java Changeset: b8f08482aca1 Author: prr Date: 2011-01-21 07:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b8f08482aca1 6892493: potential memory leaks in 2D font code indentified by parfait. Reviewed-by: bae, igor ! src/solaris/native/sun/awt/fontpath.c Changeset: c17e5a95aba7 Author: prr Date: 2011-01-21 08:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c17e5a95aba7 6892138: Windows GDI platform font lookup apis affect start-up for small UI apps Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/SunFontManager.java ! src/windows/classes/sun/awt/Win32FontManager.java + test/java/awt/font/FontNames/LocaleFamilyNames.java Changeset: ade796b84e71 Author: bae Date: 2011-01-24 15:14 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ade796b84e71 7002766: Java2d: Changes to correct c/c++ language issues for use of parfait Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/image/jpeg/jmorecfg.h ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 63a2e8e00a7b Author: bae Date: 2011-01-24 15:37 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/63a2e8e00a7b 6999620: [parfait] potential buffer overruns in 2d and awt Reviewed-by: jgodinez, prr ! src/windows/native/sun/java2d/d3d/D3DGraphicsDevice.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 74d020ed7f5b Author: lana Date: 2011-01-24 13:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/74d020ed7f5b Merge - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties Changeset: 5d4723944cbd Author: dcherepanov Date: 2011-01-20 14:27 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5d4723944cbd 7011446: ./windows/classes/sun/awt/windows/WToolkit.java needs to avoid spurious wakeup Reviewed-by: anthony ! src/windows/classes/sun/awt/windows/WToolkit.java Changeset: 1bb32dc775c8 Author: dcherepanov Date: 2011-01-20 14:28 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1bb32dc775c8 7011443: ./share/classes/sun/awt/SunToolkit.java needs to avoid spurious wakeup Reviewed-by: anthony ! src/share/classes/sun/awt/SunToolkit.java Changeset: 4cd8718d4548 Author: dcherepanov Date: 2011-01-20 14:29 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4cd8718d4548 7011442: AppletClassLoader.java needs to avoid spurious wakeup Reviewed-by: anthony ! src/share/classes/sun/applet/AppletClassLoader.java Changeset: 4c9a9871830f Author: lana Date: 2011-01-20 10:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4c9a9871830f Merge - test/javax/script/E4XErrorTest.java - test/sun/security/krb5/auto/basic.sh Changeset: f6b73a9b3895 Author: lana Date: 2011-01-24 13:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f6b73a9b3895 Merge Changeset: 63972a313ca4 Author: rupashka Date: 2011-01-11 12:51 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/63972a313ca4 6589952: Swing: dead links in API documentation Reviewed-by: alexp ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/SizeSequence.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/event/InternalFrameAdapter.java ! src/share/classes/javax/swing/event/InternalFrameListener.java ! src/share/classes/javax/swing/plaf/multi/doc-files/multi_tsc.html ! src/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/ParagraphView.java ! src/share/classes/javax/swing/text/html/StyleSheet.java Changeset: 2a966dd275fc Author: rupashka Date: 2011-01-13 20:12 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2a966dd275fc 6990651: Regression: NPE when refreshing applet since 6u22-b01 Reviewed-by: peterz ! src/share/classes/javax/swing/text/html/parser/ParserDelegator.java + test/javax/swing/JLabel/7004134/bug7004134.java + test/javax/swing/text/html/parser/Parser/6990651/bug6990651.java Changeset: 5787add5b679 Author: rupashka Date: 2011-01-17 19:14 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5787add5b679 6342301: Bad interaction between setting the ui and file filters in JFileChooser Reviewed-by: alexp ! src/share/classes/javax/swing/JFileChooser.java + test/javax/swing/JFileChooser/6342301/bug6342301.java Changeset: ca3bafeffd3b Author: rupashka Date: 2011-01-19 17:01 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ca3bafeffd3b 6246816: SwingSet2 should be rewritten Reviewed-by: peterz ! make/common/Demo.gmk ! make/mkdemo/jfc/Makefile + make/mkdemo/jfc/SwingSet3/Makefile Changeset: e93106dc798b Author: lana Date: 2011-01-19 21:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e93106dc798b Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/security/krb5/auto/basic.sh Changeset: b45ea2c3bd6d Author: rupashka Date: 2011-01-24 18:04 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b45ea2c3bd6d 6735293: javax.swing.text.NavigationFilter.getNextVisualPositionFrom() not always throws BadLocationException Reviewed-by: peterz ! src/share/classes/javax/swing/text/View.java + test/javax/swing/text/NavigationFilter/6735293/bug6735293.java Changeset: 1f3ecbfa0c29 Author: lana Date: 2011-01-24 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1f3ecbfa0c29 Merge Changeset: b8663921f5d7 Author: chegar Date: 2011-01-07 13:08 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b8663921f5d7 7000511: PrintStream, PrintWriter, Formatter, Scanner leave files open when exception thrown Reviewed-by: alanb, mduigou ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/Scanner.java ! test/ProblemList.txt + test/java/io/PrintStream/FailingConstructors.java + test/java/io/PrintWriter/FailingConstructors.java ! test/java/util/Formatter/Constructors.java + test/java/util/Formatter/FailingConstructors.java + test/java/util/Scanner/FailingConstructors.java Changeset: 5124c2a50539 Author: alanb Date: 2011-01-07 15:49 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5124c2a50539 6993732: Remove the HPI Reviewed-by: ohair, lancea, chegar, mduigou, mchung, mr ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/Modules.gmk ! make/common/Release.gmk ! make/java/Makefile ! make/java/fdlibm/Makefile - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile ! make/tools/reorder/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c Changeset: ddaffd64796c Author: alanb Date: 2011-01-07 15:51 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ddaffd64796c Merge Changeset: 6bf1c5958c22 Author: chegar Date: 2011-01-07 21:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6bf1c5958c22 7009760: Possible stack corruption in Java_java_net_TwoStacksPlainSocketImpl_socketGetOption Summary: SOCKET_ADDRESS -> SOCKETADDRESS Reviewed-by: alanb ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c Changeset: 3dbc783a8073 Author: smarks Date: 2011-01-07 15:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3dbc783a8073 7008728: diamond conversion of basic security, permissions, authentication Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java ! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java ! src/share/classes/com/sun/security/auth/module/SolarisLoginModule.java ! src/share/classes/com/sun/security/auth/module/UnixLoginModule.java ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/Permissions.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/SecureClassLoader.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/UnresolvedPermissionCollection.java ! src/share/classes/javax/security/auth/PrivateCredentialPermission.java ! src/share/classes/javax/security/auth/SubjectDomainCombiner.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/sun/security/acl/AclEntryImpl.java ! src/share/classes/sun/security/acl/AclImpl.java ! src/share/classes/sun/security/acl/GroupImpl.java ! test/com/sun/security/auth/module/LdapLoginModule/CheckConfigs.java ! test/com/sun/security/auth/module/LdapLoginModule/CheckOptions.java Changeset: ee5bf287d0c4 Author: alanb Date: 2011-01-10 09:32 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ee5bf287d0c4 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit Reviewed-by: chegar ! make/java/nio/Makefile ! src/solaris/native/sun/nio/ch/FileChannelImpl.c Changeset: f4d755bbdabe Author: lancea Date: 2011-01-10 14:43 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f4d755bbdabe 6544224: Remove the need of sun.reflect.misc Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java Changeset: 2a0ff59928de Author: smarks Date: 2011-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2a0ff59928de 7005608: diamond conversion of JCA and crypto providers Reviewed-by: wetmore ! src/share/classes/java/security/Security.java ! src/share/classes/sun/security/jca/ProviderList.java ! src/share/classes/sun/security/jca/Providers.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/Sun.java ! src/share/classes/sun/security/provider/VerificationProvider.java ! src/share/classes/sun/security/provider/X509Factory.java ! src/share/classes/sun/security/rsa/RSACore.java ! src/share/classes/sun/security/rsa/SunRsaSign.java Changeset: befe813e24d2 Author: lancea Date: 2011-01-11 12:36 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/befe813e24d2 7000693: java.sql.Timestamp compareTo() issues using low values Reviewed-by: okutsu ! src/share/classes/java/sql/Timestamp.java Changeset: 6d0217114886 Author: smarks Date: 2011-01-11 13:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6d0217114886 7011095: revert diamond changes from 6880112 that occur in method args Reviewed-by: darcy, alanb ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/StringCoding.java ! src/share/classes/java/util/logging/Logger.java Changeset: cb3ecb5e4ce5 Author: dl Date: 2011-01-12 14:40 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cb3ecb5e4ce5 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011 Reviewed-by: dholmes, chegar, mduigou ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicMarkableReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java ! src/share/classes/java/util/concurrent/locks/Condition.java ! test/ProblemList.txt ! test/java/util/WeakHashMap/GCDuringIteration.java ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java ! test/java/util/concurrent/ConcurrentQueues/IteratorWeakConsistency.java ! test/java/util/concurrent/Executors/AutoShutdown.java ! test/java/util/concurrent/Phaser/Basic.java + test/java/util/concurrent/Phaser/FickleRegister.java + test/java/util/concurrent/Phaser/PhaseOverflow.java + test/java/util/concurrent/Phaser/TieredArriveLoops.java ! test/java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java Changeset: a5a22f93e4c5 Author: smarks Date: 2011-01-12 13:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a5a22f93e4c5 7008713: diamond conversion of kerberos5 and security tools Reviewed-by: weijun ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/PrincipalName.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/internal/Authenticator.java ! src/share/classes/sun/security/krb5/internal/AuthorizationData.java ! src/share/classes/sun/security/krb5/internal/EncAPRepPart.java ! src/share/classes/sun/security/krb5/internal/HostAddresses.java ! src/share/classes/sun/security/krb5/internal/KDCReq.java ! src/share/classes/sun/security/krb5/internal/KDCReqBody.java ! src/share/classes/sun/security/krb5/internal/KRBCred.java ! src/share/classes/sun/security/krb5/internal/KRBError.java ! src/share/classes/sun/security/krb5/internal/KrbCredInfo.java ! src/share/classes/sun/security/krb5/internal/LastReq.java ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! test/sun/security/krb5/IPv6.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/Context.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/LoginModuleOptions.java ! test/sun/security/krb5/tools/KtabCheck.java Changeset: f5c0b3cbee2f Author: kamg Date: 2011-01-12 11:47 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f5c0b3cbee2f 6436034: Instance filter doesn't filter event if it occurs in native method Summary: Use 'GetLocalInstance' JVMTI extension if it exists Reviewed-by: coleenp, dcubed ! src/share/back/debugInit.c ! src/share/back/eventFilter.c ! src/share/instrument/JPLISAgent.c ! src/share/javavm/export/jvmti.h + test/com/sun/jdi/NativeInstanceFilter.java + test/com/sun/jdi/NativeInstanceFilterTarg.java Changeset: 295f6b861c12 Author: kamg Date: 2011-01-12 15:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/295f6b861c12 Merge Changeset: 538f913777cf Author: michaelm Date: 2011-01-13 11:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/538f913777cf 6896088: URLClassLoader.close() apparently not working for JAR URLs on Windows Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/B6896088.java Changeset: 9f265d55c1c4 Author: michaelm Date: 2011-01-13 11:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9f265d55c1c4 Merge Changeset: 694951adefec Author: chegar Date: 2011-01-13 13:24 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/694951adefec 6964547: Impossible to set useV4 in SocksSocketImpl Summary: Add socksProxyVersion property Reviewed-by: alanb, michaelm ! make/sun/net/FILES_java.gmk ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/doc-files/net-properties.html + src/share/classes/sun/net/SocksProxy.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java + test/java/net/Socks/SocksProxyVersion.java Changeset: 38729ba6eb4f Author: michaelm Date: 2011-01-12 15:05 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/38729ba6eb4f 6829919: URLClassLoader.close() doesn't close resource file if getResourceAsStream(...) was called before Reviewed-by: chegar ! src/share/classes/java/net/URLClassLoader.java ! test/java/net/URLClassLoader/closetest/CloseTest.java + test/java/net/URLClassLoader/closetest/Common.java + test/java/net/URLClassLoader/closetest/GetResourceAsStream.java + test/java/net/URLClassLoader/closetest/build2.sh Changeset: ed390b2e5ca4 Author: michaelm Date: 2011-01-13 11:10 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ed390b2e5ca4 Merge Changeset: 067b5f603fc8 Author: michaelm Date: 2011-01-13 14:41 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/067b5f603fc8 Merge Changeset: 3215b22cd90e Author: michaelm Date: 2011-01-13 16:33 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3215b22cd90e 7003398: NetworkInterface equals() and hashCode() behaviors depend on permissions granted Reviewed-by: chegar, alanb ! src/share/classes/java/net/NetworkInterface.java + test/java/net/NetworkInterface/Equals.java Changeset: 29f2e311cce7 Author: mduigou Date: 2011-01-13 20:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/29f2e311cce7 6728865: Provide a better heuristics for Collections.disjoint method Reviewed-by: alanb, dholmes, chegar, forax ! src/share/classes/java/util/Collections.java Changeset: 59e352561146 Author: darcy Date: 2011-01-13 22:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/59e352561146 7012279: Project Coin: Clarify AutoCloseable and Throwable javadoc Reviewed-by: jjb ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Throwable.java Changeset: 983364897f72 Author: chegar Date: 2011-01-14 22:34 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/983364897f72 7010903: impl. of http.maxConnections is different from the description in JavaSE document Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java Changeset: d61d9bf190f5 Author: smarks Date: 2011-01-14 15:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d61d9bf190f5 7012003: diamond conversion for ssl Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/CipherSuiteList.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHandlerTest.java Changeset: 507627325c81 Author: sundar Date: 2011-01-17 13:29 +0530 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/507627325c81 6508943: small typo in the documentation 6759414: javascript engine can not write to StringWriter 6869617: RhinoScriptEngine bug : ScriptException cause not set (with fix) 7012701: Add a test to check that Rhino's RegExp parser accepts unescaped '[' Reviewed-by: alanb, jjh ! src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java ! src/share/classes/javax/script/CompiledScript.java + test/javax/script/CauseExceptionTest.java + test/javax/script/StringWriterPrintTest.java + test/javax/script/UnescapedBracketRegExTest.java Changeset: 9596a600758c Author: lana Date: 2011-01-19 19:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9596a600758c Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java Changeset: e64b1f11cd0b Author: chegar Date: 2011-01-20 15:23 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e64b1f11cd0b 7011857: java/util/concurrent/Phaser/FickleRegister.java fails on solaris-sparc Summary: Remove from ProblemList, failure resolved by 7009231 Reviewed-by: alanb ! test/ProblemList.txt Changeset: cc195c981ae2 Author: mchung Date: 2011-01-20 22:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cc195c981ae2 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/ProblemList.txt Changeset: 2a8d1a0a2418 Author: chegar Date: 2011-01-21 17:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2a8d1a0a2418 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi Reviewed-by: alanb, michaelm ! src/share/classes/java/net/InetAddress.java - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/chaining/Providers.java + test/sun/net/InetAddress/nameservice/chaining/Simple1NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/Simple2NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/SimpleNameService.java + test/sun/net/InetAddress/nameservice/deadlock/Hang.java + test/sun/net/InetAddress/nameservice/deadlock/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameService.java + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/simple/CacheTest.java + test/sun/net/InetAddress/nameservice/simple/DefaultCaching.java + test/sun/net/InetAddress/nameservice/simple/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/simple/SimpleNameService.java + test/sun/net/InetAddress/nameservice/simple/SimpleNameServiceDescriptor.java Changeset: 6a7b8406a1b9 Author: chegar Date: 2011-01-21 17:04 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6a7b8406a1b9 Merge Changeset: f26d1a7fe4d2 Author: mchung Date: 2011-01-21 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f26d1a7fe4d2 6912013: Remove the temporary launcher fix to add modules in the bootclasspath Reviewed-by: ksrini ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/classes/sun/launcher/LauncherHelper.java Changeset: 9c18818e7a5f Author: mchung Date: 2011-01-21 09:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9c18818e7a5f Merge - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 2381e810330b Author: zgu Date: 2011-01-20 10:45 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2381e810330b 6983248: net/net001 and net/net003 fail on WinXP with JDK7-B108 Summary: Using closesocket to close socket handler to avoid invalid C runtime parameter exception. Reviewed-by: alanb, phh, dcubed, dsamersoff, coleenp, acorn ! src/windows/demo/jvmti/hprof/hprof_md.c Changeset: d03e47de3a89 Author: zgu Date: 2011-01-21 11:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d03e47de3a89 Merge Changeset: c73c178159d8 Author: phh Date: 2011-01-20 19:34 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c73c178159d8 6173675: M&M: approximate memory allocation rate/amount per thread Summary: Subclass com.sun.management.ThreadMXBean from java.lang.management.ThreadMXBean, add getAllocatedBytes() and friends to c.s.m.ThreadMXBean and have sun.management.ThreadImpl implement c.s.m.ThreadMXBean rather than j.l.m.ThreadMXBean. Reviewed-by: mchung, alanb, dholmes, emcmanus ! make/java/management/mapfile-vers + src/share/classes/com/sun/management/ThreadMXBean.java ! src/share/classes/sun/management/ThreadImpl.java ! src/share/classes/sun/management/VMManagement.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/javavm/export/jmm.h ! src/share/native/sun/management/ThreadImpl.c ! src/share/native/sun/management/VMManagementImpl.c + test/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java + test/com/sun/management/ThreadMXBean/ThreadAllocatedMemoryArray.java + test/com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java Changeset: 64ef2f52d781 Author: phh Date: 2011-01-21 07:29 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/64ef2f52d781 7013682: two test checking cpuTime filed java/lang/management/ThreadMXBean Summary: Typo in 6173675 fix dropped getThreadCpuTime(long) result on the floor. Reviewed-by: mchung, dholmes ! src/share/classes/sun/management/ThreadImpl.java Changeset: cd13b2114f2e Author: phh Date: 2011-01-22 08:42 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cd13b2114f2e Merge ! src/share/classes/sun/management/ThreadImpl.java Changeset: d1365fdfb3ea Author: phh Date: 2011-01-22 08:43 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d1365fdfb3ea Merge - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 4cc447291326 Author: sherman Date: 2011-01-24 11:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4cc447291326 7006576: (zipfs) Path.exists() always returns false on dirs when zip/JAR file built without dirs 7009092: (zipfs) ZipPath.isSameFile() should always return true if this Path and the given Path are equal. 7009085: (zipfs) ZipPath.normalize("/./.") returns null. 7009102: (zipfs) ZipPath.toRealPath() should always return absolute path. Summary: zip filesystem provider update Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java ! test/demo/zipfs/PathOps.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 1f977c82b733 Author: lana Date: 2011-01-24 13:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1f977c82b733 Merge ! make/common/Defs-windows.gmk - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 47cfd89c3227 Author: lana Date: 2011-01-28 10:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/47cfd89c3227 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 006c683ead1a Author: ohair Date: 2011-01-05 14:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/006c683ead1a 6975326: Problem in install/make/rebase/Makefile, grep on empty pattern 6413588: Add 'ldd -r' and 'dump -Lv' checks to all .so files delivered in the JDK 7000995: Add check in makefiles to verify that msvcp100.dll is NOT used Reviewed-by: mduigou ! make/com/sun/java/pack/Makefile ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-linux.gmk ! make/common/shared/Defs-solaris.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/java/redist/Makefile Changeset: 9576644931b2 Author: ohair Date: 2011-01-07 21:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9576644931b2 6980024: Rebranding jre7/jdk7 License, Copyright, Readme 6912291: Third party license agreement should be present in all bundles Reviewed-by: katleman ! make/common/Modules.gmk ! make/common/Release.gmk ! make/common/shared/Defs-control.gmk Changeset: 8c3c6ac6fcdb Author: ohair Date: 2011-01-10 09:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8c3c6ac6fcdb Merge Changeset: 658559ca4526 Author: ohair Date: 2011-01-10 17:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/658559ca4526 7011382: Fix use of VS100COMNTOOLS when installed in non-default or non-space path Reviewed-by: prr ! make/common/shared/Defs-windows.gmk Changeset: fd6319676bd3 Author: ohair Date: 2011-01-10 17:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fd6319676bd3 Merge Changeset: 713d20f796c0 Author: ohair Date: 2011-01-10 18:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/713d20f796c0 6989472: Provide simple jdk identification information in the install image Reviewed-by: alanb ! make/common/Release.gmk ! make/common/shared/Defs-versions.gmk Changeset: 523386cfb731 Author: ohair Date: 2011-01-10 22:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/523386cfb731 Merge Changeset: 83cef4633684 Author: ohair Date: 2011-01-13 17:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/83cef4633684 Merge Changeset: 4241588a12c3 Author: ohair Date: 2011-01-13 13:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4241588a12c3 7008047: remove sanity check of msival tool from JDK tree Reviewed-by: billyh ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk Changeset: 81e66ce6f501 Author: ohair Date: 2011-01-13 23:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/81e66ce6f501 Merge Changeset: 0c29bbd10e19 Author: ohair Date: 2011-01-14 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0c29bbd10e19 6950375: Remove msvcrt.dll from the Windows JRE bundles Reviewed-by: prr ! make/Makefile ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/java/redist/Makefile ! make/jdk_generic_profile.sh ! src/share/demo/jvmti/index.html Changeset: 329f49ab5c4c Author: ohair Date: 2011-01-16 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/329f49ab5c4c Merge Changeset: 688f415db098 Author: ohair Date: 2011-01-26 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/688f415db098 Merge Changeset: aecb8f0eb83b Author: ohair Date: 2011-01-27 18:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/aecb8f0eb83b Merge Changeset: f08682e23279 Author: ohair Date: 2011-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f08682e23279 Merge ! make/common/Defs-windows.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Modules.gmk ! make/common/Program.gmk ! make/common/Release.gmk Changeset: 07c68a15ec79 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/07c68a15ec79 Added tag jdk7-b128 for changeset f08682e23279 ! .hgtags From paul.hohensee at oracle.com Fri Feb 4 07:05:00 2011 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Fri, 04 Feb 2011 10:05:00 -0500 Subject: Update: Request for reviews (M): 7017124: Fix some VM stats to avoid 32-bit overflow In-Reply-To: <4D4B74E0.7040907@oracle.com> References: <4D4B74E0.7040907@oracle.com> Message-ID: <4D4C159C.5050204@oracle.com> Ok. Paul On 2/3/11 10:39 PM, Vladimir Kozlov wrote: > Update after reviews. > Renamed method and moved it outside Atomic class since it is not atomic. > > http://cr.openjdk.java.net/~kvn/7017124/webrev.01 > > Fixed 7017124: Fix some VM stats to avoid 32-bit overflow > > During long enough time (tens minutes) on modern processors > some VM statistic 32-bit values overflow. We need to use longs. > And when a value is long we still have a problem since it is > incremented not atomically in 32-bit VM. > > Added new method inc_stat_counter() to increment long > statistic values and use atomic long load and store. > > Fixed several output formats to use FORMAT macros. > > I have to remove v9 check assert from Atomic_move_long() since > it is called before VM_Version is initialized and C2 is built > for v9 only anyway. > > I fixed only statistic which was interesting to me. From vladimir.kozlov at oracle.com Fri Feb 4 08:46:46 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 04 Feb 2011 08:46:46 -0800 Subject: Update: Request for reviews (M): 7017124: Fix some VM stats to avoid 32-bit overflow In-Reply-To: <4D4C159C.5050204@oracle.com> References: <4D4B74E0.7040907@oracle.com> <4D4C159C.5050204@oracle.com> Message-ID: <4D4C2D76.9060801@oracle.com> Thank you, Paul Vladimir Paul Hohensee wrote: > Ok. > > Paul > > On 2/3/11 10:39 PM, Vladimir Kozlov wrote: >> Update after reviews. >> Renamed method and moved it outside Atomic class since it is not atomic. >> >> http://cr.openjdk.java.net/~kvn/7017124/webrev.01 >> >> Fixed 7017124: Fix some VM stats to avoid 32-bit overflow >> >> During long enough time (tens minutes) on modern processors >> some VM statistic 32-bit values overflow. We need to use longs. >> And when a value is long we still have a problem since it is >> incremented not atomically in 32-bit VM. >> >> Added new method inc_stat_counter() to increment long >> statistic values and use atomic long load and store. >> >> Fixed several output formats to use FORMAT macros. >> >> I have to remove v9 check assert from Atomic_move_long() since >> it is called before VM_Version is initialized and C2 is built >> for v9 only anyway. >> >> I fixed only statistic which was interesting to me. From tom.rodriguez at oracle.com Fri Feb 4 10:41:22 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 4 Feb 2011 10:41:22 -0800 Subject: Update: Request for reviews (M): 7017124: Fix some VM stats to avoid 32-bit overflow In-Reply-To: <4D4B74E0.7040907@oracle.com> References: <4D4B74E0.7040907@oracle.com> Message-ID: Looks good. tom On Feb 3, 2011, at 7:39 PM, Vladimir Kozlov wrote: > Update after reviews. > Renamed method and moved it outside Atomic class since it is not atomic. > > http://cr.openjdk.java.net/~kvn/7017124/webrev.01 > > Fixed 7017124: Fix some VM stats to avoid 32-bit overflow > > During long enough time (tens minutes) on modern processors > some VM statistic 32-bit values overflow. We need to use longs. > And when a value is long we still have a problem since it is > incremented not atomically in 32-bit VM. > > Added new method inc_stat_counter() to increment long > statistic values and use atomic long load and store. > > Fixed several output formats to use FORMAT macros. > > I have to remove v9 check assert from Atomic_move_long() since > it is called before VM_Version is initialized and C2 is built > for v9 only anyway. > > I fixed only statistic which was interesting to me. From vladimir.kozlov at oracle.com Fri Feb 4 10:40:20 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 04 Feb 2011 10:40:20 -0800 Subject: Update: Request for reviews (M): 7017124: Fix some VM stats to avoid 32-bit overflow In-Reply-To: References: <4D4B74E0.7040907@oracle.com> Message-ID: <4D4C4814.5000207@oracle.com> Thank you, Tom Vladimir Tom Rodriguez wrote: > Looks good. > > tom > > On Feb 3, 2011, at 7:39 PM, Vladimir Kozlov wrote: > >> Update after reviews. >> Renamed method and moved it outside Atomic class since it is not atomic. >> >> http://cr.openjdk.java.net/~kvn/7017124/webrev.01 >> >> Fixed 7017124: Fix some VM stats to avoid 32-bit overflow >> >> During long enough time (tens minutes) on modern processors >> some VM statistic 32-bit values overflow. We need to use longs. >> And when a value is long we still have a problem since it is >> incremented not atomically in 32-bit VM. >> >> Added new method inc_stat_counter() to increment long >> statistic values and use atomic long load and store. >> >> Fixed several output formats to use FORMAT macros. >> >> I have to remove v9 check assert from Atomic_move_long() since >> it is called before VM_Version is initialized and C2 is built >> for v9 only anyway. >> >> I fixed only statistic which was interesting to me. > From tony.printezis at oracle.com Fri Feb 4 11:43:52 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Fri, 04 Feb 2011 19:43:52 +0000 Subject: hg: jdk7/hotspot/hotspot: 5 new changesets Message-ID: <20110204194400.ADF7247418@hg.openjdk.java.net> Changeset: b7a938236e43 Author: tonyp Date: 2011-01-31 16:28 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b7a938236e43 7014679: G1: deadlock during concurrent cleanup Summary: There's a potential deadlock between the concurrent cleanup thread and the GC workers that are trying to allocate and waiting for more free regions to be made available. Reviewed-by: iveresov, jcoomes ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: e49cfa28f585 Author: ysr Date: 2011-02-01 10:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e49cfa28f585 6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented Summary: Fix calculation of _desired, in free list statistics, which was missing an intended set of parentheses. Reviewed-by: poonam, jmasa ! src/share/vm/gc_implementation/shared/allocationStats.hpp Changeset: 986b2844f7a2 Author: brutisso Date: 2011-02-01 14:05 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/986b2844f7a2 6789220: CMS: intermittent timeout running nsk/regression/b4796926 Summary: The reference handler java thread and the GC could dead lock Reviewed-by: never, johnc, jcoomes ! src/share/vm/compiler/compileBroker.cpp Changeset: c33825b68624 Author: johnc Date: 2011-02-02 10:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c33825b68624 6923430: G1: assert(res != 0,"This should have worked.") 7007446: G1: expand the heap with a single step, not one region at a time Summary: Changed G1CollectedHeap::expand() to expand the committed space by calling VirtualSpace::expand_by() once rather than for every region in the expansion amount. This allows the success or failure of the expansion to be determined before creating any heap regions. Introduced a develop flag G1ExitOnExpansionFailure (false by default) that, when true, will exit the VM if the expansion of the committed space fails. Finally G1CollectedHeap::expand() returns a status back to it's caller so that the caller knows whether to attempt the allocation. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 176d0be30214 Author: phh Date: 2011-02-03 16:06 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/176d0be30214 7016998: gcutil class LinearLeastSquareFit doesn't initialize some of its fields Summary: Initialize _sum_x_squared, _intercept and _slope in constructor. Reviewed-by: bobv, coleenp ! src/share/vm/gc_implementation/shared/gcUtil.cpp From erik.trimble at oracle.com Fri Feb 4 18:27:38 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Sat, 05 Feb 2011 02:27:38 +0000 Subject: hg: jdk7/hotspot/hotspot: 5 new changesets Message-ID: <20110205022750.EBA2047431@hg.openjdk.java.net> Changeset: 907c1aed0f8c Author: cl Date: 2011-01-27 17:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/907c1aed0f8c Added tag jdk7-b127 for changeset 102466e70deb ! .hgtags Changeset: 9a5762f44859 Author: trims Date: 2011-02-01 18:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/9a5762f44859 Merge ! .hgtags - src/share/vm/gc_implementation/g1/concurrentZFThread.cpp - src/share/vm/gc_implementation/g1/concurrentZFThread.hpp Changeset: 6ecdca5709df Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/6ecdca5709df Added tag jdk7-b128 for changeset 9a5762f44859 ! .hgtags Changeset: ae4b185f2ed1 Author: trims Date: 2011-02-03 23:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ae4b185f2ed1 Merge ! .hgtags - agent/src/share/classes/sun/jvm/hotspot/oops/SymbolKlass.java - src/share/vm/ci/ciSymbolKlass.cpp - src/share/vm/ci/ciSymbolKlass.hpp - src/share/vm/oops/symbolKlass.cpp - src/share/vm/oops/symbolKlass.hpp - src/share/vm/oops/symbolOop.cpp - src/share/vm/oops/symbolOop.hpp Changeset: c6bf3ca2bb31 Author: trims Date: 2011-02-04 16:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c6bf3ca2bb31 Merge From kelly.ohair at oracle.com Mon Feb 7 09:37:01 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Feb 2011 09:37:01 -0800 Subject: OpenJDK Build Procedures Message-ID: <6F760CF0-8A55-4C8A-91F6-BCB1122CBB07@oracle.com> It is critical that all changes to the OpenJDK build process, as defined in the existing Makefiles, be reviewed by the Build Infrastructure Group (http://openjdk.java.net/groups/ build/) via the build-dev at openjdk.java.net mailing list prior to integration into the public shared repositories. This includes ANY change to the Makefiles, ant scripts, build property files, build dependencies, or system configurations required. We will make all attempts to keep this review lightweight, and in most cases this is just a double check that the changes related to building are well understood, publicly discussed, and adequately documented. The OpenJDK Build README files at: OpenJDK7: http://hg.openjdk.java.net/jdk7/jdk7/raw-file/tip/README-builds.html OpenJDK6: http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html will be updated soon and I encourage anyone with suggested fixes to these documents to send me a note. If necessary, I will pursue a 'hg rollback' of changesets pushed without this build review. -kto From robert.ottenhag at oracle.com Mon Feb 7 13:14:20 2011 From: robert.ottenhag at oracle.com (robert.ottenhag at oracle.com) Date: Mon, 07 Feb 2011 21:14:20 +0000 Subject: hg: jdk7/hotspot/hotspot: 8 new changesets Message-ID: <20110207211437.4CD79474D0@hg.openjdk.java.net> Changeset: d70fe6ab4436 Author: coleenp Date: 2011-02-01 11:23 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/d70fe6ab4436 6588413: Use -fvisibility=hidden for gcc compiles Summary: Add option for gcc 4 and above, define JNIEXPORT and JNIIMPORT to visibility=default, add for jio_snprintf and others since -fvisibility=hidden overrides --version-script definitions. Reviewed-by: kamg, never ! make/linux/makefiles/gcc.make ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! src/cpu/sparc/vm/jni_sparc.h ! src/cpu/x86/vm/jni_x86.h ! src/cpu/zero/vm/jni_zero.h ! src/os/linux/vm/jvm_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: b92c45f2bc75 Author: bobv Date: 2011-02-02 11:35 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository Reviewed-by: dholmes, bdelsart ! make/Makefile + make/closed.make ! make/jprt.properties ! make/linux/Makefile ! make/linux/makefiles/adlc.make + make/linux/makefiles/arm.make ! make/linux/makefiles/buildtree.make + make/linux/makefiles/ppc.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/top.make ! make/linux/makefiles/vm.make + make/linux/platform_arm + make/linux/platform_ppc ! src/os/linux/vm/osThread_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/linux/vm/thread_linux.inline.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Defs.hpp ! src/share/vm/c1/c1_FpuStackSim.hpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/c1/c1_MacroAssembler.hpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/classfile/classFileStream.hpp ! src/share/vm/classfile/stackMapTable.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/code/icBuffer.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/relocInfo.hpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/bytecodeInterpreter.hpp ! src/share/vm/interpreter/bytecodeInterpreter.inline.hpp ! src/share/vm/interpreter/bytecodeStream.hpp ! src/share/vm/interpreter/bytecodes.cpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/interpreter/cppInterpreter.hpp ! src/share/vm/interpreter/cppInterpreterGenerator.hpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/interpreter/interpreterGenerator.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/templateInterpreter.hpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/output.hpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jni_md.h ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/dtraceJSDT.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/frame.inline.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/icache.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/javaFrameAnchor.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/registerMap.hpp ! src/share/vm/runtime/relocator.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stackValueCollection.cpp ! src/share/vm/runtime/statSampler.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/stubRoutines.hpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/threadLocalStorage.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/copy.hpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 9cd8a2c2d584 Author: bobv Date: 2011-02-02 11:54 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/9cd8a2c2d584 Merge ! src/os/linux/vm/os_linux.cpp Changeset: face83fc8882 Author: coleenp Date: 2011-02-02 18:38 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/face83fc8882 7012088: jump to 0 address because of lack of memory ordering in SignatureHandlerLibrary::add Summary: Write method signature handler under lock to prevent race with growable array resizing Reviewed-by: dsamersoff, dholmes ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: bf8517f4e4d0 Author: kamg Date: 2011-02-02 14:38 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/bf8517f4e4d0 6766644: Redefinition of compiled method fails with assertion "Can not load classes with the Compiler thread" Summary: Defer posting events from the compiler thread: use service thread Reviewed-by: coleenp, dholmes, never, dcubed - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java + agent/src/share/classes/sun/jvm/hotspot/runtime/ServiceThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Thread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp + src/share/vm/runtime/serviceThread.cpp + src/share/vm/runtime/serviceThread.hpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/services/lowMemoryDetector.hpp ! src/share/vm/services/management.cpp ! src/share/vm/utilities/macros.hpp Changeset: d28def44457d Author: coleenp Date: 2011-02-03 21:30 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/d28def44457d 7017009: Secondary out of c-heap memory error reporting out of memory Summary: Use os::malloc() to allocate buffer to read elf symbols and check for null Reviewed-by: zgu, phh, dsamersoff, dholmes, dcubed ! src/share/vm/utilities/elfSymbolTable.cpp Changeset: 5e139f767ddb Author: coleenp Date: 2011-02-03 20:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5e139f767ddb Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java Changeset: e9f24eebafd4 Author: rottenha Date: 2011-02-07 08:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e9f24eebafd4 Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java From dmytro_sheyko at hotmail.com Tue Feb 8 01:24:55 2011 From: dmytro_sheyko at hotmail.com (Dmytro Sheyko) Date: Tue, 8 Feb 2011 16:24:55 +0700 Subject: Some issues on identifying user.name on Windows Message-ID: Hi, I noticed following code openjdk-7-ea-src-b127-27_jan_2011\jdk\src\windows\native\java\lang\java_props_md.c /* * User name * We try to avoid calling GetUserName as it turns out to * be surprisingly expensive on NT. It pulls in an extra * 100 K of footprint. */ { WCHAR *uname = _wgetenv(L"USERNAME"); if (uname != NULL && wcslen(uname) > 0) { sprops.user_name = _wcsdup(uname); } else { WCHAR buf[100]; int buflen = sizeof(buf); sprops.user_name = GetUserNameW(buf, &buflen) ? _wcsdup(buf) : L"unknown"; } } In my opinion there are some issues in it. 1. We identify buffer length in bytes but GetUserNameW expects size in wchars. This can lead to buffer overflow. 2. In normal cases user name is allocated in heap (_wcsdup does this), but in problematic case user_name points to the static string "unknown". This can lead to problems once we decide to free memory. 3. Solaris and Linux return "?" in problematic case, but Windows returns "unknown". This seems inconsistent. I believe that Windows should also return "?" in order to make it consistent with Linux and Solaris and to let know whether username is definitely unknown. It's impossible to create user with name "?" because it has a forbidden character. On the other hand it is possible have user with name "unknown" literally, so if java says that user name is "unknown" we can't definitely know whether user is really unknown or he has such a name. I propose following code instead: /* * User name * We try to avoid calling GetUserName as it turns out to * be surprisingly expensive on NT. It pulls in an extra * 100 K of footprint. */ { WCHAR *uname = _wgetenv(L"USERNAME"); if (uname != NULL && wcslen(uname) > 0) { sprops.user_name = _wcsdup(uname); } else { sprops.user_name = IdentifyUserName(); } } static LPWSTR IdentifyUserName() { DWORD buflen = 0; GetUserNameW(0, &buflen); // identify buffer length if (GetLastError() == ERROR_INSUFFICIENT_BUFFER) { // 'buflen' receives the required buffer size in WCHARs, including the terminating null character. LPWSTR result = (LPWSTR) malloc(buflen * sizeof(WCHAR)); if (result) { if (GetUserNameW(result, &buflen)) { return result; } else { free(result); } } } return _wcsdup(L"?"); // allocate username in heap, use impossible username } Regards, Dmytro -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110208/66e32e06/attachment.html From tom.rodriguez at oracle.com Tue Feb 8 14:01:38 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Tue, 8 Feb 2011 14:01:38 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal Message-ID: http://cr.openjdk.java.net/~never/7017732 7017732: move static fields into Class to prepare for perm gen removal Reviewed-by: Currently static fields are stored in the instanceKlass but when those are moved into native memory we'd have to have a new card mark strategy for static fields. This could be something like setting a flag in the instanceKlass and then rescanning every klass during a GC which seems expensive or marking the card for the java.lang.Class then making sure to scan the instanceKlass when scanning the Class. If we move them into the Class then almost all the existing machinery works exactly as it always has. The only execution difference is which constant is materialized for the field access. Most of the machinery for static fields is now over in javaClasses.cpp. The bootstrap had to change slightly since we don't have Class until we've loaded a few classes but it all fits into the existing mirror creation logic. I also only create mirrors for real Java classes whereas previously we also created them for internal klasses we create. The main implementation oddity is that java.lang.Class instances are now variably sized. This required a small change in size_given_klass and a new instanceMirrorKlass to handle visiting the oops in them. Performance is unchanged. Tested with ctw, runthese, nsk jvmti tests and jbb with the various collectors. From christian.thalinger at oracle.com Wed Feb 9 03:52:04 2011 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Wed, 9 Feb 2011 12:52:04 +0100 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: References: Message-ID: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/7017732 src/cpu/x86/vm/c1_CodeStubs_x86.cpp: 315 Register tmp = rax; 316 Register tmp2 = rbx; 317 if (_obj == tmp) tmp = rcx; 318 else if (_obj == tmp2) tmp = rcx; 319 __ push(tmp); 320 __ push(tmp2); 321 __ get_thread(tmp); 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); 324 __ pop(tmp2); 325 __ pop(tmp); Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: 315 Register tmp = rax; 316 Register tmp2 = rbx; 319 __ push(tmp); 320 __ push(tmp2); 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); 321 __ get_thread(tmp); 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); 324 __ pop(tmp2); 325 __ pop(tmp); -- Christian From vladimir.kozlov at oracle.com Wed Feb 9 09:39:38 2011 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Wed, 09 Feb 2011 17:39:38 +0000 Subject: hg: hsx/hsx20/baseline: 7014998: assert(is_T_family(features) == is_niagara(features)) failed: Niagara should be T series Message-ID: <20110209173940.B117047557@hg.openjdk.java.net> Changeset: ec9e977dd8e4 Author: kvn Date: 2011-02-01 10:27 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/ec9e977dd8e4 7014998: assert(is_T_family(features) == is_niagara(features)) failed: Niagara should be T series Summary: Use substring search instead of compare and convert string to upper case before search. Reviewed-by: never, phh, iveresov ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp From tony.printezis at oracle.com Wed Feb 9 11:44:54 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Wed, 09 Feb 2011 19:44:54 +0000 Subject: hg: hsx/hsx20/baseline: 3 new changesets Message-ID: <20110209194500.27B724755E@hg.openjdk.java.net> Changeset: bd2e08334e84 Author: tonyp Date: 2011-01-21 11:30 -0500 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/bd2e08334e84 7013718: G1: small fixes for two assert/guarantee failures Summary: Two small fixes to deal with a guarantee failure (the marking thread should join the SuspendibleThreadSet before calling a method that does pause prediction work so that said method is never called during a pause) and an assert failure (an assert is too strong). Reviewed-by: iveresov, johnc ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp Changeset: 4e66274b6bb3 Author: tonyp Date: 2011-01-25 17:58 -0500 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/4e66274b6bb3 7014261: G1: RSet-related failures Summary: A race between the concurrent cleanup thread and the VM thread while it is processing the "expanded sparse table list" causes both threads to try to free the same sparse table entry and either causes one of the threads to fail or leaves the entry in an inconsistent state. The solution is purge all entries on the expanded list that correspond go regions that are being cleaned up. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp Changeset: 908c5092d72a Author: tonyp Date: 2011-01-31 16:28 -0500 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/908c5092d72a 7014679: G1: deadlock during concurrent cleanup Summary: There's a potential deadlock between the concurrent cleanup thread and the GC workers that are trying to allocate and waiting for more free regions to be made available. Reviewed-by: iveresov, jcoomes ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp From tom.rodriguez at oracle.com Wed Feb 9 12:05:21 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 9 Feb 2011 12:05:21 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> Message-ID: <002CFEB1-A8FF-4878-9FE3-15972429179D@oracle.com> On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: > On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >> http://cr.openjdk.java.net/~never/7017732 > > src/cpu/x86/vm/c1_CodeStubs_x86.cpp: > > 315 Register tmp = rax; > 316 Register tmp2 = rbx; > 317 if (_obj == tmp) tmp = rcx; > 318 else if (_obj == tmp2) tmp = rcx; > 319 __ push(tmp); > 320 __ push(tmp2); > 321 __ get_thread(tmp); > 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); > 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); > 324 __ pop(tmp2); > 325 __ pop(tmp); > > Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. You're right. > What about this: > > 315 Register tmp = rax; > 316 Register tmp2 = rbx; > 319 __ push(tmp); > 320 __ push(tmp2); > 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); > 321 __ get_thread(tmp); > 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); > 324 __ pop(tmp2); > 325 __ pop(tmp); I like that. I change it. Thanks! tom > > -- Christian From tom.rodriguez at oracle.com Wed Feb 9 13:24:11 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 9 Feb 2011 13:24:11 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> Message-ID: I've updated the webrev with this change, fixed a couple macro names that still referenced InstanceKlass and fixed the alignment of the continuation slashes. tom On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: > On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >> http://cr.openjdk.java.net/~never/7017732 > > src/cpu/x86/vm/c1_CodeStubs_x86.cpp: > > 315 Register tmp = rax; > 316 Register tmp2 = rbx; > 317 if (_obj == tmp) tmp = rcx; > 318 else if (_obj == tmp2) tmp = rcx; > 319 __ push(tmp); > 320 __ push(tmp2); > 321 __ get_thread(tmp); > 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); > 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); > 324 __ pop(tmp2); > 325 __ pop(tmp); > > Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: > > 315 Register tmp = rax; > 316 Register tmp2 = rbx; > 319 __ push(tmp); > 320 __ push(tmp2); > 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); > 321 __ get_thread(tmp); > 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); > 324 __ pop(tmp2); > 325 __ pop(tmp); > > -- Christian From tom.rodriguez at oracle.com Wed Feb 9 13:39:43 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 9 Feb 2011 13:39:43 -0800 Subject: review (XS) for 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Message-ID: http://cr.openjdk.java.net/~never/7018101 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Reviewed-by: dladdr1 takes a pointer an Elf symbol structure through an untyped pointer. The current code is using Sym which is typedef'ed to Elf32_Sym even in 64 bit mode. This causes the result to be misinterpreted and produces bogus symbolic stack traces on 64 bit solaris. It appears that the typedefs are done this way for compatibility reasons and that defining _ELF64 would cause the correct definitions to be used. I can't find any documentation on that so instead I've chosen to explicitly pick the proper type. Tested by producing hs_err files and comparing the symbolic trace the VM produces with what the external decoded produces. This is for hs20. From karen.kinnear at oracle.com Wed Feb 9 13:50:47 2011 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Wed, 9 Feb 2011 16:50:47 -0500 Subject: review (XS) for 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit In-Reply-To: References: Message-ID: Thank you so much Tom. This looks good. Karen On Feb 9, 2011, at 4:39 PM, Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/7018101 > > 7018101: os::dll_address_to_function_name returning wrong answers in > 64 bit > Reviewed-by: > > dladdr1 takes a pointer an Elf symbol structure through an untyped > pointer. The current code is using Sym which is typedef'ed to > Elf32_Sym even in 64 bit mode. This causes the result to be > misinterpreted and produces bogus symbolic stack traces on 64 bit > solaris. It appears that the typedefs are done this way for > compatibility reasons and that defining _ELF64 would cause the correct > definitions to be used. I can't find any documentation on that so > instead I've chosen to explicitly pick the proper type. Tested by > producing hs_err files and comparing the symbolic trace the VM > produces with what the external decoded produces. This is for hs20. From tom.rodriguez at oracle.com Wed Feb 9 14:32:40 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 9 Feb 2011 14:32:40 -0800 Subject: review (XS) for 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit In-Reply-To: References: Message-ID: <305993E0-4239-4EA3-93A6-8A1B10A5354E@oracle.com> Thanks for the reviews. tom On Feb 9, 2011, at 1:50 PM, Karen Kinnear wrote: > Thank you so much Tom. This looks good. > > Karen > > On Feb 9, 2011, at 4:39 PM, Tom Rodriguez wrote: > >> http://cr.openjdk.java.net/~never/7018101 >> >> 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit >> Reviewed-by: >> >> dladdr1 takes a pointer an Elf symbol structure through an untyped >> pointer. The current code is using Sym which is typedef'ed to >> Elf32_Sym even in 64 bit mode. This causes the result to be >> misinterpreted and produces bogus symbolic stack traces on 64 bit >> solaris. It appears that the typedefs are done this way for >> compatibility reasons and that defining _ELF64 would cause the correct >> definitions to be used. I can't find any documentation on that so >> instead I've chosen to explicitly pick the proper type. Tested by >> producing hs_err files and comparing the symbolic trace the VM >> produces with what the external decoded produces. This is for hs20. > From Dmitry.Samersoff at oracle.com Wed Feb 9 15:07:25 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 10 Feb 2011 02:07:25 +0300 Subject: review (XS) for 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit In-Reply-To: References: Message-ID: <4D531E2D.7010308@oracle.com> Tom, Looks fine for me. On 2011-02-10 00:39, Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/7018101 > > 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit > Reviewed-by: > > dladdr1 takes a pointer an Elf symbol structure through an untyped > pointer. The current code is using Sym which is typedef'ed to > Elf32_Sym even in 64 bit mode. This causes the result to be > misinterpreted and produces bogus symbolic stack traces on 64 bit > solaris. It appears that the typedefs are done this way for > compatibility reasons and that defining _ELF64 would cause the correct > definitions to be used. I can't find any documentation on that so > instead I've chosen to explicitly pick the proper type. Tested by > producing hs_err files and comparing the symbolic trace the VM > produces with what the external decoded produces. This is for hs20. -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From vladimir.kozlov at oracle.com Wed Feb 9 17:09:13 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 09 Feb 2011 17:09:13 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> Message-ID: <4D533AB9.2060206@oracle.com> Tom, Could you rename "o" (which looks like 0) in set_offset_of_static_fields(int o)? You did not initialize static field (it is C++) but you have assert to check that it is 0: instanceMirrorKlass::_offset_of_static_fields; Could you add/modify layout decription in instanceKlass.hpp for instanceMirrorKlass and static fields. I don't understand changes in Unsafe_StaticFieldBaseFromClass(), it should return handle but you just return original jobject. Thanks, Vladimir Tom Rodriguez wrote: > I've updated the webrev with this change, fixed a couple macro names that still referenced InstanceKlass and fixed the alignment of the continuation slashes. > > tom > > On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: > >> On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >>> http://cr.openjdk.java.net/~never/7017732 >> src/cpu/x86/vm/c1_CodeStubs_x86.cpp: >> >> 315 Register tmp = rax; >> 316 Register tmp2 = rbx; >> 317 if (_obj == tmp) tmp = rcx; >> 318 else if (_obj == tmp2) tmp = rcx; >> 319 __ push(tmp); >> 320 __ push(tmp2); >> 321 __ get_thread(tmp); >> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >> 324 __ pop(tmp2); >> 325 __ pop(tmp); >> >> Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: >> >> 315 Register tmp = rax; >> 316 Register tmp2 = rbx; >> 319 __ push(tmp); >> 320 __ push(tmp2); >> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >> 321 __ get_thread(tmp); >> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >> 324 __ pop(tmp2); >> 325 __ pop(tmp); >> >> -- Christian > From tom.rodriguez at oracle.com Wed Feb 9 17:28:21 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 9 Feb 2011 17:28:21 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: <4D533AB9.2060206@oracle.com> References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> <4D533AB9.2060206@oracle.com> Message-ID: <3311F28E-EDAF-4270-B807-15200E044856@oracle.com> On Feb 9, 2011, at 5:09 PM, Vladimir Kozlov wrote: > Tom, > > Could you rename "o" (which looks like 0) in set_offset_of_static_fields(int o)? > You did not initialize static field (it is C++) but you have assert to check that it is 0: > instanceMirrorKlass::_offset_of_static_fields; Fixed. > > Could you add/modify layout decription in instanceKlass.hpp for instanceMirrorKlass and static fields. I removed the no longer correct part. Did you want something added? > > I don't understand changes in Unsafe_StaticFieldBaseFromClass(), > it should return handle but you just return original jobject. We're supposed to return the object to use as the base of unsafe static field references. That's just the java.lang.Class instance which was passed in so we simply return it. What would you expect it to do? I guess we might want to unhandle it and return a new local one in case the original one wasn't a local handle. Is that what you're getting at? tom > > Thanks, > Vladimir > > Tom Rodriguez wrote: >> I've updated the webrev with this change, fixed a couple macro names that still referenced InstanceKlass and fixed the alignment of the continuation slashes. >> tom >> On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: >>> On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >>>> http://cr.openjdk.java.net/~never/7017732 >>> src/cpu/x86/vm/c1_CodeStubs_x86.cpp: >>> >>> 315 Register tmp = rax; >>> 316 Register tmp2 = rbx; >>> 317 if (_obj == tmp) tmp = rcx; >>> 318 else if (_obj == tmp2) tmp = rcx; >>> 319 __ push(tmp); >>> 320 __ push(tmp2); >>> 321 __ get_thread(tmp); >>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>> 324 __ pop(tmp2); >>> 325 __ pop(tmp); >>> >>> Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: >>> >>> 315 Register tmp = rax; >>> 316 Register tmp2 = rbx; >>> 319 __ push(tmp); >>> 320 __ push(tmp2); >>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>> 321 __ get_thread(tmp); >>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>> 324 __ pop(tmp2); >>> 325 __ pop(tmp); >>> >>> -- Christian From vladimir.kozlov at oracle.com Wed Feb 9 17:51:10 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 09 Feb 2011 17:51:10 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: <3311F28E-EDAF-4270-B807-15200E044856@oracle.com> References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> <4D533AB9.2060206@oracle.com> <3311F28E-EDAF-4270-B807-15200E044856@oracle.com> Message-ID: <4D53448E.60706@oracle.com> Tom Rodriguez wrote: > > I removed the no longer correct part. Did you want something added? Is next description is still valid? 77 // [EMBEDDED Java vtable ] size in words = vtable_len 78 // [EMBEDDED static oop fields ] size in words = static_oop_fields_size 79 // [ static non-oop fields ] size in words = static_field_size - static_oop_fields_size 80 // [EMBEDDED nonstatic oop-map blocks] size in words = nonstatic_oop_map_size >> I don't understand changes in Unsafe_StaticFieldBaseFromClass(), >> it should return handle but you just return original jobject. > > We're supposed to return the object to use as the base of unsafe static field references. That's just the java.lang.Class instance which was passed in so we simply return it. What would you expect it to do? I guess we might want to unhandle it and return a new local one in case the original one wasn't a local handle. Is that what you're getting at? Thank you for explaining. Code is good. Vladimir > > tom > >> Thanks, >> Vladimir >> >> Tom Rodriguez wrote: >>> I've updated the webrev with this change, fixed a couple macro names that still referenced InstanceKlass and fixed the alignment of the continuation slashes. >>> tom >>> On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: >>>> On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >>>>> http://cr.openjdk.java.net/~never/7017732 >>>> src/cpu/x86/vm/c1_CodeStubs_x86.cpp: >>>> >>>> 315 Register tmp = rax; >>>> 316 Register tmp2 = rbx; >>>> 317 if (_obj == tmp) tmp = rcx; >>>> 318 else if (_obj == tmp2) tmp = rcx; >>>> 319 __ push(tmp); >>>> 320 __ push(tmp2); >>>> 321 __ get_thread(tmp); >>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>> 324 __ pop(tmp2); >>>> 325 __ pop(tmp); >>>> >>>> Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: >>>> >>>> 315 Register tmp = rax; >>>> 316 Register tmp2 = rbx; >>>> 319 __ push(tmp); >>>> 320 __ push(tmp2); >>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>> 321 __ get_thread(tmp); >>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>> 324 __ pop(tmp2); >>>> 325 __ pop(tmp); >>>> >>>> -- Christian > From tom.rodriguez at oracle.com Wed Feb 9 18:16:59 2011 From: tom.rodriguez at oracle.com (tom.rodriguez at oracle.com) Date: Thu, 10 Feb 2011 02:16:59 +0000 Subject: hg: hsx/hsx20/baseline: 7016474: string compare intrinsic improvements Message-ID: <20110210021701.2E56C4757C@hg.openjdk.java.net> Changeset: e9a2b8e0572a Author: never Date: 2011-02-09 15:02 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/e9a2b8e0572a 7016474: string compare intrinsic improvements Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad From tom.rodriguez at oracle.com Wed Feb 9 18:40:31 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 9 Feb 2011 18:40:31 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: <4D53448E.60706@oracle.com> References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> <4D533AB9.2060206@oracle.com> <3311F28E-EDAF-4270-B807-15200E044856@oracle.com> <4D53448E.60706@oracle.com> Message-ID: <0BB30DC5-E9D8-484A-975B-2A91375DD1DA@oracle.com> On Feb 9, 2011, at 5:51 PM, Vladimir Kozlov wrote: > Tom Rodriguez wrote: >> I removed the no longer correct part. Did you want something added? > > Is next description is still valid? > > 77 // [EMBEDDED Java vtable ] size in words = vtable_len > 78 // [EMBEDDED static oop fields ] size in words = static_oop_fields_size > 79 // [ static non-oop fields ] size in words = static_field_size - static_oop_fields_size > 80 // [EMBEDDED nonstatic oop-map blocks] size in words = nonstatic_oop_map_size I removed lines 78 and 79 but the rest is still correct I think. > >>> I don't understand changes in Unsafe_StaticFieldBaseFromClass(), >>> it should return handle but you just return original jobject. >> We're supposed to return the object to use as the base of unsafe static field references. That's just the java.lang.Class instance which was passed in so we simply return it. What would you expect it to do? I guess we might want to unhandle it and return a new local one in case the original one wasn't a local handle. Is that what you're getting at? > > Thank you for explaining. Code is good. I've changed it to return a new local handle as that seems less surprising. @@ -704,7 +704,7 @@ UNSAFE_ENTRY(jobject, Unsafe_StaticField if (clazz == NULL) { THROW_0(vmSymbols::java_lang_NullPointerException()); } - return JNIHandles::make_local(env, java_lang_Class::as_klassOop(JNIHandles::resolve_non_null(clazz))); + return JNIHandles::make_local(env, JNIHandles::resolve_non_null(clazz)); UNSAFE_END UNSAFE_ENTRY(void, Unsafe_EnsureClassInitialized(JNIEnv *env, jobject unsafe, jobject clazz)) I've regenerated the webrev. tom > > Vladimir > >> tom >>> Thanks, >>> Vladimir >>> >>> Tom Rodriguez wrote: >>>> I've updated the webrev with this change, fixed a couple macro names that still referenced InstanceKlass and fixed the alignment of the continuation slashes. >>>> tom >>>> On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: >>>>> On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >>>>>> http://cr.openjdk.java.net/~never/7017732 >>>>> src/cpu/x86/vm/c1_CodeStubs_x86.cpp: >>>>> >>>>> 315 Register tmp = rax; >>>>> 316 Register tmp2 = rbx; >>>>> 317 if (_obj == tmp) tmp = rcx; >>>>> 318 else if (_obj == tmp2) tmp = rcx; >>>>> 319 __ push(tmp); >>>>> 320 __ push(tmp2); >>>>> 321 __ get_thread(tmp); >>>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>>> 324 __ pop(tmp2); >>>>> 325 __ pop(tmp); >>>>> >>>>> Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: >>>>> >>>>> 315 Register tmp = rax; >>>>> 316 Register tmp2 = rbx; >>>>> 319 __ push(tmp); >>>>> 320 __ push(tmp2); >>>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>>> 321 __ get_thread(tmp); >>>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>>> 324 __ pop(tmp2); >>>>> 325 __ pop(tmp); >>>>> >>>>> -- Christian From vladimir.kozlov at oracle.com Wed Feb 9 18:56:00 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 09 Feb 2011 18:56:00 -0800 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: <0BB30DC5-E9D8-484A-975B-2A91375DD1DA@oracle.com> References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> <4D533AB9.2060206@oracle.com> <3311F28E-EDAF-4270-B807-15200E044856@oracle.com> <4D53448E.60706@oracle.com> <0BB30DC5-E9D8-484A-975B-2A91375DD1DA@oracle.com> Message-ID: <4D5353C0.4050404@oracle.com> Looks good. Vladimir Tom Rodriguez wrote: > On Feb 9, 2011, at 5:51 PM, Vladimir Kozlov wrote: > >> Tom Rodriguez wrote: >>> I removed the no longer correct part. Did you want something added? >> Is next description is still valid? >> >> 77 // [EMBEDDED Java vtable ] size in words = vtable_len >> 78 // [EMBEDDED static oop fields ] size in words = static_oop_fields_size >> 79 // [ static non-oop fields ] size in words = static_field_size - static_oop_fields_size >> 80 // [EMBEDDED nonstatic oop-map blocks] size in words = nonstatic_oop_map_size > > I removed lines 78 and 79 but the rest is still correct I think. > >>>> I don't understand changes in Unsafe_StaticFieldBaseFromClass(), >>>> it should return handle but you just return original jobject. >>> We're supposed to return the object to use as the base of unsafe static field references. That's just the java.lang.Class instance which was passed in so we simply return it. What would you expect it to do? I guess we might want to unhandle it and return a new local one in case the original one wasn't a local handle. Is that what you're getting at? >> Thank you for explaining. Code is good. > > I've changed it to return a new local handle as that seems less surprising. > > @@ -704,7 +704,7 @@ UNSAFE_ENTRY(jobject, Unsafe_StaticField > if (clazz == NULL) { > THROW_0(vmSymbols::java_lang_NullPointerException()); > } > - return JNIHandles::make_local(env, java_lang_Class::as_klassOop(JNIHandles::resolve_non_null(clazz))); > + return JNIHandles::make_local(env, JNIHandles::resolve_non_null(clazz)); > UNSAFE_END > > UNSAFE_ENTRY(void, Unsafe_EnsureClassInitialized(JNIEnv *env, jobject unsafe, jobject clazz)) > > I've regenerated the webrev. > > tom > >> Vladimir >> >>> tom >>>> Thanks, >>>> Vladimir >>>> >>>> Tom Rodriguez wrote: >>>>> I've updated the webrev with this change, fixed a couple macro names that still referenced InstanceKlass and fixed the alignment of the continuation slashes. >>>>> tom >>>>> On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: >>>>>> On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >>>>>>> http://cr.openjdk.java.net/~never/7017732 >>>>>> src/cpu/x86/vm/c1_CodeStubs_x86.cpp: >>>>>> >>>>>> 315 Register tmp = rax; >>>>>> 316 Register tmp2 = rbx; >>>>>> 317 if (_obj == tmp) tmp = rcx; >>>>>> 318 else if (_obj == tmp2) tmp = rcx; >>>>>> 319 __ push(tmp); >>>>>> 320 __ push(tmp2); >>>>>> 321 __ get_thread(tmp); >>>>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>>>> 324 __ pop(tmp2); >>>>>> 325 __ pop(tmp); >>>>>> >>>>>> Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: >>>>>> >>>>>> 315 Register tmp = rax; >>>>>> 316 Register tmp2 = rbx; >>>>>> 319 __ push(tmp); >>>>>> 320 __ push(tmp2); >>>>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>>>> 321 __ get_thread(tmp); >>>>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>>>> 324 __ pop(tmp2); >>>>>> 325 __ pop(tmp); >>>>>> >>>>>> -- Christian > From christian.thalinger at oracle.com Thu Feb 10 01:07:18 2011 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Thu, 10 Feb 2011 10:07:18 +0100 Subject: review (L) for 7017732: move static fields into Class to prepare for perm gen removal In-Reply-To: <0BB30DC5-E9D8-484A-975B-2A91375DD1DA@oracle.com> References: <33AEF62A-EE62-48FF-B9D6-B38A73443590@oracle.com> <4D533AB9.2060206@oracle.com> <3311F28E-EDAF-4270-B807-15200E044856@oracle.com> <4D53448E.60706@oracle.com> <0BB30DC5-E9D8-484A-975B-2A91375DD1DA@oracle.com> Message-ID: <3C5028C8-1C34-4267-916B-D9BEA461521D@oracle.com> Yes, looks good. -- Christian On Feb 10, 2011, at 3:40 AM, Tom Rodriguez wrote: > > On Feb 9, 2011, at 5:51 PM, Vladimir Kozlov wrote: > >> Tom Rodriguez wrote: >>> I removed the no longer correct part. Did you want something added? >> >> Is next description is still valid? >> >> 77 // [EMBEDDED Java vtable ] size in words = vtable_len >> 78 // [EMBEDDED static oop fields ] size in words = static_oop_fields_size >> 79 // [ static non-oop fields ] size in words = static_field_size - static_oop_fields_size >> 80 // [EMBEDDED nonstatic oop-map blocks] size in words = nonstatic_oop_map_size > > I removed lines 78 and 79 but the rest is still correct I think. > >> >>>> I don't understand changes in Unsafe_StaticFieldBaseFromClass(), >>>> it should return handle but you just return original jobject. >>> We're supposed to return the object to use as the base of unsafe static field references. That's just the java.lang.Class instance which was passed in so we simply return it. What would you expect it to do? I guess we might want to unhandle it and return a new local one in case the original one wasn't a local handle. Is that what you're getting at? >> >> Thank you for explaining. Code is good. > > I've changed it to return a new local handle as that seems less surprising. > > @@ -704,7 +704,7 @@ UNSAFE_ENTRY(jobject, Unsafe_StaticField > if (clazz == NULL) { > THROW_0(vmSymbols::java_lang_NullPointerException()); > } > - return JNIHandles::make_local(env, java_lang_Class::as_klassOop(JNIHandles::resolve_non_null(clazz))); > + return JNIHandles::make_local(env, JNIHandles::resolve_non_null(clazz)); > UNSAFE_END > > UNSAFE_ENTRY(void, Unsafe_EnsureClassInitialized(JNIEnv *env, jobject unsafe, jobject clazz)) > > I've regenerated the webrev. > > tom > >> >> Vladimir >> >>> tom >>>> Thanks, >>>> Vladimir >>>> >>>> Tom Rodriguez wrote: >>>>> I've updated the webrev with this change, fixed a couple macro names that still referenced InstanceKlass and fixed the alignment of the continuation slashes. >>>>> tom >>>>> On Feb 9, 2011, at 3:52 AM, Christian Thalinger wrote: >>>>>> On Feb 8, 2011, at 11:01 PM, Tom Rodriguez wrote: >>>>>>> http://cr.openjdk.java.net/~never/7017732 >>>>>> src/cpu/x86/vm/c1_CodeStubs_x86.cpp: >>>>>> >>>>>> 315 Register tmp = rax; >>>>>> 316 Register tmp2 = rbx; >>>>>> 317 if (_obj == tmp) tmp = rcx; >>>>>> 318 else if (_obj == tmp2) tmp = rcx; >>>>>> 319 __ push(tmp); >>>>>> 320 __ push(tmp2); >>>>>> 321 __ get_thread(tmp); >>>>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>>>> 324 __ pop(tmp2); >>>>>> 325 __ pop(tmp); >>>>>> >>>>>> Why do you change tmp if _obj == tmp2? I think line 318 isn't required at all since if _obj == tmp2 it gets saved and restored anyway. What about this: >>>>>> >>>>>> 315 Register tmp = rax; >>>>>> 316 Register tmp2 = rbx; >>>>>> 319 __ push(tmp); >>>>>> 320 __ push(tmp2); >>>>>> 322 __ movptr(tmp2, Address(_obj, java_lang_Class::klass_offset_in_bytes())); >>>>>> 321 __ get_thread(tmp); >>>>>> 323 __ cmpptr(tmp, Address(tmp2, instanceKlass::init_thread_offset_in_bytes() + sizeof(klassOopDesc))); >>>>>> 324 __ pop(tmp2); >>>>>> 325 __ pop(tmp); >>>>>> >>>>>> -- Christian From staffan.larsen at oracle.com Thu Feb 10 07:06:44 2011 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 10 Feb 2011 07:06:44 -0800 (PST) Subject: Request for review (M) 7017824: Add support for creating 64-bit Visual Studio projects Message-ID: <1e0d678e-68aa-43da-8591-b78aab96cc3c@default> http://cr.openjdk.java.net/~sla/7017824/webrev.00/ The current make\windows\create.bat script can only create visual studio projects for 32-bit targets (Win32), it should also be possible to create 64-bit targets (x64). This fix generates two different project files, one for 32-bit target and one for 64-bit targets. While it would be great to have both targets in the same project, the current tools are not written in a way that makes it easy to fix this. The simple solution is two different projects: vs-i486\jvm.vcproj and vs-amd64\jvm.vcproj. The create.bat script will detect which target to create by checking which version of the cl.exe compiler is in the PATH. I have also removed the define of MSC_VER when invoking the complier. Instead the define _MSC_VER is used, which is defined by the compiler. Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110210/c8d0f6a0/attachment-0001.html From tom.rodriguez at oracle.com Thu Feb 10 14:28:35 2011 From: tom.rodriguez at oracle.com (tom.rodriguez at oracle.com) Date: Thu, 10 Feb 2011 22:28:35 +0000 Subject: hg: hsx/hsx20/baseline: 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Message-ID: <20110210222840.AE3BC475BD@hg.openjdk.java.net> Changeset: ac21d3bfa63b Author: never Date: 2011-02-10 12:16 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/ac21d3bfa63b 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Reviewed-by: acorn, kvn, dsamersoff ! src/os/solaris/vm/os_solaris.cpp From john.coomes at oracle.com Thu Feb 10 20:32:40 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:32:40 +0000 Subject: hg: jdk7/hotspot: 4 new changesets Message-ID: <20110211043240.3E68F47630@hg.openjdk.java.net> Changeset: ce02c0d73d6a Author: ohair Date: 2011-02-03 15:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/ce02c0d73d6a 7014634: By default, only build the product bits with a closed jdk build (like openjdk does) Reviewed-by: katleman, cl, igor, trims ! make/Defs-internal.gmk Changeset: e2a214ec8ebc Author: ohair Date: 2011-02-04 07:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/e2a214ec8ebc Merge Changeset: a6b015b59fbc Author: ohair Date: 2011-02-08 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/a6b015b59fbc 7016976: Documentation for required ant version on JDK7 builds on Solaris 10 and Solaris 11 Reviewed-by: rinaldo ! README-builds.html Changeset: cc58c11af154 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/cc58c11af154 Added tag jdk7-b129 for changeset a6b015b59fbc ! .hgtags From john.coomes at oracle.com Thu Feb 10 20:32:47 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:32:47 +0000 Subject: hg: jdk7/hotspot/corba: 3 new changesets Message-ID: <20110211043253.1D86B47631@hg.openjdk.java.net> Changeset: 6a3903e5b6cc Author: ohair Date: 2011-02-03 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/6a3903e5b6cc 6944304: Potential rebranding issues in the openjdk7/corba sources Reviewed-by: alanb, mchung, darcy ! src/share/classes/com/sun/corba/se/spi/logging/data/Activation.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/IOR.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/Interceptors.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/Naming.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/OMG.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/ORBUtil.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/POA.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/Util.mc Changeset: 66fa0fcc7792 Author: ohair Date: 2011-02-04 07:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/66fa0fcc7792 Merge Changeset: 4cdf9b86f550 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/4cdf9b86f550 Added tag jdk7-b129 for changeset 66fa0fcc7792 ! .hgtags From john.coomes at oracle.com Thu Feb 10 20:33:00 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:33:00 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b129 for changeset f5b60c5a310f Message-ID: <20110211043300.38CCE47632@hg.openjdk.java.net> Changeset: ab107c1bc4b9 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/ab107c1bc4b9 Added tag jdk7-b129 for changeset f5b60c5a310f ! .hgtags From john.coomes at oracle.com Thu Feb 10 20:33:06 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:33:06 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b129 for changeset 0f7b39ad9024 Message-ID: <20110211043307.1A02347633@hg.openjdk.java.net> Changeset: ba1fac1c2083 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/ba1fac1c2083 Added tag jdk7-b129 for changeset 0f7b39ad9024 ! .hgtags From john.coomes at oracle.com Thu Feb 10 20:33:17 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:33:17 +0000 Subject: hg: jdk7/hotspot/jdk: 5 new changesets Message-ID: <20110211043425.CBC3647634@hg.openjdk.java.net> Changeset: 001dcfd0be4b Author: ohair Date: 2011-02-08 16:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/001dcfd0be4b 7016976: Documentation for required ant version on JDK7 builds on Solaris 10 and Solaris 11 Reviewed-by: rinaldo ! make/common/shared/Defs-versions.gmk ! make/common/shared/Sanity.gmk Changeset: 1f056ddda771 Author: ohair Date: 2011-01-28 14:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1f056ddda771 7014301: Change make 3.81 sanity check to a fatal, 3.81 is needed now Reviewed-by: alanb ! make/common/shared/Sanity.gmk Changeset: 3f77dae85c85 Author: ohair Date: 2011-02-08 13:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3f77dae85c85 Merge Changeset: 14cd5d54a8d0 Author: ohair Date: 2011-02-08 20:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/14cd5d54a8d0 Merge ! make/common/shared/Sanity.gmk Changeset: 326aac19a89f Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/326aac19a89f Added tag jdk7-b129 for changeset 14cd5d54a8d0 ! .hgtags From john.coomes at oracle.com Thu Feb 10 20:34:43 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:34:43 +0000 Subject: hg: jdk7/hotspot/langtools: 22 new changesets Message-ID: <20110211043529.58B6347635@hg.openjdk.java.net> Changeset: d17f37522154 Author: jjg Date: 2011-01-10 14:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/d17f37522154 6992999: fully remove JSR 308 from langtools Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java - src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java - src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java - src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java - src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! test/tools/javac/diags/examples.not-yet.txt Changeset: 7c537f4298fb Author: jjg Date: 2011-01-10 15:08 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/7c537f4298fb 6396503: javac should not require assertions enabled Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/Main.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java + src/share/classes/com/sun/tools/javac/util/Assert.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java ! src/share/classes/javax/tools/ToolProvider.java Changeset: 17b271281525 Author: jjg Date: 2011-01-11 08:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/17b271281525 6993305: starting position of a method without modifiers and with type parameters is incorrect Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/tree/T6993305.java Changeset: d33d8c381aa1 Author: jjg Date: 2011-01-13 11:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/d33d8c381aa1 6430241: Hard to disable symbol file feature through API Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java + test/tools/javac/api/T6430241.java Changeset: a466f00c5cd2 Author: bpatel Date: 2011-01-13 21:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/a466f00c5cd2 7010528: javadoc performance regression Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java Changeset: 2d5aff89aaa3 Author: mcimadamore Date: 2011-01-14 09:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/2d5aff89aaa3 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls Summary: special syntax to denote indy return type through type parameters should be removed (and cast shall be used instead) Reviewed-by: jjg, jrose ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/Names.java - test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/meth/InvokeMHTrans.java - test/tools/javac/meth/InvokeMHTrans.out ! test/tools/javac/meth/TestCP.java ! test/tools/javac/meth/XlintWarn.java Changeset: c8d312dd17bc Author: mcimadamore Date: 2011-01-14 09:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/c8d312dd17bc 7007432: Test generic types well-formedness Summary: add a new kind of check (well-formedness of generic type w.r.t. declared bounds) in the type-harness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/types/GenericTypeWellFormednessTest.java ! test/tools/javac/types/TypeHarness.java Changeset: 712be35e40b5 Author: mcimadamore Date: 2011-01-14 09:46 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/712be35e40b5 6949040: java.dyn package must be compiled with -target 7 or better Summary: issue error (rather than warning) when @PolymorphicSignature is found and target < 7 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt Changeset: 7c7c1787fbbe Author: jjg Date: 2011-01-14 11:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/7c7c1787fbbe 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris) Reviewed-by: mcimadamore + test/tools/javac/api/T6419926.java Changeset: 0a509c765657 Author: jjg Date: 2011-01-14 11:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/0a509c765657 6571165: Minor doc bugs in JavaCompiler.java Reviewed-by: mcimadamore ! src/share/classes/javax/tools/JavaCompiler.java Changeset: 19f9b6548c70 Author: ksrini Date: 2011-01-14 13:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/19f9b6548c70 7011272: langtools build.xml should provide a patch target Reviewed-by: jonathan, jjh ! make/build.xml Changeset: 5cf6c432ef2f Author: ksrini Date: 2011-01-18 08:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/5cf6c432ef2f 6982999: tools must support -target 7 bytecodes Reviewed-by: jjg, jrose ! src/share/classes/com/sun/tools/classfile/Attribute.java + src/share/classes/com/sun/tools/classfile/BootstrapMethods_attribute.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java Changeset: b6f95173e769 Author: lana Date: 2011-01-19 19:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/b6f95173e769 Merge Changeset: 19c900c703c6 Author: mcimadamore Date: 2011-01-24 15:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/19c900c703c6 6943278: spurious error message for inference and type-variable with erroneous bound Summary: type-inference should ignore erroneous bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6943278/T6943278.java + test/tools/javac/generics/inference/6943278/T6943278.out Changeset: ce6175cfe11e Author: mcimadamore Date: 2011-01-24 15:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ce6175cfe11e 6968793: issues with diagnostics Summary: several diagnostic improvements Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6304921/T6304921.out ! test/tools/javac/6330920/T6330920.out ! test/tools/javac/6717241/T6717241a.out ! test/tools/javac/6717241/T6717241b.out ! test/tools/javac/6857948/T6857948.out ! test/tools/javac/6863465/T6863465c.out ! test/tools/javac/6863465/T6863465d.out ! test/tools/javac/T6247324.out ! test/tools/javac/TryWithResources/ResourceOutsideTry.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CantResolve.java ! test/tools/javac/diags/examples/CantResolveArgsParams.java ! test/tools/javac/diags/examples/CantResolveLocation.java ! test/tools/javac/diags/examples/CantResolveLocationArgs.java ! test/tools/javac/diags/examples/CantResolveLocationArgsParams.java - test/tools/javac/diags/examples/EnumConstRequired.java ! test/tools/javac/diags/examples/ForeachNotApplicable.java ! test/tools/javac/diags/examples/KindnameClass.java ! test/tools/javac/diags/examples/KindnameMethod.java ! test/tools/javac/diags/examples/KindnameVariable.java + test/tools/javac/diags/examples/Location.java + test/tools/javac/diags/examples/Location1.java ! test/tools/javac/diags/examples/OperatorCantBeApplied.java + test/tools/javac/diags/examples/OperatorCantBeApplied1.java ! test/tools/javac/diags/examples/StaticImportOnlyClassesAndInterfaces/StaticImportOnlyClassesAndInterfaces.java ! test/tools/javac/failover/FailOver01.out ! test/tools/javac/failover/FailOver02.out ! test/tools/javac/failover/FailOver04.out ! test/tools/javac/generics/6711619/T6711619a.out ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.out ! test/tools/javac/generics/diamond/neg/Neg11.out ! test/tools/javac/generics/inference/6943278/T6943278.out ! test/tools/javac/generics/typevars/5060485/Compatibility.out ! test/tools/javac/generics/typevars/5060485/Compatibility02.out + test/tools/javac/generics/typevars/6968793/T6968793.java + test/tools/javac/generics/typevars/6968793/T6968793.out ! test/tools/javac/policy/test1/byfile.ABD.out ! test/tools/javac/policy/test1/bytodo.ABD.out ! test/tools/javac/policy/test1/simple.ABD.out Changeset: 02e6e7dd1a64 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/02e6e7dd1a64 6510286: Wording of javac error for inner classes Summary: 'inner classes cannot have static declarations' message needs to be reworked Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/InnerNamedConstant_2.out Changeset: 812c6251ea78 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/812c6251ea78 6569633: Varargs: parser error when varargs element type is an array Summary: explicit error message when old-style array syntax is mixed with varargs Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/VarargsAndOldArraySyntax.java + test/tools/javac/varargs/6569633/T6569633.java + test/tools/javac/varargs/6569633/T6569633.out Changeset: 57e3b9bc7fb8 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/57e3b9bc7fb8 7013865: varargs: javac crashes during overload resolution with generic varargs Summary: fixed regression with varargs overload resolution that leads javac to crash Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/varargs/T7013865.java Changeset: 2314f2b07ae7 Author: lana Date: 2011-01-24 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/2314f2b07ae7 Merge - src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java - src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java - src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java - test/tools/javac/diags/examples/EnumConstRequired.java - test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/meth/InvokeMHTrans.java - test/tools/javac/meth/InvokeMHTrans.out Changeset: d7225b476a5d Author: lana Date: 2011-01-28 10:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/d7225b476a5d Merge - src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java - src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java - src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java - test/tools/javac/diags/examples/EnumConstRequired.java - test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/meth/InvokeMHTrans.java - test/tools/javac/meth/InvokeMHTrans.out Changeset: 1383d1ee8b5d Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/1383d1ee8b5d Added tag jdk7-b128 for changeset d7225b476a5d ! .hgtags Changeset: 03e7fc380090 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/03e7fc380090 Added tag jdk7-b129 for changeset 1383d1ee8b5d ! .hgtags From bengt.rutisson at oracle.com Thu Feb 10 22:16:56 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Fri, 11 Feb 2011 07:16:56 +0100 Subject: Request for review (M) 7017824: Add support for creating 64-bit Visual Studio projects In-Reply-To: <1e0d678e-68aa-43da-8591-b78aab96cc3c@default> References: <1e0d678e-68aa-43da-8591-b78aab96cc3c@default> Message-ID: <4D54D458.20904@oracle.com> Looks good, Staffan! I tried creating an x64 project and it works excellent. A couple of questions: * Do we have to allow duplicates file names due to the closed src (WinGammaPlatform.java 238-244)? * Are the Eclipse autogenerated methods in WinGammaPlatformVC7.java needed? Should they be included? * When I bild an x64 project in Visual Studio I get to choose between Win32 and x64 in the platform drop down list. The Win32 platform does not build (expected behaviour). Could that be removed from the drop down? This is not important it is easy to select x64, so no show stopper. And minor thing. Copyright year should be 2011 for all files. Thanks for fixing this! Bengt On 2011-02-10 16:06, Staffan Larsen wrote: > > http://cr.openjdk.java.net/~sla/7017824/webrev.00/ > > > The current make\windows\create.bat script can only create visual > studio projects for 32-bit targets (Win32), it should also be possible > to create 64-bit targets (x64). > > This fix generates two different project files, one for 32-bit target > and one for 64-bit targets. While it would be great to have both > targets in the same project, the current tools are not written in a > way that makes it easy to fix this. The simple solution is two > different projects: vs-i486\jvm.vcproj and vs-amd64\jvm.vcproj. > > The create.bat script will dete! ct which target to create by checking > which version of the cl.exe compiler is in the PATH. > > I have also removed the define of MSC_VER when invoking the complier. > Instead the define _/MSC/_VER is used, which is defined by the compiler. > > Thanks, > > /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110211/6fd6974a/attachment.html From staffan.larsen at oracle.com Fri Feb 11 00:06:11 2011 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 11 Feb 2011 00:06:11 -0800 (PST) Subject: Request for review (M) 7017824: Add support for creating 64-bit Visual Studio projects In-Reply-To: <4D54D458.20904@oracle.com> References: <1e0d678e-68aa-43da-8591-b78aab96cc3c@default 4D54D458.20904@oracle.com> Message-ID: Thanks Bengt. Answers inline. From: Bengt Rutisson Sent: den 11 februari 2011 07:17 To: hotspot-dev at openjdk.java.net Subject: Re: Request for review (M) 7017824: Add support for creating 64-bit Visual Studio projects Looks good, Staffan! I tried creating an x64 project and it works excellent. A couple of questions: * Do we have to allow duplicates file names due to the closed src (WinGammaPlatform.java 238-244)? Yes. If the closed dir is present, I will prefer those files (see BuildConfig.getPreferredPaths()). * Are the Eclipse autogenerated methods in WinGammaPlatformVC7.java needed? Should they be included? Yes, I started doing .equals on the filters (see makeFilters()) and just let eclipse do the implementation for me. * When I bild an x64 project in Visual Studio I get to choose between Win32 and x64 in the platform drop down list. The Win32 platform does not build (expected behaviour). Could that be removed from the drop down? This is not important it is easy to select x64, so no show stopper. I wish it could be removed. It's not present in the vcproj files so it is something that visual studio adds all by itself. And minor thing. Copyright year should be 2011 for all files. Will fix! Thanks for fixing this! Bengt On 2011-02-10 16:06, Staffan Larsen wrote: HYPERLINK "http://cr.openjdk.java.net/%7Esla/7017824/webrev.00/"http://cr.openjdk.java.net/~sla/7017824/webrev.00/ The current make\windows\create.bat script can only create visual studio projects for 32-bit targets (Win32), it should also be possible to create 64-bit targets (x64). This fix generates two different project files, one for 32-bit target and one for 64-bit targets. While it would be great to have both targets in the same project, the current tools are not written in a way that makes it easy to fix this. The simple solution is two different projects: vs-i486\jvm.vcproj and vs-amd64\jvm.vcproj. The create.bat script will dete! ct which target to create by checking which version of the cl.exe compiler is in the PATH. I have also removed the define of MSC_VER when invoking the complier. Instead the define _MSC_VER is used, which is defined by the compiler. Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110211/ab4fffc3/attachment.html From volker.simonis at gmail.com Fri Feb 11 10:24:09 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 11 Feb 2011 19:24:09 +0100 Subject: RFE: configuration for compiling HotSpot with Clang Message-ID: Hi, at the FOSEDM I've heard Chris Lattner's very nice "LLVM and Clang" keynote. The claims he made in his talk have been very impressing: he was speaking about Clang being a "production quality" "drop-in replacement" for GCC with superior code generation and improved compile speed. Already during the talk I decided that I would be interesting to prove his pretensions on the HotSpot VM. If you're interested in the details you can read my blog: http://weblogs.java.net/blog/simonis/archive/2011/02/10/compiling-hotspot-vm-clang For the impatient the summary is that Clang is still slower than current GCC versions and the generated code seems to be slightly slower as well. Nevertheless, Clang has excellent warning capabilities and is an excellent C++ compiler with regard to C++ conformance. (Now it's probably a good time to finally fix http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6889002 which I've promised already more than a year ago at http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-October/thread.html#2175 :) Attached you can find a patch which contains a Clang configuration for the HotSpot build (Linux x86/x86_64). A Clang make can be triggered by passing "USE_CLANG=true" to the make command. Warnings are currently turned off for the reasons mentioned above. This patch may also be interesting in the context of the new MacOs X port, where Clang is much more common (or perhaps even the default C++ compiler - i don't know?). Notice that this patch contains one additional change compared to the patch in the blog. While I did the tests for the blog with an slightly outdated HS20b03 I synced a brand new version today to prepare the patch. With this new version I found a true C++ bug in "src/share/vm/utilities/hashtable.hpp" which was introduced recently by the "6990754: Use native memory and reference counting to implement SymbolTable" change and which has to do with name lookup of nondependent names in dependent base classes (see http://www.parashift.com/c++-faq-lite/templates.html#faq-35.19 for a nice explanation). Wouldn't have happened with Clang:) Regards, Volker -------------- next part -------------- A non-text attachment was scrubbed... Name: clang.patch Type: text/x-patch Size: 20085 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110211/d0467981/attachment-0001.bin From robert.ottenhag at oracle.com Fri Feb 11 11:23:38 2011 From: robert.ottenhag at oracle.com (robert.ottenhag at oracle.com) Date: Fri, 11 Feb 2011 19:23:38 +0000 Subject: hg: jdk7/hotspot/hotspot: 8 new changesets Message-ID: <20110211192352.5449A4767A@hg.openjdk.java.net> Changeset: d8a72fbc4be7 Author: kamg Date: 2011-02-08 17:20 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/d8a72fbc4be7 7003401: Implement VM error-reporting functionality on erroneous termination Summary: Add support for distribution-specific error reporting Reviewed-by: coleenp, phh, jcoomes, ohair ! make/Makefile + make/altsrc.make - make/closed.make ! make/linux/makefiles/adlc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/top.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/top.make ! make/solaris/makefiles/vm.make ! make/windows/create_obj_files.sh ! make/windows/makefiles/vm.make ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp + src/share/vm/utilities/errorReporter.cpp + src/share/vm/utilities/errorReporter.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/vmError.cpp Changeset: fb539912d338 Author: coleenp Date: 2011-02-07 14:36 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/fb539912d338 6472925: OutOfMemoryError fails to generate stack trace as it now ought Summary: Print an additional message for OOM during stack trace printing Reviewed-by: dholmes, phh, acorn, kamg, dcubed ! src/share/vm/runtime/thread.cpp Changeset: 5fb3ee258e76 Author: coleenp Date: 2011-02-08 19:50 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5fb3ee258e76 Merge - make/closed.make Changeset: f36c9fe788b8 Author: mchung Date: 2011-02-08 09:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f36c9fe788b8 7017673: Remove setting of the sun.jkernel.DownloadManager as a boot classloader hook Reviewed-by: alanb, dcubed, coleenp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/thread.cpp Changeset: 5197f3d713a1 Author: mchung Date: 2011-02-08 22:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5197f3d713a1 Merge - make/closed.make ! src/share/vm/runtime/thread.cpp Changeset: 63d374c54045 Author: ctornqvi Date: 2011-02-09 11:08 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/63d374c54045 7014918: Improve core/minidump handling in Hotspot Summary: Added Minidump support on Windows, enabled large page core dumps when coredump_filter is present and writing out path/rlimit for core dumps. Reviewed-by: poonam, dsamersoff, sla, coleenp ! src/os/linux/vm/os_linux.cpp + src/os/posix/vm/os_posix.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp Changeset: b83527d0482d Author: ctornqvi Date: 2011-02-10 12:55 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b83527d0482d 7018366: hotspot/runtime_erro Fix for 7014918 does not build using MVC 2003 Summary: Looking at API_VERSION_NUMBER define to see what version of dbghelp.h/imagehlp.h is included to determine what MINIDUMP_TYPEs are defined in the header file Reviewed-by: acorn, brutisso, sla ! src/os/windows/vm/os_windows.cpp Changeset: e1523f7fd848 Author: rottenha Date: 2011-02-11 05:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e1523f7fd848 Merge - make/closed.make From mark at klomp.org Fri Feb 11 12:55:40 2011 From: mark at klomp.org (Mark Wielaard) Date: Fri, 11 Feb 2011 21:55:40 +0100 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: References: Message-ID: <1297457740.3181.15.camel@springer.wildebeest.org> Hi Volker, On Fri, 2011-02-11 at 19:24 +0100, Volker Simonis wrote: > at the FOSEDM I've heard Chris Lattner's very nice "LLVM and Clang" > keynote. The claims he made in his talk have been very impressing: he > was speaking about Clang being a "production quality" "drop-in > replacement" for GCC with superior code generation and improved > compile speed. Already during the talk I decided that I would be > interesting to prove his pretensions on the HotSpot VM. If you're > interested in the details you can read my blog: > > http://weblogs.java.net/blog/simonis/archive/2011/02/10/compiling-hotspot-vm-clang > > For the impatient the summary is that Clang is still slower than > current GCC versions and the generated code seems to be slightly > slower as well. Nice. Good that someone double checks such claims. Sad that the results are somewhat over-hyped. If you like doing more benchmarks then you really should try with a newer gcc release. GCC 4.5 is the latest, which is both faster at compiling (about 10%) and produces faster code (up to 4%) compared with earlier GCC releases. See http://gcc.gnu.org/ml/gcc/2010-04/msg00948.html GCC also has Link Time Optimization (LTO) and Feedback Driven or Profile Guided Optimization (FDO/PGO) which can (when combined) provide an additional 10% speedup of code: http://gcc.gnu.org/ml/gcc/2010-11/msg00386.html This can be somewhat trickier to setup though and is somewhat experimental. But Mozilla has been experimenting with it for firefox and got some impressive code size reductions (up to 11% smaller code, that also executes faster). Compile and link times do increase though. See http://gcc.gnu.org/wiki/summit2010?action=AttachFile&do=get&target=hubicka.pdf Cheers, Mark From mark at klomp.org Fri Feb 11 13:37:53 2011 From: mark at klomp.org (Mark Wielaard) Date: Fri, 11 Feb 2011 22:37:53 +0100 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: References: Message-ID: <1297460273.3181.19.camel@springer.wildebeest.org> On Fri, 2011-02-11 at 19:24 +0100, Volker Simonis wrote: > Notice that this patch contains one additional change compared to the > patch in the blog. While I did the tests for the blog with an slightly > outdated HS20b03 I synced a brand new version today to prepare the > patch. With this new version I found a true C++ bug in > "src/share/vm/utilities/hashtable.hpp" which was introduced recently > by the "6990754: Use native memory and reference counting to implement > SymbolTable" change and which has to do with name lookup of > nondependent names in dependent base classes (see > http://www.parashift.com/c++-faq-lite/templates.html#faq-35.19 for a > nice explanation). Wouldn't have happened with Clang:) I didn't try building HS20b03 yet, but g++ (at least version 4.1, 4.4 and 4.5) should be able to detect this. Trying to compile the FAQ example gives: t.cpp: In member function ?void D::g()?: t.cpp:12:8: error: there are no arguments to ?f? that depend on a template parameter, so a declaration of ?f? must be available t.cpp:12:8: note: (if you use ?-fpermissive?, G++ will accept your code, but allowing the use of an undeclared name is deprecated) If g++ didn't detect it in the hashtable.hpp case, could you file a bug report for it http://gcc.gnu.org/bugzilla Thanks, Mark From abhi.saha at oracle.com Fri Feb 11 20:10:39 2011 From: abhi.saha at oracle.com (abhi.saha at oracle.com) Date: Sat, 12 Feb 2011 04:10:39 +0000 Subject: hg: hsx/hsx20/baseline: 6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented Message-ID: <20110212041044.417F24769E@hg.openjdk.java.net> Changeset: befa5106b5e9 Author: poonam Date: 2011-02-11 09:16 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/befa5106b5e9 6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented Reviewed-by: ysr, minqi ! src/share/vm/gc_implementation/shared/allocationStats.hpp From john.r.rose at oracle.com Sat Feb 12 00:41:07 2011 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Sat, 12 Feb 2011 08:41:07 +0000 Subject: hg: jdk7/hotspot/jdk: 3 new changesets Message-ID: <20110212084137.C4A30476B0@hg.openjdk.java.net> Changeset: d7de46ec011b Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d7de46ec011b 7013417: JSR 292 needs to support variadic method handle calls Summary: Implement MH.asVarargsCollector, etc., and remove withTypeHandler. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodTypeImpl.java ! test/java/dyn/InvokeDynamicPrintArgs.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java ! test/java/dyn/indify/Indify.java Changeset: c86c60ad8822 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c86c60ad8822 7012650: implement JSR 292 EG adjustments through January 2010 Summary: misc. EG changes and polishes (excluding 7013417) Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/ClassValue.java ! src/share/classes/java/dyn/ConstantCallSite.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/MutableCallSite.java + src/share/classes/java/dyn/SwitchPoint.java - src/share/classes/java/dyn/Switcher.java ! src/share/classes/java/dyn/VolatileCallSite.java ! src/share/classes/java/dyn/WrongMethodTypeException.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/ToGeneric.java + src/share/classes/sun/dyn/WrapperInstance.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java Changeset: a2241b109aa1 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a2241b109aa1 7013730: JSR 292 reflective operations should report errors with standard exception types Summary: remove NoAccessException, replace it by ReflectiveOperationException subtypes; adjust javadoc of exceptions Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandles.java - src/share/classes/java/dyn/NoAccessException.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java From erik.trimble at oracle.com Sat Feb 12 01:14:42 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Sat, 12 Feb 2011 09:14:42 +0000 Subject: hg: jdk7/hotspot/hotspot: 4 new changesets Message-ID: <20110212091456.25AD6476B4@hg.openjdk.java.net> Changeset: 55b9f498dbce Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/55b9f498dbce Added tag jdk7-b129 for changeset ae4b185f2ed1 ! .hgtags Changeset: 14c2f31280dd Author: trims Date: 2011-02-11 14:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/14c2f31280dd Added tag hs21-b01 for changeset ae4b185f2ed1 ! .hgtags Changeset: 2a9f9f2200fa Author: trims Date: 2011-02-11 15:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/2a9f9f2200fa Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java Changeset: 762bc029de50 Author: trims Date: 2011-02-11 15:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/762bc029de50 7019104: Bump the HS21 build number to 02 Summary: Update the HS21 build number to 02 Reviewed-by: jcoomes ! make/hotspot_version From fweimer at bfk.de Mon Feb 14 02:38:52 2011 From: fweimer at bfk.de (Florian Weimer) Date: Mon, 14 Feb 2011 10:38:52 +0000 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: (Volker Simonis's message of "Fri\, 11 Feb 2011 19\:24\:09 +0100") References: Message-ID: <828vxiew8z.fsf@mid.bfk.de> * Volker Simonis: > For the impatient the summary is that Clang is still slower than > current GCC versions and the generated code seems to be slightly > slower as well. Interesting indeed. Did you use precompiled headers? -- Florian Weimer BFK edv-consulting GmbH http://www.bfk.de/ Kriegsstra?e 100 tel: +49-721-96201-1 D-76133 Karlsruhe fax: +49-721-96201-99 From volker.simonis at gmail.com Mon Feb 14 06:23:04 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 14 Feb 2011 15:23:04 +0100 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: <828vxiew8z.fsf@mid.bfk.de> References: <828vxiew8z.fsf@mid.bfk.de> Message-ID: That's a good point. Yes I used precompiled headers for both configurations - at least I thought I did it. I just reread the section about Precompiled Headers in the Clang Users Manual and stumbled about the following note: "Clang does not automatically use PCH files for headers that are directly included within a source file." This is a small GCC incompatibility which may have a considerable performance impact on compilation times (GCC automatically uses the .gch file for headers which are directly included from the source file, and this is exactly the way how PCH is implemented in HotSpot: there's one "precompiled.hpp" file which includes most of the other headers and which is precompiled at the beginning of the build. This "precompiled.hpp" file is than included in most of the .cpp files.). @Chris: is there any, perhaps undocumented, command line option which changes this behavior? I think this may be a general issue for GCC projects with precompiled headers migrating to Clang. So I plan to do a new series of measurements and take in to account all the other suggestions I got here and by private communication. But please be a little patient - this is just a hobby project for the evenings:) Thank you and best regards, Volker On Mon, Feb 14, 2011 at 11:38 AM, Florian Weimer wrote: > * Volker Simonis: > >> For the impatient the summary is that Clang is still slower than >> current GCC versions and the generated code seems to be slightly >> slower as well. > > Interesting indeed. ?Did you use precompiled headers? > > -- > Florian Weimer ? ? ? ? ? ? ? ? > BFK edv-consulting GmbH ? ? ? http://www.bfk.de/ > Kriegsstra?e 100 ? ? ? ? ? ? ?tel: +49-721-96201-1 > D-76133 Karlsruhe ? ? ? ? ? ? fax: +49-721-96201-99 > From vladimir.kozlov at oracle.com Mon Feb 14 11:15:42 2011 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Mon, 14 Feb 2011 19:15:42 +0000 Subject: hg: hsx/hsx20/baseline: 7017746: Regression : C2 compiler crash due to SIGSEGV in PhaseCFG::schedule_early() Message-ID: <20110214191550.C82AE47730@hg.openjdk.java.net> Changeset: 57090cdd4e01 Author: kvn Date: 2011-02-10 14:25 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/57090cdd4e01 7017746: Regression : C2 compiler crash due to SIGSEGV in PhaseCFG::schedule_early() Summary: Add TEMP edges (and KILL projections) before duplicated operands are removed in Expand() methods. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/node.cpp + test/compiler/7017746/Test.java From clattner at apple.com Mon Feb 14 15:35:45 2011 From: clattner at apple.com (Chris Lattner) Date: Mon, 14 Feb 2011 15:35:45 -0800 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: References: <828vxiew8z.fsf@mid.bfk.de> Message-ID: On Feb 14, 2011, at 6:23 AM, Volker Simonis wrote: > That's a good point. Yes I used precompiled headers for both > configurations - at least I thought I did it. > > I just reread the section about Precompiled Headers in the Clang Users > Manual and stumbled about the following note: "Clang does not > automatically use PCH files for headers that are directly included > within a source file." This is a small GCC incompatibility which may > have a considerable performance impact on compilation times (GCC > automatically uses the .gch file for headers which are directly > included from the source file, and this is exactly the way how PCH is > implemented in HotSpot: there's one "precompiled.hpp" file which > includes most of the other headers and which is precompiled at the > beginning of the build. This "precompiled.hpp" file is than included > in most of the .cpp files.). Aha, that would explain it! > @Chris: is there any, perhaps undocumented, command line option which > changes this behavior? I think this may be a general issue for GCC > projects with precompiled headers migrating to Clang. We don't have direct support for this yet, but it is something we're considering adding. A simple fix is to just pass "-include path/to/precompiled.hpp" to clang on the command line. Assuming the header has #include guards, the redundant #include in the code won't cause any problems. > So I plan to do a new series of measurements and take in to account > all the other suggestions I got here and by private communication. But > please be a little patient - this is just a hobby project for the > evenings:) Sounds great, thanks for doing this! -Chris From tony.printezis at oracle.com Tue Feb 15 00:11:25 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Tue, 15 Feb 2011 08:11:25 +0000 Subject: hg: jdk7/hotspot/hotspot: 7 new changesets Message-ID: <20110215081137.5DFC24775B@hg.openjdk.java.net> Changeset: c798c277ddd1 Author: brutisso Date: 2011-02-03 20:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c798c277ddd1 7015169: GC Cause not always set Summary: Sometimes the gc cause was not always set. This caused JStat to print the wrong information. Reviewed-by: tonyp, ysr Contributed-by: suenaga.yasumasa at oss.ntt.co.jp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/services/heapDumper.cpp Changeset: c5a923563727 Author: ysr Date: 2011-02-07 22:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c5a923563727 6912621: iCMS: Error: assert(_markBitMap.isMarked(addr + 1),"Missing Printezis bit?") Summary: Fix block_size_if_printezis_bits() so it does not expect the bits, only uses them when available. Fix block_size_no_stall() so it does not stall when the bits are missing such cases, letting the caller deal with zero size returns. Constant pool cache oops do not need to be unparsable or conc_unsafe after their klass pointer is installed. Some cosmetic clean-ups and some assertion checking for conc-usafety which, in the presence of class file redefinition, has no a-priori time boundedness, so all GCs must be able to safely deal with putatively conc-unsafe objects in a stop-world pause. Reviewed-by: jmasa, johnc ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheKlass.hpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: e5383553fd4e Author: stefank Date: 2011-02-08 12:33 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e5383553fd4e 7014851: Remove unused parallel compaction code Summary: Removed. Reviewed-by: jcoomes, brutisso ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/oops/arrayKlassKlass.cpp ! src/share/vm/oops/compiledICHolderKlass.cpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klassKlass.cpp ! src/share/vm/oops/klassPS.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/methodDataKlass.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlassKlass.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 59e20a452a2a Author: johnc Date: 2011-02-09 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/59e20a452a2a 7017008: G1: Turn on compressed oops by default. Summary: Normally compressed oops is enabled when the maximum heap size is under a certain limit, except when G1 is also enabled. Remove this limitation. Also re-enable GCBasher testing with G1 on 64 bit windows in jprt. Reviewed-by: jcoomes, brutisso, tonyp ! make/jprt.properties ! src/share/vm/runtime/arguments.cpp Changeset: 183658a2d0b3 Author: ysr Date: 2011-02-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/183658a2d0b3 7018302: newly added assert related to size of constantPoolOop causes secondary assertions or crashes Summary: 6912621 used a raw oop in the newly added assert following an allocation attempt that could result in a GC. Reviewed-by: jmasa ! src/share/vm/oops/constantPoolKlass.cpp Changeset: 55cc33cf55bc Author: stefank Date: 2011-02-11 14:15 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/55cc33cf55bc 7018257: jmm_DumpThreads allocates into permgen Summary: Don't allocate in permgen Reviewed-by: ysr, sla ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp Changeset: f7702f8c0e25 Author: tonyp Date: 2011-02-14 22:21 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f7702f8c0e25 Merge ! make/jprt.properties ! src/share/vm/services/management.cpp From john.r.rose at oracle.com Tue Feb 15 00:18:21 2011 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Tue, 15 Feb 2011 08:18:21 +0000 Subject: hg: jdk7/hotspot/jdk: 3 new changesets Message-ID: <20110215081918.091B84775D@hg.openjdk.java.net> Changeset: 5e4a41d0fccd Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5e4a41d0fccd 7016261: JSR 292 MethodType objects should be serializable Summary: Define private writeObject, readObject, and readResolve methods. Also add unit tests. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodType.java + test/java/dyn/MethodTypeTest.java Changeset: 56cbd0504a53 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/56cbd0504a53 7014755: JSR 292 member lookup interaction with security manager Summary: add security manager interactions for Lookup methods Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java Changeset: 52bcd47b4521 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/52bcd47b4521 7016520: JSR 292 rules for polymorphic signature processing must be in package-info Summary: insert rules for bytecode processors to recognize signature polymorphic names Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java From volker.simonis at gmail.com Tue Feb 15 05:52:23 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 15 Feb 2011 14:52:23 +0100 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: <1297460273.3181.19.camel@springer.wildebeest.org> References: <1297460273.3181.19.camel@springer.wildebeest.org> Message-ID: g++ 4.4.3 and 4.5.2 definitely don't find the bug. I filed a bug report with a slightly more complex example than that from the FAQ at: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47752 Regards, Volker On Fri, Feb 11, 2011 at 10:37 PM, Mark Wielaard wrote: > On Fri, 2011-02-11 at 19:24 +0100, Volker Simonis wrote: >> Notice that this patch contains one additional change compared to the >> patch in the blog. While I did the tests for the blog with an slightly >> outdated HS20b03 I synced a brand new version today to prepare the >> patch. With this new version I found a true C++ bug in >> "src/share/vm/utilities/hashtable.hpp" which was introduced recently >> by the "6990754: Use native memory and reference counting to implement >> SymbolTable" change and which has to do with name lookup of >> nondependent names in dependent base classes (see >> http://www.parashift.com/c++-faq-lite/templates.html#faq-35.19 for a >> nice explanation). Wouldn't have happened with Clang:) > > I didn't try building HS20b03 yet, but g++ (at least version 4.1, 4.4 > and 4.5) should be able to detect this. Trying to compile the FAQ > example gives: > > t.cpp: In member function ?void D::g()?: > t.cpp:12:8: error: there are no arguments to ?f? that depend on a > template parameter, so a declaration of ?f? must be available > t.cpp:12:8: note: (if you use ?-fpermissive?, G++ will accept your code, > but allowing the use of an undeclared name is deprecated) > > If g++ didn't detect it in the hashtable.hpp case, could you file a bug > report for it http://gcc.gnu.org/bugzilla > > Thanks, > > Mark > > From mark at klomp.org Tue Feb 15 07:34:05 2011 From: mark at klomp.org (Mark Wielaard) Date: Tue, 15 Feb 2011 16:34:05 +0100 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: References: <1297460273.3181.19.camel@springer.wildebeest.org> Message-ID: <1297784045.3224.34.camel@springer.wildebeest.org> On Tue, 2011-02-15 at 14:52 +0100, Volker Simonis wrote: > g++ 4.4.3 and 4.5.2 definitely don't find the bug. > > I filed a bug report with a slightly more complex example than that > from the FAQ at: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47752 Thanks for filing that bug and giving the example. I asked around and it wasn't immediately clear if it is a bug or a flaw in the c++ standard. It is on the C++ Standard Core Language Active Issues: http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_active.html#1005 Cheers, Mark From coleen.phillimore at oracle.com Tue Feb 15 08:41:34 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 15 Feb 2011 11:41:34 -0500 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: References: <1297460273.3181.19.camel@springer.wildebeest.org> Message-ID: <4D5AACBE.5010009@oracle.com> Thanks Volker. I've filed a bug against the VM for the hashtable.hpp bug and pointed to your bug (7019689). Coleen On 2/15/2011 8:52 AM, Volker Simonis wrote: > g++ 4.4.3 and 4.5.2 definitely don't find the bug. > > I filed a bug report with a slightly more complex example than that > from the FAQ at: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47752 > > Regards, > Volker > > On Fri, Feb 11, 2011 at 10:37 PM, Mark Wielaard wrote: >> On Fri, 2011-02-11 at 19:24 +0100, Volker Simonis wrote: >>> Notice that this patch contains one additional change compared to the >>> patch in the blog. While I did the tests for the blog with an slightly >>> outdated HS20b03 I synced a brand new version today to prepare the >>> patch. With this new version I found a true C++ bug in >>> "src/share/vm/utilities/hashtable.hpp" which was introduced recently >>> by the "6990754: Use native memory and reference counting to implement >>> SymbolTable" change and which has to do with name lookup of >>> nondependent names in dependent base classes (see >>> http://www.parashift.com/c++-faq-lite/templates.html#faq-35.19 for a >>> nice explanation). Wouldn't have happened with Clang:) >> I didn't try building HS20b03 yet, but g++ (at least version 4.1, 4.4 >> and 4.5) should be able to detect this. Trying to compile the FAQ >> example gives: >> >> t.cpp: In member function ?void D::g()?: >> t.cpp:12:8: error: there are no arguments to ?f? that depend on a >> template parameter, so a declaration of ?f? must be available >> t.cpp:12:8: note: (if you use ?-fpermissive?, G++ will accept your code, >> but allowing the use of an undeclared name is deprecated) >> >> If g++ didn't detect it in the hashtable.hpp case, could you file a bug >> report for it http://gcc.gnu.org/bugzilla >> >> Thanks, >> >> Mark >> >> From coleen.phillimore at oracle.com Tue Feb 15 08:47:18 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 15 Feb 2011 11:47:18 -0500 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: References: Message-ID: <4D5AAE16.5090107@oracle.com> Volker, The patch that you attached doesn't seem to fix any CHECK macros in return statements (bug 6889002). If you have a patch for this bug, I'll check it in for you. Coleen On 2/11/2011 1:24 PM, Volker Simonis wrote: > Hi, > > at the FOSEDM I've heard Chris Lattner's very nice "LLVM and Clang" > keynote. The claims he made in his talk have been very impressing: he > was speaking about Clang being a "production quality" "drop-in > replacement" for GCC with superior code generation and improved > compile speed. Already during the talk I decided that I would be > interesting to prove his pretensions on the HotSpot VM. If you're > interested in the details you can read my blog: > > http://weblogs.java.net/blog/simonis/archive/2011/02/10/compiling-hotspot-vm-clang > > For the impatient the summary is that Clang is still slower than > current GCC versions and the generated code seems to be slightly > slower as well. Nevertheless, Clang has excellent warning capabilities > and is an excellent C++ compiler with regard to C++ conformance. (Now > it's probably a good time to finally fix > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6889002 which I've > promised already more than a year ago at > http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-October/thread.html#2175 > :) > > Attached you can find a patch which contains a Clang configuration for > the HotSpot build (Linux x86/x86_64). A Clang make can be triggered by > passing "USE_CLANG=true" to the make command. Warnings are currently > turned off for the reasons mentioned above. > > This patch may also be interesting in the context of the new MacOs X > port, where Clang is much more common (or perhaps even the default C++ > compiler - i don't know?). > > Notice that this patch contains one additional change compared to the > patch in the blog. While I did the tests for the blog with an slightly > outdated HS20b03 I synced a brand new version today to prepare the > patch. With this new version I found a true C++ bug in > "src/share/vm/utilities/hashtable.hpp" which was introduced recently > by the "6990754: Use native memory and reference counting to implement > SymbolTable" change and which has to do with name lookup of > nondependent names in dependent base classes (see > http://www.parashift.com/c++-faq-lite/templates.html#faq-35.19 for a > nice explanation). Wouldn't have happened with Clang:) > > Regards, > Volker -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110215/9bcb6069/attachment-0001.html From volker.simonis at gmail.com Tue Feb 15 09:01:03 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 15 Feb 2011 18:01:03 +0100 Subject: RFE: configuration for compiling HotSpot with Clang In-Reply-To: <4D5AAE16.5090107@oracle.com> References: <4D5AAE16.5090107@oracle.com> Message-ID: There was a longer discussion around the fix for the CHECK macros about one and a half years ago. I started a patch that time but than somehow forgot about it. Now with the new compiler (and the old warnings) I remembered about it. I hope to get it done this time and to send it out for review soon. Thank you for the offer to take care about it. Volker On Tue, Feb 15, 2011 at 5:47 PM, Coleen Phillimore wrote: > > Volker, > > The patch that you attached doesn't seem to fix any CHECK macros in return > statements (bug 6889002). > If you have a patch for this bug, I'll check it in for you. > > Coleen > > > On 2/11/2011 1:24 PM, Volker Simonis wrote: > > Hi, > > at the FOSEDM I've heard Chris Lattner's very nice "LLVM and Clang" > keynote. The claims he made in his talk have been very impressing: he > was speaking about Clang being a "production quality" "drop-in > replacement" for GCC with superior code generation and improved > compile speed. Already during the talk I decided that I would be > interesting to prove his pretensions on the HotSpot VM. If you're > interested in the details you can read my blog: > > http://weblogs.java.net/blog/simonis/archive/2011/02/10/compiling-hotspot-vm-clang > > For the impatient the summary is that Clang is still slower than > current GCC versions and the generated code seems to be slightly > slower as well. Nevertheless, Clang has excellent warning capabilities > and is an excellent C++ compiler with regard to C++ conformance. (Now > it's probably a good time to finally fix > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6889002 which I've > promised already more than a year ago at > http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-October/thread.html#2175 > :) > > Attached you can find a patch which contains a Clang configuration for > the HotSpot build (Linux x86/x86_64). A Clang make can be triggered by > passing "USE_CLANG=true" to the make command. Warnings are currently > turned off for the reasons mentioned above. > > This patch may also be interesting in the context of the new MacOs X > port, where Clang is much more common (or perhaps even the default C++ > compiler - i don't know?). > > Notice that this patch contains one additional change compared to the > patch in the blog. While I did the tests for the blog with an slightly > outdated HS20b03 I synced a brand new version today to prepare the > patch. With this new version I found a true C++ bug in > "src/share/vm/utilities/hashtable.hpp" which was introduced recently > by the "6990754: Use native memory and reference counting to implement > SymbolTable" change and which has to do with name lookup of > nondependent names in dependent base classes (see > http://www.parashift.com/c++-faq-lite/templates.html#faq-35.19 for a > nice explanation). Wouldn't have happened with Clang:) > > Regards, > Volker > > From John.Coomes at oracle.com Wed Feb 16 10:10:48 2011 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 16 Feb 2011 10:10:48 -0800 Subject: review request (S/M): 6962931 move interned strings out of perm gen Message-ID: <19804.4904.199261.456867@oracle.com> This moves interned strings from the perm gen into the regular heap. The code was written by Tom Rodriguez; I've added a minor fix and done the testing. More info in the webrev: http://cr.openjdk.java.net/~jcoomes/6962931-intern/ Thanks for any feedback. -John From tom.rodriguez at oracle.com Wed Feb 16 11:05:15 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 16 Feb 2011 11:05:15 -0800 Subject: review request (S/M): 6962931 move interned strings out of perm gen In-Reply-To: <19804.4904.199261.456867@oracle.com> References: <19804.4904.199261.456867@oracle.com> Message-ID: <5AC4655F-8423-4BD9-873C-7578DF5DF049@oracle.com> I had assumed we'd be switching so that strings were always outside perm by default. ScavengeRootsInCode must be != 0 once invokedynamic is enabled by default and since that's definitely going to be enabled in 7 don't we want to turn all this on? tom On Feb 16, 2011, at 10:10 AM, John Coomes wrote: > This moves interned strings from the perm gen into the regular heap. > The code was written by Tom Rodriguez; I've added a minor fix and done > the testing. More info in the webrev: > > http://cr.openjdk.java.net/~jcoomes/6962931-intern/ > > Thanks for any feedback. > > -John > From John.Coomes at oracle.com Wed Feb 16 13:38:54 2011 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 16 Feb 2011 13:38:54 -0800 Subject: review request (S/M): 6962931 move interned strings out of perm gen In-Reply-To: <5AC4655F-8423-4BD9-873C-7578DF5DF049@oracle.com> References: <19804.4904.199261.456867@oracle.com> <5AC4655F-8423-4BD9-873C-7578DF5DF049@oracle.com> Message-ID: <19804.17390.440180.82833@oracle.com> Tom Rodriguez (tom.rodriguez at oracle.com) wrote: > I had assumed we'd be switching so that strings were always outside > perm by default. ScavengeRootsInCode must be != 0 once > invokedynamic is enabled by default and since that's definitely > going to be enabled in 7 don't we want to turn all this on? I discussed this with Tom, so this is mostly for the list ... I hadn't done any compiler-specific testing, so wasn't sure if there were other parts of the compiler that might be impacted by this change. The impact is fairly small, so I'll change ScavengeRootsInCode so it defaults to 1. Other potential reviewers, don't wait for me to update the webrev; I have meetings all day so it'll be tonight at the earliest. -John > On Feb 16, 2011, at 10:10 AM, John Coomes wrote: > > > This moves interned strings from the perm gen into the regular heap. > > The code was written by Tom Rodriguez; I've added a minor fix and done > > the testing. More info in the webrev: > > > > http://cr.openjdk.java.net/~jcoomes/6962931-intern/ > > > > Thanks for any feedback. > > > > -John > > > From erik.trimble at oracle.com Wed Feb 16 22:16:27 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Thu, 17 Feb 2011 06:16:27 +0000 Subject: hg: jdk7/hotspot/hotspot: 2 new changesets Message-ID: <20110217061632.617174780E@hg.openjdk.java.net> Changeset: e9aa2ca89ad6 Author: kamg Date: 2011-02-16 16:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e9aa2ca89ad6 7019718: make error reporting flags product instead of diagnostic Summary: see synopsis Reviewed-by: acorn, coleenp ! src/share/vm/runtime/globals.hpp Changeset: 02368ad6c63f Author: trims Date: 2011-02-16 17:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/02368ad6c63f Merge From christian.thalinger at oracle.com Thu Feb 17 00:35:31 2011 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Thu, 17 Feb 2011 09:35:31 +0100 Subject: review request (S/M): 6962931 move interned strings out of perm gen In-Reply-To: <19804.17390.440180.82833@oracle.com> References: <19804.4904.199261.456867@oracle.com> <5AC4655F-8423-4BD9-873C-7578DF5DF049@oracle.com> <19804.17390.440180.82833@oracle.com> Message-ID: <2E3667F7-EB8B-4F6F-B6AF-73089D86D352@oracle.com> On Feb 16, 2011, at 10:38 PM, John Coomes wrote: > Tom Rodriguez (tom.rodriguez at oracle.com) wrote: >> I had assumed we'd be switching so that strings were always outside >> perm by default. ScavengeRootsInCode must be != 0 once >> invokedynamic is enabled by default and since that's definitely >> going to be enabled in 7 don't we want to turn all this on? > > I discussed this with Tom, so this is mostly for the list ... > > I hadn't done any compiler-specific testing, so wasn't sure if there > were other parts of the compiler that might be impacted by this > change. The impact is fairly small, so I'll change > ScavengeRootsInCode so it defaults to 1. I think it should be fine to turn it on. -- Christian > > Other potential reviewers, don't wait for me to update the webrev; I > have meetings all day so it'll be tonight at the earliest. > > -John > >> On Feb 16, 2011, at 10:10 AM, John Coomes wrote: >> >>> This moves interned strings from the perm gen into the regular heap. >>> The code was written by Tom Rodriguez; I've added a minor fix and done >>> the testing. More info in the webrev: >>> >>> http://cr.openjdk.java.net/~jcoomes/6962931-intern/ >>> >>> Thanks for any feedback. >>> >>> -John From mlists at juma.me.uk Thu Feb 17 01:30:39 2011 From: mlists at juma.me.uk (Ismael Juma) Date: Thu, 17 Feb 2011 09:30:39 +0000 (UTC) Subject: Client VM on amd64 References: <827hdlb5nt.fsf@mid.bfk.de> <4D46D122.3070103@oracle.com> Message-ID: Paul Hohensee writes: > The reason the commits mention amd64 and compressed oops is because the > client compiler is part of the tiered compilation system (c1 + c2) > that's built into the server jvm and available via -XX:+TieredCompilation. > The 64-bit client compiler must work in order for tiered compilation to work. What is the status of TieredCompilation in terms of performance and stability? I've been using it on my desktop (HS20) with IntelliJ IDEA and SBT (build system for Scala) for a few weeks now and I've had no crashes as a result of it. That is a good sign (in terms of stability, I haven't done any performance testing yet), but it would also be good to know if there are known issues with it and if there is a plan to solve them. Best, Ismael From coleen.phillimore at oracle.com Thu Feb 17 08:21:00 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 17 Feb 2011 11:21:00 -0500 Subject: review request (S/M): 6962931 move interned strings out of perm gen In-Reply-To: <5AC4655F-8423-4BD9-873C-7578DF5DF049@oracle.com> References: <19804.4904.199261.456867@oracle.com> <5AC4655F-8423-4BD9-873C-7578DF5DF049@oracle.com> Message-ID: <4D5D4AEC.6000401@oracle.com> I have reviewed and tested this. I have a couple of comments. The option ScavengeRootsInCode is a bit confusing since this is moving all strings out of permgen so shouldn't depend on a flag that has meaning to the compiler. I'd like to see the code conditional on this flag removed. The other comment I have is based on ignorance. Isn't "tenured' the old generation? So create_tenured_from_unicode() calls basic_create() with a tenured flag and it either allocates the string in permgen or eden, so it doesn't make sense if I have the correct meaning of tenured. This would be fixed if the conditional code is removed also, if not, the names should be changed. There is also a create_from_unicode() that is uncalled, presumably because someone added create_tenured_from_unicode(). Thanks, Coleen On 2/16/2011 2:05 PM, Tom Rodriguez wrote: > I had assumed we'd be switching so that strings were always outside perm by default. ScavengeRootsInCode must be != 0 once invokedynamic is enabled by default and since that's definitely going to be enabled in 7 don't we want to turn all this on? > > tom > > On Feb 16, 2011, at 10:10 AM, John Coomes wrote: > >> This moves interned strings from the perm gen into the regular heap. >> The code was written by Tom Rodriguez; I've added a minor fix and done >> the testing. More info in the webrev: >> >> http://cr.openjdk.java.net/~jcoomes/6962931-intern/ >> >> Thanks for any feedback. >> >> -John >> From igor.veresov at oracle.com Thu Feb 17 11:39:20 2011 From: igor.veresov at oracle.com (Igor Veresov) Date: Thu, 17 Feb 2011 11:39:20 -0800 Subject: Client VM on amd64 In-Reply-To: References: <827hdlb5nt.fsf@mid.bfk.de> <4D46D122.3070103@oracle.com> Message-ID: <4D5D7968.9050601@oracle.com> On 2/17/11 1:30 AM, Ismael Juma wrote: > Paul Hohensee writes: >> The reason the commits mention amd64 and compressed oops is because the >> client compiler is part of the tiered compilation system (c1 + c2) >> that's built into the server jvm and available via -XX:+TieredCompilation. >> The 64-bit client compiler must work in order for tiered compilation to work. > > What is the status of TieredCompilation in terms of performance and stability? > > I've been using it on my desktop (HS20) with IntelliJ IDEA and SBT (build > system for Scala) for a few weeks now and I've had no crashes as a result > of it. That is a good sign (in terms of stability, I haven't done any > performance testing yet), but it would also be good to know if there are > known issues with it and if there is a plan to solve them. It should work fine in all configurations (32/64 bit, compressed oops) and the performance is good too. Try the latest Oracle's bits for jdk7 or the upcoming jdk6u25. This is how it roughly compares to pure C2 with interpreter in specjvm98 (x86, 32bit): benchmark: _200_check startup: 0.052 0.053 diff: -1.92% settled: 0.0326 0.0336 diff: -3.06% benchmark: _227_mtrt startup: 1.822 1.518 diff: 16.68% settled: 0.4027 0.4023 diff: 0.09% benchmark: _202_jess startup: 1.473 1.217 diff: 17.37% settled: 1.1567 1.0199 diff: 11.82% benchmark: _201_compress startup: 4.426 3.905 diff: 11.77% settled: 4.274 3.8 diff: 11.09% benchmark: _209_db startup: 6.562 6.566 diff: -0.06% settled: 6.2705 6.271 diff: -0.00% benchmark: _222_mpegaudio startup: 2.863 2.599 diff: 9.22% settled: 2.3185 2.2925 diff: 1.12% benchmark: _228_jack startup: 2.738 1.581 diff: 42.25% settled: 1.2824 1.0612 diff: 17.24% benchmark: _213_javac startup: 5.602 2.883 diff: 48.53% settled: 1.6939 1.745 diff: -3.01% Each subbenchmark is run 10 times. "startup" is the first iteration, "settled" is the average of last 5. Less is better (seconds). igor > > Best, > Ismael > From mlists at juma.me.uk Thu Feb 17 11:50:30 2011 From: mlists at juma.me.uk (Ismael Juma) Date: Thu, 17 Feb 2011 19:50:30 +0000 (UTC) Subject: Client VM on amd64 References: <827hdlb5nt.fsf@mid.bfk.de> <4D46D122.3070103@oracle.com> <4D5D7968.9050601@oracle.com> Message-ID: Hi Igor, Igor Veresov writes: > It should work fine in all configurations (32/64 bit, compressed oops) > and the performance is good too. Try the latest Oracle's bits for jdk7 > or the upcoming jdk6u25. Thanks for the reply. I have indeed been using the jdk6u25 (early access release) on 64-bit with compressed oops. No crashes so far. :) > This is how it roughly compares to pure C2 with interpreter in specjvm98 > (x86, 32bit): Nice! I assume that the first score is pure C2 with interpreter and the second score is tiered? Best, Ismael From igor.veresov at oracle.com Thu Feb 17 12:50:32 2011 From: igor.veresov at oracle.com (Igor Veresov) Date: Thu, 17 Feb 2011 12:50:32 -0800 Subject: Client VM on amd64 In-Reply-To: References: <827hdlb5nt.fsf@mid.bfk.de> <4D46D122.3070103@oracle.com> <4D5D7968.9050601@oracle.com> Message-ID: <4D5D8A18.7010304@oracle.com> On 2/17/11 11:50 AM, Ismael Juma wrote: > Hi Igor, > > Igor Veresov writes: >> It should work fine in all configurations (32/64 bit, compressed oops) >> and the performance is good too. Try the latest Oracle's bits for jdk7 >> or the upcoming jdk6u25. > > Thanks for the reply. I have indeed been using the jdk6u25 (early access > release) on 64-bit with compressed oops. No crashes so far. :) > >> This is how it roughly compares to pure C2 with interpreter in specjvm98 >> (x86, 32bit): > > Nice! I assume that the first score is pure C2 with interpreter and the > second score is tiered? Right. igor From erik.trimble at oracle.com Thu Feb 17 21:14:05 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Fri, 18 Feb 2011 05:14:05 +0000 Subject: hg: hsx/hsx20/baseline: 7020550: Bump the HS20 build number to 10 Message-ID: <20110218051406.E21824784B@hg.openjdk.java.net> Changeset: c6491db25cb2 Author: trims Date: 2011-02-17 21:11 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/c6491db25cb2 7020550: Bump the HS20 build number to 10 Summary: Update the HS20 build number to 10 Reviewed-by: jcoomes ! make/hotspot_version From john.cuthbertson at oracle.com Fri Feb 18 20:54:16 2011 From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com) Date: Sat, 19 Feb 2011 04:54:16 +0000 Subject: hg: hsx/hsx20/baseline: 7020042: G1: Partially remove fix for 6994628 Message-ID: <20110219045418.58BD14789F@hg.openjdk.java.net> Changeset: 1ec37096cecf Author: johnc Date: 2011-02-18 10:07 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/1ec37096cecf 7020042: G1: Partially remove fix for 6994628 Summary: Disable reference discovery and processing during concurrent marking by disabling fix for 6994628. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp From erik.trimble at oracle.com Sat Feb 19 03:01:17 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Sat, 19 Feb 2011 11:01:17 +0000 Subject: hg: hsx/hsx20/baseline: 7020846: Update Hotspot 20 to use jdk6 as JPRT release target Message-ID: <20110219110121.E3658478AE@hg.openjdk.java.net> Changeset: ea3194c0e376 Author: trims Date: 2011-02-18 19:51 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/ea3194c0e376 7020846: Update Hotspot 20 to use jdk6 as JPRT release target Summary: Change the default JPRT release target to be jdk6 Reviewed-by: ohair ! make/jprt.properties From coleen.phillimore at oracle.com Mon Feb 21 17:54:38 2011 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 22 Feb 2011 01:54:38 +0000 Subject: hg: jdk7/hotspot/hotspot: 11 new changesets Message-ID: <20110222015457.A900D47940@hg.openjdk.java.net> Changeset: 15d6977f04b0 Author: sla Date: 2011-02-10 13:03 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/15d6977f04b0 7017824: Add support for creating 64-bit Visual Studio projects Summary: Updated create.bat and ProjectCreator Reviewed-by: brutisso, stefank, ohair ! make/windows/create.bat ! make/windows/makefiles/compile.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 ! make/windows/projectfiles/common/Makefile ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/DirectoryTree.java ! src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/adlc/adlc.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: 7aa1f99ca301 Author: coleenp Date: 2011-02-12 10:28 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/7aa1f99ca301 7019157: errorHandler doesn't compile with super old gcc without precompiled headers Summary: old gccs don't support precompiled headers so have to supply includes Reviewed-by: phh, kamg ! src/share/vm/utilities/errorReporter.hpp Changeset: 54df4702df97 Author: rottenha Date: 2011-02-14 03:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/54df4702df97 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: de14f1eee390 Author: dcubed Date: 2011-02-15 19:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/de14f1eee390 6954420: 2/4 jps shows "process information unavailable" sometimes Summary: Make sure the backing store file is flushed in create_sharedmem_resources() and get_user_name_slow() no longer checks the size of the backing store file. Reviewed-by: briand, swamyv, acorn, poonam ! src/os/windows/vm/perfMemory_windows.cpp Changeset: b76d12f4ab2d Author: dholmes Date: 2011-02-14 19:27 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b76d12f4ab2d 7018429: JPRT: Update Makefile to use ALT_JDK_TARGET_IMPORT_PATH for copying JDK Summary: Set JDK_IMPORT_PATH to ALT_JDK_TARGET_IMPORT_PATH if it is defined Reviewed-by: phh, ohair ! make/Makefile ! make/defs.make Changeset: 5415131bc5ab Author: dholmes Date: 2011-02-16 01:42 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5415131bc5ab Merge Changeset: c08677f98289 Author: coleenp Date: 2011-02-16 11:34 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c08677f98289 6840152: JVM crashes when heavyweight monitors are used Summary: Turn off biased locking if !UseFastLocking or UseHeavyMonitors options are requested. Reviewed-by: phh, never, dcubed, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 3adec115d40d Author: coleenp Date: 2011-02-16 17:12 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3adec115d40d 7019689: Non-dependent name is found in dependent base class although it should be rejected Summary: fix hashtable.hpp to qualify non-dependant name with "this" Reviewed-by: phh, never, poonam Contributed-by: volker.simonis at gmail.com ! src/share/vm/utilities/hashtable.hpp Changeset: a959935a5732 Author: coleenp Date: 2011-02-16 16:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/a959935a5732 Merge Changeset: 6e70f1bb7f6f Author: coleenp Date: 2011-02-18 18:26 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/6e70f1bb7f6f 7019557: SharedMiscDataSize too small for 64-bit fastdebug JVM Summary: Increase default SharedMiscDataSize Reviewed-by: dcubed, kamg ! src/share/vm/runtime/globals.hpp Changeset: f77b3ec064b0 Author: rottenha Date: 2011-02-21 04:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f77b3ec064b0 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp From erik.trimble at oracle.com Tue Feb 22 08:56:51 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Tue, 22 Feb 2011 16:56:51 +0000 Subject: hg: hsx/hsx20/baseline: Added tag hs20-b10 for changeset ea3194c0e376 Message-ID: <20110222165653.529AD4796D@hg.openjdk.java.net> Changeset: f46354849fb3 Author: trims Date: 2011-02-22 08:51 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/baseline/rev/f46354849fb3 Added tag hs20-b10 for changeset ea3194c0e376 ! .hgtags From erik.trimble at oracle.com Tue Feb 22 08:57:42 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Tue, 22 Feb 2011 16:57:42 +0000 Subject: hg: hsx/hsx20/master: 18 new changesets Message-ID: <20110222165819.C96EC4796E@hg.openjdk.java.net> Changeset: 6aa467001334 Author: trims Date: 2011-01-25 14:57 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/6aa467001334 Added tag hs20-b07 for changeset d535bf4c1235 ! .hgtags Changeset: 08b8a97af1a8 Author: iveresov Date: 2011-01-25 18:00 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/08b8a97af1a8 7014247: CTW fails when compile sun/misc/AtomicLongCSImpl (REMOVED from JDK7) Summary: Use lea to compute field address in AtomicLongCSImpl::attemptUpdate() intrinsic on x86. Reviewed-by: never, kvn ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp Changeset: a2320a6088f0 Author: iveresov Date: 2011-01-26 11:01 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/a2320a6088f0 Merge Changeset: 907c1aed0f8c Author: cl Date: 2011-01-27 17:28 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/907c1aed0f8c Added tag jdk7-b127 for changeset 102466e70deb ! .hgtags Changeset: 9a5762f44859 Author: trims Date: 2011-02-01 18:57 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/9a5762f44859 Merge ! .hgtags - src/share/vm/gc_implementation/g1/concurrentZFThread.cpp - src/share/vm/gc_implementation/g1/concurrentZFThread.hpp Changeset: 2e85cdf72570 Author: trims Date: 2011-02-01 19:25 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/2e85cdf72570 Merge ! .hgtags Changeset: ec9e977dd8e4 Author: kvn Date: 2011-02-01 10:27 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/ec9e977dd8e4 7014998: assert(is_T_family(features) == is_niagara(features)) failed: Niagara should be T series Summary: Use substring search instead of compare and convert string to upper case before search. Reviewed-by: never, phh, iveresov ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp Changeset: bd2e08334e84 Author: tonyp Date: 2011-01-21 11:30 -0500 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/bd2e08334e84 7013718: G1: small fixes for two assert/guarantee failures Summary: Two small fixes to deal with a guarantee failure (the marking thread should join the SuspendibleThreadSet before calling a method that does pause prediction work so that said method is never called during a pause) and an assert failure (an assert is too strong). Reviewed-by: iveresov, johnc ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp Changeset: 4e66274b6bb3 Author: tonyp Date: 2011-01-25 17:58 -0500 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/4e66274b6bb3 7014261: G1: RSet-related failures Summary: A race between the concurrent cleanup thread and the VM thread while it is processing the "expanded sparse table list" causes both threads to try to free the same sparse table entry and either causes one of the threads to fail or leaves the entry in an inconsistent state. The solution is purge all entries on the expanded list that correspond go regions that are being cleaned up. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp Changeset: 908c5092d72a Author: tonyp Date: 2011-01-31 16:28 -0500 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/908c5092d72a 7014679: G1: deadlock during concurrent cleanup Summary: There's a potential deadlock between the concurrent cleanup thread and the GC workers that are trying to allocate and waiting for more free regions to be made available. Reviewed-by: iveresov, jcoomes ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: e9a2b8e0572a Author: never Date: 2011-02-09 15:02 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/e9a2b8e0572a 7016474: string compare intrinsic improvements Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad Changeset: ac21d3bfa63b Author: never Date: 2011-02-10 12:16 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/ac21d3bfa63b 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Reviewed-by: acorn, kvn, dsamersoff ! src/os/solaris/vm/os_solaris.cpp Changeset: befa5106b5e9 Author: poonam Date: 2011-02-11 09:16 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/befa5106b5e9 6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented Reviewed-by: ysr, minqi ! src/share/vm/gc_implementation/shared/allocationStats.hpp Changeset: 57090cdd4e01 Author: kvn Date: 2011-02-10 14:25 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/57090cdd4e01 7017746: Regression : C2 compiler crash due to SIGSEGV in PhaseCFG::schedule_early() Summary: Add TEMP edges (and KILL projections) before duplicated operands are removed in Expand() methods. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/node.cpp + test/compiler/7017746/Test.java Changeset: c6491db25cb2 Author: trims Date: 2011-02-17 21:11 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/c6491db25cb2 7020550: Bump the HS20 build number to 10 Summary: Update the HS20 build number to 10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1ec37096cecf Author: johnc Date: 2011-02-18 10:07 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/1ec37096cecf 7020042: G1: Partially remove fix for 6994628 Summary: Disable reference discovery and processing during concurrent marking by disabling fix for 6994628. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: ea3194c0e376 Author: trims Date: 2011-02-18 19:51 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/ea3194c0e376 7020846: Update Hotspot 20 to use jdk6 as JPRT release target Summary: Change the default JPRT release target to be jdk6 Reviewed-by: ohair ! make/jprt.properties Changeset: f46354849fb3 Author: trims Date: 2011-02-22 08:51 -0800 URL: http://hg.openjdk.java.net/hsx/hsx20/master/rev/f46354849fb3 Added tag hs20-b10 for changeset ea3194c0e376 ! .hgtags From tom.rodriguez at oracle.com Wed Feb 23 12:48:01 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 23 Feb 2011 12:48:01 -0800 Subject: review request (S/M): 6962931 move interned strings out of perm gen In-Reply-To: <4D5D4AEC.6000401@oracle.com> References: <19804.4904.199261.456867@oracle.com> <5AC4655F-8423-4BD9-873C-7578DF5DF049@oracle.com> <4D5D4AEC.6000401@oracle.com> Message-ID: On Feb 17, 2011, at 8:21 AM, Coleen Phillimore wrote: > > I have reviewed and tested this. I have a couple of comments. > > The option ScavengeRootsInCode is a bit confusing since this is moving all strings out of permgen so shouldn't depend on a flag that has meaning to the compiler. I'd like to see the code conditional on this flag removed. Currently ScavengeRootsInCode controls two things. One is the GC machinery that supports embedding scavengeable oops into compiled code and the other is which kinds of oops the compiler considers to be embeddable. The first part will become required behaviour by the end of 7 since invokedynamic requires it so at some point all tests which are comparing ScavengeRootsInCode with 0 should be simplified so that it's no longer optional. We could do that now but it might be worth waiting a little while so that we can use that flag to narrow down problems by turning it off. Anyway, I agree that controlling it through ScavengeRootsInCode is odd. Maybe we need a separate temporary flag for putting Strings and Classes in perm? Until perm goes away completely we can still allocate them there and things would continue to work fine. > > The other comment I have is based on ignorance. Isn't "tenured' the old generation? So create_tenured_from_unicode() calls basic_create() with a tenured flag and it either allocates the string in permgen or eden, so it doesn't make sense if I have the correct meaning of tenured. That's a long time oddity. I think it probably dates to the time when there was no perm gen and meta data was simply in tenured mixed with other data. It will be corrected by the time we are done since it will simply go away. tom > > This would be fixed if the conditional code is removed also, if not, the names should be changed. There is also a create_from_unicode() that is uncalled, presumably because someone added create_tenured_from_unicode(). > > Thanks, > Coleen > > On 2/16/2011 2:05 PM, Tom Rodriguez wrote: >> I had assumed we'd be switching so that strings were always outside perm by default. ScavengeRootsInCode must be != 0 once invokedynamic is enabled by default and since that's definitely going to be enabled in 7 don't we want to turn all this on? >> >> tom >> >> On Feb 16, 2011, at 10:10 AM, John Coomes wrote: >> >>> This moves interned strings from the perm gen into the regular heap. >>> The code was written by Tom Rodriguez; I've added a minor fix and done >>> the testing. More info in the webrev: >>> >>> http://cr.openjdk.java.net/~jcoomes/6962931-intern/ >>> >>> Thanks for any feedback. >>> >>> -John >>> > From vladimir.kozlov at oracle.com Wed Feb 23 15:10:19 2011 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Wed, 23 Feb 2011 23:10:19 +0000 Subject: hg: jdk7/hotspot/hotspot: 21 new changesets Message-ID: <20110223231056.0AE6E479CC@hg.openjdk.java.net> Changeset: 4f26f535a225 Author: never Date: 2011-01-31 17:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/4f26f535a225 6354181: nsk.logging.stress.threads.scmhml001 fails assertion in "src/share/vm/oops/instanceKlass.cpp, 111" Reviewed-by: jrose, acorn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 638119ce7cfd Author: twisti Date: 2011-02-01 03:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/638119ce7cfd 7009309: JSR 292: compiler/6991596/Test6991596.java crashes on fastdebug JDK7/b122 Reviewed-by: kvn, never ! agent/src/share/classes/sun/jvm/hotspot/runtime/StubRoutines.java ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/interpreter_x86.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fbf3184da15d Author: twisti Date: 2011-02-01 05:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/fbf3184da15d 7012339: JSR 292 crash in G1SATBCardTableModRefBS::write_ref_field_pre_work() Reviewed-by: jrose, never ! src/share/vm/oops/cpCacheOop.cpp Changeset: c52cba2a3359 Author: kvn Date: 2011-02-01 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c52cba2a3359 7014998: assert(is_T_family(features) == is_niagara(features)) failed: Niagara should be T series Summary: Use substring search instead of compare and convert string to upper case before search. Reviewed-by: never, phh, iveresov ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp Changeset: 194c9fdee631 Author: kvn Date: 2011-02-07 09:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1 Summary: Add ResourceMark into PhaseIdealLoop::build_and_optimize(). Reviewed-by: never ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp Changeset: 3763ca6579b7 Author: kvn Date: 2011-02-07 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3763ca6579b7 7013538: Java memory leak with escape analysis Summary: Don't allocate VectorSet iterator on C heap. Reuse resource storage in EA. Reviewed-by: never ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/phase.cpp Changeset: f7de3327c683 Author: kvn Date: 2011-02-07 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f7de3327c683 7017124: Fix some VM stats to avoid 32-bit overflow Summary: Added new method inc_stat_counter() to increment long statistic values and use atomic long load and store. Reviewed-by: dholmes, jrose, phh, never ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/opto/indexSet.cpp ! src/share/vm/opto/indexSet.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 336d17dff7cc Author: kvn Date: 2011-02-08 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/336d17dff7cc 7014874: Incorrect COOPs modes on solaris-{sparcv9,amd64} with ParallelGC Summary: Align old gen size down to keep specified heap size. Reviewed-by: ysr ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Changeset: 72d6c57d0658 Author: iveresov Date: 2011-02-09 16:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/72d6c57d0658 7017434: Tiered needs to support reprofiling Summary: Tiered needs to support proper method reprofiling after deopts. Reviewed-by: kvn ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 62a8557e8f36 Author: twisti Date: 2011-02-10 00:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/62a8557e8f36 7018277: JSR 292 change test/compiler/6987555/Test6987555.java to new MH syntax Summary: test/compiler/6987555/Test6987555.java currently does not compile because the MH return-type syntax has changed. Reviewed-by: never ! test/compiler/6987555/Test6987555.java Changeset: ab42c7e1cf83 Author: kvn Date: 2011-02-10 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ab42c7e1cf83 7017746: Regression : C2 compiler crash due to SIGSEGV in PhaseCFG::schedule_early() Summary: Add TEMP edges (and KILL projections) before duplicated operands are removed in Expand() methods. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/node.cpp + test/compiler/7017746/Test.java Changeset: bf29934d2f4f Author: kvn Date: 2011-02-10 19:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/bf29934d2f4f 7018849: 7017124 fix broke VM build on some platforms Summary: Use atomic load and store in inc_stat_counter() only on SPARC and X86. Reviewed-by: iveresov ! src/share/vm/memory/allocation.inline.hpp Changeset: 173926398291 Author: twisti Date: 2011-02-11 03:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/173926398291 7018673: Zero: 6953144, 6990754 and 7009756 made some changes which broke Zero Reviewed-by: kvn, chrisphi, twisti ! src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/methodOop.cpp Changeset: 34457f6ac818 Author: never Date: 2011-02-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/34457f6ac818 7018506: CTW swallowing OOMs after symbol changes Reviewed-by: kvn, iveresov, coleenp ! src/share/vm/classfile/classLoader.cpp Changeset: 28bf941f445e Author: twisti Date: 2011-02-14 03:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/28bf941f445e 7018378: JSR 292: _bound_int_mh produces wrong result on 64-bit SPARC Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: 2a57c59eb548 Author: never Date: 2011-02-14 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/2a57c59eb548 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Reviewed-by: acorn, kvn, dsamersoff ! src/os/solaris/vm/os_solaris.cpp Changeset: 850b2295a494 Author: kvn Date: 2011-02-14 14:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/850b2295a494 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 1957c1478794 Author: never Date: 2011-02-15 22:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1957c1478794 7019819: bare oop in ciField Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciField.cpp Changeset: 6bbaedb03534 Author: never Date: 2011-02-09 15:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/6bbaedb03534 7016474: string compare intrinsic improvements Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad Changeset: 5841dc1964f0 Author: never Date: 2011-02-22 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5841dc1964f0 7021531: lock ordering problems after fix for 6354181 Reviewed-by: kvn, jrose ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: a97fd181b813 Author: kvn Date: 2011-02-23 11:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/a97fd181b813 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/globals.hpp From robert.ottenhag at oracle.com Fri Feb 25 08:14:36 2011 From: robert.ottenhag at oracle.com (robert.ottenhag at oracle.com) Date: Fri, 25 Feb 2011 16:14:36 +0000 Subject: hg: jdk7/hotspot/hotspot: 2 new changesets Message-ID: <20110225161440.444DF47A5B@hg.openjdk.java.net> Changeset: 162b62460264 Author: dholmes Date: 2011-02-24 21:38 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/162b62460264 7021953: Remove flags from globals.hpp inadvertently dragged in by 7016023 Summary: removed erroneous flags Reviewed-by: kvn, dcubed ! src/share/vm/runtime/globals.hpp Changeset: cf16c93393f5 Author: rottenha Date: 2011-02-25 03:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/cf16c93393f5 Merge ! src/share/vm/runtime/globals.hpp From tony.printezis at oracle.com Fri Feb 25 10:46:54 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Fri, 25 Feb 2011 18:46:54 +0000 Subject: hg: jdk7/hotspot/hotspot: 3 new changesets Message-ID: <20110225184659.B8F0B47A62@hg.openjdk.java.net> Changeset: 02f78cfa4656 Author: stefank Date: 2011-02-21 11:26 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/02f78cfa4656 7020992: jmm_DumpThreads should not allocate system object arrays outside the perm gen Summary: Allocate ordinary object arrays Reviewed-by: ysr, never, mchung ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp Changeset: 8bbefb9743ae Author: tonyp Date: 2011-02-25 10:58 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/8bbefb9743ae Merge Changeset: 76b97f73ee91 Author: tonyp Date: 2011-02-25 08:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/76b97f73ee91 Merge From erik.trimble at oracle.com Fri Feb 25 17:19:51 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Sat, 26 Feb 2011 01:19:51 +0000 Subject: hg: jdk7/hotspot/hotspot: 7 new changesets Message-ID: <20110226012005.F28F147A7B@hg.openjdk.java.net> Changeset: 0a2ecf4cc384 Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0a2ecf4cc384 Added tag jdk7-b130 for changeset e9aa2ca89ad6 ! .hgtags Changeset: cdef89d821bd Author: ohair Date: 2011-02-16 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/cdef89d821bd 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 0aa3b4908911 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0aa3b4908911 Merge Changeset: 2015d9b41531 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/2015d9b41531 Added tag jdk7-b131 for changeset 0aa3b4908911 ! .hgtags Changeset: f3e07ceeaed9 Author: trims Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f3e07ceeaed9 Added tag hs21-b02 for changeset e9aa2ca89ad6 ! .hgtags Changeset: 5a4223160326 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5a4223160326 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: 658d198b2e04 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/658d198b2e04 7022570: Bump the HS21 build number to 03 Summary: Update the HS21 build number to 03 Reviewed-by: jcoomes ! make/hotspot_version From erik.trimble at oracle.com Sun Feb 27 11:26:33 2011 From: erik.trimble at oracle.com (erik.trimble at oracle.com) Date: Sun, 27 Feb 2011 19:26:33 +0000 Subject: hg: jdk7/hotspot/jdk: 89 new changesets Message-ID: <20110227194129.D0DD647ADE@hg.openjdk.java.net> Changeset: bad0ddc6f573 Author: prr Date: 2011-01-26 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/bad0ddc6f573 7014738: Update jdk repo application manifests with Windows 7 compatibility section. Reviewed-by: bae, igor ! src/windows/resource/java.manifest Changeset: d0e158473b6f Author: prr Date: 2011-01-26 13:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d0e158473b6f 6940890: Java doesn't pick up the correct fontconfig files in latest Solaris Next builds Reviewed-by: bae, igor ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java Changeset: 4cf20706dbfa Author: dlila Date: 2011-01-27 16:43 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4cf20706dbfa 4645692: solveCubic does not return all solutions. Summary: more robust solveCubic implementation. Reviewed-by: flar ! src/share/classes/java/awt/geom/CubicCurve2D.java + test/java/awt/geom/CubicCurve2D/ContainsTest.java + test/java/awt/geom/CubicCurve2D/IntersectsTest.java + test/java/awt/geom/CubicCurve2D/SolveCubicTest.java Changeset: 21621a756b32 Author: lana Date: 2011-02-03 19:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/21621a756b32 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 5e624003e622 Author: dlila Date: 2011-02-08 09:22 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5e624003e622 7016856: dashing performance was reduced during latest changes to the OpenJDK rasterizer Summary: Optimized dashing, rasterizing, and the flow of transformed coordinates Reviewed-by: flar ! src/share/classes/sun/java2d/pisces/Curve.java ! src/share/classes/sun/java2d/pisces/Dasher.java ! src/share/classes/sun/java2d/pisces/Helpers.java ! src/share/classes/sun/java2d/pisces/PiscesCache.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/classes/sun/java2d/pisces/PiscesTileGenerator.java ! src/share/classes/sun/java2d/pisces/Renderer.java ! src/share/classes/sun/java2d/pisces/Stroker.java ! src/share/classes/sun/java2d/pisces/TransformingPathConsumer2D.java Changeset: 577c5d930e44 Author: dav Date: 2011-01-25 15:33 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/577c5d930e44 6693961: cross-window focus transfer ability in the Focus Spec should be revised Reviewed-by: ant, art ! src/share/classes/java/awt/doc-files/FocusSpec.html Changeset: 5f3615691623 Author: dav Date: 2011-01-25 19:07 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5f3615691623 6431076: Cursor gets reset to text cursor in xawt TextArea when autoscrolling on append Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XGlobalCursorManager.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java + test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test.java + test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test1.java Changeset: 6fd2d28e66cd Author: denis Date: 2011-01-28 16:52 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6fd2d28e66cd 6340263: Regression testcase java/awt/dnd/DnDClipboardDeadlockTest throughs IOException: Owner timed out Reviewed-by: anthony, art ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: 9da15efec22b Author: andrew Date: 2011-02-01 17:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9da15efec22b 7015232: missing copyright header in CheckZOrderChange.java Summary: Add standard GPL header as on other tests Reviewed-by: anthony ! test/java/awt/Container/CheckZOrderChange/CheckZOrderChange.java Changeset: 3244848a4a2b Author: dav Date: 2011-02-04 17:32 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3244848a4a2b 6741526: KeyboardFocusManager.setDefaultFocusTraversalPolicy(FocusTraversalPolicy) affects created components Reviewed-by: ant, dcherepanov ! src/share/classes/java/awt/Window.java + test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_AWT.java + test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java Changeset: b5fc02e1a944 Author: lana Date: 2011-02-08 14:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b5fc02e1a944 Merge Changeset: 69fac04eda38 Author: rupashka Date: 2011-01-27 14:23 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/69fac04eda38 6902615: Method JTextComponent.getKeyStrokesForAction() throws StackOverflowError Reviewed-by: peterz ! src/share/classes/javax/swing/text/Keymap.java Changeset: ec066e903b84 Author: rupashka Date: 2011-01-27 14:33 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ec066e903b84 6935155: @since tag is missing in JTextComponent.save/restoreComposedText Reviewed-by: alexp ! src/share/classes/javax/swing/text/JTextComponent.java Changeset: 457f6b2cc155 Author: malenkov Date: 2011-01-31 21:22 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/457f6b2cc155 7001484: DOC: Method javax.swing.border.StrokeBorder.getBorderInsets() should specify how it converts float Reviewed-by: alexp ! src/share/classes/javax/swing/border/StrokeBorder.java Changeset: 020b4695370c Author: malenkov Date: 2011-01-31 21:31 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/020b4695370c 7001118: DOC: javax.swing.border.StrokeBorder.paintBorder() doesn't throw NPE in all specified cases Reviewed-by: alexp ! src/share/classes/javax/swing/border/StrokeBorder.java Changeset: 07bea0d4e454 Author: malenkov Date: 2011-01-31 21:49 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/07bea0d4e454 6999045: DOC: Unclear spec for BevelBorder constructor and BorderFactory factory method (colors switching) Reviewed-by: alexp ! src/share/classes/javax/swing/BorderFactory.java ! src/share/classes/javax/swing/border/BevelBorder.java Changeset: cbcd461067c5 Author: rupashka Date: 2011-02-02 18:37 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cbcd461067c5 6988168: Press the "Toggle Font" button.The size of the combo box didn't change. Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java Changeset: 6c4b6780ab20 Author: rupashka Date: 2011-02-02 18:41 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6c4b6780ab20 6988176: There is focus painted inside the button. Reviewed-by: alexp ! src/share/classes/sun/swing/WindowsPlacesBar.java Changeset: 057e9b837105 Author: rupashka Date: 2011-02-03 16:30 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/057e9b837105 7013453: BufferStrategyPaintManager.dispose will cause IllegalMonitorStateException in event thread Reviewed-by: alexp ! src/share/classes/javax/swing/BufferStrategyPaintManager.java + test/javax/swing/RepaintManager/7013453/bug7013453.java Changeset: 0fae79ec7248 Author: naoto Date: 2011-02-03 09:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0fae79ec7248 7013282: No appropriate CCC request for listed JDK 7 changes in java.util.spi package (b121) Reviewed-by: peytoia ! src/share/classes/java/util/spi/LocaleNameProvider.java Changeset: c7e368a95c75 Author: alexp Date: 2011-02-07 21:15 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c7e368a95c75 7016942: Revert a refactoring in TooltipManager to allow reflection hack Reviewed-by: rupashka ! src/share/classes/javax/swing/ToolTipManager.java Changeset: 989f6d3eee0d Author: alexp Date: 2011-02-07 21:34 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/989f6d3eee0d 6979537: closed/javax/swing/JSplitPane/UnitTest/UnitTest.java fails Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java Changeset: 842a0f8c89ea Author: naoto Date: 2011-02-08 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/842a0f8c89ea 7015500: Locale.toLanguageTag() uses "und" as lang subtag for private use only Locale Reviewed-by: srl ! src/share/classes/java/util/Locale.java ! src/share/classes/sun/util/locale/LanguageTag.java ! test/java/util/Locale/LocaleEnhanceTest.java Changeset: d002fe0c57c5 Author: lana Date: 2011-02-08 14:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d002fe0c57c5 Merge Changeset: dbfc1e419cb2 Author: darcy Date: 2011-01-24 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dbfc1e419cb2 7006578: Project Coin: Retrofit JDK libraries with @SafeVarargs Reviewed-by: mduigou, alexp ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/EnumSet.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/sun/swing/AccumulativeRunnable.java Changeset: ae38d1374e31 Author: mullan Date: 2011-01-24 14:56 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ae38d1374e31 5001004: Required Security Algorithms need to be defined Reviewed-by: wetmore ! src/share/classes/java/security/AlgorithmParameterGenerator.java ! src/share/classes/java/security/AlgorithmParameters.java ! src/share/classes/java/security/KeyFactory.java ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/Signature.java ! src/share/classes/java/security/cert/CertPath.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/java/security/cert/Certificate.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/CertificateFactorySpi.java ! src/share/classes/java/security/cert/package.html ! src/share/classes/java/security/package.html ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/ExemptionMechanism.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/Mac.java ! src/share/classes/javax/crypto/SecretKeyFactory.java ! src/share/classes/javax/crypto/package.html ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/net/ssl/package.html ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/package.html Changeset: b33e9b15835e Author: mullan Date: 2011-01-24 15:08 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b33e9b15835e Merge - make/common/internal/BinaryPlugs.gmk - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/classes/java/dyn/JavaMethodHandle.java - src/share/classes/java/dyn/LinkagePermission.java - src/share/classes/java/nio/channels/AsynchronousDatagramChannel.java ! src/share/classes/java/security/Security.java ! src/share/classes/javax/net/ssl/SSLContext.java - src/share/classes/sun/java2d/pisces/LineSink.java - src/share/classes/sun/net/httpserver/SelectorCache.java - src/share/classes/sun/nio/ch/SimpleAsynchronousDatagramChannelImpl.java - src/share/classes/sun/security/krb5/KrbKdcReq.java - src/share/classes/sun/security/krb5/internal/TCPClient.java - src/share/classes/sun/security/krb5/internal/UDPClient.java - src/share/demo/nio/zipfs/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipUtils.java - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/share/native/sun/font/layout/HebrewLigatureData.cpp - src/share/native/sun/font/layout/HebrewShaping.cpp - src/share/native/sun/font/layout/HebrewShaping.h - src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/java/nio/channels/AsynchronousDatagramChannel/Basic.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java - test/sun/security/krb5/auto/basic.sh Changeset: 6ac9383640c6 Author: mullan Date: 2011-01-24 15:46 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6ac9383640c6 Merge Changeset: 6e7bed89ce84 Author: mullan Date: 2011-01-25 08:41 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6e7bed89ce84 Merge Changeset: bf1b937076db Author: alanb Date: 2011-01-26 18:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/bf1b937076db 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI Reviewed-by: alexp ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java Changeset: abab55565eda Author: darcy Date: 2011-01-26 12:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/abab55565eda 7013420: Project Coin: remove general expression support from try-with-resources statement Reviewed-by: alanb ! test/java/nio/channels/FileChannel/Truncate.java Changeset: 236e3f2d0a6b Author: alanb Date: 2011-01-28 09:28 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/236e3f2d0a6b 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: chegar, sherman ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk ! make/mkdemo/Makefile ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/SerialCallbackContext.java - src/share/classes/java/io/TempFileHelper.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/channels/SeekableByteChannel.java ! src/share/classes/java/nio/file/AccessMode.java + src/share/classes/java/nio/file/CopyMoveHelper.java ! src/share/classes/java/nio/file/CopyOption.java ! src/share/classes/java/nio/file/DirectoryStream.java - src/share/classes/java/nio/file/FileRef.java ! src/share/classes/java/nio/file/FileStore.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/FileSystems.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/FileVisitor.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/LinkOption.java ! src/share/classes/java/nio/file/LinkPermission.java ! src/share/classes/java/nio/file/OpenOption.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/PathMatcher.java ! src/share/classes/java/nio/file/Paths.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java + src/share/classes/java/nio/file/TempFileHelper.java ! src/share/classes/java/nio/file/WatchEvent.java ! src/share/classes/java/nio/file/WatchKey.java ! src/share/classes/java/nio/file/WatchService.java ! src/share/classes/java/nio/file/attribute/AclEntry.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java - src/share/classes/java/nio/file/attribute/Attributes.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java ! src/share/classes/java/nio/file/attribute/DosFileAttributeView.java ! src/share/classes/java/nio/file/attribute/DosFileAttributes.java ! src/share/classes/java/nio/file/attribute/FileAttribute.java ! src/share/classes/java/nio/file/attribute/FileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileOwnerAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributeView.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributes.java ! src/share/classes/java/nio/file/attribute/PosixFilePermission.java ! src/share/classes/java/nio/file/attribute/PosixFilePermissions.java ! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java ! src/share/classes/java/nio/file/attribute/package-info.java ! src/share/classes/java/nio/file/package-info.java ! src/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/share/classes/java/nio/file/spi/FileTypeDetector.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/sun/nio/fs/AbstractAclFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractBasicFileAttributeView.java + src/share/classes/sun/nio/fs/AbstractFileSystemProvider.java ! src/share/classes/sun/nio/fs/AbstractFileTypeDetector.java ! src/share/classes/sun/nio/fs/AbstractPath.java ! src/share/classes/sun/nio/fs/AbstractPoller.java ! src/share/classes/sun/nio/fs/AbstractUserDefinedFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractWatchKey.java ! src/share/classes/sun/nio/fs/AbstractWatchService.java ! src/share/classes/sun/nio/fs/DynamicFileAttributeView.java ! src/share/classes/sun/nio/fs/FileOwnerAttributeViewImpl.java ! src/share/classes/sun/nio/fs/PollingWatchService.java ! src/share/classes/sun/security/provider/SeedGenerator.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/sample/nio/file/AclEdit.java ! src/share/sample/nio/file/Chmod.java ! src/share/sample/nio/file/Copy.java ! src/share/sample/nio/file/DiskUsage.java ! src/share/sample/nio/file/FileType.java ! src/share/sample/nio/file/WatchDir.java ! src/share/sample/nio/file/Xdd.java ! src/solaris/classes/sun/nio/fs/GnomeFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/LinuxUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxWatchService.java ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystem.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java ! src/solaris/classes/sun/nio/fs/UnixCopyFile.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileSystem.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixSecureDirectoryStream.java ! src/windows/classes/sun/nio/fs/RegistryFileTypeDetector.java ! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java ! src/windows/classes/sun/nio/fs/WindowsFileCopy.java ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! src/windows/classes/sun/nio/fs/WindowsFileSystem.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java ! src/windows/classes/sun/nio/fs/WindowsSecurityDescriptor.java ! src/windows/classes/sun/nio/fs/WindowsUserDefinedFileAttributeView.java ! src/windows/classes/sun/nio/fs/WindowsWatchService.java ! test/demo/zipfs/basic.sh ! test/java/io/File/IsHidden.java ! test/java/io/File/SetAccess.java ! test/java/io/File/SymLinks.java ! test/java/io/FileInputStream/LargeFileAvailable.java ! test/java/nio/channels/FileChannel/AtomicAppend.java ! test/java/nio/channels/FileChannel/Transfer.java ! test/java/nio/file/DirectoryStream/Basic.java ! test/java/nio/file/DirectoryStream/DriveLetter.java ! test/java/nio/file/DirectoryStream/SecureDS.java ! test/java/nio/file/FileStore/Basic.java + test/java/nio/file/Files/BytesAndLines.java + test/java/nio/file/Files/CheckPermissions.java - test/java/nio/file/Files/ContentType.java + test/java/nio/file/Files/CopyAndMove.java - test/java/nio/file/Files/CreateFileTree.java + test/java/nio/file/Files/DeleteOnClose.java + test/java/nio/file/Files/FileAttributes.java - test/java/nio/file/Files/ForceLoad.java + test/java/nio/file/Files/InterruptCopy.java + test/java/nio/file/Files/Links.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java ! test/java/nio/file/Files/Misc.java + test/java/nio/file/Files/PassThroughFileSystem.java - test/java/nio/file/Files/PrintFileTree.java + test/java/nio/file/Files/SBC.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java + test/java/nio/file/Files/TemporaryFiles.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java + test/java/nio/file/Files/delete_on_close.sh - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy + test/java/nio/file/Files/probeContentType/Basic.java + test/java/nio/file/Files/probeContentType/ForceLoad.java + test/java/nio/file/Files/probeContentType/META-INF/services/java.nio.file.spi.FileTypeDetector + test/java/nio/file/Files/probeContentType/SimpleFileTypeDetector.java + test/java/nio/file/Files/walkFileTree/CreateFileTree.java + test/java/nio/file/Files/walkFileTree/MaxDepth.java + test/java/nio/file/Files/walkFileTree/Nulls.java + test/java/nio/file/Files/walkFileTree/PrintFileTree.java + test/java/nio/file/Files/walkFileTree/SkipSiblings.java + test/java/nio/file/Files/walkFileTree/TerminateWalk.java + test/java/nio/file/Files/walkFileTree/WalkWithSecurity.java + test/java/nio/file/Files/walkFileTree/denyAll.policy + test/java/nio/file/Files/walkFileTree/grantAll.policy + test/java/nio/file/Files/walkFileTree/grantTopOnly.policy + test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java ! test/java/nio/file/Path/Misc.java - test/java/nio/file/Path/PassThroughFileSystem.java ! test/java/nio/file/Path/PathOps.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh ! test/java/nio/file/TestUtil.java ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/FileTreeModifier.java ! test/java/nio/file/WatchService/LotsOfEvents.java ! test/java/nio/file/WatchService/SensitivityModifier.java ! test/java/nio/file/attribute/AclFileAttributeView/Basic.java ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java ! test/java/nio/file/attribute/DosFileAttributeView/Basic.java - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java ! test/java/nio/file/attribute/FileTime/Basic.java ! test/java/nio/file/attribute/PosixFileAttributeView/Basic.java ! test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java ! test/java/nio/file/spi/SetDefaultProvider.java ! test/java/nio/file/spi/TestProvider.java Changeset: 60d347deb54d Author: alanb Date: 2011-01-28 09:31 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/60d347deb54d Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! test/demo/zipfs/basic.sh - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: dea360853f8b Author: alanb Date: 2011-01-28 13:26 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dea360853f8b 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420 Reviewed-by: chegar ! test/java/net/Socks/SocksProxyVersion.java Changeset: d21a1ce074a7 Author: darcy Date: 2011-01-28 17:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d21a1ce074a7 7015156: Remove JSR 308 changes from core libraries Reviewed-by: mduigou ! src/share/classes/java/lang/SuppressWarnings.java ! src/share/classes/java/lang/annotation/ElementType.java Changeset: f110edeb4428 Author: darcy Date: 2011-02-01 00:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f110edeb4428 7015827: Fix HTML validation issues in java.math package Reviewed-by: mduigou ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/RoundingMode.java Changeset: d4bc38aa7594 Author: xuelei Date: 2011-02-01 04:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d4bc38aa7594 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm Summary: add new BasicReason and improve trust anchor searching method during cert path validation Reviewed-by: mullan ! src/share/classes/java/security/cert/CertPathValidatorException.java + src/share/classes/sun/security/provider/certpath/AdaptableX509CertSelector.java ! src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/validator/SimpleValidator.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java Changeset: 21d7cd823247 Author: sundar Date: 2011-02-01 21:00 +0530 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/21d7cd823247 7015908: 3 javax.script tests fail with openjdk build Reviewed-by: alanb ! test/javax/script/CauseExceptionTest.java ! test/javax/script/StringWriterPrintTest.java ! test/javax/script/UnescapedBracketRegExTest.java Changeset: 312dc0abb960 Author: sherman Date: 2011-02-01 14:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/312dc0abb960 7015391: (zipfs) Update zip provider for 1/2011 changes 7014948: (zipfs) ZipFileSystem.newFileSystem(Path...) should not throw FileSystemAlreadyExistsException 7015139: (zipfs) ZipPath.delete() should throw DirectoryNotEmptyException when handling "real, non-empty" dir Summary: zip filesystem provider update Reviewed-by: alanb ! make/mkdemo/Makefile ! src/share/demo/nio/zipfs/Demo.java ! src/share/demo/nio/zipfs/README.txt ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributeView.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java - src/share/demo/zipfs ! test/demo/zipfs/Basic.java ! test/demo/zipfs/PathOps.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 25462d7eee24 Author: briangoetz Date: 2011-02-02 13:13 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/25462d7eee24 7012540: java.util.Objects.nonNull() incorrectly named Reviewed-by: darcy, weijun ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/lang/StackTraceElement.java ! src/share/classes/java/nio/file/DirectoryIteratorException.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/SimpleFileVisitor.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/Objects.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/sun/security/krb5/KrbAsRep.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: 3c86f24f7500 Author: chegar Date: 2011-02-03 10:10 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3c86f24f7500 7008595: Class loader leak caused by keepAliveTimer thread in KeepAliveCache Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java Changeset: dff9b6d18628 Author: coffeys Date: 2011-02-03 11:28 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dff9b6d18628 7016897: Copyright header correction : test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java Reviewed-by: vinnie ! test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java Changeset: 0f5dc2fc81b1 Author: chegar Date: 2011-02-03 11:56 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0f5dc2fc81b1 6887710: Jar index should avoid putting META-INF in the INDEX.LIST Reviewed-by: michaelm ! src/share/classes/sun/misc/JarIndex.java + test/sun/misc/JarIndex/metaInfFilenames/Basic.java + test/sun/misc/JarIndex/metaInfFilenames/jarA/META-INF/services/my.happy.land + test/sun/misc/JarIndex/metaInfFilenames/jarA/a/A.java + test/sun/misc/JarIndex/metaInfFilenames/jarA/com/message/spi/MessageService.java + test/sun/misc/JarIndex/metaInfFilenames/jarB/META-INF/JAVA2.DS + test/sun/misc/JarIndex/metaInfFilenames/jarB/META-INF/services/no.name.service + test/sun/misc/JarIndex/metaInfFilenames/jarB/b/B.java + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/fonts.mf + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/fonts/Company-corporate.ttf + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/fonts/kidpr.ttf + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/services/com.message.spi.MessageService + test/sun/misc/JarIndex/metaInfFilenames/jarC/my/impl/StandardMessageService.java Changeset: 68e3eba12afe Author: michaelm Date: 2011-02-03 12:57 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/68e3eba12afe 6751021: TEST_BUG: race condition in the test java/lang/Runtime/exec/Duped.java Reviewed-by: alanb ! test/java/lang/Runtime/exec/Duped.java Changeset: e2a182adb30f Author: alanb Date: 2011-02-03 13:37 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e2a182adb30f 7014794: (file) lookupPrincipalByGroupName fails to find large NIS groups Reviewed-by: chegar ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c Changeset: 515512634eb4 Author: vinnie Date: 2011-02-03 19:09 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/515512634eb4 6997561: A request for better error handling in JNDI Reviewed-by: robm ! src/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java + test/com/sun/jndi/ldap/LdapName/EmptyNameSearch.java Changeset: 035ecca4379c Author: sherman Date: 2011-02-03 13:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/035ecca4379c 7014645: Support perl style Unicode hex notation \x{...} Summary: Added the construct \x{...} for Unicode hex notation support Reviewed-by: alanb, okutsu ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 3c1eca364cc7 Author: ksrini Date: 2011-02-03 15:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3c1eca364cc7 6968053: (launcher) hide exceptions under certain launcher failures Reviewed-by: mchung ! src/share/bin/java.c ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/misc/VM.java ! test/tools/launcher/Arrrghs.java Changeset: 1b5c838b8db8 Author: vinnie Date: 2011-02-04 00:33 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1b5c838b8db8 6989705: ECC security code native code compiler warnings Reviewed-by: alanb, ohair ! src/share/native/sun/security/ec/ECC_JNI.cpp ! src/share/native/sun/security/ec/impl/ec.c ! src/share/native/sun/security/ec/impl/ec.h ! src/share/native/sun/security/ec/impl/ec2.h ! src/share/native/sun/security/ec/impl/ec2_163.c ! src/share/native/sun/security/ec/impl/ec2_193.c ! src/share/native/sun/security/ec/impl/ec2_233.c ! src/share/native/sun/security/ec/impl/ec2_aff.c ! src/share/native/sun/security/ec/impl/ec2_mont.c ! src/share/native/sun/security/ec/impl/ec_naf.c ! src/share/native/sun/security/ec/impl/ecc_impl.h ! src/share/native/sun/security/ec/impl/ecdecode.c ! src/share/native/sun/security/ec/impl/ecl-curve.h ! src/share/native/sun/security/ec/impl/ecl-exp.h ! src/share/native/sun/security/ec/impl/ecl-priv.h ! src/share/native/sun/security/ec/impl/ecl.c ! src/share/native/sun/security/ec/impl/ecl.h ! src/share/native/sun/security/ec/impl/ecl_curve.c ! src/share/native/sun/security/ec/impl/ecl_gf.c ! src/share/native/sun/security/ec/impl/ecl_mult.c ! src/share/native/sun/security/ec/impl/ecp.h ! src/share/native/sun/security/ec/impl/ecp_192.c ! src/share/native/sun/security/ec/impl/ecp_224.c ! src/share/native/sun/security/ec/impl/ecp_256.c ! src/share/native/sun/security/ec/impl/ecp_384.c ! src/share/native/sun/security/ec/impl/ecp_521.c ! src/share/native/sun/security/ec/impl/ecp_aff.c ! src/share/native/sun/security/ec/impl/ecp_jac.c ! src/share/native/sun/security/ec/impl/ecp_jm.c ! src/share/native/sun/security/ec/impl/ecp_mont.c ! src/share/native/sun/security/ec/impl/logtab.h ! src/share/native/sun/security/ec/impl/mp_gf2m-priv.h ! src/share/native/sun/security/ec/impl/mp_gf2m.c ! src/share/native/sun/security/ec/impl/mp_gf2m.h ! src/share/native/sun/security/ec/impl/mpi-config.h ! src/share/native/sun/security/ec/impl/mpi-priv.h ! src/share/native/sun/security/ec/impl/mpi.c ! src/share/native/sun/security/ec/impl/mpi.h ! src/share/native/sun/security/ec/impl/mplogic.c ! src/share/native/sun/security/ec/impl/mplogic.h ! src/share/native/sun/security/ec/impl/mpmontg.c ! src/share/native/sun/security/ec/impl/mpprime.h ! src/share/native/sun/security/ec/impl/oid.c ! src/share/native/sun/security/ec/impl/secitem.c ! src/share/native/sun/security/ec/impl/secoidt.h Changeset: fed61c2f4d14 Author: vinnie Date: 2011-02-04 00:33 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fed61c2f4d14 Merge Changeset: 78fe1b7a9a1a Author: vinnie Date: 2011-02-04 09:52 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/78fe1b7a9a1a 7017176: Several JNDI tests are mssing GPL header Reviewed-by: alanb ! test/com/sun/jndi/ldap/LdapName/Case.java ! test/com/sun/jndi/ldap/LdapName/EmptyNameSearch.java ! test/com/sun/jndi/ldap/LdapName/UnescapeTest.java ! test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: 9599534b1727 Author: lancea Date: 2011-02-04 09:07 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9599534b1727 7014095: Broken link in java.sql package specification Reviewed-by: alanb ! src/share/classes/java/sql/package.html Changeset: c5f953e920c6 Author: mduigou Date: 2011-02-04 12:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c5f953e920c6 7015783: Update JDK Netbeans projects to -source 1.7 Reviewed-by: darcy ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent Changeset: b8662dac7c91 Author: sherman Date: 2011-02-04 13:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b8662dac7c91 7005986: (zipfs) ZipPath.startsWith() fails because of the implementation of getName(index) Summary: Updated starsWith/endsWith to be consistent with default file system Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java ! test/demo/zipfs/PathOps.java ! test/demo/zipfs/basic.sh Changeset: a775b8d3fed0 Author: lana Date: 2011-02-04 17:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a775b8d3fed0 Merge - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties Changeset: b0bd638036bd Author: vinnie Date: 2011-02-07 09:11 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b0bd638036bd 7017486: Need synchronized access when flushing the LDAP request queue Reviewed-by: alanb ! src/share/classes/com/sun/jndi/ldap/Connection.java Changeset: f34dcfeecc8d Author: alanb Date: 2011-02-07 13:53 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f34dcfeecc8d 7012823: TEST_BUG: java/nio/MappedByteBuffer tests leave file mappingsthat prevent clean-up (win) Reviewed-by: forax ! test/java/nio/MappedByteBuffer/Force.java ! test/java/nio/MappedByteBuffer/ZeroMap.java Changeset: 32f1c5f67aae Author: alanb Date: 2011-02-07 13:55 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/32f1c5f67aae 7003155: (fs) Paths.get() does not handle escaped octets correctly Reviewed-by: sherman ! src/solaris/classes/sun/nio/fs/UnixUriUtils.java ! test/java/nio/file/Path/UriImportExport.java Changeset: 94bcd9aa2119 Author: chegar Date: 2011-02-07 14:08 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/94bcd9aa2119 7016898: PlainSocketImpl.fd is null on Windows Reviewed-by: alanb ! src/windows/classes/java/net/PlainSocketImpl.java Changeset: f9f321a7502c Author: alanb Date: 2011-02-07 18:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f9f321a7502c 7017454: Residual warnings in sun/nio/** and java/io native code (win64) Reviewed-by: chegar ! src/share/native/java/io/io_util.c ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/windows/native/java/io/canonicalize_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/sun/nio/ch/Iocp.c ! src/windows/native/sun/nio/fs/RegistryFileTypeDetector.c ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c Changeset: 08e1914d5852 Author: alanb Date: 2011-02-07 18:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/08e1914d5852 Merge Changeset: 947ce00ed7a2 Author: alanb Date: 2011-02-08 15:50 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/947ce00ed7a2 7013585: Dual-pivot quicksort improvements for highly structured (nearly sorted) and data with small periods Reviewed-by: mduigou, alanb Contributed-by: vladimir.yaroslavskiy at oracle.com ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java Changeset: 82c8c54ac1d5 Author: alanb Date: 2011-02-08 19:31 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/82c8c54ac1d5 4421494: infinite loop while parsing double literal Reviewed-by: darcy, alanb Contributed-by: dmitry.nadezhin at oracle.com ! src/share/classes/sun/misc/FloatingDecimal.java ! test/java/lang/Double/ParseDouble.java Changeset: 6661a1dfa369 Author: sherman Date: 2011-02-08 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6661a1dfa369 7017840: (zipfs) test/demo/zipfs/basic.sh needs to be updated due to 7013420 Summary: updated try-with-resourcse usage in test/demo code Reviewed-by: alanb ! src/share/demo/nio/zipfs/Demo.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 1899523d8f24 Author: lana Date: 2011-02-08 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1899523d8f24 Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: cd9a302f2806 Author: chegar Date: 2011-02-09 09:53 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cd9a302f2806 7013961: Threads attached via JNI attach prevent daemon ThreadGroups from being destroyed Reviewed-by: dholmes ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/ThreadGroup.java Changeset: 6a274c4d3e00 Author: alanb Date: 2011-02-09 15:59 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6a274c4d3e00 7018258: Dual-pivot updates in 7013585 can fail with ArrayIndexOutOfBoundsException Reviewed-by: alanb Contributed-by: vladimir.yaroslavskiy at oracle.com ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java Changeset: 37563c09305d Author: alanb Date: 2011-02-09 16:30 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/37563c09305d Merge Changeset: a8fcaf5097ec Author: lana Date: 2011-02-09 10:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a8fcaf5097ec Merge Changeset: 9d141e45ee4b Author: lana Date: 2011-02-14 16:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9d141e45ee4b Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: e4802c87e5c7 Author: herrick Date: 2011-02-09 09:19 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e4802c87e5c7 7016724: Remove sun.jkernel.* classes in JDK 7 Summary: Remove sun.jkernel.* classes in JDK 7 Reviewed-by: ohair, alanb, mchung ! make/modules/modules.config ! make/sun/Makefile - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/util/zip/ZipEntry.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java ! src/share/classes/sun/jvmstat/monitor/MonitoredVmUtil.java ! src/share/classes/sun/misc/BootClassLoaderHook.java ! src/share/classes/sun/tools/attach/HotSpotAttachProvider.java ! src/windows/bin/java_md.c - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc Changeset: dc909d130397 Author: herrick Date: 2011-02-09 09:32 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dc909d130397 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 4f84cda2a7d5 Author: igor Date: 2011-02-09 21:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4f84cda2a7d5 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc Changeset: 802c085308bf Author: igor Date: 2011-02-15 19:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/802c085308bf Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 7bb09178ffc7 Author: ohair Date: 2011-02-10 20:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7bb09178ffc7 7012644: Regression: jdk/make/common/shared/Defs-windows.gmk has problems on cygwin 7018835: Debug build issues in jdk makefiles Reviewed-by: ksrini ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Platform.gmk Changeset: 9478964f9425 Author: ohair Date: 2011-02-10 20:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9478964f9425 Merge Changeset: 71b52ce5f389 Author: mfang Date: 2011-02-10 20:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/71b52ce5f389 7017734: jdk7 message drop 1 translation integration Reviewed-by: ogino, yhuang ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_de.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_es.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_fr.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_it.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ko.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_sv.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_CN.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_es.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_fr.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_it.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ja.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ko.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_sv.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_es.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_fr.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_it.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_ja.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_ko.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_pt_BR.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_sv.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_CN.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! src/share/classes/com/sun/tools/jdi/resources/jdi_ja.properties ! src/share/classes/com/sun/tools/jdi/resources/jdi_zh_CN.properties ! src/share/classes/sun/applet/resources/MsgAppletViewer_de.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_es.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_fr.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_it.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_ja.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_ko.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_pt_BR.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_sv.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_TW.java ! src/share/classes/sun/awt/resources/awt_de.properties ! src/share/classes/sun/awt/resources/awt_es.properties ! src/share/classes/sun/awt/resources/awt_fr.properties ! src/share/classes/sun/awt/resources/awt_it.properties ! src/share/classes/sun/awt/resources/awt_ja.properties ! src/share/classes/sun/awt/resources/awt_ko.properties ! src/share/classes/sun/awt/resources/awt_pt_BR.properties ! src/share/classes/sun/awt/resources/awt_sv.properties ! src/share/classes/sun/awt/resources/awt_zh_CN.properties ! src/share/classes/sun/awt/resources/awt_zh_TW.properties ! src/share/classes/sun/management/resources/agent_de.properties ! src/share/classes/sun/management/resources/agent_es.properties ! src/share/classes/sun/management/resources/agent_fr.properties ! src/share/classes/sun/management/resources/agent_it.properties ! src/share/classes/sun/management/resources/agent_ja.properties ! src/share/classes/sun/management/resources/agent_ko.properties ! src/share/classes/sun/management/resources/agent_pt_BR.properties ! src/share/classes/sun/management/resources/agent_sv.properties ! src/share/classes/sun/management/resources/agent_zh_CN.properties ! src/share/classes/sun/management/resources/agent_zh_TW.properties ! src/share/classes/sun/misc/resources/Messages_de.java ! src/share/classes/sun/misc/resources/Messages_es.java ! src/share/classes/sun/misc/resources/Messages_fr.java ! src/share/classes/sun/misc/resources/Messages_it.java ! src/share/classes/sun/misc/resources/Messages_ja.java ! src/share/classes/sun/misc/resources/Messages_ko.java ! src/share/classes/sun/misc/resources/Messages_pt_BR.java ! src/share/classes/sun/misc/resources/Messages_sv.java ! src/share/classes/sun/misc/resources/Messages_zh_CN.java ! src/share/classes/sun/misc/resources/Messages_zh_TW.java ! src/share/classes/sun/print/resources/serviceui_de.properties ! src/share/classes/sun/print/resources/serviceui_es.properties ! src/share/classes/sun/print/resources/serviceui_fr.properties ! src/share/classes/sun/print/resources/serviceui_it.properties ! src/share/classes/sun/print/resources/serviceui_ja.properties ! src/share/classes/sun/print/resources/serviceui_ko.properties ! src/share/classes/sun/print/resources/serviceui_pt_BR.properties ! src/share/classes/sun/print/resources/serviceui_sv.properties ! src/share/classes/sun/print/resources/serviceui_zh_CN.properties ! src/share/classes/sun/print/resources/serviceui_zh_TW.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_de.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_es.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_fr.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_it.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_ja.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_ko.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_pt_BR.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_sv.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_CN.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_TW.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_ja.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_zh_CN.properties ! src/share/classes/sun/rmi/server/resources/rmid_de.properties ! src/share/classes/sun/rmi/server/resources/rmid_es.properties ! src/share/classes/sun/rmi/server/resources/rmid_fr.properties ! src/share/classes/sun/rmi/server/resources/rmid_it.properties ! src/share/classes/sun/rmi/server/resources/rmid_ja.properties ! src/share/classes/sun/rmi/server/resources/rmid_ko.properties ! src/share/classes/sun/rmi/server/resources/rmid_pt_BR.properties ! src/share/classes/sun/rmi/server/resources/rmid_sv.properties ! src/share/classes/sun/rmi/server/resources/rmid_zh_CN.properties ! src/share/classes/sun/rmi/server/resources/rmid_zh_TW.properties ! src/share/classes/sun/security/tools/JarSignerResources_ja.java ! src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java ! src/share/classes/sun/security/util/AuthResources_de.java ! src/share/classes/sun/security/util/AuthResources_es.java ! src/share/classes/sun/security/util/AuthResources_fr.java ! src/share/classes/sun/security/util/AuthResources_it.java ! src/share/classes/sun/security/util/AuthResources_ja.java ! src/share/classes/sun/security/util/AuthResources_ko.java ! src/share/classes/sun/security/util/AuthResources_pt_BR.java ! src/share/classes/sun/security/util/AuthResources_sv.java ! src/share/classes/sun/security/util/AuthResources_zh_CN.java ! src/share/classes/sun/security/util/AuthResources_zh_TW.java ! src/share/classes/sun/security/util/Resources_de.java ! src/share/classes/sun/security/util/Resources_es.java ! src/share/classes/sun/security/util/Resources_fr.java ! src/share/classes/sun/security/util/Resources_it.java ! src/share/classes/sun/security/util/Resources_ja.java ! src/share/classes/sun/security/util/Resources_ko.java ! src/share/classes/sun/security/util/Resources_pt_BR.java ! src/share/classes/sun/security/util/Resources_sv.java ! src/share/classes/sun/security/util/Resources_zh_CN.java ! src/share/classes/sun/security/util/Resources_zh_TW.java ! src/share/classes/sun/tools/jar/resources/jar_de.properties ! src/share/classes/sun/tools/jar/resources/jar_es.properties ! src/share/classes/sun/tools/jar/resources/jar_fr.properties ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/share/classes/sun/tools/jar/resources/jar_ko.properties ! src/share/classes/sun/tools/jar/resources/jar_pt_BR.properties ! src/share/classes/sun/tools/jar/resources/jar_sv.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_TW.properties ! src/share/classes/sun/tools/javac/resources/javac_ja.properties ! src/share/classes/sun/tools/javac/resources/javac_zh_CN.properties ! src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java ! src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java ! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_ja.java ! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_zh_CN.java ! src/share/classes/sun/tools/serialver/serialver_ja.properties ! src/share/classes/sun/tools/serialver/serialver_zh_CN.properties ! src/share/classes/sun/util/logging/resources/logging_de.properties ! src/share/classes/sun/util/logging/resources/logging_es.properties ! src/share/classes/sun/util/logging/resources/logging_fr.properties ! src/share/classes/sun/util/logging/resources/logging_it.properties ! src/share/classes/sun/util/logging/resources/logging_ja.properties ! src/share/classes/sun/util/logging/resources/logging_ko.properties ! src/share/classes/sun/util/logging/resources/logging_pt_BR.properties ! src/share/classes/sun/util/logging/resources/logging_sv.properties ! src/share/classes/sun/util/logging/resources/logging_zh_CN.properties ! src/share/classes/sun/util/logging/resources/logging_zh_TW.properties ! src/share/demo/jfc/CodePointIM/resources/codepoint_ja.properties ! src/share/demo/jfc/CodePointIM/resources/codepoint_zh_CN.properties ! src/share/demo/jfc/Font2DTest/resources/TextResources_ja.properties ! src/share/demo/jfc/Font2DTest/resources/TextResources_zh_CN.properties ! src/share/demo/jfc/Notepad/resources/Notepad_ja.properties ! src/share/demo/jfc/Notepad/resources/Notepad_zh_CN.properties ! src/windows/classes/sun/awt/windows/awtLocalization_es.properties ! src/windows/classes/sun/awt/windows/awtLocalization_ja.properties ! src/windows/classes/sun/awt/windows/awtLocalization_ko.properties ! src/windows/classes/sun/awt/windows/awtLocalization_pt_BR.properties ! src/windows/classes/sun/awt/windows/awtLocalization_zh_CN.properties ! src/windows/classes/sun/awt/windows/awtLocalization_zh_TW.properties ! src/windows/native/sun/jkernel/kernel_de.rc ! src/windows/native/sun/jkernel/kernel_es.rc ! src/windows/native/sun/jkernel/kernel_fr.rc ! src/windows/native/sun/jkernel/kernel_it.rc ! src/windows/native/sun/jkernel/kernel_ja.rc ! src/windows/native/sun/jkernel/kernel_ko.rc ! src/windows/native/sun/jkernel/kernel_pt_BR.rc ! src/windows/native/sun/jkernel/kernel_sv.rc ! src/windows/native/sun/jkernel/kernel_zh.rc ! src/windows/native/sun/jkernel/kernel_zh_TW.rc Changeset: 8b6d1d96ef3d Author: mfang Date: 2011-02-11 22:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8b6d1d96ef3d Merge Changeset: 0eacbbc8e1fb Author: mfang Date: 2011-02-11 23:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0eacbbc8e1fb Merge Changeset: 780e53ad2896 Author: mfang Date: 2011-02-14 13:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/780e53ad2896 Merge Changeset: 5fab973e5a47 Author: ohair Date: 2011-02-15 12:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5fab973e5a47 Merge Changeset: bdc069d3f910 Author: ohair Date: 2011-02-15 20:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/bdc069d3f910 Merge Changeset: 89055b6d9ae0 Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/89055b6d9ae0 Added tag jdk7-b130 for changeset bdc069d3f910 ! .hgtags Changeset: 0355c60c2da4 Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0355c60c2da4 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 9b2631288894 Author: ohair Date: 2011-02-16 14:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9b2631288894 7010594: Add /SAFESEH to links on windows to verify safe exceptions Reviewed-by: alanb ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windows.gmk Changeset: 5e09deee1967 Author: andrew Date: 2011-02-23 17:10 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5e09deee1967 7021314: Build should not install javaws man page Summary: Only install javaws.1 when not building OpenJDK Reviewed-by: alanb, ohair ! make/common/Release.gmk Changeset: 8ac52c85f9e9 Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8ac52c85f9e9 Merge Changeset: 11c9a066a5a4 Author: cl Date: 2011-02-24 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/11c9a066a5a4 Added tag jdk7-b131 for changeset 8ac52c85f9e9 ! .hgtags Changeset: f6cd84cfed70 Author: trims Date: 2011-02-25 12:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f6cd84cfed70 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java From zhengyu.gu at oracle.com Mon Feb 28 08:46:37 2011 From: zhengyu.gu at oracle.com (Zhengyu Gu) Date: Mon, 28 Feb 2011 11:46:37 -0500 Subject: Request for review: 7017110 : Add /SAFESEH to links on windows 32bit to verify safe exceptions In-Reply-To: <4D6BC621.2010508@oracle.com> References: <4D5AF415.6030101@oracle.com> <4D6BC621.2010508@oracle.com> Message-ID: <4D6BD16D.9060101@oracle.com> On 2/28/2011 10:58 AM, Zhengyu Gu wrote: > Resend: Could you please review the changes? > > Thanks, > > -Zhengyu > > On 2/15/2011 4:45 PM, Zhengyu Gu wrote: >> Summary: Added link flag /SAFESEH on Windows 32bit only build, to >> guarantee safe exception handlers. >> >> Bug: http://monaco.sfbay.sun.com/detail.jsf?cr=7017110 >> Webrev: http://cr.openjdk.java.net/~zgu/7017110/webrev.00/ >> >> >> Thanks, >> >> -Zhengyu >> > From kelly.ohair at oracle.com Mon Feb 28 11:07:42 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 28 Feb 2011 11:07:42 -0800 Subject: Request for review: 7017110 : Add /SAFESEH to links on windows 32bit to verify safe exceptions In-Reply-To: <4D6BD16D.9060101@oracle.com> References: <4D5AF415.6030101@oracle.com> <4D6BC621.2010508@oracle.com> <4D6BD16D.9060101@oracle.com> Message-ID: <0F188353-67DA-40B6-A99D-4FDB3D4F8F33@oracle.com> Looks good to me. -kto On Feb 28, 2011, at 8:46 AM, Zhengyu Gu wrote: > On 2/28/2011 10:58 AM, Zhengyu Gu wrote: >> Resend: Could you please review the changes? >> >> Thanks, >> >> -Zhengyu >> >> On 2/15/2011 4:45 PM, Zhengyu Gu wrote: >>> Summary: Added link flag /SAFESEH on Windows 32bit only build, to guarantee safe exception handlers. >>> >>> Bug: http://monaco.sfbay.sun.com/detail.jsf?cr=7017110 >>> Webrev: http://cr.openjdk.java.net/~zgu/7017110/webrev.00/ >>> >>> >>> Thanks, >>> >>> -Zhengyu >>> >> >