Request for reviews (XS): 7012339: JSR 292 crash in G1SATBCardTableModRefBS::write_ref_field_pre_work()

[Tom Rodriguez]

Looks good.

tom

On Jan 27, 2011, at 2:23 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/7012339/webrev.01/
> 
> 7012339: JSR 292 crash in G1SATBCardTableModRefBS::write_ref_field_pre_work()
> Reviewed-by:
> 
> The cast of &_f1 to HeapWord* in
> ConstantPoolCacheEntry::set_f1_if_null_atomic leads to the wrong
> version of update_barrier_set_pre.
> 
> The fix is to cast &_f1 to oop*.
> 
> Thanks to John Cuthbertson who actually told me what's going
> wrong.