review (XS) for 7030300: more nightly failures after statics in Class changes

[Tom Rodriguez]

On Mar 23, 2011, at 10:50 AM, Daniel D. Daugherty wrote:

> On 3/23/2011 10:39 AM, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/7030300
>>  
> 
> Thumbs up!
> 
> Are these changes applicable in a pre-static fields move world?

No.  The CodeStubs changes didn't look like that previously and the hprof bin writer changes are because of the statics changes.  Thanks!

tom

> 
> Dan
> 
> 
> agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
>   No comments.
> 
> src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp
>   No comments.
> 
> src/cpu/x86/vm/c1_CodeStubs_x86.cpp
>   No comments.
> 
> 
>> 7030300: more nightly failures after statics in Class changes
>> Reviewed-by:
>> 
>> Yet another place that needs to be updated when writing static field
>> values and the c1 CodeStubs changes need to be compressed oops aware.
>> Tested with failing tests from nightly.
>>