review (S) for 7022204: LogFile wildcarding should use %p instead of star

[Tom Rodriguez]

Thanks John and Coleen.

tom

On Mar 25, 2011, at 10:52 AM, John Rose wrote:

> Reviewed; thanks.  -- John
> 
> On Mar 25, 2011, at 9:49 AM, Tom Rodriguez wrote:
> 
>> http://cr.openjdk.java.net/~never/7022204
>> 
>> 7022204: LogFile wildcarding should use %p instead of star
>> Reviewed-by:
>> 
>> Currently to get wildcarding in the LogFile name you have to use *
>> which is very unfriendly for shell scripts.  We should use %p as we do
>> in other places.  It still accepts * and will convert it in preference
>> to %p.  I considered switching to using Arguments::copy_expand_pid but
>> it would change the behaviour of the flag in an incompatible way so I
>> just augmented the existing logic slightly.  Tested with various
>> command line flags
>