Request for review (S): 6817525: turn on method handle functionality by default for JSR 292

[Tom Rodriguez]

On Mar 28, 2011, at 12:49 PM, John Rose wrote:

> EnableInvokeDynamic and related switches may be useful for diagnostic testing, for root cause analysis.  And they are needed to differentiate behavior of 1.6 from 1.7.  But they are probably not useful as full product switches.  Unless there's a reason against it, we should categorize them as diagnostic switches.  This will affect the messages in methodHandles.cpp as well as the defs in globals.hpp.

Why do we need the related switches as separate flags at all?  EnableInvokeDynamic is required for 7 and the others are all implied by EnableInvokeDynamic.  I don't see how they can be turned on or off independently in a meaningful way.  I think it's more confusing having all these separate subflags.

tom

> 
> Also, in arguments.cpp, I suggest replacing "supported since 1.7" by "not supported before 1.7", which is logically more precise.
> 
> Thanks!
> 
> -- John
> 
> On Mar 28, 2011, at 10:41 AM, Christian Thalinger wrote:
> 
>> http://cr.openjdk.java.net/~twisti/6817525/
>> 
>> 6817525: turn on method handle functionality by default for JSR 292
>> Summary: After appropriate testing, we need to turn on EnableMethodHandles and EnableInvokeDynamic by default.
>> Reviewed-by:
>> 
>> After appropriate testing, we need to turn on EnableMethodHandles and
>> EnableInvokeDynamic by default.