Request for review (XS): 7109063: JSR 292: fix for 7085860 is incomplete

Christian Thalinger christian.thalinger at oracle.com
Mon Nov 7 07:20:07 PST 2011


When trying to push that thing via JPRT I noticed that the test case is also broken (junit is not provided so it does not compile).  Sigh.  I fixed the test too and updated the webrev.

-- Chris

On Nov 7, 2011, at 11:39 AM, Christian Thalinger wrote:

> Thank you, Alan.  -- Chris
> 
> On Nov 7, 2011, at 11:33 AM, Alan Bateman wrote:
> 
>> On 07/11/2011 09:59, Christian Thalinger wrote:
>>> http://cr.openjdk.java.net/~twisti/7109063/
>>> 
>>> 7109063: JSR 292: fix for 7085860 is incomplete
>>> Reviewed-by:
>>> 
>>> 7085860 missed to remove two unused methods in MethodHandleImpl which
>>> use the methods which were removed from MethodHandleNatives.
>>> 
>>> src/share/classes/java/lang/invoke/MethodHandleImpl.java
>>> 
>> I know you're anxious to get this in so I looked at the webrev and it looks fine to me.
>> 
>> -Alan.
> 



More information about the hotspot-dev mailing list