Request for review: 7069991: Setup make/jprt.properties files for jdk8

Keith McGuigan keith.mcguigan at oracle.com
Wed Nov 23 08:13:16 PST 2011


On Nov 23, 2011, at 10:55 AM, Kelly O'Hair wrote:
> The JPRT default release is jdk7 right now, it is overridable at  
> submit time by using the -release option.
> At submit time, JPRT sets jprt.submit.release to whatever the - 
> release setting becomes.
>
> The repository sets it's own specific release value with the  
> jprt.tools.default.release property.
> I'm having a hard time envisioning what you would want, making my  
> head hurt.
> Give me some suggestions or scenarios how you might want this to  
> work...

What *I* want, if it is feasible, is to not to ever have to specify a - 
release value at all, and let the data in the repository config  
determine the release to use.   However, if for some reason we wanted  
to override the repo default, we could specify -release when  
submitting a job.  When cutting a branch that would go to a jdk7u  
release or something like that, the config files would have to be  
adjusted at that time.   (which is what I thought this code was doing).

This may not work when a single repo is used for multiple releases,  
such as jdk7 AND jdk8, but I don't think we have a good solution for  
that in any case (other than specifying -release every time).

--
- Keith


More information about the hotspot-dev mailing list