Pls review 7116481 (S)

[Dr Andrew John Hughes]

On 15:32 Tue 29 Nov     , Paul Hohensee wrote:
> 7116481: Commercial features in Hotspot must be gated by a switch
> 
> Commercial features (those for which Oracle charges for production use, 
> though
> not for development and/or evaluation) must be gated by a "master" -XX 
> switch.
> It works in the same manner as the existing UnlockDiagnosticVMOptions and
> UnlockExperimentalVMOptions switches, so the new switch's name is
> UnlockCommercialVMOptions.  A commercial() macro designates which
> switches are gated by UnlockCommercialVMOptions.  I added a single
> commercial() -XX flag named FlightRecorder, which does nothing, but
> will eventually gate use of the Java Flight Recorder now under development.
> 
> Webrev here:
> 
> http://cr.openjdk.java.net/~phh/7116481/
> 
> Tested from the command line.  Hotspot accepts this:
> 
> -XX:+UnlockCommercialVMOptions -XX:+FlightRecorder
> 
> and doesn't accept this
> 
> -XX:+FlightRecorder
> 
> Thanks,
> 
> Paul
> 
> 

Is it really necessary to add this into the open code base?  Would this
not be more appropriate in whatever proprietary fork you use at Oracle?

'Commercial' is also the wrong word to use, as this is nothing
non-commercial about the rest of the OpenJDK code base.  What you're
referring to are proprietary features which you're not releasing the
source code to.

See http://www.gnu.org/philosophy/words-to-avoid.html#Commercial
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20111130/ba134f38/attachment-0001.bin