review for 7098528: crash with java -XX:+ExtendedDTraceProbes

Tom Rodriguez tom.rodriguez at oracle.com
Thu Oct 6 15:56:21 PDT 2011


Thanks for the reviews.

tom

On Oct 6, 2011, at 3:26 PM, Vladimir Kozlov wrote:

> Looks good.
> 
> Vladimir
> 
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/7098528
>> 61 lines changed: 46 ins; 12 del; 3 mod; 6107 unchg
>> 7098528: crash with java -XX:+ExtendedDTraceProbes
>> Reviewed-by:
>> The problem is that the dtrace and jvmti code asks for the size of the
>> java.lang.Class instance before we've set the oop_size.  We could just
>> pass the size argument down through the various interfaces but that
>> seems fragile.  Instead I changed the initialization path for Class
>> instances to setup the indirections earlier so that the dtrace paths
>> work correctly.  Tested with failing command from bug report.



More information about the hotspot-dev mailing list