use of MAXFLOAT in share/vm/opto/addnode.cpp

roger hoover rhoover at apple.com
Thu Oct 20 12:59:50 PDT 2011


Fine with me to get rid of it with other changes.  I agree that it cannot be seen anywhere in the code as it stands.  I'm about to take it out of our 6u29 build to fix our build problems.

On Oct 20, 2011, at    1:56 PM, Tom Rodriguez wrote:

> 
> On Oct 20, 2011, at 12:53 PM, roger hoover wrote:
> 
>> Yes, it is causing builds to fail with some of apple's experimental compiler/include file combinations:
>> /SourceCache/JavaJDK16/JavaJDK16-391/hotspot/src/share/vm/opto/addnode.cpp:37:1: error: "MAXFLOAT" redefined
> 
> I can delete it as part of the changes to fix the recently reported collision with __LEAF and gcc.  I don't really want a whole new bug for it.  Does it matter to you?  It can clearly be safepoint deleted since it's mentioned nowhere in the system.
> 
> tom
> 
>> 
>> On Oct 20, 2011, at    1:48 PM, Tom Rodriguez wrote:
>> 
>>> No, it looks like an old useless def that could be deleted.  Is it causing problems for you?
>>> 
>>> tom
>>> 
>>> On Oct 20, 2011, at 12:37 PM, roger hoover wrote:
>>> 
>>>> ./src/share/vm/opto/addnode.cpp:37:#define MAXFLOAT        ((float)3.40282346638528860e+38)
>>>> 
>>>> Can anyone explain the inclusion of the above definition of MAXFLOAT?
>>>> 
>>>> roger
>>>> 
>>> 
>> 
> 



More information about the hotspot-dev mailing list