From john.coomes at oracle.com Fri Sep 2 06:15:23 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Sep 2011 13:15:23 +0000 Subject: hg: hsx/hotspot-main: 9 new changesets Message-ID: <20110902131524.18142472F4@hg.openjdk.java.net> Changeset: 0b615980879e Author: jjg Date: 2011-06-30 16:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/0b615980879e 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/sanity-rules.gmk Changeset: 05e24d6ed56d Author: lana Date: 2011-07-14 18:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/05e24d6ed56d Merge Changeset: fd8615098a54 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/fd8615098a54 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: f42e3d9394b4 Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/f42e3d9394b4 Merge Changeset: 3bec5415a227 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/3bec5415a227 Added tag jdk8-b01 for changeset f42e3d9394b4 ! .hgtags Changeset: e01201e727da Author: neugens Date: 2011-07-26 21:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/e01201e727da 7071275: Fix jdk7 references in README files, remove Forest Extension mentions Summary: Change documentation to remove reference to forest and reflect update to jdk8. Reviewed-by: ohair ! README ! README-builds.html Changeset: 69f592185747 Author: schien Date: 2011-08-24 13:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/69f592185747 Merge Changeset: 587bb549dff8 Author: schien Date: 2011-08-25 17:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/587bb549dff8 Added tag jdk8-b02 for changeset 69f592185747 ! .hgtags Changeset: 0b66a233bfb9 Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/0b66a233bfb9 Added tag jdk8-b03 for changeset 587bb549dff8 ! .hgtags From john.coomes at oracle.com Fri Sep 2 06:15:32 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Sep 2011 13:15:32 +0000 Subject: hg: hsx/hotspot-main/corba: 4 new changesets Message-ID: <20110902131535.BF57C472F5@hg.openjdk.java.net> Changeset: 949fb60ca830 Author: ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/949fb60ca830 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: ed8d94519a87 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/ed8d94519a87 Added tag jdk8-b01 for changeset 949fb60ca830 ! .hgtags Changeset: cd0da00694fb Author: schien Date: 2011-08-25 17:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/cd0da00694fb Added tag jdk8-b02 for changeset ed8d94519a87 ! .hgtags Changeset: 60a68d688e24 Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/60a68d688e24 Added tag jdk8-b03 for changeset cd0da00694fb ! .hgtags From john.coomes at oracle.com Fri Sep 2 06:15:44 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Sep 2011 13:15:44 +0000 Subject: hg: hsx/hotspot-main/jaxp: 4 new changesets Message-ID: <20110902131544.378BF472F6@hg.openjdk.java.net> Changeset: 4f0fcb812767 Author: ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/4f0fcb812767 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: ca4d6ad55a66 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/ca4d6ad55a66 Added tag jdk8-b01 for changeset 4f0fcb812767 ! .hgtags Changeset: 7a74371ce0c6 Author: schien Date: 2011-08-25 17:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/7a74371ce0c6 Added tag jdk8-b02 for changeset ca4d6ad55a66 ! .hgtags Changeset: acbcadef0b21 Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/acbcadef0b21 Added tag jdk8-b03 for changeset 7a74371ce0c6 ! .hgtags From john.coomes at oracle.com Fri Sep 2 06:15:52 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Sep 2011 13:15:52 +0000 Subject: hg: hsx/hotspot-main/jaxws: 4 new changesets Message-ID: <20110902131552.2B052472F7@hg.openjdk.java.net> Changeset: 64df57a1edec Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/64df57a1edec 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: 1034127ed402 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/1034127ed402 Added tag jdk8-b01 for changeset 64df57a1edec ! .hgtags Changeset: 7dcb0307508f Author: schien Date: 2011-08-25 17:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/7dcb0307508f Added tag jdk8-b02 for changeset 1034127ed402 ! .hgtags Changeset: 3f6f08163331 Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/3f6f08163331 Added tag jdk8-b03 for changeset 7dcb0307508f ! .hgtags From john.coomes at oracle.com Fri Sep 2 06:17:42 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Sep 2011 13:17:42 +0000 Subject: hg: hsx/hotspot-main/jdk: 78 new changesets Message-ID: <20110902133157.B204F472F8@hg.openjdk.java.net> Changeset: 74598b748a57 Author: lana Date: 2011-07-01 12:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/74598b748a57 Merge Changeset: 0a00216a858c Author: lana Date: 2011-07-07 19:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0a00216a858c Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: 77d5cc943286 Author: prr Date: 2011-07-19 14:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/77d5cc943286 7068471: NPE in sun.font.FontConfigManager.getFontConfigFont() when libfontconfig.so is not installed Reviewed-by: jgodinez, prr Contributed-by: spoole at linux.vnet.ibm.com ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: ae05aa9ede7b Author: bae Date: 2011-07-20 16:18 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ae05aa9ede7b 7044285: 64 bit VM crashes in Java_sun_java2d_loops_MaskFill_MaskFill Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.h Changeset: 40d0dea5d0fc Author: neugens Date: 2011-07-26 21:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/40d0dea5d0fc 7070155: A small refactoring patch for the abstract RenderingEngine. Summary: Simplify code by using ReflectiveOperationException instead of 3 ignored catch blocks Reviewed-by: prr ! src/share/classes/sun/java2d/pipe/RenderingEngine.java Changeset: 0795f0dacfec Author: bagiras Date: 2011-07-11 15:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0795f0dacfec 7050935: closed/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.html fails on win32 Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp + test/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java Changeset: acea32663757 Author: peytoia Date: 2011-07-12 08:00 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/acea32663757 7042148: closed/java/awt/font/TextLayout/CheckLayoutLTR.java failed Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7042148.java Changeset: 75ee78eb7322 Author: peytoia Date: 2011-07-12 08:46 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/75ee78eb7322 7051769: java.text.Bidi.toString() output is wrong Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7051769.java Changeset: 6bc0e1709d97 Author: lana Date: 2011-07-11 16:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6bc0e1709d97 Merge Changeset: cce5659427bb Author: rupashka Date: 2011-07-12 11:41 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/cce5659427bb 7019963: The goto parent directory button doesn't operate in JFileChooser Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java Changeset: 5c22624d193e Author: rupashka Date: 2011-07-15 14:43 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5c22624d193e 4909150: WindowsTreeUI can cause NullPointerException occasionally Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java Changeset: 6ee24f03760d Author: serb Date: 2011-07-15 19:18 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6ee24f03760d 7043679: Wrong class name is used in Java_sun_awt_windows_WPrinterJob_initIDs Reviewed-by: dav, art ! src/windows/native/sun/windows/awt_PrintJob.cpp Changeset: c90a43ebf8fd Author: serb Date: 2011-07-15 19:19 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c90a43ebf8fd 7043815: AWT-XAWT - AWT-EventQueue-0 deadlock. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java Changeset: 252f71b26b23 Author: serb Date: 2011-07-15 19:23 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/252f71b26b23 6596915: JCK-runtime-6a/tests/api/java_awt/Component/index.html tesPaintAll fails Reviewed-by: art, dcherepanov, anthony ! src/solaris/classes/sun/awt/X11/XButtonPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XLabelPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XPanelPeer.java ! src/solaris/classes/sun/awt/X11/XRepaintArea.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/solaris/classes/sun/awt/X11/XWarningWindow.java ! src/solaris/classes/sun/awt/X11/XWindow.java + test/java/awt/Component/PaintAll/PaintAll.java Changeset: 3ed58dbad819 Author: serb Date: 2011-07-15 19:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3ed58dbad819 6642728: Use reflection to access ScrollPane's private method from within sun.awt package Reviewed-by: art, anthony ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/windows/native/sun/windows/awt_ScrollPane.cpp Changeset: 9c642ae9a543 Author: serb Date: 2011-07-15 19:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9c642ae9a543 4717864: setFont() does not update Fonts of Menus already on screen Reviewed-by: art, bagiras ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/native/sun/windows/awt_Menu.cpp ! src/windows/native/sun/windows/awt_Menu.h ! src/windows/native/sun/windows/awt_MenuBar.cpp ! src/windows/native/sun/windows/awt_MenuBar.h ! src/windows/native/sun/windows/awt_MenuItem.cpp ! src/windows/native/sun/windows/awt_MenuItem.h Changeset: 3ac81907aa7d Author: rupashka Date: 2011-07-18 17:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3ac81907aa7d 6509273: Password in JPasswordField gets Printed in clear text Reviewed-by: alexp ! src/share/classes/sun/swing/text/TextComponentPrintable.java Changeset: c05b36e4749e Author: rupashka Date: 2011-07-18 18:21 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c05b36e4749e 7031941: Use generificated JComboBox and JList in core libraries Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionComboBoxModel.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/sun/swing/FilePane.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java Changeset: 190b11164876 Author: lana Date: 2011-07-27 22:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/190b11164876 Merge Changeset: 996547848b00 Author: lana Date: 2011-08-01 17:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/996547848b00 Merge Changeset: 34fdcdb70d20 Author: rupashka Date: 2011-07-28 18:13 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/34fdcdb70d20 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp ! src/share/classes/javax/swing/RepaintManager.java Changeset: 86098b3f7789 Author: rupashka Date: 2011-07-28 18:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/86098b3f7789 7071166: LayoutStyle.getPreferredGap() - IAE is expected but not thrown Reviewed-by: peterz ! src/share/classes/sun/swing/DefaultLayoutStyle.java + test/javax/swing/GroupLayout/7071166/bug7071166.java Changeset: 0ce1f0b21446 Author: serb Date: 2011-08-01 17:05 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0ce1f0b21446 7068060: closed/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java failed on windows Reviewed-by: art, dcherepanov + test/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java Changeset: 854e74d8d956 Author: rupashka Date: 2011-08-03 16:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/854e74d8d956 7072328: Sun URL in the MetalLookAndFeel.getLayoutStyle() specification should be replaced with Oracle one Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java Changeset: 634c2a492cf5 Author: lana Date: 2011-08-05 15:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/634c2a492cf5 Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: e4c936c28960 Author: jjg Date: 2011-06-30 16:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e4c936c28960 7061190: Update boot JDK version for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-versions.gmk Changeset: cf4edfcd7119 Author: jjg Date: 2011-06-30 16:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/cf4edfcd7119 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-java.gmk Changeset: 74328e59a4bf Author: jjg Date: 2011-06-30 17:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/74328e59a4bf 7058708: Eliminate JDK build tools build warnings Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/tools/Makefile ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java ! make/tools/src/build/tools/compileproperties/CompileProperties.java ! make/tools/src/build/tools/dirdiff/DirDiff.java ! make/tools/src/build/tools/dtdbuilder/DTDBuilder.java ! make/tools/src/build/tools/dtdbuilder/DTDInputStream.java ! make/tools/src/build/tools/dtdbuilder/DTDParser.java ! make/tools/src/build/tools/dtdbuilder/PublicMapping.java ! make/tools/src/build/tools/generatebreakiteratordata/CharSet.java ! make/tools/src/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java ! make/tools/src/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java ! make/tools/src/build/tools/generatecharacter/GenerateCharacter.java ! make/tools/src/build/tools/generatecharacter/SpecialCaseMap.java ! make/tools/src/build/tools/generatecharacter/UnicodeSpec.java ! make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java ! make/tools/src/build/tools/hasher/Hasher.java ! make/tools/src/build/tools/jarsplit/JarSplit.java ! make/tools/src/build/tools/javazic/Gen.java ! make/tools/src/build/tools/javazic/GenDoc.java ! make/tools/src/build/tools/javazic/Main.java ! make/tools/src/build/tools/javazic/Mappings.java ! make/tools/src/build/tools/javazic/Simple.java ! make/tools/src/build/tools/javazic/Time.java ! make/tools/src/build/tools/javazic/Zoneinfo.java ! make/tools/src/build/tools/jdwpgen/AbstractCommandNode.java ! make/tools/src/build/tools/jdwpgen/AbstractGroupNode.java ! make/tools/src/build/tools/jdwpgen/AbstractNamedNode.java ! make/tools/src/build/tools/jdwpgen/AbstractTypeListNode.java ! make/tools/src/build/tools/jdwpgen/AltNode.java ! make/tools/src/build/tools/jdwpgen/CommandSetNode.java ! make/tools/src/build/tools/jdwpgen/ConstantSetNode.java ! make/tools/src/build/tools/jdwpgen/ErrorSetNode.java ! make/tools/src/build/tools/jdwpgen/Node.java ! make/tools/src/build/tools/jdwpgen/OutNode.java ! make/tools/src/build/tools/jdwpgen/RootNode.java ! make/tools/src/build/tools/jdwpgen/SelectNode.java ! make/tools/src/build/tools/makeclasslist/MakeClasslist.java ! make/tools/src/build/tools/stripproperties/StripProperties.java Changeset: e93679cf1e1a Author: valeriep Date: 2011-06-30 18:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e93679cf1e1a 7058133: Javah should use the freshly built classes instead of those from the BOOTDIR jdk Summary: Changed javah to use the newly built classes specified by $(CLASSDESTDIR) Reviewed-by: vinnie ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile Changeset: f0ec49c21d09 Author: valeriep Date: 2011-07-01 17:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f0ec49c21d09 Merge Changeset: e88093d75e36 Author: coffeys Date: 2011-07-05 15:25 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e88093d75e36 7041125: LDAP API does not catch malformed filters that contain two operands for the ! operator Reviewed-by: weijun, xuelei ! src/share/classes/com/sun/jndi/ldap/Filter.java ! test/com/sun/jndi/ldap/InvalidLdapFilters.java Changeset: f68d30c0a2e3 Author: mullan Date: 2011-07-06 11:08 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f68d30c0a2e3 7054969: Null-check-in-finally pattern in java/security documentation Reviewed-by: vinnie ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509Certificate.java ! src/share/classes/java/security/cert/X509Extension.java Changeset: 63be90976177 Author: ksrini Date: 2011-07-08 10:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/63be90976177 7060849: Eliminate pack200 build warnings Reviewed-by: ksrini, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/java/pack/Makefile ! make/common/shared/Defs-java.gmk ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/Coding.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java Changeset: 5adf431673ac Author: peytoia Date: 2011-07-12 07:32 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5adf431673ac 7012364: test/java/util/Locale/LocaleCategory.sh fails on Cygwin Reviewed-by: okutsu ! test/java/util/Locale/LocaleCategory.sh Changeset: 549b7c3f0bdc Author: dl Date: 2011-07-12 15:23 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/549b7c3f0bdc 7058828: test/java/util/concurrent/Phaser/Arrive.java fails intermittently Reviewed-by: chegar ! test/java/util/concurrent/Phaser/Arrive.java Changeset: 42fe05e54e69 Author: naoto Date: 2011-07-12 10:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/42fe05e54e69 7022407: Spinning CPU in LocaleObjectCache.get() Reviewed-by: okutsu ! src/share/classes/sun/util/locale/LocaleObjectCache.java Changeset: db419c454f92 Author: dl Date: 2011-07-13 12:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/db419c454f92 7057320: test/java/util/concurrent/Executors/AutoShutdown.java failing intermittently Summary: Add retry/timeout for checking activeCount Reviewed-by: chegar ! test/java/util/concurrent/Executors/AutoShutdown.java Changeset: 7ac6a297f9a0 Author: lana Date: 2011-07-14 18:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7ac6a297f9a0 Merge Changeset: c0c983ca797b Author: ksrini Date: 2011-07-15 16:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c0c983ca797b 7062969: java -help still shows http://java.sun.com/javase/reference Reviewed-by: ohair, darcy ! src/share/classes/sun/launcher/resources/launcher.properties Changeset: d987f8738096 Author: darcy Date: 2011-07-17 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d987f8738096 7062430: Minor inconsistency in ulp descriptions Reviewed-by: smarks, alanb ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java Changeset: cbfc7f910af3 Author: alanb Date: 2011-07-18 13:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/cbfc7f910af3 7068059: Update jdk/test/ProblemList.txt Reviewed-by: mchung, chegar ! test/ProblemList.txt Changeset: 8bbea505b060 Author: chegar Date: 2011-07-18 22:25 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/8bbea505b060 7021280: SocketPermission should accept wildcards Reviewed-by: michaelm ! src/share/classes/java/net/SocketPermission.java + test/java/net/SocketPermission/Wildcard.java Changeset: 5355b9ccd19d Author: xuelei Date: 2011-07-19 08:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5355b9ccd19d 7059709: close the IO in a final block Reviewed-by: smarks, mullan, wetmore ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java Changeset: d17eb3380a49 Author: ksrini Date: 2011-07-19 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d17eb3380a49 7067922: (launcher) java -jar throws NPE if JAR file does not contain Main-Class attribute Reviewed-by: darcy, ohair, alanb, mduigou ! src/share/classes/sun/launcher/LauncherHelper.java ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: d083644bc615 Author: darcy Date: 2011-07-19 17:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d083644bc615 7007535: (reflect) Please generalize Constructor and Method Reviewed-by: mduigou, peterjones, dholmes, andrew ! src/share/classes/java/lang/reflect/Constructor.java + src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java Changeset: 99dc852080e1 Author: xuelei Date: 2011-07-19 21:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/99dc852080e1 7065972: Some race condition may happen in SSLSocketImpl class Reviewed-by: wetmore, weijun, dgu ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 9505edecc8b5 Author: jjg Date: 2011-07-20 12:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9505edecc8b5 7068617: Core libraries don't build with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulgakov at oracle.com ! make/java/java/Makefile ! src/share/classes/sun/reflect/generics/reflectiveObjects/NotImplementedException.java ! src/share/classes/sun/reflect/misc/ConstructorUtil.java ! src/share/classes/sun/reflect/misc/FieldUtil.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java Changeset: 70ec3aa8e99a Author: chegar Date: 2011-07-21 17:28 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/70ec3aa8e99a 7068416: Lightweight HTTP Server should support TCP_NODELAY Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/net/httpserver/ServerImpl.java ! test/com/sun/net/httpserver/Test1.java Changeset: c8dbb9e19355 Author: weijun Date: 2011-07-22 10:25 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c8dbb9e19355 6330275: Rework the PaddingTest regression test. Reviewed-by: wetmore, smarks ! test/ProblemList.txt ! test/com/sun/crypto/provider/Cipher/DES/PaddingTest.java Changeset: 0ec4b6498a69 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0ec4b6498a69 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: a499fdfbe723 Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a499fdfbe723 Merge Changeset: 07a12583d4ea Author: chegar Date: 2011-07-25 14:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/07a12583d4ea 7035556: DatagramSocket.java:183: warning: unreachable catch clause Summary: Remove redundant catches in bind Reviewed-by: alanb, michaelm, wetmore, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/DatagramSocket.java Changeset: c563e8060adf Author: jjg Date: 2011-07-25 16:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c563e8060adf 7069870: Parts of the JDK erroneously rely on generic array initializers with diamond Reviewed-by: ksrini, mcimadamore Contributed-by: alexandre.boulgakov at oracle.com ! make/tools/src/build/tools/jarsplit/JarSplit.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java Changeset: a80562f7ea50 Author: chegar Date: 2011-07-27 18:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a80562f7ea50 6670868: StackOverFlow with bad authenticated Proxy tunnels Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java Changeset: 7525866a4046 Author: jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7525866a4046 7068616: NIO libraries do not build with javac -Xlint:all,-deprecation -Werror Reviewed-by: alanb, chegar Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/nio/Makefile ! make/com/sun/nio/sctp/Makefile ! make/java/nio/Makefile ! make/java/sun_nio/Makefile ! make/sun/nio/Makefile ! make/sun/nio/cs/Makefile ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Reflect.java ! src/share/classes/sun/nio/ch/SelectorImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/share/classes/sun/nio/cs/FastCharsetProvider.java ! src/share/classes/sun/nio/cs/StreamDecoder.java ! src/share/classes/sun/nio/cs/ThreadLocalCoders.java ! src/share/classes/sun/nio/fs/Util.java ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpNet.java ! src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/windows/classes/sun/nio/ch/PendingIoCache.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java Changeset: cea7c749f805 Author: xuelei Date: 2011-07-29 02:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/cea7c749f805 7068662: Reserve and restore the default locale Reviewed-by: alanb, weijun ! test/com/sun/org/apache/xml/internal/security/exceptions/LocaleTest.java ! test/java/beans/XMLDecoder/Test6341798.java ! test/java/io/pathNames/win32/bug6344646.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/URLConnection/SetIfModifiedSince.java ! test/java/util/Locale/LocaleCategory.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/ResourceBundle/Bug6190861.java ! test/java/util/ResourceBundle/Control/Bug6530694.java ! test/java/util/ResourceBundle/Control/StressTest.java ! test/java/util/ResourceBundle/Test4314141.java ! test/java/util/ResourceBundle/Test4318520.java ! test/java/util/jar/JarFile/TurkCert.java ! test/javax/crypto/Cipher/Turkish.java ! test/javax/swing/JColorChooser/Test6524757.java ! test/sun/security/tools/keytool/KeyToolTest.java ! test/sun/text/resources/Collator/Bug4248694.java ! test/sun/text/resources/Collator/Bug4804273.java ! test/sun/text/resources/Collator/Bug4848897.java ! test/sun/text/resources/Format/Bug4651568.java ! test/sun/util/resources/Locale/Bug4965260.java ! test/sun/util/resources/TimeZone/Bug4640234.java Changeset: 4030297803eb Author: jjg Date: 2011-07-29 16:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4030297803eb 7072523: java.math should be built with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulgakov at oracle.com ! make/java/math/Makefile Changeset: 809e8db0c142 Author: chegar Date: 2011-07-29 10:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/809e8db0c142 6978200: ServerSocket.toString include "port=0" in the returned String Summary: Removal of "port=0" from ServerSocket.toString method Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/ServerSocket.java Changeset: e68db408d08c Author: weijun Date: 2011-08-04 18:18 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e68db408d08c 7061379: [Kerberos] Cross-realm authentication fails, due to nameType problem Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/PrincipalName.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/PrincipalNameEquals.java Changeset: 565555e89034 Author: mduigou Date: 2011-08-04 08:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/565555e89034 7073296: Executable.equalParamTypes() incorrectly returns true when the number of params differs. Reviewed-by: alanb, darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Executable.java + test/java/lang/reflect/Constructor/Equals.java Changeset: b9fffbe98230 Author: darcy Date: 2011-08-06 14:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b9fffbe98230 7075098: Remove unused fdlibm files Reviewed-by: alanb, mduigou ! make/java/fdlibm/FILES_c.gmk ! src/share/native/java/lang/fdlibm/include/fdlibm.h ! src/share/native/java/lang/fdlibm/include/jfdlibm.h - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 3f3a59423a7e Author: lana Date: 2011-08-05 16:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3f3a59423a7e Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: a5f825ef8587 Author: lana Date: 2011-08-07 17:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a5f825ef8587 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 94934ebbb654 Author: alanb Date: 2011-08-08 13:20 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/94934ebbb654 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions Reviewed-by: alanb Contributed-by: neil.richards at ngmr.net ! src/share/bin/jli_util.h Changeset: d4ab25d65adb Author: darcy Date: 2011-08-08 09:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d4ab25d65adb 6380161: (reflect) Exception from newInstance() not chained to cause. Reviewed-by: dholmes, lancea, forax ! src/share/classes/java/lang/Class.java Changeset: 0f1b4b3bc833 Author: mchung Date: 2011-08-08 16:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0f1b4b3bc833 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/basic.sh Reviewed-by: sherman ! test/demo/zipfs/basic.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh Changeset: 39498fc31d63 Author: mchung Date: 2011-08-08 16:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/39498fc31d63 7012365: TEST_BUG: test/java/nio/charset/spi/basic.sh can be run with Cygwin Reviewed-by: darcy ! test/java/nio/charset/spi/basic.sh Changeset: 26fe74aa48ef Author: chegar Date: 2011-08-09 16:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/26fe74aa48ef 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) Reviewed-by: mchung ! test/java/lang/instrument/ManifestTest.sh Changeset: cf203f293b4e Author: chegar Date: 2011-08-09 16:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/cf203f293b4e 7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin Reviewed-by: alanb, dcubed ! test/com/sun/jdi/ShellScaffold.sh Changeset: 2cdbbc4a6359 Author: lana Date: 2011-08-09 17:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2cdbbc4a6359 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 13e70aa1398e Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/13e70aa1398e Added tag jdk8-b01 for changeset 2cdbbc4a6359 ! .hgtags Changeset: dfa15ff0f99e Author: schien Date: 2011-08-25 17:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/dfa15ff0f99e Added tag jdk8-b02 for changeset 13e70aa1398e ! .hgtags Changeset: d8fccd6db59b Author: nloodin Date: 2011-08-31 13:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d8fccd6db59b 7067811: Update demo/sample code to state it should not be used for production Summary: Added comment block after copyright block stating that code is unfit for production. Reviewed-by: ohair ! make/common/Defs.gmk ! make/mkdemo/Makefile ! make/mksample/Makefile ! src/share/classes/com/sun/tools/example/debug/bdi/AccessWatchpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/AmbiguousMethodException.java ! src/share/classes/com/sun/tools/example/debug/bdi/BreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/ChildSession.java ! src/share/classes/com/sun/tools/example/debug/bdi/EvaluationException.java ! src/share/classes/com/sun/tools/example/debug/bdi/EventRequestSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/EventRequestSpecList.java ! src/share/classes/com/sun/tools/example/debug/bdi/ExceptionSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/ExecutionManager.java ! src/share/classes/com/sun/tools/example/debug/bdi/FrameIndexOutOfBoundsException.java ! src/share/classes/com/sun/tools/example/debug/bdi/InputListener.java ! src/share/classes/com/sun/tools/example/debug/bdi/JDIEventSource.java ! src/share/classes/com/sun/tools/example/debug/bdi/LineBreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/LineNotFoundException.java ! src/share/classes/com/sun/tools/example/debug/bdi/MalformedMemberNameException.java ! src/share/classes/com/sun/tools/example/debug/bdi/MethodBreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/MethodNotFoundException.java ! src/share/classes/com/sun/tools/example/debug/bdi/ModificationWatchpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/NoSessionException.java ! src/share/classes/com/sun/tools/example/debug/bdi/NoThreadException.java ! src/share/classes/com/sun/tools/example/debug/bdi/OutputListener.java ! src/share/classes/com/sun/tools/example/debug/bdi/ParseException.java ! src/share/classes/com/sun/tools/example/debug/bdi/PatternReferenceTypeSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/ReferenceTypeSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/Session.java ! src/share/classes/com/sun/tools/example/debug/bdi/SessionListener.java ! src/share/classes/com/sun/tools/example/debug/bdi/SourceNameReferenceTypeSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/SpecErrorEvent.java ! src/share/classes/com/sun/tools/example/debug/bdi/SpecEvent.java ! src/share/classes/com/sun/tools/example/debug/bdi/SpecListener.java ! src/share/classes/com/sun/tools/example/debug/bdi/ThreadGroupIterator.java ! src/share/classes/com/sun/tools/example/debug/bdi/ThreadInfo.java ! src/share/classes/com/sun/tools/example/debug/bdi/ThreadIterator.java ! src/share/classes/com/sun/tools/example/debug/bdi/Utils.java ! src/share/classes/com/sun/tools/example/debug/bdi/VMLaunchFailureException.java ! src/share/classes/com/sun/tools/example/debug/bdi/VMNotInterruptedException.java ! src/share/classes/com/sun/tools/example/debug/bdi/WatchpointSpec.java ! src/share/classes/com/sun/tools/example/debug/event/AbstractEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/AccessWatchpointEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/ClassPrepareEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/ClassUnloadEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/ExceptionEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/JDIAdapter.java ! src/share/classes/com/sun/tools/example/debug/event/JDIListener.java ! src/share/classes/com/sun/tools/example/debug/event/LocatableEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/LocationTriggerEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/ModificationWatchpointEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/ThreadDeathEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/ThreadStartEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/VMDeathEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/VMDisconnectEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/VMStartEventSet.java ! src/share/classes/com/sun/tools/example/debug/event/WatchpointEventSet.java ! src/share/classes/com/sun/tools/example/debug/expr/ASCII_UCodeESC_CharStream.java ! src/share/classes/com/sun/tools/example/debug/expr/ExpressionParser.java ! src/share/classes/com/sun/tools/example/debug/expr/ExpressionParserConstants.java ! src/share/classes/com/sun/tools/example/debug/expr/ExpressionParserTokenManager.java ! src/share/classes/com/sun/tools/example/debug/expr/LValue.java ! src/share/classes/com/sun/tools/example/debug/expr/ParseException.java ! src/share/classes/com/sun/tools/example/debug/expr/Token.java ! src/share/classes/com/sun/tools/example/debug/expr/TokenMgrError.java ! src/share/classes/com/sun/tools/example/debug/gui/ApplicationTool.java ! src/share/classes/com/sun/tools/example/debug/gui/ClassManager.java ! src/share/classes/com/sun/tools/example/debug/gui/ClassTreeTool.java ! src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java ! src/share/classes/com/sun/tools/example/debug/gui/CommandTool.java ! src/share/classes/com/sun/tools/example/debug/gui/ContextListener.java ! src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java ! src/share/classes/com/sun/tools/example/debug/gui/CurrentFrameChangedEvent.java ! src/share/classes/com/sun/tools/example/debug/gui/Environment.java ! src/share/classes/com/sun/tools/example/debug/gui/GUI.java ! src/share/classes/com/sun/tools/example/debug/gui/Icons.java ! src/share/classes/com/sun/tools/example/debug/gui/JDBFileFilter.java ! src/share/classes/com/sun/tools/example/debug/gui/JDBMenuBar.java ! src/share/classes/com/sun/tools/example/debug/gui/JDBToolBar.java ! src/share/classes/com/sun/tools/example/debug/gui/LaunchTool.java ! src/share/classes/com/sun/tools/example/debug/gui/MonitorListModel.java ! src/share/classes/com/sun/tools/example/debug/gui/MonitorTool.java ! src/share/classes/com/sun/tools/example/debug/gui/OutputSink.java ! src/share/classes/com/sun/tools/example/debug/gui/SearchPath.java ! src/share/classes/com/sun/tools/example/debug/gui/SingleLeafTreeSelectionModel.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceListener.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceManager.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceModel.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceTool.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceTreeTool.java ! src/share/classes/com/sun/tools/example/debug/gui/SourcepathChangedEvent.java ! src/share/classes/com/sun/tools/example/debug/gui/StackTraceTool.java ! src/share/classes/com/sun/tools/example/debug/gui/ThreadTreeTool.java ! src/share/classes/com/sun/tools/example/debug/gui/TypeScript.java ! src/share/classes/com/sun/tools/example/debug/gui/TypeScriptOutputListener.java ! src/share/classes/com/sun/tools/example/debug/gui/TypeScriptWriter.java ! src/share/classes/com/sun/tools/example/debug/tty/AccessWatchpointSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/AmbiguousMethodException.java ! src/share/classes/com/sun/tools/example/debug/tty/BreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/share/classes/com/sun/tools/example/debug/tty/Env.java ! src/share/classes/com/sun/tools/example/debug/tty/EventHandler.java ! src/share/classes/com/sun/tools/example/debug/tty/EventNotifier.java ! src/share/classes/com/sun/tools/example/debug/tty/EventRequestSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/EventRequestSpecList.java ! src/share/classes/com/sun/tools/example/debug/tty/ExceptionSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/LineNotFoundException.java ! src/share/classes/com/sun/tools/example/debug/tty/MalformedMemberNameException.java ! src/share/classes/com/sun/tools/example/debug/tty/MessageOutput.java ! src/share/classes/com/sun/tools/example/debug/tty/ModificationWatchpointSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/PatternReferenceTypeSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/ReferenceTypeSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/SourceMapper.java ! src/share/classes/com/sun/tools/example/debug/tty/TTY.java ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources.java ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadGroupIterator.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadInfo.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadIterator.java ! src/share/classes/com/sun/tools/example/debug/tty/VMConnection.java ! src/share/classes/com/sun/tools/example/debug/tty/VMNotConnectedException.java ! src/share/classes/com/sun/tools/example/debug/tty/WatchpointSpec.java ! src/share/classes/com/sun/tools/example/trace/EventThread.java ! src/share/classes/com/sun/tools/example/trace/StreamRedirectThread.java ! src/share/classes/com/sun/tools/example/trace/Trace.java + src/share/demo/README ! src/share/demo/applets/ArcTest/ArcTest.java ! src/share/demo/applets/BarChart/BarChart.java ! src/share/demo/applets/Blink/Blink.java ! src/share/demo/applets/CardTest/CardTest.java ! src/share/demo/applets/Clock/Clock.java ! src/share/demo/applets/DitherTest/DitherTest.java ! src/share/demo/applets/DrawTest/DrawTest.java ! src/share/demo/applets/Fractal/CLSFractal.java ! src/share/demo/applets/GraphicsTest/AppletFrame.java ! src/share/demo/applets/GraphicsTest/GraphicsTest.java ! src/share/demo/applets/MoleculeViewer/Matrix3D.java ! src/share/demo/applets/MoleculeViewer/XYZApp.java ! src/share/demo/applets/NervousText/NervousText.java ! src/share/demo/applets/SimpleGraph/GraphApplet.java ! src/share/demo/applets/SortDemo/BidirBubbleSortAlgorithm.java ! src/share/demo/applets/SortDemo/BubbleSortAlgorithm.java ! src/share/demo/applets/SortDemo/QSortAlgorithm.java ! src/share/demo/applets/SortDemo/SortAlgorithm.java ! src/share/demo/applets/SortDemo/SortItem.java ! src/share/demo/applets/SpreadSheet/SpreadSheet.java ! src/share/demo/applets/WireFrame/Matrix3D.java ! src/share/demo/applets/WireFrame/ThreeD.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Destinations.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Group.java ! src/share/demo/java2d/J2DBench/src/j2dbench/J2DBench.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Modifier.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Node.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Option.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Result.java ! src/share/demo/java2d/J2DBench/src/j2dbench/ResultSet.java ! src/share/demo/java2d/J2DBench/src/j2dbench/Test.java ! src/share/demo/java2d/J2DBench/src/j2dbench/TestEnvironment.java ! src/share/demo/java2d/J2DBench/src/j2dbench/report/HTMLSeriesReporter.java ! src/share/demo/java2d/J2DBench/src/j2dbench/report/IIOComparator.java ! src/share/demo/java2d/J2DBench/src/j2dbench/report/J2DAnalyzer.java ! src/share/demo/java2d/J2DBench/src/j2dbench/report/XMLHTMLReporter.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/GraphicsTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/ImageTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/MiscTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/PixelTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/RenderTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/iio/IIOTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/iio/InputImageTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/iio/InputStreamTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/iio/InputTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/iio/OutputImageTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/iio/OutputStreamTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/iio/OutputTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/text/TextConstructionTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/text/TextMeasureTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/text/TextRenderTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/text/TextTests.java ! src/share/demo/java2d/J2DBench/src/j2dbench/ui/CompactLayout.java ! src/share/demo/java2d/J2DBench/src/j2dbench/ui/EnableButton.java ! src/share/demo/jfc/CodePointIM/CodePointIM.java ! src/share/demo/jfc/CodePointIM/CodePointInputMethod.java ! src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java ! src/share/demo/jfc/FileChooserDemo/ExampleFileSystemView.java ! src/share/demo/jfc/FileChooserDemo/ExampleFileView.java ! src/share/demo/jfc/FileChooserDemo/FileChooserDemo.java ! src/share/demo/jfc/Font2DTest/Font2DTest.java ! src/share/demo/jfc/Font2DTest/Font2DTestApplet.java ! src/share/demo/jfc/Font2DTest/FontPanel.java ! src/share/demo/jfc/Font2DTest/RangeMenu.java ! src/share/demo/jfc/Metalworks/AquaMetalTheme.java ! src/share/demo/jfc/Metalworks/BigContrastMetalTheme.java ! src/share/demo/jfc/Metalworks/ContrastMetalTheme.java ! src/share/demo/jfc/Metalworks/DemoMetalTheme.java ! src/share/demo/jfc/Metalworks/GreenMetalTheme.java ! src/share/demo/jfc/Metalworks/KhakiMetalTheme.java ! src/share/demo/jfc/Metalworks/MetalThemeMenu.java ! src/share/demo/jfc/Metalworks/Metalworks.java ! src/share/demo/jfc/Metalworks/MetalworksDocumentFrame.java ! src/share/demo/jfc/Metalworks/MetalworksFrame.java ! src/share/demo/jfc/Metalworks/MetalworksHelp.java ! src/share/demo/jfc/Metalworks/MetalworksInBox.java ! src/share/demo/jfc/Metalworks/MetalworksPrefs.java ! src/share/demo/jfc/Metalworks/PropertiesMetalTheme.java ! src/share/demo/jfc/Metalworks/UISwitchListener.java ! src/share/demo/jfc/Notepad/ElementTreePanel.java ! src/share/demo/jfc/Notepad/Notepad.java ! src/share/demo/jfc/SampleTree/DynamicTreeNode.java ! src/share/demo/jfc/SampleTree/SampleData.java ! src/share/demo/jfc/SampleTree/SampleTree.java ! src/share/demo/jfc/SampleTree/SampleTreeCellRenderer.java ! src/share/demo/jfc/SampleTree/SampleTreeModel.java ! src/share/demo/jfc/SwingApplet/SwingApplet.java ! src/share/demo/jfc/TableExample/JDBCAdapter.java ! src/share/demo/jfc/TableExample/OldJTable.java ! src/share/demo/jfc/TableExample/TableExample.java ! src/share/demo/jfc/TableExample/TableExample2.java ! src/share/demo/jfc/TableExample/TableExample3.java ! src/share/demo/jfc/TableExample/TableExample4.java ! src/share/demo/jfc/TableExample/TableMap.java ! src/share/demo/jfc/TableExample/TableSorter.java ! src/share/demo/jfc/TransparentRuler/transparentruler/Ruler.java ! src/share/demo/jvmti/agent_util/agent_util.c ! src/share/demo/jvmti/agent_util/agent_util.h ! src/share/demo/jvmti/compiledMethodLoad/compiledMethodLoad.c ! src/share/demo/jvmti/gctest/gctest.c ! src/share/demo/jvmti/heapTracker/HeapTracker.java ! src/share/demo/jvmti/heapTracker/heapTracker.c ! src/share/demo/jvmti/heapTracker/heapTracker.h ! src/share/demo/jvmti/heapViewer/heapViewer.c ! src/share/demo/jvmti/hprof/debug_malloc.c ! src/share/demo/jvmti/hprof/debug_malloc.h ! src/share/demo/jvmti/hprof/hprof.h ! src/share/demo/jvmti/hprof/hprof_blocks.c ! src/share/demo/jvmti/hprof/hprof_blocks.h ! src/share/demo/jvmti/hprof/hprof_check.c ! src/share/demo/jvmti/hprof/hprof_check.h ! src/share/demo/jvmti/hprof/hprof_class.c ! src/share/demo/jvmti/hprof/hprof_class.h ! src/share/demo/jvmti/hprof/hprof_cpu.c ! src/share/demo/jvmti/hprof/hprof_cpu.h ! src/share/demo/jvmti/hprof/hprof_error.c ! src/share/demo/jvmti/hprof/hprof_error.h ! src/share/demo/jvmti/hprof/hprof_event.c ! src/share/demo/jvmti/hprof/hprof_event.h ! src/share/demo/jvmti/hprof/hprof_frame.c ! src/share/demo/jvmti/hprof/hprof_frame.h ! src/share/demo/jvmti/hprof/hprof_init.c ! src/share/demo/jvmti/hprof/hprof_init.h ! src/share/demo/jvmti/hprof/hprof_io.c ! src/share/demo/jvmti/hprof/hprof_io.h ! src/share/demo/jvmti/hprof/hprof_ioname.c ! src/share/demo/jvmti/hprof/hprof_ioname.h ! src/share/demo/jvmti/hprof/hprof_listener.c ! src/share/demo/jvmti/hprof/hprof_listener.h ! src/share/demo/jvmti/hprof/hprof_loader.c ! src/share/demo/jvmti/hprof/hprof_loader.h ! src/share/demo/jvmti/hprof/hprof_md.h ! src/share/demo/jvmti/hprof/hprof_monitor.c ! src/share/demo/jvmti/hprof/hprof_monitor.h ! src/share/demo/jvmti/hprof/hprof_object.c ! src/share/demo/jvmti/hprof/hprof_object.h ! src/share/demo/jvmti/hprof/hprof_reference.c ! src/share/demo/jvmti/hprof/hprof_reference.h ! src/share/demo/jvmti/hprof/hprof_site.c ! src/share/demo/jvmti/hprof/hprof_site.h ! src/share/demo/jvmti/hprof/hprof_stack.c ! src/share/demo/jvmti/hprof/hprof_stack.h ! src/share/demo/jvmti/hprof/hprof_string.c ! src/share/demo/jvmti/hprof/hprof_string.h ! src/share/demo/jvmti/hprof/hprof_table.c ! src/share/demo/jvmti/hprof/hprof_table.h ! src/share/demo/jvmti/hprof/hprof_tag.c ! src/share/demo/jvmti/hprof/hprof_tag.h ! src/share/demo/jvmti/hprof/hprof_tls.c ! src/share/demo/jvmti/hprof/hprof_tls.h ! src/share/demo/jvmti/hprof/hprof_trace.c ! src/share/demo/jvmti/hprof/hprof_trace.h ! src/share/demo/jvmti/hprof/hprof_tracker.c ! src/share/demo/jvmti/hprof/hprof_tracker.h ! src/share/demo/jvmti/hprof/hprof_util.c ! src/share/demo/jvmti/hprof/hprof_util.h ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.h ! src/share/demo/jvmti/minst/Minst.java ! src/share/demo/jvmti/minst/minst.c ! src/share/demo/jvmti/minst/minst.h ! src/share/demo/jvmti/mtrace/Mtrace.java ! src/share/demo/jvmti/mtrace/mtrace.c ! src/share/demo/jvmti/mtrace/mtrace.h ! src/share/demo/jvmti/versionCheck/versionCheck.c ! src/share/demo/jvmti/waiters/Agent.cpp ! src/share/demo/jvmti/waiters/Agent.hpp ! src/share/demo/jvmti/waiters/Monitor.cpp ! src/share/demo/jvmti/waiters/Monitor.hpp ! src/share/demo/jvmti/waiters/Thread.cpp ! src/share/demo/jvmti/waiters/Thread.hpp ! src/share/demo/jvmti/waiters/waiters.cpp ! src/share/demo/management/FullThreadDump/Deadlock.java ! src/share/demo/management/FullThreadDump/FullThreadDump.java ! src/share/demo/management/FullThreadDump/ThreadMonitor.java ! src/share/demo/management/JTop/JTop.java ! src/share/demo/management/JTop/JTopPlugin.java ! src/share/demo/management/MemoryMonitor/MemoryMonitor.java ! src/share/demo/management/VerboseGC/PrintGCStat.java ! src/share/demo/management/VerboseGC/VerboseGC.java ! src/share/demo/nio/zipfs/Demo.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/JarFileSystemProvider.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipCoder.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipConstants.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipDirectoryStream.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributeView.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributes.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipUtils.java ! src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/EditableAtEndDocument.java ! src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptJConsolePlugin.java ! src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java ! src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/heapdump.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/hello.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/invoke.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/verbose.js + src/share/sample/README ! src/share/sample/forkjoin/mergesort/MergeDemo.java ! src/share/sample/forkjoin/mergesort/MergeSort.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScanner.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScannerMXBean.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManager.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManagerMXBean.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirAgent.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirClient.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfig.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfigMXBean.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManager.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManagerMXBean.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/DirectoryScannerConfig.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/FileMatch.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultLogConfig.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultRecord.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ScanManagerConfig.java ! src/share/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/XmlConfigUtils.java ! src/share/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/DirectoryScannerTest.java ! src/share/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanDirConfigTest.java ! src/share/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanManagerTest.java ! src/share/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/TestUtils.java ! src/share/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/config/XmlConfigUtilsTest.java ! src/share/sample/nio/chatserver/ChatServer.java ! src/share/sample/nio/chatserver/Client.java ! src/share/sample/nio/chatserver/ClientReader.java ! src/share/sample/nio/chatserver/DataReader.java ! src/share/sample/nio/chatserver/MessageReader.java ! src/share/sample/nio/chatserver/NameReader.java ! src/share/sample/nio/file/AclEdit.java ! src/share/sample/nio/file/Chmod.java ! src/share/sample/nio/file/Copy.java ! src/share/sample/nio/file/DiskUsage.java ! src/share/sample/nio/file/FileType.java ! src/share/sample/nio/file/WatchDir.java ! src/share/sample/nio/file/Xdd.java ! src/share/sample/nio/multicast/MulticastAddress.java ! src/share/sample/nio/multicast/Reader.java ! src/share/sample/nio/multicast/Sender.java ! src/share/sample/nio/server/AcceptHandler.java ! src/share/sample/nio/server/Acceptor.java ! src/share/sample/nio/server/B1.java ! src/share/sample/nio/server/BN.java ! src/share/sample/nio/server/BP.java ! src/share/sample/nio/server/ChannelIO.java ! src/share/sample/nio/server/ChannelIOSecure.java ! src/share/sample/nio/server/Content.java ! src/share/sample/nio/server/Dispatcher.java ! src/share/sample/nio/server/Dispatcher1.java ! src/share/sample/nio/server/DispatcherN.java ! src/share/sample/nio/server/FileContent.java ! src/share/sample/nio/server/Handler.java ! src/share/sample/nio/server/MalformedRequestException.java ! src/share/sample/nio/server/N1.java ! src/share/sample/nio/server/N2.java ! src/share/sample/nio/server/Reply.java ! src/share/sample/nio/server/Request.java ! src/share/sample/nio/server/RequestHandler.java ! src/share/sample/nio/server/RequestServicer.java ! src/share/sample/nio/server/Sendable.java ! src/share/sample/nio/server/Server.java ! src/share/sample/nio/server/StringContent.java ! src/share/sample/nio/server/URLDumper.java ! src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java ! src/share/sample/scripting/scriptpad/src/resources/Main.js ! src/share/sample/scripting/scriptpad/src/resources/conc.js ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/share/sample/scripting/scriptpad/src/resources/mm.js ! src/share/sample/scripting/scriptpad/src/resources/scriptpad.js ! src/share/sample/scripting/scriptpad/src/scripts/browse.js ! src/share/sample/scripting/scriptpad/src/scripts/insertfile.js ! src/share/sample/scripting/scriptpad/src/scripts/linewrap.js ! src/share/sample/scripting/scriptpad/src/scripts/mail.js ! src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.js ! src/share/sample/scripting/scriptpad/src/scripts/textcolor.js ! src/share/sample/vm/clr-jvm/invoked.java ! src/share/sample/vm/clr-jvm/jinvoker.cpp ! src/share/sample/vm/clr-jvm/jinvokerExp.h ! src/share/sample/vm/jvm-clr/invoker.cpp ! src/share/sample/vm/jvm-clr/invoker.h ! src/share/sample/vm/jvm-clr/invoker.java ! src/share/sample/vm/jvm-clr/invokerExp.h ! src/solaris/demo/jni/Poller/Client.java ! src/solaris/demo/jni/Poller/LinkedQueue.java ! src/solaris/demo/jni/Poller/Poller.c ! src/solaris/demo/jni/Poller/Poller.java ! src/solaris/demo/jni/Poller/PollingServer.java ! src/solaris/demo/jni/Poller/SimpleServer.java ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c Changeset: c9956a6753fb Author: yhuang Date: 2011-08-14 23:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c9956a6753fb 7066203: Update currency data to the latest ISO 4217 standard Reviewed-by: naoto ! make/java/util/FILES_properties.gmk ! make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/java/util/LocaleISOData.java ! src/share/classes/sun/util/resources/CurrencyNames.properties ! src/share/classes/sun/util/resources/CurrencyNames_de.properties ! src/share/classes/sun/util/resources/CurrencyNames_es.properties + src/share/classes/sun/util/resources/CurrencyNames_es_CU.properties ! src/share/classes/sun/util/resources/CurrencyNames_et_EE.properties ! src/share/classes/sun/util/resources/CurrencyNames_fr.properties ! src/share/classes/sun/util/resources/CurrencyNames_ja.properties ! src/share/classes/sun/util/resources/CurrencyNames_ko.properties ! src/share/classes/sun/util/resources/CurrencyNames_pt.properties ! src/share/classes/sun/util/resources/CurrencyNames_sk_SK.properties ! src/share/classes/sun/util/resources/CurrencyNames_zh_CN.properties ! src/share/classes/sun/util/resources/CurrencyNames_zh_TW.properties ! src/share/classes/sun/util/resources/LocaleNames.properties ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt ! test/java/util/Locale/LocaleTest.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 954efddeee41 Author: mfang Date: 2011-08-17 14:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/954efddeee41 Merge ! make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java Changeset: f10654c857fd Author: mfang Date: 2011-08-29 17:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f10654c857fd Merge Changeset: 7989ee9fe673 Author: mfang Date: 2011-08-31 09:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7989ee9fe673 Merge Changeset: d977bcc79584 Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d977bcc79584 Added tag jdk8-b03 for changeset 7989ee9fe673 ! .hgtags From john.coomes at oracle.com Fri Sep 2 08:34:41 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 02 Sep 2011 15:34:41 +0000 Subject: hg: hsx/hotspot-main/langtools: 18 new changesets Message-ID: <20110902153521.7E5E447310@hg.openjdk.java.net> Changeset: b0909f992710 Author: ksrini Date: 2011-06-30 14:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b0909f992710 7059905: (javadoc) promote method visibility for netbeans usage Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java Changeset: 409b104f8b86 Author: ksrini Date: 2011-07-01 13:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/409b104f8b86 6735320: StringIndexOutOfBoundsException for empty @serialField tag Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/SerialFieldTagImpl.java + test/com/sun/javadoc/T6735320/SerialFieldTest.java + test/com/sun/javadoc/T6735320/T6735320.java ! test/com/sun/javadoc/lib/JavadocTester.java Changeset: 0d8edba73d70 Author: ksrini Date: 2011-07-01 14:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/0d8edba73d70 7060642: (javadoc) improve performance on accessing inlinedTags Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! src/share/classes/com/sun/tools/javadoc/ThrowsTagImpl.java Changeset: 111bbf1ad913 Author: darcy Date: 2011-07-05 16:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/111bbf1ad913 7025809: Provided new utility visitors supporting SourceVersion.RELEASE_8 Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java + src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java + src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java + src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java + src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/ElementScanner7.java + src/share/classes/javax/lang/model/util/ElementScanner8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java + src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java + src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java + src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java + src/share/classes/javax/lang/model/util/TypeKindVisitor8.java ! src/share/sample/javac/processing/src/CheckNamesProcessor.java ! test/tools/javac/6402516/CheckLocalElements.java ! test/tools/javac/api/TestOperators.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/failover/FailOver15.out ! test/tools/javac/lib/JavacTestingAbstractProcessor.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/TestSymtabItems.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 7337295434b6 Author: jjg Date: 2011-07-07 13:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/7337295434b6 7061125: Proposed javac argument processing performance improvement Reviewed-by: jjg, dlsmith, mcimadamore, forax Contributed-by: schlosna at gmail.com ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/T6358166.java ! test/tools/javac/T6358168.java Changeset: 025a370b9fc3 Author: lana Date: 2011-07-14 18:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/025a370b9fc3 Merge Changeset: 2d3096441387 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/2d3096441387 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: 36f31b87b0ab Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/36f31b87b0ab Merge Changeset: 0b5beb9562c6 Author: mcimadamore Date: 2011-07-27 19:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/0b5beb9562c6 7062745: Regression: difference in overload resolution when two methods are maximally specific Summary: Fix most specific when two methods are maximally specific and only one has non-raw return type Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java + test/tools/javac/generics/rawOverride/7062745/T7062745neg.java + test/tools/javac/generics/rawOverride/7062745/T7062745neg.out + test/tools/javac/generics/rawOverride/7062745/T7062745pos.java Changeset: d5f33267a06d Author: mcimadamore Date: 2011-07-27 19:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/d5f33267a06d 7046778: Project Coin: problem with diamond and member inner classes Summary: Diamond inference generates spurious error messages when target type is a member inner class Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/diamond/neg/Neg09.out Changeset: e427c42e1a7e Author: mcimadamore Date: 2011-07-27 19:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e427c42e1a7e 7057297: Project Coin: diamond erroneously accepts in array initializer expressions Summary: Diamond in array initializer expressions should be rejected Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/CannotCreateArrayWithDiamond.java + test/tools/javac/generics/diamond/7057297/T7057297.java + test/tools/javac/generics/diamond/7057297/T7057297.out Changeset: 0d6d41563040 Author: ksrini Date: 2011-07-27 11:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/0d6d41563040 7068902: (javac) allow enabling or disabling of String folding Summary: Contributed by netbeans team, modified to suit by the langtools team. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/parser/StringFoldingTest.java Changeset: 64b9b7ae3366 Author: darcy Date: 2011-08-04 11:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/64b9b7ae3366 7071246: Enclosing string literal in parenthesis in switch-case crashes javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! test/tools/javac/StringsInSwitch/StringSwitches.java Changeset: c0d5f93af048 Author: jjg Date: 2011-08-05 15:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/c0d5f93af048 7074189: some javac tests fail with latest jtreg 4.1 b03 Reviewed-by: darcy + test/tools/javac/lib/CompileFail.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/warnings/Serial.java Changeset: e9f118c2bd3c Author: ksrini Date: 2011-08-05 19:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e9f118c2bd3c 7064544: (javadoc) miscellaneous fixes requested by netbeans Summary: Contributed by netbeans team, modified to suit by the langtools team. Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLinkTaglet/pkg/C.java Changeset: b3c059de2a61 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b3c059de2a61 Added tag jdk8-b01 for changeset e9f118c2bd3c ! .hgtags Changeset: f497fac86cf9 Author: schien Date: 2011-08-25 17:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/f497fac86cf9 Added tag jdk8-b02 for changeset b3c059de2a61 ! .hgtags Changeset: 5df63fd8fa64 Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/5df63fd8fa64 Added tag jdk8-b03 for changeset f497fac86cf9 ! .hgtags From john.coomes at oracle.com Fri Sep 2 18:30:22 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 03 Sep 2011 01:30:22 +0000 Subject: hg: hsx/hsx22/hotspot: 9 new changesets Message-ID: <20110903013043.887194732E@hg.openjdk.java.net> Changeset: 31e253c1da42 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/31e253c1da42 Added tag jdk8-b01 for changeset 0cc8a70952c3 ! .hgtags Changeset: a3592789b47c Author: schien Date: 2011-08-25 17:17 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/a3592789b47c Added tag jdk8-b02 for changeset 31e253c1da42 ! .hgtags Changeset: 3a2fb61165df Author: jcoomes Date: 2011-08-31 13:57 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/3a2fb61165df Merge - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastAAccess0.java - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastIAccess0.java Changeset: 0fa3ace511fe Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/0fa3ace511fe Added tag jdk8-b03 for changeset 3a2fb61165df ! .hgtags Changeset: 5755e84e970f Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/5755e84e970f Added tag hs22-b01 for changeset 0cc8a70952c3 ! .hgtags Changeset: 40c5e268d399 Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/40c5e268d399 Added tag hs22-b02 for changeset 7c29742c41b4 ! .hgtags Changeset: 52220701f19f Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/52220701f19f Added tag hs22-b03 for changeset 3a2fb61165df ! .hgtags Changeset: ce9bde819dcb Author: jcoomes Date: 2011-09-02 03:49 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/ce9bde819dcb 7086589: bump the hs22 build number to 04 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5c123cbeebbe Author: jcoomes Date: 2011-09-02 15:52 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/5c123cbeebbe Added tag hs22-b04 for changeset ce9bde819dcb ! .hgtags From john.coomes at oracle.com Fri Sep 2 19:26:31 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 03 Sep 2011 02:26:31 +0000 Subject: hg: hsx/hotspot-main/hotspot: 9 new changesets Message-ID: <20110903022648.E4B3347331@hg.openjdk.java.net> Changeset: 31e253c1da42 Author: cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/31e253c1da42 Added tag jdk8-b01 for changeset 0cc8a70952c3 ! .hgtags Changeset: a3592789b47c Author: schien Date: 2011-08-25 17:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a3592789b47c Added tag jdk8-b02 for changeset 31e253c1da42 ! .hgtags Changeset: 3a2fb61165df Author: jcoomes Date: 2011-08-31 13:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3a2fb61165df Merge - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastAAccess0.java - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastIAccess0.java Changeset: 0fa3ace511fe Author: schien Date: 2011-09-01 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0fa3ace511fe Added tag jdk8-b03 for changeset 3a2fb61165df ! .hgtags Changeset: 5755e84e970f Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5755e84e970f Added tag hs22-b01 for changeset 0cc8a70952c3 ! .hgtags Changeset: 40c5e268d399 Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/40c5e268d399 Added tag hs22-b02 for changeset 7c29742c41b4 ! .hgtags Changeset: 52220701f19f Author: jcoomes Date: 2011-09-02 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/52220701f19f Added tag hs22-b03 for changeset 3a2fb61165df ! .hgtags Changeset: ce9bde819dcb Author: jcoomes Date: 2011-09-02 03:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ce9bde819dcb 7086589: bump the hs22 build number to 04 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5c123cbeebbe Author: jcoomes Date: 2011-09-02 15:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5c123cbeebbe Added tag hs22-b04 for changeset ce9bde819dcb ! .hgtags From john.coomes at oracle.com Sat Sep 3 03:19:52 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 03 Sep 2011 10:19:52 +0000 Subject: hg: hsx/hotspot-main/hotspot: 6 new changesets Message-ID: <20110903102009.B965C47343@hg.openjdk.java.net> Changeset: 3cd0157e1d4d Author: iveresov Date: 2011-08-25 02:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3cd0157e1d4d 7082969: NUMA interleaving Summary: Support interleaving on NUMA systems for collectors that don't have NUMA-awareness. Reviewed-by: iveresov, ysr Contributed-by: Tom Deneau ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: eeae91c9baba Author: johnc Date: 2011-08-29 10:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/eeae91c9baba 7080389: G1: refactor marking code in evacuation pause copy closures Summary: Refactor code marking code in the evacuation pause copy closures so that an evacuated object is only marked by the thread that successfully copies it. Reviewed-by: stefank, brutisso, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp Changeset: 9447b2fb6fcf Author: iveresov Date: 2011-08-29 17:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9447b2fb6fcf 7082645: Hotspot doesn't compile on old linuxes after 7060836 Summary: Move syscall ids definitions into os_linux.cpp Reviewed-by: johnc ! src/os/linux/vm/os_linux.cpp Changeset: 4fe626cbf0bf Author: johnc Date: 2011-08-31 10:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4fe626cbf0bf 7066841: remove MacroAssembler::br_on_reg_cond() on sparc Summary: Remove the macro assembler routine br_on_reg_cond() and replace the remaining calls to that routine with an equivalent. Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: ae1b1788f63f Author: ysr Date: 2011-08-31 23:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ae1b1788f63f Merge Changeset: 4668545121b8 Author: jcoomes Date: 2011-09-02 21:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4668545121b8 Merge From tom.rodriguez at oracle.com Wed Sep 7 21:40:02 2011 From: tom.rodriguez at oracle.com (tom.rodriguez at oracle.com) Date: Thu, 08 Sep 2011 04:40:02 +0000 Subject: hg: hsx/hotspot-main/jdk: 7082631: JSR 292: need profiling support in GWTs Message-ID: <20110908044038.B17EE47465@hg.openjdk.java.net> Changeset: 3b59f4bc8046 Author: never Date: 2011-09-07 21:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3b59f4bc8046 7082631: JSR 292: need profiling support in GWTs Summary: add CountingMethodHandle Reviewed-by: twisti, jrose ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java + src/share/classes/java/lang/invoke/CountingMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java From igor.veresov at oracle.com Thu Sep 8 00:05:03 2011 From: igor.veresov at oracle.com (igor.veresov at oracle.com) Date: Thu, 08 Sep 2011 07:05:03 +0000 Subject: hg: hsx/hotspot-main/hotspot: 20 new changesets Message-ID: <20110908070545.6124E4746D@hg.openjdk.java.net> Changeset: ac8738449b6f Author: never Date: 2011-08-25 20:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ac8738449b6f 7082949: JSR 292: missing ResourceMark in methodOopDesc::make_invoke_method Reviewed-by: kvn, twisti ! src/share/vm/oops/methodOop.cpp + test/compiler/7082949/Test7082949.java Changeset: baf763f388e6 Author: kvn Date: 2011-08-26 08:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/baf763f388e6 7059037: Use BIS for zeroing on T4 Summary: Use BIS for zeroing new allocated big (2Kb and more) objects and arrays. Reviewed-by: never, twisti, ysr ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/copy_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 8805f8c1e23e Author: iveresov Date: 2011-08-27 00:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8805f8c1e23e 6591247: C2 cleans up the merge point too early during SplitIf Summary: Remove region self reference last Reviewed-by: kvn, never ! src/share/vm/opto/split_if.cpp Changeset: b27c72d69fd1 Author: twisti Date: 2011-08-29 05:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b27c72d69fd1 7083184: JSR 292: don't store context class argument with call site dependencies Reviewed-by: jrose, never ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/dependencies.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/callGenerator.cpp Changeset: 19241ae0d839 Author: never Date: 2011-08-30 00:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/19241ae0d839 7082263: Reflection::resolve_field/field_get/field_set are broken Reviewed-by: kvn, dholmes, stefank, coleenp ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/jvmg.make - make/solaris/makefiles/mapfile-vers-nonproduct ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! src/share/vm/precompiled.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp - src/share/vm/runtime/reflectionCompat.hpp Changeset: b346f13112d8 Author: iveresov Date: 2011-08-30 19:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b346f13112d8 7085279: C1 overflows code buffer with VerifyOops and CompressedOops Summary: Increase the limit of code emitted per LIR instruction, increase the max size of the nmethod generated by C1 Reviewed-by: never, kvn, johnc ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_globals.hpp Changeset: de847cac9235 Author: twisti Date: 2011-08-31 01:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/de847cac9235 7078382: JSR 292: don't count method handle adapters against inlining budgets Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/opto/bytecodeInfo.cpp Changeset: a64d352d1118 Author: kvn Date: 2011-08-31 09:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a64d352d1118 7085137: -XX:+VerifyOops is broken Summary: Replace set() with patchable_set() to generate 8 instructions always. Reviewed-by: iveresov, never, roland ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad Changeset: c124e2e7463e Author: never Date: 2011-08-31 16:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c124e2e7463e 7083786: dead various dead chunks of code Reviewed-by: iveresov, kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.hpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/forte.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: a32de5085326 Author: twisti Date: 2011-09-01 01:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a32de5085326 7079673: JSR 292: C1 should inline bytecoded method handle adapters Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/parse.hpp Changeset: aa67216400d3 Author: twisti Date: 2011-09-02 00:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/aa67216400d3 7085404: JSR 292: VolatileCallSites should have push notification too Reviewed-by: never, kvn ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 11a4af030e4b Author: twisti Date: 2011-09-02 04:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/11a4af030e4b 7071709: JSR 292: switchpoint invalidation should be pushed not pulled Reviewed-by: never ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parse3.cpp Changeset: 2f9b79ddb05c Author: kvn Date: 2011-09-02 12:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2f9b79ddb05c 7039731: arraycopy could use prefetch on SPARC Summary: Use BIS and prefetch in arraycopy stubs for Sparc (BIS for T4 only). Reviewed-by: never, iveresov ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2090c623107e Author: never Date: 2011-09-02 22:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2090c623107e 7016881: JSR 292: JDI: sun.jvm.hotspot.utilities.AssertionFailure: index out of bounds Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java Changeset: c26de9aef2ed Author: never Date: 2011-09-02 20:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c26de9aef2ed 7071307: MethodHandle bimorphic inlining should consider the frequency Reviewed-by: twisti, roland, kvn, iveresov ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/ci/ciCallProfile.hpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciObject.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 7ffacbb338d4 Author: never Date: 2011-09-03 09:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7ffacbb338d4 Merge Changeset: 7b5c767f229c Author: kvn Date: 2011-09-03 14:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7b5c767f229c 7086560: 7085404 changes broke VM with -XX:-EnableInvokeDynamic Summary: Add check that ciEnv::_CallSite_klass is initialized. Reviewed-by: jrose ! src/share/vm/ci/ciField.hpp Changeset: 7588156f5cf9 Author: never Date: 2011-09-05 17:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7588156f5cf9 7051798: SA-JDI: NPE in Frame.addressOfStackSlot(Frame.java:244) Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/HSDB.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java + agent/src/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/code/PCDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/RicochetBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/RuntimeStub.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/OopMapSet.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ReferenceTypeImpl.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/StackFrameImpl.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Frame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/linux_amd64/LinuxAMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/solaris_amd64/SolarisAMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCFrame.java + agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCRicochetFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java + agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RicochetFrame.java ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/code/pcDesc.cpp ! src/share/vm/code/pcDesc.hpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c2d3caa64b3e Author: roland Date: 2011-09-07 09:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c2d3caa64b3e 7086394: c2/arm: enable UseFPUForSpilling Summary: ARM has instructions to move data directly between the fpu and integer registers. Reviewed-by: kvn, never ! src/share/vm/opto/matcher.cpp Changeset: d968f546734e Author: iveresov Date: 2011-09-07 11:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d968f546734e Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/runtime/globals.hpp - src/share/vm/runtime/reflectionCompat.hpp From robert.ottenhag at oracle.com Thu Sep 8 13:31:37 2011 From: robert.ottenhag at oracle.com (robert.ottenhag at oracle.com) Date: Thu, 08 Sep 2011 20:31:37 +0000 Subject: hg: hsx/hotspot-main/hotspot: 2 new changesets Message-ID: <20110908203143.A7A1A47497@hg.openjdk.java.net> Changeset: 2fecca53a2c6 Author: roland Date: 2011-09-07 14:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2fecca53a2c6 7085012: ARM: com/sun/jdi/PopSynchronousTest.java still fails Summary: InterpreterRuntime::popframe_move_outgoing_args() is required for the ARM interpreter. Reviewed-by: kvn, twisti ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp Changeset: 5596e125fe4f Author: rottenha Date: 2011-09-08 06:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5596e125fe4f Merge ! src/share/vm/interpreter/interpreterRuntime.cpp From rednaxelafx at gmail.com Fri Sep 9 00:11:19 2011 From: rednaxelafx at gmail.com (Krystal Mok) Date: Fri, 9 Sep 2011 15:11:19 +0800 Subject: outputStream's position not updated by disassembler Message-ID: Hi all, I tried to add disassembly support in VM error reporting, but had a couple of issues. The result I'm looking for is something like this: Instructions: (pc=0x00002b148974ddf2) 0x00002b148974ddd2: 48 8b 05 17 0d 42 00 41 c7 85 48 02 00 00 06 00 0x00002b148974dde2: 00 00 8b 38 e8 ed 3f 9a ff c6 80 6c 02 00 00 01 0x00002b148974ddf2: 45 89 26 c6 80 6c 02 00 00 00 48 8b 5b 48 48 8b 0x00002b148974de02: 7b 10 4c 8b 63 08 48 83 3f 00 74 09 e8 cd 6f a3 [Disassembling for mach='i386:x86-64'] 0x00002b148974ddf2: mov %r12d,(%r14) 0x00002b148974ddf5: movb $0x0,0x26c(%rax) 0x00002b148974ddfc: mov 0x48(%rbx),%rbx 0x00002b148974de00: mov 0x10(%rbx),%rdi ... I'm working on Linux/x64, HS20-b11. If I made this change to reuse the disassembler plugin (if available): diff -r f0f676c5a2c6 src/os_cpu/linux_x86/vm/os_linux_x86.cpp --- a/src/os_cpu/linux_x86/vm/os_linux_x86.cpp Tue Mar 15 19:30:16 2011 -0700 +++ b/src/os_cpu/linux_x86/vm/os_linux_x86.cpp Fri Sep 09 14:50:16 2011 +0800 @@ -29,6 +29,7 @@ #include "classfile/vmSymbols.hpp" #include "code/icBuffer.hpp" #include "code/vtableStubs.hpp" +#include "compiler/disassembler.hpp" #include "interpreter/interpreter.hpp" #include "jvm_linux.h" #include "memory/allocation.inline.hpp" @@ -808,6 +809,11 @@ address pc = os::Linux::ucontext_get_pc(uc); st->print_cr("Instructions: (pc=" PTR_FORMAT ")", pc); print_hex_dump(st, pc - 32, pc + 32, sizeof(char)); + + // dump disassembly near pc + st->cr(); + Disassembler::decode(pc, pc + 32, st); + st->cr(); } void os::print_register_info(outputStream *st, void *context) { Then the disassembly output I'm getting misses all newlines at the end of each instruction, like this: [Disassembling for mach='i386:x86-64'] 0x00002b148974ddf2: mov %r12d,(%r14) 0x00002b148974ddf5: movb $0x0,0x26c(%rax) ... Tracing down, the newlines are requested by the disassembler plugin (hsdis in this case), handled by printf_to_env(void* env_pv, const char* format, ...), which in turn calls outputStream::bol(). bol() decides whether or not to write a newline depending on the current position. By instrumenting printf_to_env, I found that the position was always 0 during disassembling, which caused the problem of missing newlines. But the same plugin, when used in situations like PrintInterpreter, works fine; the position gets updated correctly, and no newlines are lost. Does anyone have any idea what might have caused the difference? The outputStream instances are different, sure, but staticBufferStream used in error reporting look pretty innocent to me. P.S. I could just work around this by changing the bol() call to a cr()call. But that feels hackish, and I'm looking for a cleaner solution. Regards, Kris Mok -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110909/1f08f6b7/attachment.html From stefan.karlsson at oracle.com Fri Sep 9 08:03:05 2011 From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com) Date: Fri, 09 Sep 2011 15:03:05 +0000 Subject: hg: hsx/hotspot-main/hotspot: 10 new changesets Message-ID: <20110909150323.AC7B1474E5@hg.openjdk.java.net> Changeset: 27702f012017 Author: iveresov Date: 2011-09-06 21:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/27702f012017 7087583: Hotspot fails to allocate heap with mmap(MAP_HUGETLB) Summary: Try using small pages when transparent huge pages allocation fails Reviewed-by: ysr ! src/os/linux/vm/os_linux.cpp Changeset: 20213c8a3c40 Author: tonyp Date: 2011-09-07 12:21 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/20213c8a3c40 7050392: G1: Introduce flag to generate a log of the G1 ergonomic decisions Summary: It introduces ergonomic decision logging in G1 for the following heuristics: heap sizing, collection set construction, concurrent cycle initiation, and partially-young GC start/end. The code has a bit of refactoring in a few places to make the decision logging possible. It also replaces alternative ad-hoc logging that we have under different parameters and switches (G1_DEBUG, G1PolicyVerbose). Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp + src/share/vm/gc_implementation/g1/g1ErgoVerbose.cpp + src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: c2bf0120ee5d Author: stefank Date: 2011-09-01 16:18 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c2bf0120ee5d 7085906: Replace the permgen allocated sentinelRef with a self-looped end Summary: Remove the sentinelRef and let the last Reference in a discovered chain point back to itself. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/memory/sharedHeap.cpp Changeset: 05550041d664 Author: ysr Date: 2011-09-07 15:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/05550041d664 Merge ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: eca1193ca245 Author: ysr Date: 2011-09-07 13:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/eca1193ca245 4965777: GC changes to support use of discovered field for pending references Summary: If and when the reference handler thread is able to use the discovered field to link reference objects in its pending list, so will GC. In that case, GC will scan through this field once a reference object has been placed on the pending list, but not scan that field before that stage, as the field is used by the concurrent GC thread to link discovered objects. When ReferenceHandleR thread does not use the discovered field for the purpose of linking the elements in the pending list, as would be the case in older JDKs, the JVM will fall back to the old behaviour of using the next field for that purpose. Reviewed-by: jcoomes, mchung, stefank ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/java.hpp Changeset: a6128a8ed624 Author: iveresov Date: 2011-09-07 18:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a6128a8ed624 7086226: UseNUMA fails on old versions of windows Summary: Return correct answers from os::numa_*() for UMA machines or if NUMA API is not supported Reviewed-by: johnc ! src/os/windows/vm/os_windows.cpp Changeset: 4f41766176cf Author: tonyp Date: 2011-09-08 05:16 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4f41766176cf 7084509: G1: fix inconsistencies and mistakes in the young list target length calculations Summary: Fixed inconsistencies and mistakes in the young list target length calculations so that a) the calculated target length is optimal (before, it was not), b) other parameters like max survivor size and max gc locker eden expansion are always consistent with the calculated target length (before, they were not always), and c) the resulting target length was always bound by desired min and max values (before, it was not). Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: af2ab04e0038 Author: brutisso Date: 2011-09-08 16:29 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/af2ab04e0038 6929868: G1: introduce min / max young gen size bounds Summary: Make G1 handle young gen size command line flags more consistently Reviewed-by: tonyp, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: 3bddbf0f57d6 Author: tonyp Date: 2011-09-09 05:20 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3bddbf0f57d6 7087717: G1: make the G1PrintRegionLivenessInfo parameter diagnostic Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: e984655be425 Author: stefank Date: 2011-09-09 14:44 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e984655be425 Merge ! src/share/vm/prims/jvm.h From john.coomes at oracle.com Fri Sep 9 20:22:20 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 10 Sep 2011 03:22:20 +0000 Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets Message-ID: <20110910032231.692D747511@hg.openjdk.java.net> Changeset: dce7d24674f4 Author: schien Date: 2011-09-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/dce7d24674f4 Added tag jdk8-b04 for changeset 0fa3ace511fe ! .hgtags Changeset: 79f9a3ed607a Author: jcoomes Date: 2011-09-09 16:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/79f9a3ed607a Merge ! .hgtags - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 513a84dd0f8b Author: jcoomes Date: 2011-09-09 16:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/513a84dd0f8b 7088991: Bump ths hs22 build number to 05 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 140317da459a Author: jcoomes Date: 2011-09-09 16:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/140317da459a Added tag hs22-b05 for changeset 513a84dd0f8b ! .hgtags From john.coomes at oracle.com Fri Sep 9 21:37:02 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 10 Sep 2011 04:37:02 +0000 Subject: hg: hsx/hsx22/hotspot: 42 new changesets Message-ID: <20110910043821.2EAAF47514@hg.openjdk.java.net> Changeset: dce7d24674f4 Author: schien Date: 2011-09-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/dce7d24674f4 Added tag jdk8-b04 for changeset 0fa3ace511fe ! .hgtags Changeset: 3cd0157e1d4d Author: iveresov Date: 2011-08-25 02:57 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/3cd0157e1d4d 7082969: NUMA interleaving Summary: Support interleaving on NUMA systems for collectors that don't have NUMA-awareness. Reviewed-by: iveresov, ysr Contributed-by: Tom Deneau ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: eeae91c9baba Author: johnc Date: 2011-08-29 10:13 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/eeae91c9baba 7080389: G1: refactor marking code in evacuation pause copy closures Summary: Refactor code marking code in the evacuation pause copy closures so that an evacuated object is only marked by the thread that successfully copies it. Reviewed-by: stefank, brutisso, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp Changeset: 9447b2fb6fcf Author: iveresov Date: 2011-08-29 17:42 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/9447b2fb6fcf 7082645: Hotspot doesn't compile on old linuxes after 7060836 Summary: Move syscall ids definitions into os_linux.cpp Reviewed-by: johnc ! src/os/linux/vm/os_linux.cpp Changeset: 4fe626cbf0bf Author: johnc Date: 2011-08-31 10:16 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/4fe626cbf0bf 7066841: remove MacroAssembler::br_on_reg_cond() on sparc Summary: Remove the macro assembler routine br_on_reg_cond() and replace the remaining calls to that routine with an equivalent. Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: ae1b1788f63f Author: ysr Date: 2011-08-31 23:55 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/ae1b1788f63f Merge Changeset: 4668545121b8 Author: jcoomes Date: 2011-09-02 21:33 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/4668545121b8 Merge Changeset: ac8738449b6f Author: never Date: 2011-08-25 20:29 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/ac8738449b6f 7082949: JSR 292: missing ResourceMark in methodOopDesc::make_invoke_method Reviewed-by: kvn, twisti ! src/share/vm/oops/methodOop.cpp + test/compiler/7082949/Test7082949.java Changeset: baf763f388e6 Author: kvn Date: 2011-08-26 08:52 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/baf763f388e6 7059037: Use BIS for zeroing on T4 Summary: Use BIS for zeroing new allocated big (2Kb and more) objects and arrays. Reviewed-by: never, twisti, ysr ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/copy_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 8805f8c1e23e Author: iveresov Date: 2011-08-27 00:23 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/8805f8c1e23e 6591247: C2 cleans up the merge point too early during SplitIf Summary: Remove region self reference last Reviewed-by: kvn, never ! src/share/vm/opto/split_if.cpp Changeset: b27c72d69fd1 Author: twisti Date: 2011-08-29 05:07 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/b27c72d69fd1 7083184: JSR 292: don't store context class argument with call site dependencies Reviewed-by: jrose, never ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/dependencies.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/callGenerator.cpp Changeset: 19241ae0d839 Author: never Date: 2011-08-30 00:54 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/19241ae0d839 7082263: Reflection::resolve_field/field_get/field_set are broken Reviewed-by: kvn, dholmes, stefank, coleenp ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/jvmg.make - make/solaris/makefiles/mapfile-vers-nonproduct ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! src/share/vm/precompiled.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp - src/share/vm/runtime/reflectionCompat.hpp Changeset: b346f13112d8 Author: iveresov Date: 2011-08-30 19:01 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/b346f13112d8 7085279: C1 overflows code buffer with VerifyOops and CompressedOops Summary: Increase the limit of code emitted per LIR instruction, increase the max size of the nmethod generated by C1 Reviewed-by: never, kvn, johnc ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_globals.hpp Changeset: de847cac9235 Author: twisti Date: 2011-08-31 01:40 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/de847cac9235 7078382: JSR 292: don't count method handle adapters against inlining budgets Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/opto/bytecodeInfo.cpp Changeset: a64d352d1118 Author: kvn Date: 2011-08-31 09:48 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/a64d352d1118 7085137: -XX:+VerifyOops is broken Summary: Replace set() with patchable_set() to generate 8 instructions always. Reviewed-by: iveresov, never, roland ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad Changeset: c124e2e7463e Author: never Date: 2011-08-31 16:46 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/c124e2e7463e 7083786: dead various dead chunks of code Reviewed-by: iveresov, kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.hpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/forte.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: a32de5085326 Author: twisti Date: 2011-09-01 01:31 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/a32de5085326 7079673: JSR 292: C1 should inline bytecoded method handle adapters Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/parse.hpp Changeset: aa67216400d3 Author: twisti Date: 2011-09-02 00:36 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/aa67216400d3 7085404: JSR 292: VolatileCallSites should have push notification too Reviewed-by: never, kvn ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 11a4af030e4b Author: twisti Date: 2011-09-02 04:28 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/11a4af030e4b 7071709: JSR 292: switchpoint invalidation should be pushed not pulled Reviewed-by: never ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parse3.cpp Changeset: 2f9b79ddb05c Author: kvn Date: 2011-09-02 12:13 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/2f9b79ddb05c 7039731: arraycopy could use prefetch on SPARC Summary: Use BIS and prefetch in arraycopy stubs for Sparc (BIS for T4 only). Reviewed-by: never, iveresov ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2090c623107e Author: never Date: 2011-09-02 22:00 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/2090c623107e 7016881: JSR 292: JDI: sun.jvm.hotspot.utilities.AssertionFailure: index out of bounds Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java Changeset: c26de9aef2ed Author: never Date: 2011-09-02 20:58 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/c26de9aef2ed 7071307: MethodHandle bimorphic inlining should consider the frequency Reviewed-by: twisti, roland, kvn, iveresov ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/ci/ciCallProfile.hpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciObject.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 7ffacbb338d4 Author: never Date: 2011-09-03 09:56 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/7ffacbb338d4 Merge Changeset: 7b5c767f229c Author: kvn Date: 2011-09-03 14:03 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/7b5c767f229c 7086560: 7085404 changes broke VM with -XX:-EnableInvokeDynamic Summary: Add check that ciEnv::_CallSite_klass is initialized. Reviewed-by: jrose ! src/share/vm/ci/ciField.hpp Changeset: 7588156f5cf9 Author: never Date: 2011-09-05 17:09 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/7588156f5cf9 7051798: SA-JDI: NPE in Frame.addressOfStackSlot(Frame.java:244) Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/HSDB.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java + agent/src/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/code/PCDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/RicochetBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/RuntimeStub.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/OopMapSet.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ReferenceTypeImpl.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/StackFrameImpl.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Frame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/linux_amd64/LinuxAMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/solaris_amd64/SolarisAMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCFrame.java + agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCRicochetFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java + agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RicochetFrame.java ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/code/pcDesc.cpp ! src/share/vm/code/pcDesc.hpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c2d3caa64b3e Author: roland Date: 2011-09-07 09:35 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/c2d3caa64b3e 7086394: c2/arm: enable UseFPUForSpilling Summary: ARM has instructions to move data directly between the fpu and integer registers. Reviewed-by: kvn, never ! src/share/vm/opto/matcher.cpp Changeset: d968f546734e Author: iveresov Date: 2011-09-07 11:52 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/d968f546734e Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/runtime/globals.hpp - src/share/vm/runtime/reflectionCompat.hpp Changeset: 2fecca53a2c6 Author: roland Date: 2011-09-07 14:15 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/2fecca53a2c6 7085012: ARM: com/sun/jdi/PopSynchronousTest.java still fails Summary: InterpreterRuntime::popframe_move_outgoing_args() is required for the ARM interpreter. Reviewed-by: kvn, twisti ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp Changeset: 5596e125fe4f Author: rottenha Date: 2011-09-08 06:36 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/5596e125fe4f Merge ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: 27702f012017 Author: iveresov Date: 2011-09-06 21:03 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/27702f012017 7087583: Hotspot fails to allocate heap with mmap(MAP_HUGETLB) Summary: Try using small pages when transparent huge pages allocation fails Reviewed-by: ysr ! src/os/linux/vm/os_linux.cpp Changeset: 20213c8a3c40 Author: tonyp Date: 2011-09-07 12:21 -0400 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/20213c8a3c40 7050392: G1: Introduce flag to generate a log of the G1 ergonomic decisions Summary: It introduces ergonomic decision logging in G1 for the following heuristics: heap sizing, collection set construction, concurrent cycle initiation, and partially-young GC start/end. The code has a bit of refactoring in a few places to make the decision logging possible. It also replaces alternative ad-hoc logging that we have under different parameters and switches (G1_DEBUG, G1PolicyVerbose). Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp + src/share/vm/gc_implementation/g1/g1ErgoVerbose.cpp + src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: c2bf0120ee5d Author: stefank Date: 2011-09-01 16:18 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/c2bf0120ee5d 7085906: Replace the permgen allocated sentinelRef with a self-looped end Summary: Remove the sentinelRef and let the last Reference in a discovered chain point back to itself. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/memory/sharedHeap.cpp Changeset: 05550041d664 Author: ysr Date: 2011-09-07 15:00 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/05550041d664 Merge ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: eca1193ca245 Author: ysr Date: 2011-09-07 13:55 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/eca1193ca245 4965777: GC changes to support use of discovered field for pending references Summary: If and when the reference handler thread is able to use the discovered field to link reference objects in its pending list, so will GC. In that case, GC will scan through this field once a reference object has been placed on the pending list, but not scan that field before that stage, as the field is used by the concurrent GC thread to link discovered objects. When ReferenceHandleR thread does not use the discovered field for the purpose of linking the elements in the pending list, as would be the case in older JDKs, the JVM will fall back to the old behaviour of using the next field for that purpose. Reviewed-by: jcoomes, mchung, stefank ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/java.hpp Changeset: a6128a8ed624 Author: iveresov Date: 2011-09-07 18:58 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/a6128a8ed624 7086226: UseNUMA fails on old versions of windows Summary: Return correct answers from os::numa_*() for UMA machines or if NUMA API is not supported Reviewed-by: johnc ! src/os/windows/vm/os_windows.cpp Changeset: 4f41766176cf Author: tonyp Date: 2011-09-08 05:16 -0400 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/4f41766176cf 7084509: G1: fix inconsistencies and mistakes in the young list target length calculations Summary: Fixed inconsistencies and mistakes in the young list target length calculations so that a) the calculated target length is optimal (before, it was not), b) other parameters like max survivor size and max gc locker eden expansion are always consistent with the calculated target length (before, they were not always), and c) the resulting target length was always bound by desired min and max values (before, it was not). Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: af2ab04e0038 Author: brutisso Date: 2011-09-08 16:29 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/af2ab04e0038 6929868: G1: introduce min / max young gen size bounds Summary: Make G1 handle young gen size command line flags more consistently Reviewed-by: tonyp, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: 3bddbf0f57d6 Author: tonyp Date: 2011-09-09 05:20 -0400 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/3bddbf0f57d6 7087717: G1: make the G1PrintRegionLivenessInfo parameter diagnostic Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: e984655be425 Author: stefank Date: 2011-09-09 14:44 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/e984655be425 Merge ! src/share/vm/prims/jvm.h Changeset: 79f9a3ed607a Author: jcoomes Date: 2011-09-09 16:17 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/79f9a3ed607a Merge ! .hgtags - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 513a84dd0f8b Author: jcoomes Date: 2011-09-09 16:24 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/513a84dd0f8b 7088991: Bump ths hs22 build number to 05 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 140317da459a Author: jcoomes Date: 2011-09-09 16:33 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/140317da459a Added tag hs22-b05 for changeset 513a84dd0f8b ! .hgtags From scott.oaks at oracle.com Mon Sep 12 08:03:40 2011 From: scott.oaks at oracle.com (Scott Oaks) Date: Mon, 12 Sep 2011 11:03:40 -0400 Subject: JDK7 perm gen leak Message-ID: <4E6E1F4C.1050402@oracle.com> I am trying to track down a permgen leak in an app we have running JDK 7. When I run jmap -permstat, I'm a little confused by the output. The first line of the jmap output is: 304286 intern Strings occupying 48081424 bytes. But I thought that the interned strings were moved out of permgen in JDK 7? Maybe that output is just left over from JDK 6. The bigger issue is the output from the class loaders -- every line in the output says that the classloader in question is dead, e.g: 0x000000019a1c2770 0 0 0x000000019a1c27d0 dead weblogic/utils/classloaders/GenericClassLoader at 0x0000000140ae6950 Well, there is one exception; the bootstrap classloader is still showing that it is live. Still, at least some of those weblogic class loaders must still be alive, as the app is still running and using classes loaded by them. I hope that many more are actually dead (else they are the source of the leak) -- but I am not sure how to tell how many are actually dead vs. alive. I have to go look at the dump and trace the classloaders back anyway, so it isn't really a big issue -- but it is a little curious to me. -Scott From jon.masamitsu at oracle.com Mon Sep 12 10:25:19 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Mon, 12 Sep 2011 10:25:19 -0700 Subject: JDK7 perm gen leak In-Reply-To: <4E6E1F4C.1050402@oracle.com> References: <4E6E1F4C.1050402@oracle.com> Message-ID: <4E6E407F.4070802@oracle.com> On 09/12/11 08:03, Scott Oaks wrote: > I am trying to track down a permgen leak in an app we have running JDK > 7. When I run jmap -permstat, I'm a little confused by the output. > > The first line of the jmap output is: > 304286 intern Strings occupying 48081424 bytes. > > But I thought that the interned strings were moved out of permgen in > JDK 7? Maybe that output is just left over from JDK 6. Yes, the strings were moved out of the perm gen. The numbers from the output are generated from the internal StringTable. I believe the numbers are correct but perhaps shouldn't be printed out for -permstat. From tom.rodriguez at oracle.com Mon Sep 12 12:26:55 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Mon, 12 Sep 2011 12:26:55 -0700 Subject: JDK7 perm gen leak In-Reply-To: <4E6E407F.4070802@oracle.com> References: <4E6E1F4C.1050402@oracle.com> <4E6E407F.4070802@oracle.com> Message-ID: <60FEB980-7B69-4F31-AFBD-0DF50C47C2DF@oracle.com> On Sep 12, 2011, at 10:25 AM, Jon Masamitsu wrote: > > > On 09/12/11 08:03, Scott Oaks wrote: >> I am trying to track down a permgen leak in an app we have running JDK 7. When I run jmap -permstat, I'm a little confused by the output. >> >> The first line of the jmap output is: >> 304286 intern Strings occupying 48081424 bytes. >> >> But I thought that the interned strings were moved out of permgen in JDK 7? Maybe that output is just left over from JDK 6. > > Yes, the strings were moved out of the perm gen. The numbers from > the output are generated from the internal StringTable. I believe > the numbers are correct but perhaps shouldn't be printed out > for -permstat. Yes, that should be removed. It easy to fix this but it seems like it would still be useful to report interned string usage in the jinfo output. I don't see any obvious place to put it though. Any suggestions? tom > From tom.rodriguez at oracle.com Mon Sep 12 12:35:55 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Mon, 12 Sep 2011 12:35:55 -0700 Subject: JDK7 perm gen leak In-Reply-To: <4E6E1F4C.1050402@oracle.com> References: <4E6E1F4C.1050402@oracle.com> Message-ID: <8A64699E-6F85-43D3-8C47-2C58622158B3@oracle.com> On Sep 12, 2011, at 8:03 AM, Scott Oaks wrote: > I am trying to track down a permgen leak in an app we have running JDK 7. When I run jmap -permstat, I'm a little confused by the output. > > The first line of the jmap output is: > 304286 intern Strings occupying 48081424 bytes. > > But I thought that the interned strings were moved out of permgen in JDK 7? Maybe that output is just left over from JDK 6. > > The bigger issue is the output from the class loaders -- every line in the output says that the classloader in question is dead, e.g: > > 0x000000019a1c2770 0 0 0x000000019a1c27d0 dead weblogic/utils/classloaders/GenericClassLoader at 0x0000000140ae6950 > > Well, there is one exception; the bootstrap classloader is still showing that it is live. Still, at least some of those weblogic class loaders must still be alive, as the app is still running and using classes loaded by them. I hope that many more are actually dead (else they are the source of the leak) -- but I am not sure how to tell how many are actually dead vs. alive. I have to go look at the dump and trace the classloaders back anyway, so it isn't really a big issue -- but it is a little curious to me. The liveness analysis of the SA is somewhat suspect since it has to visit exactly the same roots that the JVM does and there's no cross validation that the SA and JVM agree on these kinds of things. Which collector are you using? You should get a dump using an agent like hprof instead and use that to figure out liveness. tom > > -Scott From tom.rodriguez at oracle.com Tue Sep 13 15:32:25 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Tue, 13 Sep 2011 15:32:25 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <201108311423.06276.kurt@intricatesoftware.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> Message-ID: I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. http://cr.openjdk.java.net/~never/7089790_full http://cr.openjdk.java.net/~never/7089790_headers_only http://cr.openjdk.java.net/~never/7089790_shared http://cr.openjdk.java.net/~never/7089790_bsd_only http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. Relative to the original webrev, these are the changes I made: Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. Fixed a few more printing mismatches. Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. tom On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: > On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>> >>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>> >>>>> http://markmail.org/message/rigdtb5heiliutec >>>>> >>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>> >>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>> can run it on. >>> >>> Hi Greg, >>> >>> Refreshing my memory by reading the freebsd-java list for this time-frame >>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>> search I used: >>> >>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >> >> I've tried setting UseMemBar to false and ran the resulting JDK on a few >> different things, including code designed to produce I/O and CPU load >> across a thread pool and I haven't been able to produce any problems. >> >> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >> does look like we can get off of the UseMemBar setting. > > That's great. OpenBSD will work with it set to false too. Perhaps we should get > some testing on Mac OS/X MP to confirm there's no problem there too. > > Thanks, > -Kurt From vladimir.kozlov at oracle.com Tue Sep 13 16:31:59 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 13 Sep 2011 16:31:59 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers Message-ID: <4E6FE7EF.9050008@oracle.com> http://cr.openjdk.java.net/~kvn/7090259/webrev 7090259: Fix hotspot sources to build with old compilers Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 Sun C++. I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. Thanks, Vladimir From tom.rodriguez at oracle.com Tue Sep 13 16:59:11 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Tue, 13 Sep 2011 16:59:11 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E6FE7EF.9050008@oracle.com> References: <4E6FE7EF.9050008@oracle.com> Message-ID: <3E745991-9B18-412F-BC28-A420F4A636E5@oracle.com> The method_comparator changes should include a comment indicating that this was done to avoid a problem with older Microsoft compilers. Otherwise it looks good. tom On Sep 13, 2011, at 4:31 PM, Vladimir Kozlov wrote: > http://cr.openjdk.java.net/~kvn/7090259/webrev > > 7090259: Fix hotspot sources to build with old compilers > > Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 Sun C++. > > I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. > > Thanks, > Vladimir From vladimir.kozlov at oracle.com Tue Sep 13 17:05:21 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 13 Sep 2011 17:05:21 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <3E745991-9B18-412F-BC28-A420F4A636E5@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <3E745991-9B18-412F-BC28-A420F4A636E5@oracle.com> Message-ID: <4E6FEFC1.4050107@oracle.com> Thank you, Tom I will add the comment. Vladimir Tom Rodriguez wrote: > The method_comparator changes should include a comment indicating that this was done to avoid a problem with older Microsoft compilers. Otherwise it looks good. > > tom > > On Sep 13, 2011, at 4:31 PM, Vladimir Kozlov wrote: > >> http://cr.openjdk.java.net/~kvn/7090259/webrev >> >> 7090259: Fix hotspot sources to build with old compilers >> >> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 Sun C++. >> >> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. >> >> Thanks, >> Vladimir > From tom.rodriguez at oracle.com Tue Sep 13 19:39:35 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Tue, 13 Sep 2011 19:39:35 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> Message-ID: Did anyone else receive this email? I never received a copy but it shows until the hotspot-dev archives and I suspect that means something went wrong with the oracle mail servers again. tom On Sep 13, 2011, at 3:32 PM, Tom Rodriguez wrote: > I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. > > http://cr.openjdk.java.net/~never/7089790_full > http://cr.openjdk.java.net/~never/7089790_headers_only > http://cr.openjdk.java.net/~never/7089790_shared > http://cr.openjdk.java.net/~never/7089790_bsd_only > http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux > > full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. > > Relative to the original webrev, these are the changes I made: > > Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. > > Fixed a few more printing mismatches. > > Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. > > I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. > > Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. > > tom > > On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: > >> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>> >>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>> >>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>> >>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>> >>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>> can run it on. >>>> >>>> Hi Greg, >>>> >>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>> search I used: >>>> >>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>> >>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>> different things, including code designed to produce I/O and CPU load >>> across a thread pool and I haven't been able to produce any problems. >>> >>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>> does look like we can get off of the UseMemBar setting. >> >> That's great. OpenBSD will work with it set to false too. Perhaps we should get >> some testing on Mac OS/X MP to confirm there's no problem there too. >> >> Thanks, >> -Kurt > From kurt at intricatesoftware.com Tue Sep 13 19:58:57 2011 From: kurt at intricatesoftware.com (Kurt Miller) Date: Tue, 13 Sep 2011 22:58:57 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> Message-ID: <4E701871.8070201@intricatesoftware.com> Hi Tom, Yes, I received two copies in my inbox. One from you directly and another from the list server. It appears to be working ok from my perspective. BTW, thanks for preparing this! I will give them a try hopefully tomorrow and let you know how it goes. Regards, -Kurt On 09/13/11 22:39, Tom Rodriguez wrote: > Did anyone else receive this email? I never received a copy but it shows until the hotspot-dev archives and I suspect that means something went wrong with the oracle mail servers again. > > tom > > On Sep 13, 2011, at 3:32 PM, Tom Rodriguez wrote: > >> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >> >> http://cr.openjdk.java.net/~never/7089790_full >> http://cr.openjdk.java.net/~never/7089790_headers_only >> http://cr.openjdk.java.net/~never/7089790_shared >> http://cr.openjdk.java.net/~never/7089790_bsd_only >> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >> >> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >> >> Relative to the original webrev, these are the changes I made: >> >> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >> >> Fixed a few more printing mismatches. >> >> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >> >> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >> >> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >> >> tom >> >> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >> >>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>> >>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>> >>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>> >>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>> >>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>> can run it on. >>>>> >>>>> Hi Greg, >>>>> >>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>> search I used: >>>>> >>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>> >>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>> different things, including code designed to produce I/O and CPU load >>>> across a thread pool and I haven't been able to produce any problems. >>>> >>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>> does look like we can get off of the UseMemBar setting. >>> >>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>> some testing on Mac OS/X MP to confirm there's no problem there too. >>> >>> Thanks, >>> -Kurt >> > From bengt.rutisson at oracle.com Tue Sep 13 23:33:39 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 14 Sep 2011 08:33:39 +0200 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E6FE7EF.9050008@oracle.com> References: <4E6FE7EF.9050008@oracle.com> Message-ID: <4E704AC3.5050805@oracle.com> Vladimir, Thanks for fixing this. What was it about the template version of method_compartor() that made vs2003 generate incorrect optimized code? I just want to make sure I don't add more templates with the same issue. Also, how long will we be supporting vs2003? I was under the impression that we had switched to vs2010 even for JDK6. Clearly I was wrong. Does that mean that we will keep vs2003 for the duration of JDK6 and thus implicitly have that as a build requirement for JDK7 as long as we are using the express model? Bengt On 2011-09-14 01:31, Vladimir Kozlov wrote: > http://cr.openjdk.java.net/~kvn/7090259/webrev > > 7090259: Fix hotspot sources to build with old compilers > > Fixed warnings which prevent building VM with old compilers. Used > non-template method_comparator() in sort_methods() since vs2003 > generates incorrect optimized code for it. Added -xwe compilation > flag. Tested with 5.7, 5.8 and 5.10 Sun C++. > > I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since > Tony fixed it already there. > > Thanks, > Vladimir From bengt.rutisson at oracle.com Wed Sep 14 00:36:14 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 14 Sep 2011 09:36:14 +0200 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E704AC3.5050805@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <4E704AC3.5050805@oracle.com> Message-ID: <4E70596E.6090507@oracle.com> Hi again, > Also, how long will we be supporting vs2003? I was under the > impression that we had switched to vs2010 even for JDK6. Clearly I was > wrong. Does that mean that we will keep vs2003 for the duration of > JDK6 and thus implicitly have that as a build requirement for JDK7 as > long as we are using the express model? I realized that I did know about vs2003 being the compiler for JDK6. Sorry for the noise. I am still interested in understanding what templates to avoid with vs2003. Thanks Bengt > > > Bengt > > On 2011-09-14 01:31, Vladimir Kozlov wrote: >> http://cr.openjdk.java.net/~kvn/7090259/webrev >> >> 7090259: Fix hotspot sources to build with old compilers >> >> Fixed warnings which prevent building VM with old compilers. Used >> non-template method_comparator() in sort_methods() since vs2003 >> generates incorrect optimized code for it. Added -xwe compilation >> flag. Tested with 5.7, 5.8 and 5.10 Sun C++. >> >> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since >> Tony fixed it already there. >> >> Thanks, >> Vladimir > From christian.thalinger at oracle.com Wed Sep 14 06:28:59 2011 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Wed, 14 Sep 2011 15:28:59 +0200 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> Message-ID: <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> On Sep 14, 2011, at 12:32 AM, Tom Rodriguez wrote: > I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. I did builds on Lion and everything looks good. > > http://cr.openjdk.java.net/~never/7089790_full That's too huge to review. The only thing I needed on my Mac OS X was this change: 75 # amd64 76 ifneq (,$(findstring $(ARCH), amd64 x86_64)) taken from: http://hg.openjdk.java.net/macosx-port/macosx-port/hotspot/file/a00aa3dd9244/make/bsd/makefiles/defs.make > http://cr.openjdk.java.net/~never/7089790_headers_only src/share/vm/runtime/os.hpp: + #ifdef TARGET_OS_FAMILY_bsd + # include "jvm_bsd.h" + #endif This is included twice. > > http://cr.openjdk.java.net/~never/7089790_shared Looks good. > http://cr.openjdk.java.net/~never/7089790_bsd_only This one is empty(?). > http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp: ! // HACK: si_code does not work on linux 2.2.12-20!!! ! // HACK: si_code does not work on bsd 2.2.12-20!!! I doubt there is a bsd 2.2.12 kernel :-) Seriously, I suppose si_code does work on BSD? src/os_cpu/bsd_x86/vm/bsd_x86_32.s: src/os_cpu/bsd_x86/vm/bsd_x86_64.s: + #ifdef __APPLE__ + .align 4 + #else .align 16 + #endif Maybe we should use a ALIGN macro instead. src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp + #ifndef _ALLBSD_SOURCE #include + #endif + #ifdef __APPLE__ + #include + #endif + + #if defined(AMD64) + # if defined(__APPLE__) + # define bswap_16(x) OSSwapInt16(x) + # define bswap_32(x) OSSwapInt32(x) + # define bswap_64(x) OSSwapInt64(x) + # elif defined(__OpenBSD__) + # define bswap_16(x) swap16(x) + # define bswap_32(x) swap32(x) + # define bswap_64(x) swap64(x) + # elif defined(__NetBSD__) + # define bswap_16(x) bswap16(x) + # define bswap_32(x) bswap32(x) + # define bswap_64(x) bswap64(x) + # else + # define bswap_16(x) __bswap16(x) + # define bswap_32(x) __bswap32(x) + # define bswap_64(x) __bswap64(x) + # endif + #endif src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp: - #include + #ifdef __APPLE__ + #include + #define bswap16(x) OSSwapInt16(x) + #define bswap32(x) OSSwapInt32(x) + #define bswap64(x) OSSwapInt64(x) + #else + # include + #endif Why is byteswap.h removed from bytes_bsd_zero but sys/endian.h is used for !APPLE? bytes_bsd_x86 does something different. src/os/bsd/vm/os_bsd.cpp: ! julong os::Bsd::available_memory() { + #ifdef _ALLBSD_SOURCE + // XXXBSD: this is just a stopgap implementation + return physical_memory() >> 2; + #else Is this going to be fixed anytime soon? + // This work-around is not necessary for 10.5+, as CrashReporter no longer intercedes + // on caught fatal signals. Should we check the Mac OS X version here and not do the workaround if >= 10.5? Generally there are a couple of linux -> bsd renames like: ! // thread has a unique thread_id (LinuxThreads or NPTL). It can be used ! // thread has a unique thread_id (BsdThreads or NPTL). It can be used which are wrong but I think it doesn't matter. But someone will have to deal with that when merging linux/bsd/solaris to posix. -- Christian > > full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. > > Relative to the original webrev, these are the changes I made: > > Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. > > Fixed a few more printing mismatches. > > Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. > > I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. > > Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. > > tom > > On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: > >> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>> >>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>> >>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>> >>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>> >>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>> can run it on. >>>> >>>> Hi Greg, >>>> >>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>> search I used: >>>> >>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>> >>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>> different things, including code designed to produce I/O and CPU load >>> across a thread pool and I haven't been able to produce any problems. >>> >>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>> does look like we can get off of the UseMemBar setting. >> >> That's great. OpenBSD will work with it set to false too. Perhaps we should get >> some testing on Mac OS/X MP to confirm there's no problem there too. >> >> Thanks, >> -Kurt > From vladimir.kozlov at oracle.com Wed Sep 14 08:59:59 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 14 Sep 2011 08:59:59 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E70596E.6090507@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <4E704AC3.5050805@oracle.com> <4E70596E.6090507@oracle.com> Message-ID: <4E70CF7F.6060300@oracle.com> On 9/14/11 12:36 AM, Bengt Rutisson wrote: > > Hi again, > >> Also, how long will we be supporting vs2003? I was under the impression that we had switched to vs2010 even for JDK6. >> Clearly I was wrong. Does that mean that we will keep vs2003 for the duration of JDK6 and thus implicitly have that as >> a build requirement for JDK7 as long as we are using the express model? > > I realized that I did know about vs2003 being the compiler for JDK6. Sorry for the noise. > > I am still interested in understanding what templates to avoid with vs2003. This is what Tom found analyzing crush: On 9/13/11 9:52 AM, Tom Rodriguez wrote: > I'm looking at it in the debugger and it appears to be crashing in the method_comparator in the new QuickSort code. It sort of looks like the passed in pointers are small integers instead of pointers but the array itself looks ok. maybe it's an optimizer bug? > > Actually I think it's a disagreement about the calling convention. The caller pushes the arguments: > > 080e5409 50 push eax > 080e540a 51 push ecx > 080e540b ff5510 call dword ptr [ebp+10h] > 080e540e 83c408 add esp,8 > > but the callee thinks they are in registers: > > jvm!method_comparator: > 080e78a0 8b4808 mov ecx,dword ptr [eax+8] > 080e78a3 0fb74928 movzx ecx,word ptr [ecx+28h] > 080e78a7 53 push ebx > 080e78a8 8b5f08 mov ebx,dword ptr [edi+8 > > There seems to be a bit of mixing of calling convention going on in the binary, which seems very odd. > > tom I think it is because one of template classes (C comparator) for QuickSort::sort is method type which is also template. Vladimir > > Thanks > Bengt > >> >> >> Bengt >> >> On 2011-09-14 01:31, Vladimir Kozlov wrote: >>> http://cr.openjdk.java.net/~kvn/7090259/webrev >>> >>> 7090259: Fix hotspot sources to build with old compilers >>> >>> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() >>> since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 >>> Sun C++. >>> >>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. >>> >>> Thanks, >>> Vladimir >> > From jon.masamitsu at oracle.com Wed Sep 14 09:29:34 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Wed, 14 Sep 2011 09:29:34 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E6FE7EF.9050008@oracle.com> References: <4E6FE7EF.9050008@oracle.com> Message-ID: <4E70D66E.7080002@oracle.com> Vladimir, Where changes like this to explicitly add the cast 101 err_msg("Found an inactive reference " PTR_FORMAT " with a non-NULL discovered field", 102 (oopDesc*)obj)); ^^^^^^^^^^^^^ because the Solaris compilers issued a warning there? I'm wondering because I was just cleaning out some casts that I thought were not needed but maybe they are. Jon On 9/13/2011 4:31 PM, Vladimir Kozlov wrote: > http://cr.openjdk.java.net/~kvn/7090259/webrev > > 7090259: Fix hotspot sources to build with old compilers > > Fixed warnings which prevent building VM with old compilers. Used > non-template method_comparator() in sort_methods() since vs2003 > generates incorrect optimized code for it. Added -xwe compilation > flag. Tested with 5.7, 5.8 and 5.10 Sun C++. > > I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since > Tony fixed it already there. > > Thanks, > Vladimir From vladimir.kozlov at oracle.com Wed Sep 14 09:34:28 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 14 Sep 2011 09:34:28 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E70D66E.7080002@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <4E70D66E.7080002@oracle.com> Message-ID: <4E70D794.9050400@oracle.com> Yes, there was warning: "/opt/jprt/temp/P1/170801.amurillo/source/src/share/vm/oops/instanceRefKlass.cpp", line 355: Warning: A non-POD object of type "oop" passed as a variable argument to function "FormatBuffer<256>::FormatBuffer(const char*, ...)". Try SS11 compiler with your change before you push it. Vladimir Jon Masamitsu wrote: > Vladimir, > > Where changes like this to explicitly add the cast > > 101 err_msg("Found an inactive reference " PTR_FORMAT " with > a non-NULL discovered field", > > 102 (oopDesc*)obj)); > > ^^^^^^^^^^^^^ > > because the Solaris compilers issued a warning there? > > I'm wondering because I was just cleaning out some casts > that I thought were not needed but maybe they are. > > Jon > > > On 9/13/2011 4:31 PM, Vladimir Kozlov wrote: >> http://cr.openjdk.java.net/~kvn/7090259/webrev >> >> 7090259: Fix hotspot sources to build with old compilers >> >> Fixed warnings which prevent building VM with old compilers. Used >> non-template method_comparator() in sort_methods() since vs2003 >> generates incorrect optimized code for it. Added -xwe compilation >> flag. Tested with 5.7, 5.8 and 5.10 Sun C++. >> >> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since >> Tony fixed it already there. >> >> Thanks, >> Vladimir From tom.rodriguez at oracle.com Wed Sep 14 09:54:05 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 09:54:05 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E70D794.9050400@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <4E70D66E.7080002@oracle.com> <4E70D794.9050400@oracle.com> Message-ID: <5F1BB365-4B7F-4D4E-85AB-65EDCA2B79E3@oracle.com> On Sep 14, 2011, at 9:34 AM, Vladimir Kozlov wrote: > Yes, there was warning: > > "/opt/jprt/temp/P1/170801.amurillo/source/src/share/vm/oops/instanceRefKlass.cpp", line 355: Warning: A non-POD object of type "oop" passed as a variable argument to function "FormatBuffer<256>::FormatBuffer(const char*, ...)". > > Try SS11 compiler with your change before you push it. More importantly, because of CHEKC_UNHANDLED_OOPS, the code wouldn't do what was intended since it was pushing an object on the stack, an oop, but the format was expecting a pointer value. The explicit cast should convert it to an actual pointer. I believe the current compilers don't complain but it's still doing the wrong thing. Should we disable CHECK_UNHANDLED_OOPS? tom > > Vladimir > > Jon Masamitsu wrote: >> Vladimir, >> Where changes like this to explicitly add the cast >> 101 err_msg("Found an inactive reference " PTR_FORMAT " with a non-NULL discovered field", >> 102 (oopDesc*)obj)); >> ^^^^^^^^^^^^^ >> because the Solaris compilers issued a warning there? >> I'm wondering because I was just cleaning out some casts >> that I thought were not needed but maybe they are. >> Jon >> On 9/13/2011 4:31 PM, Vladimir Kozlov wrote: >>> http://cr.openjdk.java.net/~kvn/7090259/webrev >>> >>> 7090259: Fix hotspot sources to build with old compilers >>> >>> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 Sun C++. >>> >>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. >>> >>> Thanks, >>> Vladimir From tom.rodriguez at oracle.com Wed Sep 14 10:05:58 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 10:05:58 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E70CF7F.6060300@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <4E704AC3.5050805@oracle.com> <4E70596E.6090507@oracle.com> <4E70CF7F.6060300@oracle.com> Message-ID: <20CDC09E-FDE7-45B5-B930-88122D3C6F85@oracle.com> On Sep 14, 2011, at 8:59 AM, Vladimir Kozlov wrote: > On 9/14/11 12:36 AM, Bengt Rutisson wrote: >> >> Hi again, >> >>> Also, how long will we be supporting vs2003? I was under the impression that we had switched to vs2010 even for JDK6. >>> Clearly I was wrong. Does that mean that we will keep vs2003 for the duration of JDK6 and thus implicitly have that as >>> a build requirement for JDK7 as long as we are using the express model? >> >> I realized that I did know about vs2003 being the compiler for JDK6. Sorry for the noise. >> >> I am still interested in understanding what templates to avoid with vs2003. > > This is what Tom found analyzing crush: I'm still confused by it. It appears to think the arguments are in eax and edi which doesn't match any calling convention I can find. I guess it's just a bug. tom > > On 9/13/11 9:52 AM, Tom Rodriguez wrote: > > I'm looking at it in the debugger and it appears to be crashing in the method_comparator in the new QuickSort code. It sort of looks like the passed in pointers are small integers instead of pointers but the array itself looks ok. maybe it's an optimizer bug? > > > > Actually I think it's a disagreement about the calling convention. The caller pushes the arguments: > > > > 080e5409 50 push eax > > 080e540a 51 push ecx > > 080e540b ff5510 call dword ptr [ebp+10h] > > 080e540e 83c408 add esp,8 > > > > but the callee thinks they are in registers: > > > > jvm!method_comparator: > > 080e78a0 8b4808 mov ecx,dword ptr [eax+8] > > 080e78a3 0fb74928 movzx ecx,word ptr [ecx+28h] > > 080e78a7 53 push ebx > > 080e78a8 8b5f08 mov ebx,dword ptr [edi+8 > > > > There seems to be a bit of mixing of calling convention going on in the binary, which seems very odd. > > > > tom > > I think it is because one of template classes (C comparator) for QuickSort::sort is method type which is also template. > > Vladimir > > >> >> Thanks >> Bengt >> >>> >>> >>> Bengt >>> >>> On 2011-09-14 01:31, Vladimir Kozlov wrote: >>>> http://cr.openjdk.java.net/~kvn/7090259/webrev >>>> >>>> 7090259: Fix hotspot sources to build with old compilers >>>> >>>> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() >>>> since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 >>>> Sun C++. >>>> >>>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. >>>> >>>> Thanks, >>>> Vladimir >>> >> From vladimir.kozlov at oracle.com Wed Sep 14 10:47:35 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 14 Sep 2011 10:47:35 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> Message-ID: <4E70E8B7.7080500@oracle.com> I looked only on changes in our current sources. Why change globals_sparc.hpp and not other files (as on ther platforms)? java_md.c typo? I think it sould be __linux__: ! #ifdef __linux ! #if defined(__linux) Remove last change in javaClasses.cpp, it is fixed. In typeArrayOop.hpp only orderAccess_bsd_x86.inline.hpp and orderAccess_bsd_zero.inline.hpp are exit. Otherwise include other platforms also into bytecodeInterpreter.cpp, javaFrameAnchor.hpp, taskqueue.hpp and also in places where *_bsd_x86.hpp and *_bsd_zero.hpp are included. Christian already pointed double inclusion jvm_bsd.h in os.hpp. Vladimir Tom Rodriguez wrote: > I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. > > http://cr.openjdk.java.net/~never/7089790_full > http://cr.openjdk.java.net/~never/7089790_headers_only > http://cr.openjdk.java.net/~never/7089790_shared > http://cr.openjdk.java.net/~never/7089790_bsd_only > http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux > > full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. > > Relative to the original webrev, these are the changes I made: > > Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. > > Fixed a few more printing mismatches. > > Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. > > I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. > > Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. > > tom > > On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: > >> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>> >>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>> >>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>> can run it on. >>>> Hi Greg, >>>> >>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>> search I used: >>>> >>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>> different things, including code designed to produce I/O and CPU load >>> across a thread pool and I haven't been able to produce any problems. >>> >>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>> does look like we can get off of the UseMemBar setting. >> That's great. OpenBSD will work with it set to false too. Perhaps we should get >> some testing on Mac OS/X MP to confirm there's no problem there too. >> >> Thanks, >> -Kurt > From tom.rodriguez at oracle.com Wed Sep 14 11:01:14 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 11:01:14 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <4E70E8B7.7080500@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> Message-ID: <1546B9CC-8C10-4DB2-BA16-1EE8FE89CF37@oracle.com> On Sep 14, 2011, at 10:47 AM, Vladimir Kozlov wrote: > I looked only on changes in our current sources. > > Why change globals_sparc.hpp and not other files (as on ther platforms)? I'm not sure that you mean. globals_x86.hpp and globals_zero.hpp have the same change. > > java_md.c typo? I think it sould be __linux__: > > ! #ifdef __linux > ! #if defined(__linux) Yes that looks like a preexisting bug. I'll fix it. > > Remove last change in javaClasses.cpp, it is fixed. Yes I'll remove that. > > In typeArrayOop.hpp only orderAccess_bsd_x86.inline.hpp and orderAccess_bsd_zero.inline.hpp are exit. Otherwise include other platforms also into bytecodeInterpreter.cpp, javaFrameAnchor.hpp, taskqueue.hpp and also in places where *_bsd_x86.hpp and *_bsd_zero.hpp are included. Some files have includes for all and other don't. I'll update it so all have the same set. This whole thing has convinced me that we should be using dispatch files. Some of the include lists are getting as long as my arm. > > Christian already pointed double inclusion jvm_bsd.h in os.hpp. Yes. Thanks. tom > > Vladimir > > Tom Rodriguez wrote: >> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >> http://cr.openjdk.java.net/~never/7089790_full >> http://cr.openjdk.java.net/~never/7089790_headers_only >> http://cr.openjdk.java.net/~never/7089790_shared >> http://cr.openjdk.java.net/~never/7089790_bsd_only >> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >> Relative to the original webrev, these are the changes I made: >> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >> Fixed a few more printing mismatches. >> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >> tom >> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>> >>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>> >>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>> can run it on. >>>>> Hi Greg, >>>>> >>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>> search I used: >>>>> >>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>> different things, including code designed to produce I/O and CPU load >>>> across a thread pool and I haven't been able to produce any problems. >>>> >>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>> does look like we can get off of the UseMemBar setting. >>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>> some testing on Mac OS/X MP to confirm there's no problem there too. >>> >>> Thanks, >>> -Kurt From vladimir.kozlov at oracle.com Wed Sep 14 11:05:11 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 14 Sep 2011 11:05:11 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <1546B9CC-8C10-4DB2-BA16-1EE8FE89CF37@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> <1546B9CC-8C10-4DB2-BA16-1EE8FE89CF37@oracle.com> Message-ID: <4E70ECD7.7030702@oracle.com> Tom Rodriguez wrote: > On Sep 14, 2011, at 10:47 AM, Vladimir Kozlov wrote: > >> I looked only on changes in our current sources. >> >> Why change globals_sparc.hpp and not other files (as on ther platforms)? > > I'm not sure that you mean. globals_x86.hpp and globals_zero.hpp have the same change. You changed globals_sparc.hpp but not, for example, copy_sparc.hpp as on other platforms. I don't understand why we even need change anything for sparc there are no bsd code (no new files) for sparc. Vladimir > >> java_md.c typo? I think it sould be __linux__: >> >> ! #ifdef __linux >> ! #if defined(__linux) > > Yes that looks like a preexisting bug. I'll fix it. > >> Remove last change in javaClasses.cpp, it is fixed. > > Yes I'll remove that. > >> In typeArrayOop.hpp only orderAccess_bsd_x86.inline.hpp and orderAccess_bsd_zero.inline.hpp are exit. Otherwise include other platforms also into bytecodeInterpreter.cpp, javaFrameAnchor.hpp, taskqueue.hpp and also in places where *_bsd_x86.hpp and *_bsd_zero.hpp are included. > > Some files have includes for all and other don't. I'll update it so all have the same set. This whole thing has convinced me that we should be using dispatch files. Some of the include lists are getting as long as my arm. > >> Christian already pointed double inclusion jvm_bsd.h in os.hpp. > > Yes. > > Thanks. > > tom > >> Vladimir >> >> Tom Rodriguez wrote: >>> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >>> http://cr.openjdk.java.net/~never/7089790_full >>> http://cr.openjdk.java.net/~never/7089790_headers_only >>> http://cr.openjdk.java.net/~never/7089790_shared >>> http://cr.openjdk.java.net/~never/7089790_bsd_only >>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >>> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >>> Relative to the original webrev, these are the changes I made: >>> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >>> Fixed a few more printing mismatches. >>> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >>> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >>> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >>> tom >>> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >>>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>>> >>>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>>> >>>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>>> can run it on. >>>>>> Hi Greg, >>>>>> >>>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>>> search I used: >>>>>> >>>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>>> different things, including code designed to produce I/O and CPU load >>>>> across a thread pool and I haven't been able to produce any problems. >>>>> >>>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>>> does look like we can get off of the UseMemBar setting. >>>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>>> some testing on Mac OS/X MP to confirm there's no problem there too. >>>> >>>> Thanks, >>>> -Kurt > From tom.rodriguez at oracle.com Wed Sep 14 11:14:03 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 11:14:03 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <4E70ECD7.7030702@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> <1546B9CC-8C10-4DB2-BA16-1EE8FE89CF37@oracle.com> <4E70ECD7.7030702@oracle.com> Message-ID: <788AA7CF-D6AD-4B9C-B992-4A35D96C564E@oracle.com> On Sep 14, 2011, at 11:05 AM, Vladimir Kozlov wrote: > Tom Rodriguez wrote: >> On Sep 14, 2011, at 10:47 AM, Vladimir Kozlov wrote: >>> I looked only on changes in our current sources. >>> >>> Why change globals_sparc.hpp and not other files (as on ther platforms)? >> I'm not sure that you mean. globals_x86.hpp and globals_zero.hpp have the same change. > > You changed globals_sparc.hpp but not, for example, copy_sparc.hpp as on other platforms. I don't understand why we even need change anything for sparc there are no bsd code (no new files) for sparc. Oh, you mean the changes aren't complete for sparc. I thought you were complaining about the actual contents of globals_sparc.hpp. There are BSD ports to most architectures, including sparc, so I suspect the changes were just forward thinking on the part of whoever originally did them. We can either leave them out or extend them. I'm fine either way. tom > > Vladimir > >>> java_md.c typo? I think it sould be __linux__: >>> >>> ! #ifdef __linux >>> ! #if defined(__linux) >> Yes that looks like a preexisting bug. I'll fix it. >>> Remove last change in javaClasses.cpp, it is fixed. >> Yes I'll remove that. >>> In typeArrayOop.hpp only orderAccess_bsd_x86.inline.hpp and orderAccess_bsd_zero.inline.hpp are exit. Otherwise include other platforms also into bytecodeInterpreter.cpp, javaFrameAnchor.hpp, taskqueue.hpp and also in places where *_bsd_x86.hpp and *_bsd_zero.hpp are included. >> Some files have includes for all and other don't. I'll update it so all have the same set. This whole thing has convinced me that we should be using dispatch files. Some of the include lists are getting as long as my arm. >>> Christian already pointed double inclusion jvm_bsd.h in os.hpp. >> Yes. >> Thanks. >> tom >>> Vladimir >>> >>> Tom Rodriguez wrote: >>>> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >>>> http://cr.openjdk.java.net/~never/7089790_full >>>> http://cr.openjdk.java.net/~never/7089790_headers_only >>>> http://cr.openjdk.java.net/~never/7089790_shared >>>> http://cr.openjdk.java.net/~never/7089790_bsd_only >>>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >>>> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >>>> Relative to the original webrev, these are the changes I made: >>>> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >>>> Fixed a few more printing mismatches. >>>> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >>>> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >>>> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >>>> tom >>>> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >>>>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>>>> >>>>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>>>> >>>>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>>>> can run it on. >>>>>>> Hi Greg, >>>>>>> >>>>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>>>> search I used: >>>>>>> >>>>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>>>> different things, including code designed to produce I/O and CPU load >>>>>> across a thread pool and I haven't been able to produce any problems. >>>>>> >>>>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>>>> does look like we can get off of the UseMemBar setting. >>>>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>>>> some testing on Mac OS/X MP to confirm there's no problem there too. >>>>> >>>>> Thanks, >>>>> -Kurt From coleen.phillimore at oracle.com Wed Sep 14 11:15:20 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Wed, 14 Sep 2011 14:15:20 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <4E70E8B7.7080500@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> Message-ID: <4E70EF38.7050405@oracle.com> On 9/14/2011 1:47 PM, Vladimir Kozlov wrote: > > Remove last change in javaClasses.cpp, it is fixed. Is it to prevent this compilation error on solaris-sparcv9 for jdk6? "/opt/jprt/temp/P1/010944.coleenp/source/src/share/vm/classfile/javaClasses.cpp", line 2704: Error: Overloading ambiguity between "methodOop::operator methodOopDesc*() const" and "oop::operator void*() const". "/opt/jprt/temp/P1/010944.coleenp/source/src/share/vm/classfile/javaClasses.cpp", line 2704: Error: Overloading ambiguity between "methodOop::operator methodOopDesc*() const" and "oop::operator void*() const". Thanks, Coleen From tom.rodriguez at oracle.com Wed Sep 14 11:19:16 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 11:19:16 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <4E70EF38.7050405@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> <4E70EF38.7050405@oracle.com> Message-ID: Yes. tom On Sep 14, 2011, at 11:15 AM, Coleen Phillimore wrote: > > On 9/14/2011 1:47 PM, Vladimir Kozlov wrote: >> >> Remove last change in javaClasses.cpp, it is fixed. > > Is it to prevent this compilation error on solaris-sparcv9 for jdk6? > > "/opt/jprt/temp/P1/010944.coleenp/source/src/share/vm/classfile/javaClasses.cpp", > line 2704: Error: Overloading ambiguity between "methodOop::operator > methodOopDesc*() const" and "oop::operator void*() const". > "/opt/jprt/temp/P1/010944.coleenp/source/src/share/vm/classfile/javaClasses.cpp", > line 2704: Error: Overloading ambiguity between "methodOop::operator > methodOopDesc*() const" and "oop::operator void*() const". > > Thanks, > Coleen > > From coleen.phillimore at oracle.com Wed Sep 14 11:39:22 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Wed, 14 Sep 2011 14:39:22 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> <4E70EF38.7050405@oracle.com> Message-ID: <4E70F4DA.8000803@oracle.com> Great! thanks, Coleen On 9/14/2011 2:19 PM, Tom Rodriguez wrote: > Yes. > > tom > > On Sep 14, 2011, at 11:15 AM, Coleen Phillimore wrote: > >> On 9/14/2011 1:47 PM, Vladimir Kozlov wrote: >>> Remove last change in javaClasses.cpp, it is fixed. >> Is it to prevent this compilation error on solaris-sparcv9 for jdk6? >> >> "/opt/jprt/temp/P1/010944.coleenp/source/src/share/vm/classfile/javaClasses.cpp", >> line 2704: Error: Overloading ambiguity between "methodOop::operator >> methodOopDesc*() const" and "oop::operator void*() const". >> "/opt/jprt/temp/P1/010944.coleenp/source/src/share/vm/classfile/javaClasses.cpp", >> line 2704: Error: Overloading ambiguity between "methodOop::operator >> methodOopDesc*() const" and "oop::operator void*() const". >> >> Thanks, >> Coleen >> >> From glewis at eyesbeyond.com Wed Sep 14 11:44:59 2011 From: glewis at eyesbeyond.com (Greg Lewis) Date: Wed, 14 Sep 2011 11:44:59 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> Message-ID: <20110914184459.GA81847@misty.eyesbeyond.com> G'day Tom, On Tue, Sep 13, 2011 at 02:18:15PM -0700, Tom Rodriguez wrote: > I've finally prepared a set of changes against the latest hotspot-comp > with the bsd-port changes. They compile on all our supported platforms > with the jdk7 and jdk6 tools and I also built on Snow Leopard and > incorporated a few extra changes there to make it all compile. > I've prepared several webrevs to ease reviewing. > > http://cr.openjdk.java.net/~never/7089790_full > http://cr.openjdk.java.net/~never/7089790_headers_only > http://cr.openjdk.java.net/~never/7089790_shared > http://cr.openjdk.java.net/~never/7089790_bsd_only > http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux > [snip] > > Who all should I mark as the contributors for these changes? Roger, > Greg and Kurt? If you could take a copy of the bits and confirm that I > haven't introduced any issues on BSD that would be greatly appreciated. > Thanks for your patience. Built and lightly tested on FreeBSD. Looks good from that perspective. I sent you separate mail privately about the contributors from the BSD port side. Roger, can you please provide a list of the contributors from the team at Apple? > On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: > > > On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: > >> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: > >>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: > >>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: > >>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: > >>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. > >>>>> > >>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. > >>>>> > >>>>> http://markmail.org/message/rigdtb5heiliutec > >>>>> > >>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. > >>>> > >>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I > >>>> can run it on. > >>> > >>> Hi Greg, > >>> > >>> Refreshing my memory by reading the freebsd-java list for this time-frame > >>> and I see that it was rather easy to reproduce on SMP hardware. Reports > >>> included using tomcat, netbeans and in one case 'java -version'. Here's the > >>> search I used: > >>> > >>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 > >> > >> I've tried setting UseMemBar to false and ran the resulting JDK on a few > >> different things, including code designed to produce I/O and CPU load > >> across a thread pool and I haven't been able to produce any problems. > >> > >> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it > >> does look like we can get off of the UseMemBar setting. > > > > That's great. OpenBSD will work with it set to false too. Perhaps we should get > > some testing on Mac OS/X MP to confirm there's no problem there too. > > > > Thanks, > > -Kurt > -- Greg Lewis Email : glewis at eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis at FreeBSD.org From vladimir.kozlov at oracle.com Wed Sep 14 12:04:30 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 14 Sep 2011 12:04:30 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <788AA7CF-D6AD-4B9C-B992-4A35D96C564E@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> <1546B9CC-8C10-4DB2-BA16-1EE8FE89CF37@oracle.com> <4E70ECD7.7030702@oracle.com> <788AA7CF-D6AD-4B9C-B992-4A35D96C564E@oracle.com> Message-ID: <4E70FABE.5080607@oracle.com> I think we should remove sparc related changes since they are not complete and useless. Vladimir Tom Rodriguez wrote: > On Sep 14, 2011, at 11:05 AM, Vladimir Kozlov wrote: > >> Tom Rodriguez wrote: >>> On Sep 14, 2011, at 10:47 AM, Vladimir Kozlov wrote: >>>> I looked only on changes in our current sources. >>>> >>>> Why change globals_sparc.hpp and not other files (as on ther platforms)? >>> I'm not sure that you mean. globals_x86.hpp and globals_zero.hpp have the same change. >> You changed globals_sparc.hpp but not, for example, copy_sparc.hpp as on other platforms. I don't understand why we even need change anything for sparc there are no bsd code (no new files) for sparc. > > Oh, you mean the changes aren't complete for sparc. I thought you were complaining about the actual contents of globals_sparc.hpp. There are BSD ports to most architectures, including sparc, so I suspect the changes were just forward thinking on the part of whoever originally did them. We can either leave them out or extend them. I'm fine either way. > > tom > >> Vladimir >> >>>> java_md.c typo? I think it sould be __linux__: >>>> >>>> ! #ifdef __linux >>>> ! #if defined(__linux) >>> Yes that looks like a preexisting bug. I'll fix it. >>>> Remove last change in javaClasses.cpp, it is fixed. >>> Yes I'll remove that. >>>> In typeArrayOop.hpp only orderAccess_bsd_x86.inline.hpp and orderAccess_bsd_zero.inline.hpp are exit. Otherwise include other platforms also into bytecodeInterpreter.cpp, javaFrameAnchor.hpp, taskqueue.hpp and also in places where *_bsd_x86.hpp and *_bsd_zero.hpp are included. >>> Some files have includes for all and other don't. I'll update it so all have the same set. This whole thing has convinced me that we should be using dispatch files. Some of the include lists are getting as long as my arm. >>>> Christian already pointed double inclusion jvm_bsd.h in os.hpp. >>> Yes. >>> Thanks. >>> tom >>>> Vladimir >>>> >>>> Tom Rodriguez wrote: >>>>> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >>>>> http://cr.openjdk.java.net/~never/7089790_full >>>>> http://cr.openjdk.java.net/~never/7089790_headers_only >>>>> http://cr.openjdk.java.net/~never/7089790_shared >>>>> http://cr.openjdk.java.net/~never/7089790_bsd_only >>>>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >>>>> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >>>>> Relative to the original webrev, these are the changes I made: >>>>> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >>>>> Fixed a few more printing mismatches. >>>>> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >>>>> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >>>>> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >>>>> tom >>>>> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >>>>>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>>>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>>>>> >>>>>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>>>>> >>>>>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>>>>> can run it on. >>>>>>>> Hi Greg, >>>>>>>> >>>>>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>>>>> search I used: >>>>>>>> >>>>>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>>>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>>>>> different things, including code designed to produce I/O and CPU load >>>>>>> across a thread pool and I haven't been able to produce any problems. >>>>>>> >>>>>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>>>>> does look like we can get off of the UseMemBar setting. >>>>>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>>>>> some testing on Mac OS/X MP to confirm there's no problem there too. >>>>>> >>>>>> Thanks, >>>>>> -Kurt > From rhoover at apple.com Wed Sep 14 11:48:37 2011 From: rhoover at apple.com (roger hoover) Date: Wed, 14 Sep 2011 12:48:37 -0600 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <20110914184459.GA81847@misty.eyesbeyond.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> Message-ID: On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: > > I sent you separate mail privately about the contributors from the BSD > port side. Roger, can you please provide a list of the contributors from > the team at Apple? Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. roger -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20110914/c3d6e4ef/attachment.html From kurt at intricatesoftware.com Wed Sep 14 12:23:20 2011 From: kurt at intricatesoftware.com (Kurt Miller) Date: Wed, 14 Sep 2011 15:23:20 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <20110914184459.GA81847@misty.eyesbeyond.com> References: <201108021234.30179.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> Message-ID: <201109141523.20334.kurt@intricatesoftware.com> On Wednesday 14 September 2011 02:44:59 pm Greg Lewis wrote: > G'day Tom, > > On Tue, Sep 13, 2011 at 02:18:15PM -0700, Tom Rodriguez wrote: > > I've finally prepared a set of changes against the latest hotspot-comp > > with the bsd-port changes. They compile on all our supported platforms > > with the jdk7 and jdk6 tools and I also built on Snow Leopard and > > incorporated a few extra changes there to make it all compile. > > I've prepared several webrevs to ease reviewing. > > > > http://cr.openjdk.java.net/~never/7089790_full > > http://cr.openjdk.java.net/~never/7089790_headers_only > > http://cr.openjdk.java.net/~never/7089790_shared > > http://cr.openjdk.java.net/~never/7089790_bsd_only > > http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux > > > [snip] > > > > Who all should I mark as the contributors for these changes? Roger, > > Greg and Kurt? If you could take a copy of the bits and confirm that I > > haven't introduced any issues on BSD that would be greatly appreciated. > > Thanks for your patience. > > Built and lightly tested on FreeBSD. Looks good from that perspective. Same here on OpenBSD. Builds fine and it is able to boostrap the next build. Thanks, -Kurt From bengt.rutisson at oracle.com Wed Sep 14 12:34:03 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 14 Sep 2011 21:34:03 +0200 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <20CDC09E-FDE7-45B5-B930-88122D3C6F85@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <4E704AC3.5050805@oracle.com> <4E70596E.6090507@oracle.com> <4E70CF7F.6060300@oracle.com> <20CDC09E-FDE7-45B5-B930-88122D3C6F85@oracle.com> Message-ID: <4E7101AB.4000800@oracle.com> Vladimir and Tom, Thanks for providing the background information. Just to verify that I got it right: there seems to be a bug related to templates in the vs2003 compiler, but we are not sure exactly what template patterns that will trigger the bug. Any suggestions for how to do testing if I do another change that involves templates? Thanks, Bengt On 2011-09-14 19:05, Tom Rodriguez wrote: > On Sep 14, 2011, at 8:59 AM, Vladimir Kozlov wrote: > >> On 9/14/11 12:36 AM, Bengt Rutisson wrote: >>> Hi again, >>> >>>> Also, how long will we be supporting vs2003? I was under the impression that we had switched to vs2010 even for JDK6. >>>> Clearly I was wrong. Does that mean that we will keep vs2003 for the duration of JDK6 and thus implicitly have that as >>>> a build requirement for JDK7 as long as we are using the express model? >>> I realized that I did know about vs2003 being the compiler for JDK6. Sorry for the noise. >>> >>> I am still interested in understanding what templates to avoid with vs2003. >> This is what Tom found analyzing crush: > I'm still confused by it. It appears to think the arguments are in eax and edi which doesn't match any calling convention I can find. I guess it's just a bug. > > tom > >> On 9/13/11 9:52 AM, Tom Rodriguez wrote: >>> I'm looking at it in the debugger and it appears to be crashing in the method_comparator in the new QuickSort code. It sort of looks like the passed in pointers are small integers instead of pointers but the array itself looks ok. maybe it's an optimizer bug? >>> >>> Actually I think it's a disagreement about the calling convention. The caller pushes the arguments: >>> >>> 080e5409 50 push eax >>> 080e540a 51 push ecx >>> 080e540b ff5510 call dword ptr [ebp+10h] >>> 080e540e 83c408 add esp,8 >>> >>> but the callee thinks they are in registers: >>> >>> jvm!method_comparator: >>> 080e78a0 8b4808 mov ecx,dword ptr [eax+8] >>> 080e78a3 0fb74928 movzx ecx,word ptr [ecx+28h] >>> 080e78a7 53 push ebx >>> 080e78a8 8b5f08 mov ebx,dword ptr [edi+8 >>> >>> There seems to be a bit of mixing of calling convention going on in the binary, which seems very odd. >>> >>> tom >> I think it is because one of template classes (C comparator) for QuickSort::sort is method type which is also template. >> >> Vladimir >> >> >>> Thanks >>> Bengt >>> >>>> >>>> Bengt >>>> >>>> On 2011-09-14 01:31, Vladimir Kozlov wrote: >>>>> http://cr.openjdk.java.net/~kvn/7090259/webrev >>>>> >>>>> 7090259: Fix hotspot sources to build with old compilers >>>>> >>>>> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() >>>>> since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 >>>>> Sun C++. >>>>> >>>>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. >>>>> >>>>> Thanks, >>>>> Vladimir From tom.rodriguez at oracle.com Wed Sep 14 12:44:03 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 12:44:03 -0700 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: <4E7101AB.4000800@oracle.com> References: <4E6FE7EF.9050008@oracle.com> <4E704AC3.5050805@oracle.com> <4E70596E.6090507@oracle.com> <4E70CF7F.6060300@oracle.com> <20CDC09E-FDE7-45B5-B930-88122D3C6F85@oracle.com> <4E7101AB.4000800@oracle.com> Message-ID: On Sep 14, 2011, at 12:34 PM, Bengt Rutisson wrote: > > Vladimir and Tom, > > Thanks for providing the background information. > > Just to verify that I got it right: there seems to be a bug related to templates in the vs2003 compiler, but we are not sure exactly what template patterns that will trigger the bug. I suspect it was templating a function which wasn't part of a class. I would guess that this would work: class MethodComparator { template int compare(C* a, C* b); }; The bug was pretty clearly a problem which how method_comparator was being generated and not how it was being used. > > Any suggestions for how to do testing if I do another change that involves templates? Running it through JPRT with -release jdk6 is the only thing I can think of. We should probably do this more regularly than we do. tom > > Thanks, > Bengt > > > On 2011-09-14 19:05, Tom Rodriguez wrote: >> On Sep 14, 2011, at 8:59 AM, Vladimir Kozlov wrote: >> >>> On 9/14/11 12:36 AM, Bengt Rutisson wrote: >>>> Hi again, >>>> >>>>> Also, how long will we be supporting vs2003? I was under the impression that we had switched to vs2010 even for JDK6. >>>>> Clearly I was wrong. Does that mean that we will keep vs2003 for the duration of JDK6 and thus implicitly have that as >>>>> a build requirement for JDK7 as long as we are using the express model? >>>> I realized that I did know about vs2003 being the compiler for JDK6. Sorry for the noise. >>>> >>>> I am still interested in understanding what templates to avoid with vs2003. >>> This is what Tom found analyzing crush: >> I'm still confused by it. It appears to think the arguments are in eax and edi which doesn't match any calling convention I can find. I guess it's just a bug. >> >> tom >> >>> On 9/13/11 9:52 AM, Tom Rodriguez wrote: >>>> I'm looking at it in the debugger and it appears to be crashing in the method_comparator in the new QuickSort code. It sort of looks like the passed in pointers are small integers instead of pointers but the array itself looks ok. maybe it's an optimizer bug? >>>> >>>> Actually I think it's a disagreement about the calling convention. The caller pushes the arguments: >>>> >>>> 080e5409 50 push eax >>>> 080e540a 51 push ecx >>>> 080e540b ff5510 call dword ptr [ebp+10h] >>>> 080e540e 83c408 add esp,8 >>>> >>>> but the callee thinks they are in registers: >>>> >>>> jvm!method_comparator: >>>> 080e78a0 8b4808 mov ecx,dword ptr [eax+8] >>>> 080e78a3 0fb74928 movzx ecx,word ptr [ecx+28h] >>>> 080e78a7 53 push ebx >>>> 080e78a8 8b5f08 mov ebx,dword ptr [edi+8 >>>> >>>> There seems to be a bit of mixing of calling convention going on in the binary, which seems very odd. >>>> >>>> tom >>> I think it is because one of template classes (C comparator) for QuickSort::sort is method type which is also template. >>> >>> Vladimir >>> >>> >>>> Thanks >>>> Bengt >>>> >>>>> >>>>> Bengt >>>>> >>>>> On 2011-09-14 01:31, Vladimir Kozlov wrote: >>>>>> http://cr.openjdk.java.net/~kvn/7090259/webrev >>>>>> >>>>>> 7090259: Fix hotspot sources to build with old compilers >>>>>> >>>>>> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() >>>>>> since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 >>>>>> Sun C++. >>>>>> >>>>>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. >>>>>> >>>>>> Thanks, >>>>>> Vladimir > From tom.rodriguez at oracle.com Wed Sep 14 12:44:23 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 12:44:23 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <4E70FABE.5080607@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <4E70E8B7.7080500@oracle.com> <1546B9CC-8C10-4DB2-BA16-1EE8FE89CF37@oracle.com> <4E70ECD7.7030702@oracle.com> <788AA7CF-D6AD-4B9C-B992-4A35D96C564E@oracle.com> <4E70FABE.5080607@oracle.com> Message-ID: That's fine with me. tom On Sep 14, 2011, at 12:04 PM, Vladimir Kozlov wrote: > I think we should remove sparc related changes since they are not complete and useless. > > Vladimir > > Tom Rodriguez wrote: >> On Sep 14, 2011, at 11:05 AM, Vladimir Kozlov wrote: >>> Tom Rodriguez wrote: >>>> On Sep 14, 2011, at 10:47 AM, Vladimir Kozlov wrote: >>>>> I looked only on changes in our current sources. >>>>> >>>>> Why change globals_sparc.hpp and not other files (as on ther platforms)? >>>> I'm not sure that you mean. globals_x86.hpp and globals_zero.hpp have the same change. >>> You changed globals_sparc.hpp but not, for example, copy_sparc.hpp as on other platforms. I don't understand why we even need change anything for sparc there are no bsd code (no new files) for sparc. >> Oh, you mean the changes aren't complete for sparc. I thought you were complaining about the actual contents of globals_sparc.hpp. There are BSD ports to most architectures, including sparc, so I suspect the changes were just forward thinking on the part of whoever originally did them. We can either leave them out or extend them. I'm fine either way. >> tom >>> Vladimir >>> >>>>> java_md.c typo? I think it sould be __linux__: >>>>> >>>>> ! #ifdef __linux >>>>> ! #if defined(__linux) >>>> Yes that looks like a preexisting bug. I'll fix it. >>>>> Remove last change in javaClasses.cpp, it is fixed. >>>> Yes I'll remove that. >>>>> In typeArrayOop.hpp only orderAccess_bsd_x86.inline.hpp and orderAccess_bsd_zero.inline.hpp are exit. Otherwise include other platforms also into bytecodeInterpreter.cpp, javaFrameAnchor.hpp, taskqueue.hpp and also in places where *_bsd_x86.hpp and *_bsd_zero.hpp are included. >>>> Some files have includes for all and other don't. I'll update it so all have the same set. This whole thing has convinced me that we should be using dispatch files. Some of the include lists are getting as long as my arm. >>>>> Christian already pointed double inclusion jvm_bsd.h in os.hpp. >>>> Yes. >>>> Thanks. >>>> tom >>>>> Vladimir >>>>> >>>>> Tom Rodriguez wrote: >>>>>> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >>>>>> http://cr.openjdk.java.net/~never/7089790_full >>>>>> http://cr.openjdk.java.net/~never/7089790_headers_only >>>>>> http://cr.openjdk.java.net/~never/7089790_shared >>>>>> http://cr.openjdk.java.net/~never/7089790_bsd_only >>>>>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >>>>>> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >>>>>> Relative to the original webrev, these are the changes I made: >>>>>> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >>>>>> Fixed a few more printing mismatches. >>>>>> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >>>>>> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >>>>>> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >>>>>> tom >>>>>> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >>>>>>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>>>>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>>>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>>>>>> >>>>>>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>>>>>> >>>>>>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>>>>>> can run it on. >>>>>>>>> Hi Greg, >>>>>>>>> >>>>>>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>>>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>>>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>>>>>> search I used: >>>>>>>>> >>>>>>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>>>>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>>>>>> different things, including code designed to produce I/O and CPU load >>>>>>>> across a thread pool and I haven't been able to produce any problems. >>>>>>>> >>>>>>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>>>>>> does look like we can get off of the UseMemBar setting. >>>>>>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>>>>>> some testing on Mac OS/X MP to confirm there's no problem there too. >>>>>>> >>>>>>> Thanks, >>>>>>> -Kurt From bengt.rutisson at oracle.com Wed Sep 14 12:55:47 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 14 Sep 2011 21:55:47 +0200 Subject: Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers In-Reply-To: References: <4E6FE7EF.9050008@oracle.com> <4E704AC3.5050805@oracle.com> <4E70596E.6090507@oracle.com> <4E70CF7F.6060300@oracle.com> <20CDC09E-FDE7-45B5-B930-88122D3C6F85@oracle.com> <4E7101AB.4000800@oracle.com> Message-ID: <4E7106C3.2000606@oracle.com> Tom, On 2011-09-14 21:44, Tom Rodriguez wrote: > On Sep 14, 2011, at 12:34 PM, Bengt Rutisson wrote: > >> Vladimir and Tom, >> >> Thanks for providing the background information. >> >> Just to verify that I got it right: there seems to be a bug related to templates in the vs2003 compiler, but we are not sure exactly what template patterns that will trigger the bug. > I suspect it was templating a function which wasn't part of a class. I would guess that this would work: > > class MethodComparator { > template int compare(C* a, C* b); > }; > > The bug was pretty clearly a problem which how method_comparator was being generated and not how it was being used. Thanks! This was exactly the kind of information I was looking for. >> Any suggestions for how to do testing if I do another change that involves templates? > Running it through JPRT with -release jdk6 is the only thing I can think of. We should probably do this more regularly than we do. Ok. I'll do that next time. Thanks, Bengt > tom > >> Thanks, >> Bengt >> >> >> On 2011-09-14 19:05, Tom Rodriguez wrote: >>> On Sep 14, 2011, at 8:59 AM, Vladimir Kozlov wrote: >>> >>>> On 9/14/11 12:36 AM, Bengt Rutisson wrote: >>>>> Hi again, >>>>> >>>>>> Also, how long will we be supporting vs2003? I was under the impression that we had switched to vs2010 even for JDK6. >>>>>> Clearly I was wrong. Does that mean that we will keep vs2003 for the duration of JDK6 and thus implicitly have that as >>>>>> a build requirement for JDK7 as long as we are using the express model? >>>>> I realized that I did know about vs2003 being the compiler for JDK6. Sorry for the noise. >>>>> >>>>> I am still interested in understanding what templates to avoid with vs2003. >>>> This is what Tom found analyzing crush: >>> I'm still confused by it. It appears to think the arguments are in eax and edi which doesn't match any calling convention I can find. I guess it's just a bug. >>> >>> tom >>> >>>> On 9/13/11 9:52 AM, Tom Rodriguez wrote: >>>>> I'm looking at it in the debugger and it appears to be crashing in the method_comparator in the new QuickSort code. It sort of looks like the passed in pointers are small integers instead of pointers but the array itself looks ok. maybe it's an optimizer bug? >>>>> >>>>> Actually I think it's a disagreement about the calling convention. The caller pushes the arguments: >>>>> >>>>> 080e5409 50 push eax >>>>> 080e540a 51 push ecx >>>>> 080e540b ff5510 call dword ptr [ebp+10h] >>>>> 080e540e 83c408 add esp,8 >>>>> >>>>> but the callee thinks they are in registers: >>>>> >>>>> jvm!method_comparator: >>>>> 080e78a0 8b4808 mov ecx,dword ptr [eax+8] >>>>> 080e78a3 0fb74928 movzx ecx,word ptr [ecx+28h] >>>>> 080e78a7 53 push ebx >>>>> 080e78a8 8b5f08 mov ebx,dword ptr [edi+8 >>>>> >>>>> There seems to be a bit of mixing of calling convention going on in the binary, which seems very odd. >>>>> >>>>> tom >>>> I think it is because one of template classes (C comparator) for QuickSort::sort is method type which is also template. >>>> >>>> Vladimir >>>> >>>> >>>>> Thanks >>>>> Bengt >>>>> >>>>>> Bengt >>>>>> >>>>>> On 2011-09-14 01:31, Vladimir Kozlov wrote: >>>>>>> http://cr.openjdk.java.net/~kvn/7090259/webrev >>>>>>> >>>>>>> 7090259: Fix hotspot sources to build with old compilers >>>>>>> >>>>>>> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() >>>>>>> since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 >>>>>>> Sun C++. >>>>>>> >>>>>>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there. >>>>>>> >>>>>>> Thanks, >>>>>>> Vladimir From tom.rodriguez at oracle.com Wed Sep 14 13:16:54 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 13:16:54 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> Message-ID: <297568D0-983B-4385-A597-AD41F0227F99@oracle.com> On Sep 14, 2011, at 11:48 AM, roger hoover wrote: > > On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >> >> I sent you separate mail privately about the contributors from the BSD >> port side. Roger, can you please provide a list of the contributors from >> the team at Apple? > > Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. Keep in mind that this changeset is just bsd-port with a few minor changes cherry picked from the mac os port repo. tom > > roger > From tom.rodriguez at oracle.com Wed Sep 14 13:21:00 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 13:21:00 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <201109141523.20334.kurt@intricatesoftware.com> References: <201108021234.30179.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <201109141523.20334.kurt@intricatesoftware.com> Message-ID: <0605D11B-E691-480F-9314-49D5460DE04E@oracle.com> On Sep 14, 2011, at 12:23 PM, Kurt Miller wrote: > On Wednesday 14 September 2011 02:44:59 pm Greg Lewis wrote: >> G'day Tom, >> >> On Tue, Sep 13, 2011 at 02:18:15PM -0700, Tom Rodriguez wrote: >>> I've finally prepared a set of changes against the latest hotspot-comp >>> with the bsd-port changes. They compile on all our supported platforms >>> with the jdk7 and jdk6 tools and I also built on Snow Leopard and >>> incorporated a few extra changes there to make it all compile. >>> I've prepared several webrevs to ease reviewing. >>> >>> http://cr.openjdk.java.net/~never/7089790_full >>> http://cr.openjdk.java.net/~never/7089790_headers_only >>> http://cr.openjdk.java.net/~never/7089790_shared >>> http://cr.openjdk.java.net/~never/7089790_bsd_only >>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >>> >> [snip] >>> >>> Who all should I mark as the contributors for these changes? Roger, >>> Greg and Kurt? If you could take a copy of the bits and confirm that I >>> haven't introduced any issues on BSD that would be greatly appreciated. >>> Thanks for your patience. >> >> Built and lightly tested on FreeBSD. Looks good from that perspective. > > Same here on OpenBSD. Builds fine and it is able to boostrap the next build. Great! Thanks for the testing. tom > > Thanks, > -Kurt From tom.rodriguez at oracle.com Wed Sep 14 13:21:46 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 13:21:46 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> Message-ID: On Sep 14, 2011, at 6:28 AM, Christian Thalinger wrote: > > On Sep 14, 2011, at 12:32 AM, Tom Rodriguez wrote: > >> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. > > I did builds on Lion and everything looks good. Thanks. > >> >> http://cr.openjdk.java.net/~never/7089790_full > > That's too huge to review. The only thing I needed on my Mac OS X was this change: > > 75 # amd64 > 76 ifneq (,$(findstring $(ARCH), amd64 x86_64)) > > taken from: > > http://hg.openjdk.java.net/macosx-port/macosx-port/hotspot/file/a00aa3dd9244/make/bsd/makefiles/defs.make Added. > >> http://cr.openjdk.java.net/~never/7089790_headers_only > > src/share/vm/runtime/os.hpp: > > + #ifdef TARGET_OS_FAMILY_bsd > + # include "jvm_bsd.h" > + #endif > > This is included twice. Fixed. > >> >> http://cr.openjdk.java.net/~never/7089790_shared > > Looks good. > >> http://cr.openjdk.java.net/~never/7089790_bsd_only > > This one is empty(?). Pilot error. It's there now. > >> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux > > src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp: > > ! // HACK: si_code does not work on linux 2.2.12-20!!! > ! // HACK: si_code does not work on bsd 2.2.12-20!!! I don't think I want to fix things like that. They just make the code diverge. > > I doubt there is a bsd 2.2.12 kernel :-) Seriously, I suppose si_code does work on BSD? > > src/os_cpu/bsd_x86/vm/bsd_x86_32.s: > src/os_cpu/bsd_x86/vm/bsd_x86_64.s: > > + #ifdef __APPLE__ > + .align 4 > + #else > .align 16 > + #endif > > Maybe we should use a ALIGN macro instead. Maybe. I'm not sure I even understand the purpose of the change. It seems pretty spurious. > > src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp > > + #ifndef _ALLBSD_SOURCE > #include > + #endif > > + #ifdef __APPLE__ > + #include > + #endif > + > + #if defined(AMD64) > + # if defined(__APPLE__) > + # define bswap_16(x) OSSwapInt16(x) > + # define bswap_32(x) OSSwapInt32(x) > + # define bswap_64(x) OSSwapInt64(x) > + # elif defined(__OpenBSD__) > + # define bswap_16(x) swap16(x) > + # define bswap_32(x) swap32(x) > + # define bswap_64(x) swap64(x) > + # elif defined(__NetBSD__) > + # define bswap_16(x) bswap16(x) > + # define bswap_32(x) bswap32(x) > + # define bswap_64(x) bswap64(x) > + # else > + # define bswap_16(x) __bswap16(x) > + # define bswap_32(x) __bswap32(x) > + # define bswap_64(x) __bswap64(x) > + # endif > + #endif > > src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp: > > - #include > + #ifdef __APPLE__ > + #include > + #define bswap16(x) OSSwapInt16(x) > + #define bswap32(x) OSSwapInt32(x) > + #define bswap64(x) OSSwapInt64(x) > + #else > + # include > + #endif > > Why is byteswap.h removed from bytes_bsd_zero but sys/endian.h is used for !APPLE? bytes_bsd_x86 does something different. Someone else will have to answer that question. > > src/os/bsd/vm/os_bsd.cpp: > > ! julong os::Bsd::available_memory() { > + #ifdef _ALLBSD_SOURCE > + // XXXBSD: this is just a stopgap implementation > + return physical_memory() >> 2; > + #else > > Is this going to be fixed anytime soon? > > + // This work-around is not necessary for 10.5+, as CrashReporter no longer intercedes > + // on caught fatal signals. > > Should we check the Mac OS X version here and not do the workaround if >= 10.5? I would prefer if these kinds of things were ironed out in a later set of changes. Maybe that's something we should file a bug for, though I'm not quite sure what to use. > > Generally there are a couple of linux -> bsd renames like: > > ! // thread has a unique thread_id (LinuxThreads or NPTL). It can be used > ! // thread has a unique thread_id (BsdThreads or NPTL). It can be used > > which are wrong but I think it doesn't matter. But someone will have to deal with that when merging linux/bsd/solaris to posix. Yup. Thanks! tom > > -- Christian > >> >> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >> >> Relative to the original webrev, these are the changes I made: >> >> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >> >> Fixed a few more printing mismatches. >> >> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >> >> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >> >> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >> >> tom >> >> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >> >>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>> >>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>> >>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>> >>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>> >>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>> can run it on. >>>>> >>>>> Hi Greg, >>>>> >>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>> search I used: >>>>> >>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>> >>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>> different things, including code designed to produce I/O and CPU load >>>> across a thread pool and I haven't been able to produce any problems. >>>> >>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>> does look like we can get off of the UseMemBar setting. >>> >>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>> some testing on Mac OS/X MP to confirm there's no problem there too. >>> >>> Thanks, >>> -Kurt >> > From christian.thalinger at oracle.com Wed Sep 14 13:38:24 2011 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Wed, 14 Sep 2011 22:38:24 +0200 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> Message-ID: <51610B3B-6467-4A5A-85F4-1C287BBE2DC7@oracle.com> On Sep 14, 2011, at 10:21 PM, Tom Rodriguez wrote: > > On Sep 14, 2011, at 6:28 AM, Christian Thalinger wrote: > >> >> On Sep 14, 2011, at 12:32 AM, Tom Rodriguez wrote: >> >>> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >> >> I did builds on Lion and everything looks good. > > Thanks. > >> >>> >>> http://cr.openjdk.java.net/~never/7089790_full >> >> That's too huge to review. The only thing I needed on my Mac OS X was this change: >> >> 75 # amd64 >> 76 ifneq (,$(findstring $(ARCH), amd64 x86_64)) >> >> taken from: >> >> http://hg.openjdk.java.net/macosx-port/macosx-port/hotspot/file/a00aa3dd9244/make/bsd/makefiles/defs.make > > Added. > >> >>> http://cr.openjdk.java.net/~never/7089790_headers_only >> >> src/share/vm/runtime/os.hpp: >> >> + #ifdef TARGET_OS_FAMILY_bsd >> + # include "jvm_bsd.h" >> + #endif >> >> This is included twice. > > Fixed. > >> >>> >>> http://cr.openjdk.java.net/~never/7089790_shared >> >> Looks good. >> >>> http://cr.openjdk.java.net/~never/7089790_bsd_only >> >> This one is empty(?). > > Pilot error. It's there now. > >> >>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >> >> src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp: >> >> ! // HACK: si_code does not work on linux 2.2.12-20!!! >> ! // HACK: si_code does not work on bsd 2.2.12-20!!! > > I don't think I want to fix things like that. They just make the code diverge. > >> >> I doubt there is a bsd 2.2.12 kernel :-) Seriously, I suppose si_code does work on BSD? >> >> src/os_cpu/bsd_x86/vm/bsd_x86_32.s: >> src/os_cpu/bsd_x86/vm/bsd_x86_64.s: >> >> + #ifdef __APPLE__ >> + .align 4 >> + #else >> .align 16 >> + #endif >> >> Maybe we should use a ALIGN macro instead. > > Maybe. I'm not sure I even understand the purpose of the change. It seems pretty spurious. > >> >> src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp >> >> + #ifndef _ALLBSD_SOURCE >> #include >> + #endif >> >> + #ifdef __APPLE__ >> + #include >> + #endif >> + >> + #if defined(AMD64) >> + # if defined(__APPLE__) >> + # define bswap_16(x) OSSwapInt16(x) >> + # define bswap_32(x) OSSwapInt32(x) >> + # define bswap_64(x) OSSwapInt64(x) >> + # elif defined(__OpenBSD__) >> + # define bswap_16(x) swap16(x) >> + # define bswap_32(x) swap32(x) >> + # define bswap_64(x) swap64(x) >> + # elif defined(__NetBSD__) >> + # define bswap_16(x) bswap16(x) >> + # define bswap_32(x) bswap32(x) >> + # define bswap_64(x) bswap64(x) >> + # else >> + # define bswap_16(x) __bswap16(x) >> + # define bswap_32(x) __bswap32(x) >> + # define bswap_64(x) __bswap64(x) >> + # endif >> + #endif >> >> src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp: >> >> - #include >> + #ifdef __APPLE__ >> + #include >> + #define bswap16(x) OSSwapInt16(x) >> + #define bswap32(x) OSSwapInt32(x) >> + #define bswap64(x) OSSwapInt64(x) >> + #else >> + # include >> + #endif >> >> Why is byteswap.h removed from bytes_bsd_zero but sys/endian.h is used for !APPLE? bytes_bsd_x86 does something different. > > Someone else will have to answer that question. Sure. Actually all the detailed questions were heading to the people who wrote that code. I did not expect an answer from you. -- Christian > >> >> src/os/bsd/vm/os_bsd.cpp: >> >> ! julong os::Bsd::available_memory() { >> + #ifdef _ALLBSD_SOURCE >> + // XXXBSD: this is just a stopgap implementation >> + return physical_memory() >> 2; >> + #else >> >> Is this going to be fixed anytime soon? >> >> + // This work-around is not necessary for 10.5+, as CrashReporter no longer intercedes >> + // on caught fatal signals. >> >> Should we check the Mac OS X version here and not do the workaround if >= 10.5? > > I would prefer if these kinds of things were ironed out in a later set of changes. Maybe that's something we should file a bug for, though I'm not quite sure what to use. > >> >> Generally there are a couple of linux -> bsd renames like: >> >> ! // thread has a unique thread_id (LinuxThreads or NPTL). It can be used >> ! // thread has a unique thread_id (BsdThreads or NPTL). It can be used >> >> which are wrong but I think it doesn't matter. But someone will have to deal with that when merging linux/bsd/solaris to posix. > > Yup. > > Thanks! > > tom > >> >> -- Christian >> >>> >>> full is a regular webrev of the full set of changes. header_only is just include changes in shared code, shared are the actual changes to shared code, bsd_only are the src/os/bsd and src/os_cpu/bsd_* changes and bsd_vs_linux is webrev comparing the bsd sources against the current linux sources. The shared changed are about 460 lines and the bsd_vs_linux changes are about 2600 so it's really not that large. The duplication of the linux code in bsd makes it seem quite large and hopefully we can address that once the Mac port gets into full swing. >>> >>> Relative to the original webrev, these are the changes I made: >>> >>> Made the needed changes on solaris and windows to use the PRI* macros for globalDefinitions. I confirmed that the current definitions are the same as the old definitions so nothing should change printing-wise with existing builds. >>> >>> Fixed a few more printing mismatches. >>> >>> Eliminated the inclusion on elf.h and modified the decoder support on apple to indicate that it doesn't currently support decoding within the JVM. >>> >>> I'm assuming that we'll leave in the UseMembar changes and the hack for $ORIGIN until those issues are fully resolved. >>> >>> Who all should I mark as the contributors for these changes? Roger, Greg and Kurt? If you could take a copy of the bits and confirm that I haven't introduced any issues on BSD that would be greatly appreciated. Thanks for your patience. >>> >>> tom >>> >>> On Aug 31, 2011, at 11:23 AM, Kurt Miller wrote: >>> >>>> On Wednesday 31 August 2011 11:30:45 am Greg Lewis wrote: >>>>> On Wed, Aug 03, 2011 at 11:24:22AM -0400, Kurt Miller wrote: >>>>>> On Wednesday 03 August 2011 01:41:01 am Greg Lewis wrote: >>>>>>> On Tue, Aug 02, 2011 at 05:18:17PM -0400, Kurt Miller wrote: >>>>>>>> On Tuesday 02 August 2011 08:47:39 am Tom Rodriguez wrote: >>>>>>>>> What are the UseMembar changes about? They are fine, I'm curious why they are needed. I believe !UseMembar is more efficient. >>>>>>>> >>>>>>>> In the 1.5 update time-frame Sun was working on changing UseMembar from default true to false. When I intergrated this change into FreeBSD's port we started hitting intermittant segfaults that I debugged and traced back to the UseMembar setting change. Since releasing stable certified binaries quickly was one of the goals, I reverted the UseMembar default back to true instead of taking time to find the root cause. More details can be found in the freebsd-port thread below. >>>>>>>> >>>>>>>> http://markmail.org/message/rigdtb5heiliutec >>>>>>>> >>>>>>>> IIRC, when I worked on porting BSD hotspot support to 1.6 I tried setting UseMembar default to off/false and it still caused intermittant segfaults. Although, I don't recall if I checked this again with OpenJDK7 on FreeBSD SMP systems. >>>>>>> >>>>>>> Do we have a test case that shows this up? I have a FreeBSD SMP system I >>>>>>> can run it on. >>>>>> >>>>>> Hi Greg, >>>>>> >>>>>> Refreshing my memory by reading the freebsd-java list for this time-frame >>>>>> and I see that it was rather easy to reproduce on SMP hardware. Reports >>>>>> included using tomcat, netbeans and in one case 'java -version'. Here's the >>>>>> search I used: >>>>>> >>>>>> http://markmail.org/search/list:org%2Efreebsd%2Efreebsd-java+sigbus+diablo+1%2E5%2E0_06 >>>>> >>>>> I've tried setting UseMemBar to false and ran the resulting JDK on a few >>>>> different things, including code designed to produce I/O and CPU load >>>>> across a thread pool and I haven't been able to produce any problems. >>>>> >>>>> I didn't try with Tomcat and I tried Eclipse rather than Netbeans, but it >>>>> does look like we can get off of the UseMemBar setting. >>>> >>>> That's great. OpenBSD will work with it set to false too. Perhaps we should get >>>> some testing on Mac OS/X MP to confirm there's no problem there too. >>>> >>>> Thanks, >>>> -Kurt >>> >> > From landonf at plausible.coop Wed Sep 14 13:39:14 2011 From: landonf at plausible.coop (Landon Fuller) Date: Wed, 14 Sep 2011 16:39:14 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> Message-ID: On Sep 14, 2011, at 4:21 PM, Tom Rodriguez wrote: >> >> >>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >> >> src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp: >> >> ! // HACK: si_code does not work on linux 2.2.12-20!!! >> ! // HACK: si_code does not work on bsd 2.2.12-20!!! > > I don't think I want to fix things like that. They just make the code diverge. > >> >> I doubt there is a bsd 2.2.12 kernel :-) Seriously, I suppose si_code does work on BSD? The s/linux/bsd/ issue aside, si_code is not set on SIGFPE for <= 10.6. I believe this was fixed in 10.7, but the Apple guys can confirm (tracked by rdar://4428508 ?). >> src/os_cpu/bsd_x86/vm/bsd_x86_32.s: >> src/os_cpu/bsd_x86/vm/bsd_x86_64.s: >> >> + #ifdef __APPLE__ >> + .align 4 >> + #else >> .align 16 >> + #endif >> >> Maybe we should use a ALIGN macro instead. > > Maybe. I'm not sure I even understand the purpose of the change. It seems pretty spurious. IIRC, Apple's assembler .align directive takes a power of two -- i.e., .align 4^2 -landonf From tom.rodriguez at oracle.com Wed Sep 14 13:54:28 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 13:54:28 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> Message-ID: <75C3F78A-0D76-4E26-8FAB-B4A16D2F3720@oracle.com> On Sep 14, 2011, at 1:39 PM, Landon Fuller wrote: > > On Sep 14, 2011, at 4:21 PM, Tom Rodriguez wrote: > >>> >>> >>>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >>> >>> src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp: >>> >>> ! // HACK: si_code does not work on linux 2.2.12-20!!! >>> ! // HACK: si_code does not work on bsd 2.2.12-20!!! >> >> I don't think I want to fix things like that. They just make the code diverge. >> >>> >>> I doubt there is a bsd 2.2.12 kernel :-) Seriously, I suppose si_code does work on BSD? > > The s/linux/bsd/ issue aside, si_code is not set on SIGFPE for <= 10.6. > > I believe this was fixed in 10.7, but the Apple guys can confirm (tracked by rdar://4428508 ?). > >>> src/os_cpu/bsd_x86/vm/bsd_x86_32.s: >>> src/os_cpu/bsd_x86/vm/bsd_x86_64.s: >>> >>> + #ifdef __APPLE__ >>> + .align 4 >>> + #else >>> .align 16 >>> + #endif >>> >>> Maybe we should use a ALIGN macro instead. >> >> Maybe. I'm not sure I even understand the purpose of the change. It seems pretty spurious. > > IIRC, Apple's assembler .align directive takes a power of two -- i.e., .align 4^2 Ok. Why isn't it just using p2align which appears to have exactly the same meaning? And why is the second one needed since the next function starts with p2align 4? Why would BSD want 16^2 alignment anyway? diff -r 9b3694fcfe94 src/os_cpu/bsd_x86/vm/bsd_x86_32.s --- a/src/os_cpu/bsd_x86/vm/bsd_x86_32.s +++ b/src/os_cpu/bsd_x86/vm/bsd_x86_32.s @@ -56,23 +56,13 @@ # Support for void os::Solaris::init_thread_fpu_state() in os_solaris_i486.cpp # Set fpu to 53 bit precision. This happens too early to use a stub. # ported from solaris_x86_32.s -#ifdef __APPLE__ - .align 4 -#else - .align 16 -#endif + .p2align 4,,15 SYMBOL(fixcw): pushl $0x27f fldcw 0(%esp) popl %eax ret -#ifdef __APPLE__ - .align 4 -#else - .align 16 -#endif - .globl SYMBOL(SafeFetch32), SYMBOL(Fetch32PFI), SYMBOL(Fetch32Resume) .globl SYMBOL(SafeFetchN) ## TODO: avoid exposing Fetch32PFI and Fetch32Resume. tom > > -landonf From landonf at plausible.coop Wed Sep 14 14:24:13 2011 From: landonf at plausible.coop (Landon Fuller) Date: Wed, 14 Sep 2011 17:24:13 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <75C3F78A-0D76-4E26-8FAB-B4A16D2F3720@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> <75C3F78A-0D76-4E26-8FAB-B4A16D2F3720@oracle.com> Message-ID: <05CE5071-2644-4B8B-97BA-61879E0A2CC7@plausible.coop> On Sep 14, 2011, at 4:54 PM, Tom Rodriguez wrote: > > On Sep 14, 2011, at 1:39 PM, Landon Fuller wrote: > >> >> On Sep 14, 2011, at 4:21 PM, Tom Rodriguez wrote: >> >>>> >>>> >>>>> http://cr.openjdk.java.net/~never/7089790_bsd_vs_linux >>>> >>>> src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp: >>>> >>>> ! // HACK: si_code does not work on linux 2.2.12-20!!! >>>> ! // HACK: si_code does not work on bsd 2.2.12-20!!! >>> >>> I don't think I want to fix things like that. They just make the code diverge. >>> >>>> >>>> I doubt there is a bsd 2.2.12 kernel :-) Seriously, I suppose si_code does work on BSD? >> >> The s/linux/bsd/ issue aside, si_code is not set on SIGFPE for <= 10.6. >> >> I believe this was fixed in 10.7, but the Apple guys can confirm (tracked by rdar://4428508 ?). >> >>>> src/os_cpu/bsd_x86/vm/bsd_x86_32.s: >>>> src/os_cpu/bsd_x86/vm/bsd_x86_64.s: >>>> >>>> + #ifdef __APPLE__ >>>> + .align 4 >>>> + #else >>>> .align 16 >>>> + #endif >>>> >>>> Maybe we should use a ALIGN macro instead. >>> >>> Maybe. I'm not sure I even understand the purpose of the change. It seems pretty spurious. >> >> IIRC, Apple's assembler .align directive takes a power of two -- i.e., .align 4^2 > > Ok. Why isn't it just using p2align which appears to have exactly the same meaning? I don't see any reason not to use p2align. I believe the original intent (3+ years ago, my memory is hazy) was only to call out the Apple changes more explicitly. > And why is the second one needed since the next function starts with p2align 4? Ah -- I hadn't seen the context. Then yes, it's spurious. The duplicate may be a merge artifact, and other instances could simply be replaced. > Why would BSD want 16^2 alignment anyway? Apple is unique in its handling of .align. Cheers, -landonf From tom.rodriguez at oracle.com Wed Sep 14 14:33:54 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 14 Sep 2011 14:33:54 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <05CE5071-2644-4B8B-97BA-61879E0A2CC7@plausible.coop> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> <75C3F78A-0D76-4E26-8FAB-B4A16D2F3720@oracle.com> <05CE5071-2644-4B8B-97BA-61879E0A2CC7@plausible.coop> Message-ID: >>> >>>>> src/os_cpu/bsd_x86/vm/bsd_x86_32.s: >>>>> src/os_cpu/bsd_x86/vm/bsd_x86_64.s: >>>>> >>>>> + #ifdef __APPLE__ >>>>> + .align 4 >>>>> + #else >>>>> .align 16 >>>>> + #endif >>>>> >>>>> Maybe we should use a ALIGN macro instead. >>>> >>>> Maybe. I'm not sure I even understand the purpose of the change. It seems pretty spurious. >>> >>> IIRC, Apple's assembler .align directive takes a power of two -- i.e., .align 4^2 >> >> Ok. Why isn't it just using p2align which appears to have exactly the same meaning? > > I don't see any reason not to use p2align. I believe the original intent (3+ years ago, my memory is hazy) was only to call out the Apple changes more explicitly. > >> And why is the second one needed since the next function starts with p2align 4? > > Ah -- I hadn't seen the context. Then yes, it's spurious. The duplicate may be a merge artifact, and other instances could simply be replaced. > >> Why would BSD want 16^2 alignment anyway? > > Apple is unique in its handling of .align. I realized that afterwards. I'll shift the code to use p2align uniformly since that will do the right thing everywhere. tom > > Cheers, > -landonf > From swingler at apple.com Wed Sep 14 15:29:02 2011 From: swingler at apple.com (Mike Swingler) Date: Wed, 14 Sep 2011 15:29:02 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> Message-ID: <26026AD5-7AAA-4461-805D-6486204C1D1F@apple.com> On Sep 14, 2011, at 1:39 PM, Landon Fuller wrote: > I believe this was fixed in 10.7, but the Apple guys can confirm (tracked byrdar://4428508 ?). Underimplemented SIGFPE codes was fixed in Snow Leopard 10.6.0 GM. Regards, Mike Swingler Java Engineering Apple Inc. From kurt at intricatesoftware.com Wed Sep 14 19:45:46 2011 From: kurt at intricatesoftware.com (Kurt Miller) Date: Wed, 14 Sep 2011 22:45:46 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <51610B3B-6467-4A5A-85F4-1C287BBE2DC7@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94310126-7E27-40FF-BE44-15D5A635F9BF@oracle.com> <51610B3B-6467-4A5A-85F4-1C287BBE2DC7@oracle.com> Message-ID: <4E7166DA.9020605@intricatesoftware.com> On 9/14/11 4:38 PM, Christian Thalinger wrote: > On Sep 14, 2011, at 10:21 PM, Tom Rodriguez wrote: >> On Sep 14, 2011, at 6:28 AM, Christian Thalinger wrote: >>> src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp >>> >>> + #ifndef _ALLBSD_SOURCE >>> #include >>> + #endif byteswap doesn't exist on bsd (Checked Mac OS X 10.5, OpenBSD 5.0 and FreeBSD 7.0). Instead of ifndef _ALLBSD_SOURCE this should just be deleted since this is already a bsd only file. I went a little overboard with the ifdef/ifndef approach to minimize the differences between linux and bsd to help with merges. >>> + #ifdef __APPLE__ >>> + #include >>> + #endif >>> + >>> + #if defined(AMD64) >>> + # if defined(__APPLE__) >>> + # define bswap_16(x) OSSwapInt16(x) >>> + # define bswap_32(x) OSSwapInt32(x) >>> + # define bswap_64(x) OSSwapInt64(x) >>> + # elif defined(__OpenBSD__) >>> + # define bswap_16(x) swap16(x) >>> + # define bswap_32(x) swap32(x) >>> + # define bswap_64(x) swap64(x) >>> + # elif defined(__NetBSD__) >>> + # define bswap_16(x) bswap16(x) >>> + # define bswap_32(x) bswap32(x) >>> + # define bswap_64(x) bswap64(x) >>> + # else >>> + # define bswap_16(x) __bswap16(x) >>> + # define bswap_32(x) __bswap32(x) >>> + # define bswap_64(x) __bswap64(x) >>> + # endif >>> + #endif >>> >>> src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp: >>> >>> - #include >>> + #ifdef __APPLE__ >>> + #include >>> + #define bswap16(x) OSSwapInt16(x) >>> + #define bswap32(x) OSSwapInt32(x) >>> + #define bswap64(x) OSSwapInt64(x) >>> + #else >>> + # include >>> + #endif >>> >>> Why is byteswap.h removed from bytes_bsd_zero but sys/endian.h is used for !APPLE? bytes_bsd_x86 does something different. byteswap.h is remove from both. sys/endian.h is how the BSD's get the bswap* definitions, except APPLE which gets them from libkern/OSByteOrder.h. It looks like this is different because zero support has been tested on APPLE and FreeBSD. I the zero file will need to end up with this block too: + # if defined(__APPLE__) + # define bswap_16(x) OSSwapInt16(x) + # define bswap_32(x) OSSwapInt32(x) + # define bswap_64(x) OSSwapInt64(x) + # elif defined(__OpenBSD__) + # define bswap_16(x) swap16(x) + # define bswap_32(x) swap32(x) + # define bswap_64(x) swap64(x) + # elif defined(__NetBSD__) + # define bswap_16(x) bswap16(x) + # define bswap_32(x) bswap32(x) + # define bswap_64(x) bswap64(x) + # else + # define bswap_16(x) __bswap16(x) + # define bswap_32(x) __bswap32(x) + # define bswap_64(x) __bswap64(x) + # endif and the rest of the file changed to use the bswap_NN() versions of the definitions to have full support. Regards, -Kurt From stefan.karlsson at oracle.com Thu Sep 15 12:40:39 2011 From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com) Date: Thu, 15 Sep 2011 19:40:39 +0000 Subject: hg: hsx/hotspot-main/hotspot: 3 new changesets Message-ID: <20110915194044.E24BC476F8@hg.openjdk.java.net> Changeset: f1b4e0e0bdad Author: tonyp Date: 2011-09-13 12:40 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f1b4e0e0bdad 7089625: G1: policy for how many old regions to add to the CSet (when young gen is fixed) is broken Summary: When refactoring the code for a previous fix, a condition was not correctly negated which prevents the G1 policy from adding the correct number of old regions to the CSet when the young gen size is fixed. The changeset also fixes a small syntactical issue in g1ErgoVerbose.hpp which is causing compiler warnings. Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp Changeset: 0a63380c8ac8 Author: iveresov Date: 2011-09-13 16:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0a63380c8ac8 7090069: Java launcher hangs in infinite loop on windows when UseNUMA[Interleaving] is specified Summary: Fix _numa_used_node_list array size specification Reviewed-by: kvn, johnc, jmasa, ysr ! src/os/windows/vm/os_windows.cpp Changeset: f94227b6117b Author: kvn Date: 2011-09-13 20:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f94227b6117b 7090259: Fix hotspot sources to build with old compilers Summary: Fixed warnings which prevent building VM with old compilers. Reviewed-by: never ! make/solaris/makefiles/sparcWorks.make ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/opto/block.cpp From igor.veresov at oracle.com Thu Sep 15 14:52:13 2011 From: igor.veresov at oracle.com (igor.veresov at oracle.com) Date: Thu, 15 Sep 2011 21:52:13 +0000 Subject: hg: hsx/hotspot-main/hotspot: 16 new changesets Message-ID: <20110915215246.4B24D47700@hg.openjdk.java.net> Changeset: da6a29fb0da5 Author: kvn Date: 2011-09-07 12:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/da6a29fb0da5 7054211: No loop unrolling done in jdk7b144 for a test update() while loop Summary: restore unrolling code for CaffeineMark. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp Changeset: 5432047c7db7 Author: bdelsart Date: 2011-09-08 10:12 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5432047c7db7 7087445: Improve platform independence of JSR292 shared code Summary: changes necessary for some JSR292 ports Reviewed-by: jrose, dholmes ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/zero/vm/frame_zero.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/frame.hpp Changeset: b0efc7ee3b31 Author: twisti Date: 2011-09-08 05:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b0efc7ee3b31 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/klassOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/prims/methodHandles.cpp Changeset: fdcb1e828d53 Author: kvn Date: 2011-09-08 12:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/fdcb1e828d53 7087947: Add regression test for 7068051 Summary: Add regression test. Reviewed-by: never + test/compiler/7068051/Test7068051.java + test/compiler/7068051/Test7068051.sh Changeset: 8f47d8870d9a Author: roland Date: 2011-09-08 09:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8f47d8870d9a 7087453: PhaseChaitin::yank_if_dead() should handle MachTemp inputs Summary: PhaseChaitin::yank_if_dead() should be able to handle MachTemp inputs as a special case and yank them. Reviewed-by: never, kvn ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/postaloc.cpp Changeset: 5257f8e66b40 Author: iveresov Date: 2011-09-09 12:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5257f8e66b40 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 2c24ef16533d Author: kvn Date: 2011-09-09 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64 Summary: Revert changes which caused regression. Reviewed-by: never ! src/share/vm/opto/loopnode.cpp Changeset: c565834fb592 Author: never Date: 2011-09-10 00:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c565834fb592 7088020: SEGV in JNIHandleBlock::release_block Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp + test/compiler/7088020/Test7088020.java Changeset: e6b1331a51d2 Author: never Date: 2011-09-10 17:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e6b1331a51d2 7086585: make Java field injection more flexible Reviewed-by: jrose, twisti, kvn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/java_lang_Class.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/SOQL.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/test/jdi/sasanity.sh ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/cpCacheOop.cpp + src/share/vm/oops/fieldInfo.hpp + src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: f6f3bb0ee072 Author: never Date: 2011-09-11 14:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f6f3bb0ee072 7088955: add C2 IR support to the SA Reviewed-by: kvn ! agent/make/Makefile ! agent/make/saenv.sh ! agent/make/saenv64.sh ! agent/src/os/solaris/Makefile - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp ! agent/src/share/classes/sun/jvm/hotspot/CLHSDB.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/DebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciConstant.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciField.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstance.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodData.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObject.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjectFactory.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciReceiverTypeData.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciSymbol.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciType.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciVirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java + agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/AddressException.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/SADebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/VirtualMachineImpl.java + agent/src/share/classes/sun/jvm/hotspot/oops/ArrayData.java + agent/src/share/classes/sun/jvm/hotspot/oops/BitData.java + agent/src/share/classes/sun/jvm/hotspot/oops/BranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/CIntField.java + agent/src/share/classes/sun/jvm/hotspot/oops/CounterData.java + agent/src/share/classes/sun/jvm/hotspot/oops/DataLayout.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/FieldType.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/oops/JumpData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java + agent/src/share/classes/sun/jvm/hotspot/oops/MultiBranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopUtilities.java + agent/src/share/classes/sun/jvm/hotspot/oops/ProfileData.java + agent/src/share/classes/sun/jvm/hotspot/oops/ReceiverTypeData.java + agent/src/share/classes/sun/jvm/hotspot/oops/RetData.java + agent/src/share/classes/sun/jvm/hotspot/oops/VirtualCallData.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block_Array.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block_List.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallDynamicJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallRuntimeNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallStaticJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/Compile.java + agent/src/share/classes/sun/jvm/hotspot/opto/HaltNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/InlineTree.java + agent/src/share/classes/sun/jvm/hotspot/opto/JVMState.java + agent/src/share/classes/sun/jvm/hotspot/opto/LoopNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallRuntimeNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallStaticJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachIfNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachReturnNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachSafePointNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MultiNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node_Array.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node_List.java + agent/src/share/classes/sun/jvm/hotspot/opto/Phase.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhaseRegAlloc.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhiNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/ProjNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/RegionNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/RootNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/SafePointNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/TypeNode.java + agent/src/share/classes/sun/jvm/hotspot/prims/JvmtiExport.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompilerThread.java + agent/src/share/classes/sun/jvm/hotspot/runtime/InstanceConstructor.java + agent/src/share/classes/sun/jvm/hotspot/runtime/StaticBaseConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java + agent/src/share/classes/sun/jvm/hotspot/runtime/VirtualBaseConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VirtualConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_x86/Win32X86JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! agent/src/share/classes/sun/jvm/hotspot/types/TypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/ui/CommandProcessorPanel.java + agent/src/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java + agent/src/share/classes/sun/jvm/hotspot/utilities/GrowableArray.java ! make/sa.files ! src/share/vm/ci/ciArrayKlass.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/regalloc.hpp ! src/share/vm/opto/type.hpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/vframeArray.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/exceptions.hpp ! src/share/vm/utilities/growableArray.hpp Changeset: ab577c97a5f3 Author: never Date: 2011-09-12 13:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ab577c97a5f3 7089709: type "jushort" not found Reviewed-by: kvn, twisti ! src/share/vm/runtime/vmStructs.cpp Changeset: 2209834ccb59 Author: kvn Date: 2011-09-13 11:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2209834ccb59 7089632: assert(machtmp->outcnt() == 1) failed: expected for a MachTemp Summary: Replace assert with check to delete MachTemp nodes only when they are really dead. Reviewed-by: never ! src/share/vm/opto/postaloc.cpp Changeset: 10ee2b297ccd Author: bdelsart Date: 2011-09-14 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/10ee2b297ccd 7057978: improve robustness of c1 ARM back-end wrt non encodable constants Summary: ARM only, avoid assertion failures for huge constants generated by C1 shared code Reviewed-by: never, vladidan ! src/share/vm/c1/c1_LIR.cpp Changeset: 393f4b789fd0 Author: bdelsart Date: 2011-09-14 16:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/393f4b789fd0 7077806: ARM: java.lang.InternalError: bound subword value does not fit into the subword type Summary: shared fix necessary for ARM/PPC Reviewed-by: twisti, roland ! src/share/vm/prims/methodHandles.hpp Changeset: 35c656d0b685 Author: never Date: 2011-09-14 13:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/35c656d0b685 7090654: nightly failures after 7086585 Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 8ed53447f690 Author: iveresov Date: 2011-09-15 12:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8ed53447f690 Merge - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java ! src/share/vm/classfile/javaClasses.cpp From john.r.rose at oracle.com Thu Sep 15 17:21:29 2011 From: john.r.rose at oracle.com (John Rose) Date: Thu, 15 Sep 2011 17:21:29 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> Message-ID: <94CF4622-CE8E-4106-ABF1-3100BE0D2189@oracle.com> On Sep 13, 2011, at 3:32 PM, Tom Rodriguez wrote: > I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. > > http://cr.openjdk.java.net/~never/7089790_full I tried this out with a build and JSR 292 test on my Macbook (10.6.8) and it works. I ran the diffs from your changes against the transitional patch currently in mvm-dev, and they don't contain anything surprising (relative to this Email thread). The PRIxnn macro simplifications are good. Perhaps the final form of them in globalDefinitions could be reorganized a little, also? The parallel 32-bit and 64-bit definitions occur in different order and with different spacing. This irregularity makes them harder to read. I looked at the helpful differences you posted between Linux and BSD. I noticed that there is a definition (bsd_{x86,zero}) of SurvivorRatio introduced which apparently reproduces the definition in the shared globals.hpp, and is not in the linux side. Do we need it? Thanks. This convergence of source bases is very welcome to all of us mac-heads. -- John P.S. I noticed something that needs cleanup later on. There are 8 replacements of this form, which all protect elf-specific code: -#ifndef _WINDOWS +#if !defined(_WINDOWS) && !defined(__APPLE__) At minimum it probably requires something like TARGET_OS_OBJECT_elf, and more likely a move of the code into src/os/elf or some similar platform-specific code base. This is not neatly covered by the linux/bsd merge, since elf is one of the ways in which linux and bsd differ. From Baiyan.Huang at morganstanley.com Thu Sep 15 21:09:05 2011 From: Baiyan.Huang at morganstanley.com (Huang, Baiyan) Date: Fri, 16 Sep 2011 12:09:05 +0800 Subject: Disable JVM from handling hard errors In-Reply-To: <4E5661AE.1040602@oracle.com> References: <4E5624AC.40105@oracle.com> <4E5661AE.1040602@oracle.com> Message-ID: Thanks Coleen. -XX:+UseOSErrorReporting seems just work for Windows, do we have any other options for Linux (ex. redhat) so we could achieve this as in Windows. -Baiyan -----Original Message----- From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore Sent: Thursday, August 25, 2011 10:53 PM To: hotspot-dev at openjdk.java.net Subject: Re: Disable JVM from handling hard errors The option you want is -XX:+UseOSErrorReporting. That will stop and put you in the windows debugger at the point of the crash. Coleen On 8/25/2011 10:17 AM, Huang, Baiyan wrote: > Thanks David, > > But what if I don't have the permission to change the JNI code? > > Actually, even I can change the JNI code, and I install my exception handler, it also "handle" the exception, and the execution flow is jump to other place, rather than the "crash" point. -XX:CreateMinidumpOnCrash should be similar as it also requires a exception handler. > > I am thinking of away to disable the internal handling in JVM of such exception. > > -Baiyan > > > -----Original Message----- > From: David Holmes [mailto:David.Holmes at oracle.com] > Sent: Thursday, August 25, 2011 6:32 PM > To: Huang, Baiyan (ISGT) > Cc: hotspot-dev at openjdk.java.net > Subject: Re: Disable JVM from handling hard errors > > On 25/08/2011 7:56 PM, Huang, Baiyan wrote: >> Suppose I have a simple JNI program in Windows: >> >> int* p = NULL; >> >> *p = 5; >> >> When run it from JVM, not like normal C++ application, JVM will nicely catch >> such hard exception and do some cleanup work. >> >> The problem here is it also stops me from generating crash dumps right >> there, although there is a JVM option: -XX:OnError, but core dumps generated >> at this point is far from the crime scene thus hard to debug. >> >> Do you have any suggestions? > I think you'd need to install your own fatal exception handler whilst in the > JNI code, and restore the JVM handler when leaving. I'm not sure of the > details on Windows in terms of API. > > But the JVM fatal error handling can create a crash dump - use > -XX:CreateMinidumpOnCrash > > David > >> Thanks. >> >> -Baiyan >> >> ---------------------------------------------------------------------------- >> NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions >> or views contained herein are not intended to be, and do not constitute, >> advice within the meaning of Section 975 of the Dodd-Frank Wall Street >> Reform and Consumer Protection Act. If you have received this communication >> in error, please destroy all electronic and paper copies and notify the >> sender immediately. Mistransmission is not intended to waive confidentiality >> or privilege. Morgan Stanley reserves the right, to the extent permitted >> under applicable law, to monitor electronic communications. This message is >> subject to terms available at the following link: >> http://www.morganstanley.com/disclaimers. If you cannot access these links, >> please notify us by reply message and we will send the contents to you. By >> messaging with Morgan Stanley you consent to the foregoing. > -------------------------------------------------------------------------- > NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions or views contained herein are not intended to be, and do not constitute, advice within the meaning of Section 975 of the Dodd-Frank Wall Street Reform and Consumer Protection Act. If you have received this communication in error, please destroy all electronic and paper copies and notify the sender immediately. Mistransmission is not intended to waive confidentiality or privilege. Morgan Stanley reserves the right, to the extent permitted under applicable law, to monitor electronic communications. This message is subject to terms available at the following link: http://www.morganstanley.com/disclaimers. If you cannot access these links, please notify us by reply message and we will send the contents to you. By messaging with Morgan Stanley you consent to the foregoing. -------------------------------------------------------------------------- NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions or views contained herein are not intended to be, and do not constitute, advice within the meaning of Section 975 of the Dodd-Frank Wall Street Reform and Consumer Protection Act. If you have received this communication in error, please destroy all electronic and paper copies and notify the sender immediately. Mistransmission is not intended to waive confidentiality or privilege. Morgan Stanley reserves the right, to the extent permitted under applicable law, to monitor electronic communications. This message is subject to terms available at the following link: http://www.morganstanley.com/disclaimers. If you cannot access these links, please notify us by reply message and we will send the contents to you. By messaging with Morgan Stanley you consent to the foregoing. From john.coomes at oracle.com Thu Sep 15 23:47:18 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Sep 2011 06:47:18 +0000 Subject: hg: hsx/hotspot-main/hotspot: 5 new changesets Message-ID: <20110916064728.4C84F4771A@hg.openjdk.java.net> Changeset: 0db80d8e77fc Author: schien Date: 2011-09-15 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0db80d8e77fc Added tag jdk8-b05 for changeset dce7d24674f4 ! .hgtags Changeset: 558f525a6ebe Author: jcoomes Date: 2011-09-15 19:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/558f525a6ebe Merge ! .hgtags - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 8ab2f4108d20 Author: jcoomes Date: 2011-09-15 20:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8ab2f4108d20 7091294: disable quicksort tests Reviewed-by: jmasa, ysr, kvn ! src/share/vm/utilities/quickSort.cpp Changeset: 650d15d8f372 Author: jcoomes Date: 2011-09-15 20:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/650d15d8f372 7091255: Bump the hs22 build number to 06 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5a3c2bc614ca Author: jcoomes Date: 2011-09-15 20:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5a3c2bc614ca Added tag hs22-b06 for changeset 650d15d8f372 ! .hgtags From john.coomes at oracle.com Fri Sep 16 02:44:32 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 16 Sep 2011 09:44:32 +0000 Subject: hg: hsx/hsx22/hotspot: 24 new changesets Message-ID: <20110916094517.4F9E247721@hg.openjdk.java.net> Changeset: 0db80d8e77fc Author: schien Date: 2011-09-15 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/0db80d8e77fc Added tag jdk8-b05 for changeset dce7d24674f4 ! .hgtags Changeset: f1b4e0e0bdad Author: tonyp Date: 2011-09-13 12:40 -0400 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/f1b4e0e0bdad 7089625: G1: policy for how many old regions to add to the CSet (when young gen is fixed) is broken Summary: When refactoring the code for a previous fix, a condition was not correctly negated which prevents the G1 policy from adding the correct number of old regions to the CSet when the young gen size is fixed. The changeset also fixes a small syntactical issue in g1ErgoVerbose.hpp which is causing compiler warnings. Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp Changeset: 0a63380c8ac8 Author: iveresov Date: 2011-09-13 16:58 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/0a63380c8ac8 7090069: Java launcher hangs in infinite loop on windows when UseNUMA[Interleaving] is specified Summary: Fix _numa_used_node_list array size specification Reviewed-by: kvn, johnc, jmasa, ysr ! src/os/windows/vm/os_windows.cpp Changeset: f94227b6117b Author: kvn Date: 2011-09-13 20:28 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/f94227b6117b 7090259: Fix hotspot sources to build with old compilers Summary: Fixed warnings which prevent building VM with old compilers. Reviewed-by: never ! make/solaris/makefiles/sparcWorks.make ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/opto/block.cpp Changeset: da6a29fb0da5 Author: kvn Date: 2011-09-07 12:58 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/da6a29fb0da5 7054211: No loop unrolling done in jdk7b144 for a test update() while loop Summary: restore unrolling code for CaffeineMark. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp Changeset: 5432047c7db7 Author: bdelsart Date: 2011-09-08 10:12 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/5432047c7db7 7087445: Improve platform independence of JSR292 shared code Summary: changes necessary for some JSR292 ports Reviewed-by: jrose, dholmes ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/zero/vm/frame_zero.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/frame.hpp Changeset: b0efc7ee3b31 Author: twisti Date: 2011-09-08 05:11 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/b0efc7ee3b31 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/klassOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/prims/methodHandles.cpp Changeset: fdcb1e828d53 Author: kvn Date: 2011-09-08 12:44 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/fdcb1e828d53 7087947: Add regression test for 7068051 Summary: Add regression test. Reviewed-by: never + test/compiler/7068051/Test7068051.java + test/compiler/7068051/Test7068051.sh Changeset: 8f47d8870d9a Author: roland Date: 2011-09-08 09:35 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/8f47d8870d9a 7087453: PhaseChaitin::yank_if_dead() should handle MachTemp inputs Summary: PhaseChaitin::yank_if_dead() should be able to handle MachTemp inputs as a special case and yank them. Reviewed-by: never, kvn ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/postaloc.cpp Changeset: 5257f8e66b40 Author: iveresov Date: 2011-09-09 12:44 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/5257f8e66b40 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 2c24ef16533d Author: kvn Date: 2011-09-09 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64 Summary: Revert changes which caused regression. Reviewed-by: never ! src/share/vm/opto/loopnode.cpp Changeset: c565834fb592 Author: never Date: 2011-09-10 00:11 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/c565834fb592 7088020: SEGV in JNIHandleBlock::release_block Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp + test/compiler/7088020/Test7088020.java Changeset: e6b1331a51d2 Author: never Date: 2011-09-10 17:29 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/e6b1331a51d2 7086585: make Java field injection more flexible Reviewed-by: jrose, twisti, kvn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/java_lang_Class.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/SOQL.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/test/jdi/sasanity.sh ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/cpCacheOop.cpp + src/share/vm/oops/fieldInfo.hpp + src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: f6f3bb0ee072 Author: never Date: 2011-09-11 14:48 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/f6f3bb0ee072 7088955: add C2 IR support to the SA Reviewed-by: kvn ! agent/make/Makefile ! agent/make/saenv.sh ! agent/make/saenv64.sh ! agent/src/os/solaris/Makefile - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp ! agent/src/share/classes/sun/jvm/hotspot/CLHSDB.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/DebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciConstant.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciField.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstance.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodData.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObject.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciObjectFactory.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciReceiverTypeData.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciSymbol.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciType.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlassKlass.java + agent/src/share/classes/sun/jvm/hotspot/ci/ciVirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java + agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/AddressException.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/SADebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/VirtualMachineImpl.java + agent/src/share/classes/sun/jvm/hotspot/oops/ArrayData.java + agent/src/share/classes/sun/jvm/hotspot/oops/BitData.java + agent/src/share/classes/sun/jvm/hotspot/oops/BranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/CIntField.java + agent/src/share/classes/sun/jvm/hotspot/oops/CounterData.java + agent/src/share/classes/sun/jvm/hotspot/oops/DataLayout.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/FieldType.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/oops/JumpData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java + agent/src/share/classes/sun/jvm/hotspot/oops/MultiBranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopUtilities.java + agent/src/share/classes/sun/jvm/hotspot/oops/ProfileData.java + agent/src/share/classes/sun/jvm/hotspot/oops/ReceiverTypeData.java + agent/src/share/classes/sun/jvm/hotspot/oops/RetData.java + agent/src/share/classes/sun/jvm/hotspot/oops/VirtualCallData.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block_Array.java + agent/src/share/classes/sun/jvm/hotspot/opto/Block_List.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallDynamicJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallRuntimeNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/CallStaticJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/Compile.java + agent/src/share/classes/sun/jvm/hotspot/opto/HaltNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/InlineTree.java + agent/src/share/classes/sun/jvm/hotspot/opto/JVMState.java + agent/src/share/classes/sun/jvm/hotspot/opto/LoopNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallRuntimeNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachCallStaticJavaNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachIfNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachReturnNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MachSafePointNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/MultiNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node_Array.java + agent/src/share/classes/sun/jvm/hotspot/opto/Node_List.java + agent/src/share/classes/sun/jvm/hotspot/opto/Phase.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhaseRegAlloc.java + agent/src/share/classes/sun/jvm/hotspot/opto/PhiNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/ProjNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/RegionNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/RootNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/SafePointNode.java + agent/src/share/classes/sun/jvm/hotspot/opto/TypeNode.java + agent/src/share/classes/sun/jvm/hotspot/prims/JvmtiExport.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompilerThread.java + agent/src/share/classes/sun/jvm/hotspot/runtime/InstanceConstructor.java + agent/src/share/classes/sun/jvm/hotspot/runtime/StaticBaseConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java + agent/src/share/classes/sun/jvm/hotspot/runtime/VirtualBaseConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VirtualConstructor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_x86/Win32X86JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! agent/src/share/classes/sun/jvm/hotspot/types/TypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/ui/CommandProcessorPanel.java + agent/src/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java + agent/src/share/classes/sun/jvm/hotspot/utilities/GrowableArray.java ! make/sa.files ! src/share/vm/ci/ciArrayKlass.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/regalloc.hpp ! src/share/vm/opto/type.hpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/vframeArray.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/exceptions.hpp ! src/share/vm/utilities/growableArray.hpp Changeset: ab577c97a5f3 Author: never Date: 2011-09-12 13:51 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/ab577c97a5f3 7089709: type "jushort" not found Reviewed-by: kvn, twisti ! src/share/vm/runtime/vmStructs.cpp Changeset: 2209834ccb59 Author: kvn Date: 2011-09-13 11:46 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/2209834ccb59 7089632: assert(machtmp->outcnt() == 1) failed: expected for a MachTemp Summary: Replace assert with check to delete MachTemp nodes only when they are really dead. Reviewed-by: never ! src/share/vm/opto/postaloc.cpp Changeset: 10ee2b297ccd Author: bdelsart Date: 2011-09-14 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/10ee2b297ccd 7057978: improve robustness of c1 ARM back-end wrt non encodable constants Summary: ARM only, avoid assertion failures for huge constants generated by C1 shared code Reviewed-by: never, vladidan ! src/share/vm/c1/c1_LIR.cpp Changeset: 393f4b789fd0 Author: bdelsart Date: 2011-09-14 16:28 +0200 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/393f4b789fd0 7077806: ARM: java.lang.InternalError: bound subword value does not fit into the subword type Summary: shared fix necessary for ARM/PPC Reviewed-by: twisti, roland ! src/share/vm/prims/methodHandles.hpp Changeset: 35c656d0b685 Author: never Date: 2011-09-14 13:57 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/35c656d0b685 7090654: nightly failures after 7086585 Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 8ed53447f690 Author: iveresov Date: 2011-09-15 12:44 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/8ed53447f690 Merge - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java ! src/share/vm/classfile/javaClasses.cpp Changeset: 558f525a6ebe Author: jcoomes Date: 2011-09-15 19:33 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/558f525a6ebe Merge ! .hgtags - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 8ab2f4108d20 Author: jcoomes Date: 2011-09-15 20:30 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/8ab2f4108d20 7091294: disable quicksort tests Reviewed-by: jmasa, ysr, kvn ! src/share/vm/utilities/quickSort.cpp Changeset: 650d15d8f372 Author: jcoomes Date: 2011-09-15 20:56 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/650d15d8f372 7091255: Bump the hs22 build number to 06 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5a3c2bc614ca Author: jcoomes Date: 2011-09-15 20:56 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/5a3c2bc614ca Added tag hs22-b06 for changeset 650d15d8f372 ! .hgtags From c.m.bockisch at cs.utwente.nl Fri Sep 16 06:28:46 2011 From: c.m.bockisch at cs.utwente.nl (Christoph Bockisch) Date: Fri, 16 Sep 2011 15:28:46 +0200 Subject: Invitation to attend workshop on Virtual Machines and Intermediate Languages (VMIL) @ SPLASH 2011 Message-ID: <4E734F0E.5040205@cs.utwente.nl> Dear colleagues, we would like to invite you to attend the workshop on Virtual Machines and Intermediate Languages (VMIL 2011), which will be co-located with SPLASH. Please note that the early registration deadline for SPLASH is Sept. 23 and that it is required that you register for the workshop participation. This workshop is a forum for research in virtual machines (VM) and intermediate languages (IL). It is dedicated to identifying programming mechanisms and constructs that are currently realized as code transformations or implemented in libraries but should rather be supported at VM and IL level. Besides the presentation of accepted papers, the workshop features an invited talk by Lars Bak, Google For more details on the format and program of the workshop please see our homepage: http://www.cs.iastate.edu/~design/vmil/ We look forward to meeting you at the workshop. Best regards, Christoph Bockisch, Hridesh Rajan, Michael Haupt and Robert Dyer VMIL 2011 Organizers From coleen.phillimore at oracle.com Fri Sep 16 06:33:44 2011 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Fri, 16 Sep 2011 09:33:44 -0400 Subject: Disable JVM from handling hard errors In-Reply-To: References: <4E5624AC.40105@oracle.com> <4E5661AE.1040602@oracle.com> Message-ID: <4E735038.7060804@oracle.com> If you have a product build, you can use the OnError option to launch the debugger at the point of the crash. // -XX:OnError="gcore %p; gdb - %p" // dump core and launch debugger Linux doesn't mess up the stack at the point of SEGV like Windows, so you should see your JNI failure in the debug stack that gdb gives you. Hope this helps. Coleen On 9/16/2011 12:09 AM, Huang, Baiyan wrote: > Thanks Coleen. > > -XX:+UseOSErrorReporting seems just work for Windows, do we have any other options for Linux (ex. redhat) so we could achieve this as in Windows. > > -Baiyan > > -----Original Message----- > From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore > Sent: Thursday, August 25, 2011 10:53 PM > To: hotspot-dev at openjdk.java.net > Subject: Re: Disable JVM from handling hard errors > > The option you want is -XX:+UseOSErrorReporting. That will stop and put > you in the windows debugger at the point of the crash. > > Coleen > > On 8/25/2011 10:17 AM, Huang, Baiyan wrote: >> Thanks David, >> >> But what if I don't have the permission to change the JNI code? >> >> Actually, even I can change the JNI code, and I install my exception handler, it also "handle" the exception, and the execution flow is jump to other place, rather than the "crash" point. -XX:CreateMinidumpOnCrash should be similar as it also requires a exception handler. >> >> I am thinking of away to disable the internal handling in JVM of such exception. >> >> -Baiyan >> >> >> -----Original Message----- >> From: David Holmes [mailto:David.Holmes at oracle.com] >> Sent: Thursday, August 25, 2011 6:32 PM >> To: Huang, Baiyan (ISGT) >> Cc: hotspot-dev at openjdk.java.net >> Subject: Re: Disable JVM from handling hard errors >> >> On 25/08/2011 7:56 PM, Huang, Baiyan wrote: >>> Suppose I have a simple JNI program in Windows: >>> >>> int* p = NULL; >>> >>> *p = 5; >>> >>> When run it from JVM, not like normal C++ application, JVM will nicely catch >>> such hard exception and do some cleanup work. >>> >>> The problem here is it also stops me from generating crash dumps right >>> there, although there is a JVM option: -XX:OnError, but core dumps generated >>> at this point is far from the crime scene thus hard to debug. >>> >>> Do you have any suggestions? >> I think you'd need to install your own fatal exception handler whilst in the >> JNI code, and restore the JVM handler when leaving. I'm not sure of the >> details on Windows in terms of API. >> >> But the JVM fatal error handling can create a crash dump - use >> -XX:CreateMinidumpOnCrash >> >> David >> >>> Thanks. >>> >>> -Baiyan >>> >>> ---------------------------------------------------------------------------- >>> NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions >>> or views contained herein are not intended to be, and do not constitute, >>> advice within the meaning of Section 975 of the Dodd-Frank Wall Street >>> Reform and Consumer Protection Act. If you have received this communication >>> in error, please destroy all electronic and paper copies and notify the >>> sender immediately. Mistransmission is not intended to waive confidentiality >>> or privilege. Morgan Stanley reserves the right, to the extent permitted >>> under applicable law, to monitor electronic communications. This message is >>> subject to terms available at the following link: >>> http://www.morganstanley.com/disclaimers. If you cannot access these links, >>> please notify us by reply message and we will send the contents to you. By >>> messaging with Morgan Stanley you consent to the foregoing. >> -------------------------------------------------------------------------- >> NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions or views contained herein are not intended to be, and do not constitute, advice within the meaning of Section 975 of the Dodd-Frank Wall Street Reform and Consumer Protection Act. If you have received this communication in error, please destroy all electronic and paper copies and notify the sender immediately. Mistransmission is not intended to waive confidentiality or privilege. Morgan Stanley reserves the right, to the extent permitted under applicable law, to monitor electronic communications. This message is subject to terms available at the following link: http://www.morganstanley.com/disclaimers. If you cannot access these links, please notify us by reply message and we will send the contents to you. By messaging with Morgan Stanley you consent to the foregoing. > -------------------------------------------------------------------------- > NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions or views contained herein are not intended to be, and do not constitute, advice within the meaning of Section 975 of the Dodd-Frank Wall Street Reform and Consumer Protection Act. If you have received this communication in error, please destroy all electronic and paper copies and notify the sender immediately. Mistransmission is not intended to waive confidentiality or privilege. Morgan Stanley reserves the right, to the extent permitted under applicable law, to monitor electronic communications. This message is subject to terms available at the following link: http://www.morganstanley.com/disclaimers. If you cannot access these links, please notify us by reply message and we will send the contents to you. By messaging with Morgan Stanley you consent to the foregoing. From kurt at intricatesoftware.com Fri Sep 16 06:46:26 2011 From: kurt at intricatesoftware.com (Kurt Miller) Date: Fri, 16 Sep 2011 09:46:26 -0400 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <4E7166DA.9020605@intricatesoftware.com> References: <201108021234.30179.kurt@intricatesoftware.com> <51610B3B-6467-4A5A-85F4-1C287BBE2DC7@oracle.com> <4E7166DA.9020605@intricatesoftware.com> Message-ID: <201109160946.27151.kurt@intricatesoftware.com> On Wednesday 14 September 2011 10:45:46 pm Kurt Miller wrote: > On 9/14/11 4:38 PM, Christian Thalinger wrote: > > On Sep 14, 2011, at 10:21 PM, Tom Rodriguez wrote: > >> On Sep 14, 2011, at 6:28 AM, Christian Thalinger wrote: > >>> src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp > >>> > >>> + #ifndef _ALLBSD_SOURCE > >>> #include > >>> + #endif > > byteswap doesn't exist on bsd (Checked Mac OS X 10.5, OpenBSD 5.0 and > FreeBSD 7.0). Instead of ifndef _ALLBSD_SOURCE this should just be > deleted since this is already a bsd only file. I went a little overboard > with the ifdef/ifndef approach to minimize the differences between linux > and bsd to help with merges. > > >>> + #ifdef __APPLE__ > >>> + #include > >>> + #endif > >>> + > >>> + #if defined(AMD64) > >>> + # if defined(__APPLE__) > >>> + # define bswap_16(x) OSSwapInt16(x) > >>> + # define bswap_32(x) OSSwapInt32(x) > >>> + # define bswap_64(x) OSSwapInt64(x) > >>> + # elif defined(__OpenBSD__) > >>> + # define bswap_16(x) swap16(x) > >>> + # define bswap_32(x) swap32(x) > >>> + # define bswap_64(x) swap64(x) > >>> + # elif defined(__NetBSD__) > >>> + # define bswap_16(x) bswap16(x) > >>> + # define bswap_32(x) bswap32(x) > >>> + # define bswap_64(x) bswap64(x) > >>> + # else > >>> + # define bswap_16(x) __bswap16(x) > >>> + # define bswap_32(x) __bswap32(x) > >>> + # define bswap_64(x) __bswap64(x) > >>> + # endif > >>> + #endif > >>> > >>> src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp: > >>> > >>> - #include > >>> + #ifdef __APPLE__ > >>> + #include > >>> + #define bswap16(x) OSSwapInt16(x) > >>> + #define bswap32(x) OSSwapInt32(x) > >>> + #define bswap64(x) OSSwapInt64(x) > >>> + #else > >>> + # include > >>> + #endif > >>> > >>> Why is byteswap.h removed from bytes_bsd_zero but sys/endian.h is used for !APPLE? bytes_bsd_x86 does something different. > > byteswap.h is remove from both. > > sys/endian.h is how the BSD's get the bswap* definitions, except APPLE > which gets them from libkern/OSByteOrder.h. It looks like this is > different because zero support has been tested on APPLE and FreeBSD. I > the zero file will need to end up with this block too: > > + # if defined(__APPLE__) > + # define bswap_16(x) OSSwapInt16(x) > + # define bswap_32(x) OSSwapInt32(x) > + # define bswap_64(x) OSSwapInt64(x) > + # elif defined(__OpenBSD__) > + # define bswap_16(x) swap16(x) > + # define bswap_32(x) swap32(x) > + # define bswap_64(x) swap64(x) > + # elif defined(__NetBSD__) > + # define bswap_16(x) bswap16(x) > + # define bswap_32(x) bswap32(x) > + # define bswap_64(x) bswap64(x) > + # else > + # define bswap_16(x) __bswap16(x) > + # define bswap_32(x) __bswap32(x) > + # define bswap_64(x) __bswap64(x) > + # endif > > and the rest of the file changed to use the bswap_NN() versions of the > definitions to have full support. I tested the zero build on OpenBSD and found that the above changes are needed for the build to work. There was one other minor change needed as well. The following is the diff that can be applied on top of the webrev to fix this fiile: ================ begin ===================== --- hotspot/src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp.orig Thu Sep 15 19:18:02 2011 +++ hotspot/src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp Thu Sep 15 19:19:50 2011 @@ -30,23 +30,38 @@ #ifdef __APPLE__ #include -#define bswap16(x) OSSwapInt16(x) -#define bswap32(x) OSSwapInt32(x) -#define bswap64(x) OSSwapInt64(x) #else # include #endif +#if defined(__APPLE__) +# define bswap_16(x) OSSwapInt16(x) +# define bswap_32(x) OSSwapInt32(x) +# define bswap_64(x) OSSwapInt64(x) +#elif defined(__OpenBSD__) +# define bswap_16(x) swap16(x) +# define bswap_32(x) swap32(x) +# define bswap_64(x) swap64(x) +#elif defined(__NetBSD__) +# define bswap_16(x) bswap16(x) +# define bswap_32(x) bswap32(x) +# define bswap_64(x) bswap64(x)patch-hotspot_src_os_cpu_bsd_zero_vm_bytes_bsd_zero_inline_hpp +#else +# define bswap_16(x) __bswap16(x) +# define bswap_32(x) __bswap32(x) +# define bswap_64(x) __bswap64(x) +#endif + inline u2 Bytes::swap_u2(u2 x) { - return bswap16(x); + return bswap_16(x); } inline u4 Bytes::swap_u4(u4 x) { - return bswap32(x); + return bswap_32(x); } inline u8 Bytes::swap_u8(u8 x) { - return bswap64(x); + return bswap_64(x); } #endif // OS_CPU_BSD_ZERO_VM_BYTES_BSD_ZERO_INLINE_HPP ================== end ================= The above change makes the bsd diff to linux version minimal (this is not to be applied, just for information): ================begin ================== --- hotspot/src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp.orig.linux Thu Sep 15 19:17:51 2011 +++ hotspot/src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp Thu Sep 15 19:19:50 2011 @@ -28,7 +28,29 @@ // Efficient swapping of data bytes from Java byte // ordering to native byte ordering and vice versa. -#include +#ifdef __APPLE__ +#include +#else +# include +#endif + +#if defined(__APPLE__) +# define bswap_16(x) OSSwapInt16(x) +# define bswap_32(x) OSSwapInt32(x) +# define bswap_64(x) OSSwapInt64(x) +#elif defined(__OpenBSD__) +# define bswap_16(x) swap16(x) +# define bswap_32(x) swap32(x) +# define bswap_64(x) swap64(x) +#elif defined(__NetBSD__) +# define bswap_16(x) bswap16(x) +# define bswap_32(x) bswap32(x) +# define bswap_64(x) bswap64(x) +#else +# define bswap_16(x) __bswap16(x) +# define bswap_32(x) __bswap32(x) +# define bswap_64(x) __bswap64(x) +#endif inline u2 Bytes::swap_u2(u2 x) { return bswap_16(x); ================== end =============== If possible, this minor change is needed to fix the zero build on OpenBSD. This is diff would be applied on top of the webrev. Alternatively this can be handled later after the webrev is merged.: =========== start ================== --- hotspot/src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp.orig Fri Sep 16 07:31:22 2011 +++ hotspot/src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp Fri Sep 16 07:31:45 2011 @@ -24,6 +24,7 @@ */ #if defined(_ALLBSD_SOURCE) && !defined(__APPLE__) && !defined(__NetBSD__) +# include # include /* For pthread_attr_get_np */ #endif @@ -341,7 +342,7 @@ static void current_stack_region(address *bottom, size stack_top = (address) ss.ss_sp; stack_bytes = ss.ss_size; - stack_bottom = stacktop - stack_bytes; + stack_bottom = stack_top - stack_bytes; #elif defined(_ALLBSD_SOURCE) pthread_attr_t attr; =========== end =================== From tom.rodriguez at oracle.com Fri Sep 16 10:35:27 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 10:35:27 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <94CF4622-CE8E-4106-ABF1-3100BE0D2189@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94CF4622-CE8E-4106-ABF1-3100BE0D2189@oracle.com> Message-ID: <9D54389E-D734-489B-AA66-FA6C61F4A36D@oracle.com> On Sep 15, 2011, at 5:21 PM, John Rose wrote: > On Sep 13, 2011, at 3:32 PM, Tom Rodriguez wrote: > >> I've finally prepared a set of changes against the latest hotspot-comp with the bsd-port changes. They compile on all our supported platforms with the jdk7 and jdk6 tools and I also built on Snow Leopard and incorporated a few extra changes there to make it all compile. I've prepared several webrevs to ease reviewing. >> >> http://cr.openjdk.java.net/~never/7089790_full > > I tried this out with a build and JSR 292 test on my Macbook (10.6.8) and it works. Thanks. > > I ran the diffs from your changes against the transitional patch currently in mvm-dev, and they don't contain anything surprising (relative to this Email thread). > > The PRIxnn macro simplifications are good. Perhaps the final form of them in globalDefinitions could be reorganized a little, also? The parallel 32-bit and 64-bit definitions occur in different order and with different spacing. This irregularity makes them harder to read. You mean the grouping? How about this? I also simplified the pointer comment. // Format 32-bit quantities. #define INT32_FORMAT "%" PRId32 #define UINT32_FORMAT "%" PRIu32 #define INT32_FORMAT_W(width) "%" #width PRId32 #define UINT32_FORMAT_W(width) "%" #width PRIu32 #define PTR32_FORMAT "0x%08" PRIx32 // Format 64-bit quantities. #define INT64_FORMAT "%" PRId64 #define UINT64_FORMAT "%" PRIu64 #define INT64_FORMAT_W(width) "%" #width PRId64 #define UINT64_FORMAT_W(width) "%" #width PRIu64 #define PTR64_FORMAT "0x%016" PRIx64 // Format pointers which change size between 32- and 64-bit. #ifdef _LP64 #define INTPTR_FORMAT "0x%016" PRIxPTR #define PTR_FORMAT "0x%016" PRIxPTR #else // !_LP64 #define INTPTR_FORMAT "0x%08" PRIxPTR #define PTR_FORMAT "0x%08" PRIxPTR #endif // _LP64 #define SSIZE_FORMAT "%" PRIdPTR #define SIZE_FORMAT "%" PRIuPTR #define SSIZE_FORMAT_W(width) "%" #width PRIdPTR #define SIZE_FORMAT_W(width) "%" #width PRIuPTR #define UINTX_FORMAT "%" PRIuPTR #define INTX_FORMAT "%" PRIdPTR #define UINTX_FORMAT_W(width) "%" #width PRIuPTR > > I looked at the helpful differences you posted between Linux and BSD. I noticed that there is a definition (bsd_{x86,zero}) of SurvivorRatio introduced which apparently reproduces the definition in the shared globals.hpp, and is not in the linux side. Do we need it? It seems useless since SurvivorRatio isn't product_pd. I'll remove it. Thanks! tom > > Thanks. This convergence of source bases is very welcome to all of us mac-heads. > > -- John > > P.S. I noticed something that needs cleanup later on. There are 8 replacements of this form, which all protect elf-specific code: > -#ifndef _WINDOWS > +#if !defined(_WINDOWS) && !defined(__APPLE__) > > At minimum it probably requires something like TARGET_OS_OBJECT_elf, and more likely a move of the code into src/os/elf or some similar platform-specific code base. This is not neatly covered by the linux/bsd merge, since elf is one of the ways in which linux and bsd differ. > From tom.rodriguez at oracle.com Fri Sep 16 10:41:01 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 10:41:01 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <201109160946.27151.kurt@intricatesoftware.com> References: <201108021234.30179.kurt@intricatesoftware.com> <51610B3B-6467-4A5A-85F4-1C287BBE2DC7@oracle.com> <4E7166DA.9020605@intricatesoftware.com> <201109160946.27151.kurt@intricatesoftware.com> Message-ID: <19D63AC9-EB3E-453F-B8AE-D66322A71792@oracle.com> > > I tested the zero build on OpenBSD and found that the above changes are needed > for the build to work. There was one other minor change needed as well. > > The following is the diff that can be applied on top of the webrev to fix this fiile: I incorporated that. > > If possible, this minor change is needed to fix the zero build on OpenBSD. This is diff would be applied on top of the webrev. Alternatively this can be handled later after the webrev is merged.: I added this as well. Thanks. tom > > =========== start ================== > --- hotspot/src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp.orig Fri Sep 16 07:31:22 2011 > +++ hotspot/src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp Fri Sep 16 07:31:45 2011 > @@ -24,6 +24,7 @@ > */ > > #if defined(_ALLBSD_SOURCE) && !defined(__APPLE__) && !defined(__NetBSD__) > +# include > # include /* For pthread_attr_get_np */ > #endif > > @@ -341,7 +342,7 @@ static void current_stack_region(address *bottom, size > > stack_top = (address) ss.ss_sp; > stack_bytes = ss.ss_size; > - stack_bottom = stacktop - stack_bytes; > + stack_bottom = stack_top - stack_bytes; > #elif defined(_ALLBSD_SOURCE) > pthread_attr_t attr; > > =========== end =================== From tom.rodriguez at oracle.com Fri Sep 16 10:45:49 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 10:45:49 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> Message-ID: <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> On Sep 14, 2011, at 11:48 AM, roger hoover wrote: > > On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >> >> I sent you separate mail privately about the contributors from the BSD >> port side. Roger, can you please provide a list of the contributors from >> the team at Apple? > > Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. This is the list I have: Kurt Miller Greg Lewis Jung-uk Kim Christos Zoulas Landon Fuller The FreeBSD Foundation Michael Franz Roger Hoover I don't have an address for Alexander Strange and I'm not sure the FreeBSD foundation can be a contributor. I thought they had to be individuals? tom > > roger > From rhoover at apple.com Fri Sep 16 10:53:47 2011 From: rhoover at apple.com (roger hoover) Date: Fri, 16 Sep 2011 11:53:47 -0600 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> Message-ID: <6950EBFB-029A-4E9F-8AB4-A991B19DBB22@apple.com> Alex is astrange at apple.com I'm not sure if Alex contributed anything directly to the bsd submission, but has done much of the mac specific stuff that we'll get to in the next round. My major contribution to the BSD port was bugging the Oracle hotspot team to start evaluating it. roger On Sep 16, 2011, at 11:45 AM, Tom Rodriguez wrote: > > On Sep 14, 2011, at 11:48 AM, roger hoover wrote: > >> >> On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >>> >>> I sent you separate mail privately about the contributors from the BSD >>> port side. Roger, can you please provide a list of the contributors from >>> the team at Apple? >> >> Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. > > This is the list I have: > > Kurt Miller > Greg Lewis > Jung-uk Kim > Christos Zoulas > Landon Fuller > The FreeBSD Foundation > Michael Franz > Roger Hoover > > I don't have an address for Alexander Strange and I'm not sure the FreeBSD foundation can be a contributor. I thought they had to be individuals? > > tom > >> >> roger >> > From tom.rodriguez at oracle.com Fri Sep 16 11:18:29 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 11:18:29 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <6950EBFB-029A-4E9F-8AB4-A991B19DBB22@apple.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> <6950EBFB-029A-4E9F-8AB4-A991B19DBB22@apple.com> Message-ID: http://cr.openjdk.java.net/~never/7089790_reviewupdates has the changes made as part of the review comments. I've also updated http://cr.openjdk.java.net/~never/7089790_full. Unless we get some last minute changes for hsearch I think we're done with this big step. Thanks for all reviews! tom On Sep 16, 2011, at 10:53 AM, roger hoover wrote: > Alex is astrange at apple.com > > I'm not sure if Alex contributed anything directly to the bsd submission, but has done much of the mac specific stuff that we'll get to in the next round. My major contribution to the BSD port was bugging the Oracle hotspot team to start evaluating it. > > roger > > On Sep 16, 2011, at 11:45 AM, Tom Rodriguez wrote: > >> >> On Sep 14, 2011, at 11:48 AM, roger hoover wrote: >> >>> >>> On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >>>> >>>> I sent you separate mail privately about the contributors from the BSD >>>> port side. Roger, can you please provide a list of the contributors from >>>> the team at Apple? >>> >>> Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. >> >> This is the list I have: >> >> Kurt Miller >> Greg Lewis >> Jung-uk Kim >> Christos Zoulas >> Landon Fuller >> The FreeBSD Foundation >> Michael Franz >> Roger Hoover >> >> I don't have an address for Alexander Strange and I'm not sure the FreeBSD foundation can be a contributor. I thought they had to be individuals? >> >> tom >> >>> >>> roger >>> >> > From john.r.rose at oracle.com Fri Sep 16 11:49:41 2011 From: john.r.rose at oracle.com (John Rose) Date: Fri, 16 Sep 2011 11:49:41 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <9D54389E-D734-489B-AA66-FA6C61F4A36D@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94CF4622-CE8E-4106-ABF1-3100BE0D2189@oracle.com> <9D54389E-D734-489B-AA66-FA6C61F4A36D@oracle.com> Message-ID: On Sep 16, 2011, at 10:35 AM, Tom Rodriguez wrote: >> The PRIxnn macro simplifications are good. Perhaps the final form of them in globalDefinitions could be reorganized a little, also? The parallel 32-bit and 64-bit definitions occur in different order and with different spacing. This irregularity makes them harder to read. > > You mean the grouping? How about this? I also simplified the pointer comment. Yes, that's easier to process. One more nit: In the last stanza "uint" comes before "int", where elsewhere the signed versions come first. I suggest swapping lines 1 and 2 here: > #define UINTX_FORMAT "%" PRIuPTR > #define INTX_FORMAT "%" PRIdPTR > #define UINTX_FORMAT_W(width) "%" #width PRIuPTR > >> I looked at the helpful differences you posted between Linux and BSD. I noticed that there is a definition (bsd_{x86,zero}) of SurvivorRatio introduced which apparently reproduces the definition in the shared globals.hpp, and is not in the linux side. Do we need it? > > It seems useless since SurvivorRatio isn't product_pd. I'll remove it. > > Thanks! You're welcome. -- John From vladimir.kozlov at oracle.com Fri Sep 16 11:55:52 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 16 Sep 2011 11:55:52 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> <6950EBFB-029A-4E9F-8AB4-A991B19DBB22@apple.com> Message-ID: <4E739BB8.4020000@oracle.com> typeArrayOop.hpp still has non-existing includes for sparc, arm and ppc. Vladimir Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/7089790_reviewupdates has the changes made as part of the review comments. I've also updated http://cr.openjdk.java.net/~never/7089790_full. Unless we get some last minute changes for hsearch I think we're done with this big step. Thanks for all reviews! > > tom > > On Sep 16, 2011, at 10:53 AM, roger hoover wrote: > >> Alex is astrange at apple.com >> >> I'm not sure if Alex contributed anything directly to the bsd submission, but has done much of the mac specific stuff that we'll get to in the next round. My major contribution to the BSD port was bugging the Oracle hotspot team to start evaluating it. >> >> roger >> >> On Sep 16, 2011, at 11:45 AM, Tom Rodriguez wrote: >> >>> On Sep 14, 2011, at 11:48 AM, roger hoover wrote: >>> >>>> On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >>>>> I sent you separate mail privately about the contributors from the BSD >>>>> port side. Roger, can you please provide a list of the contributors from >>>>> the team at Apple? >>>> Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. >>> This is the list I have: >>> >>> Kurt Miller >>> Greg Lewis >>> Jung-uk Kim >>> Christos Zoulas >>> Landon Fuller >>> The FreeBSD Foundation >>> Michael Franz >>> Roger Hoover >>> >>> I don't have an address for Alexander Strange and I'm not sure the FreeBSD foundation can be a contributor. I thought they had to be individuals? >>> >>> tom >>> >>>> roger >>>> > From tom.rodriguez at oracle.com Fri Sep 16 12:32:34 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 12:32:34 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <4E739BB8.4020000@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> <6950EBFB-029A-4E9F-8AB4-A991B19DBB22@apple.com> <4E739BB8.4020000@oracle.com> Message-ID: Ah, yes. That's what I forgot. I'm going to clean it up so the includes only cover ports that actually exist. Webrevs are updated. tom On Sep 16, 2011, at 11:55 AM, Vladimir Kozlov wrote: > typeArrayOop.hpp still has non-existing includes for sparc, arm and ppc. > > Vladimir > > Tom Rodriguez wrote: >> http://cr.openjdk.java.net/~never/7089790_reviewupdates has the changes made as part of the review comments. I've also updated http://cr.openjdk.java.net/~never/7089790_full. Unless we get some last minute changes for hsearch I think we're done with this big step. Thanks for all reviews! >> tom >> On Sep 16, 2011, at 10:53 AM, roger hoover wrote: >>> Alex is astrange at apple.com >>> >>> I'm not sure if Alex contributed anything directly to the bsd submission, but has done much of the mac specific stuff that we'll get to in the next round. My major contribution to the BSD port was bugging the Oracle hotspot team to start evaluating it. >>> >>> roger >>> >>> On Sep 16, 2011, at 11:45 AM, Tom Rodriguez wrote: >>> >>>> On Sep 14, 2011, at 11:48 AM, roger hoover wrote: >>>> >>>>> On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >>>>>> I sent you separate mail privately about the contributors from the BSD >>>>>> port side. Roger, can you please provide a list of the contributors from >>>>>> the team at Apple? >>>>> Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. >>>> This is the list I have: >>>> >>>> Kurt Miller >>>> Greg Lewis >>>> Jung-uk Kim >>>> Christos Zoulas >>>> Landon Fuller >>>> The FreeBSD Foundation >>>> Michael Franz >>>> Roger Hoover >>>> >>>> I don't have an address for Alexander Strange and I'm not sure the FreeBSD foundation can be a contributor. I thought they had to be individuals? >>>> >>>> tom >>>> >>>>> roger >>>>> From tom.rodriguez at oracle.com Fri Sep 16 12:32:59 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 12:32:59 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <94CF4622-CE8E-4106-ABF1-3100BE0D2189@oracle.com> <9D54389E-D734-489B-AA66-FA6C61F4A36D@oracle.com> Message-ID: On Sep 16, 2011, at 11:49 AM, John Rose wrote: > On Sep 16, 2011, at 10:35 AM, Tom Rodriguez wrote: > >>> The PRIxnn macro simplifications are good. Perhaps the final form of them in globalDefinitions could be reorganized a little, also? The parallel 32-bit and 64-bit definitions occur in different order and with different spacing. This irregularity makes them harder to read. >> >> You mean the grouping? How about this? I also simplified the pointer comment. > > Yes, that's easier to process. > > One more nit: In the last stanza "uint" comes before "int", where elsewhere the signed versions come first. I suggest swapping lines 1 and 2 here: > >> #define UINTX_FORMAT "%" PRIuPTR >> #define INTX_FORMAT "%" PRIdPTR >> #define UINTX_FORMAT_W(width) "%" #width PRIuPTR Fixed. tom >> >>> I looked at the helpful differences you posted between Linux and BSD. I noticed that there is a definition (bsd_{x86,zero}) of SurvivorRatio introduced which apparently reproduces the definition in the shared globals.hpp, and is not in the linux side. Do we need it? >> >> It seems useless since SurvivorRatio isn't product_pd. I'll remove it. >> >> Thanks! > > You're welcome. > > -- John From vladimir.kozlov at oracle.com Fri Sep 16 13:01:26 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 16 Sep 2011 13:01:26 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> <6950EBFB-029A-4E9F-8AB4-A991B19DBB22@apple.com> <4E739BB8.4020000@oracle.com> Message-ID: <4E73AB16.4090406@oracle.com> Good. Vladimir Tom Rodriguez wrote: > Ah, yes. That's what I forgot. I'm going to clean it up so the includes only cover ports that actually exist. Webrevs are updated. > > tom > > On Sep 16, 2011, at 11:55 AM, Vladimir Kozlov wrote: > >> typeArrayOop.hpp still has non-existing includes for sparc, arm and ppc. >> >> Vladimir >> >> Tom Rodriguez wrote: >>> http://cr.openjdk.java.net/~never/7089790_reviewupdates has the changes made as part of the review comments. I've also updated http://cr.openjdk.java.net/~never/7089790_full. Unless we get some last minute changes for hsearch I think we're done with this big step. Thanks for all reviews! >>> tom >>> On Sep 16, 2011, at 10:53 AM, roger hoover wrote: >>>> Alex is astrange at apple.com >>>> >>>> I'm not sure if Alex contributed anything directly to the bsd submission, but has done much of the mac specific stuff that we'll get to in the next round. My major contribution to the BSD port was bugging the Oracle hotspot team to start evaluating it. >>>> >>>> roger >>>> >>>> On Sep 16, 2011, at 11:45 AM, Tom Rodriguez wrote: >>>> >>>>> On Sep 14, 2011, at 11:48 AM, roger hoover wrote: >>>>> >>>>>> On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >>>>>>> I sent you separate mail privately about the contributors from the BSD >>>>>>> port side. Roger, can you please provide a list of the contributors from >>>>>>> the team at Apple? >>>>>> Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. >>>>> This is the list I have: >>>>> >>>>> Kurt Miller >>>>> Greg Lewis >>>>> Jung-uk Kim >>>>> Christos Zoulas >>>>> Landon Fuller >>>>> The FreeBSD Foundation >>>>> Michael Franz >>>>> Roger Hoover >>>>> >>>>> I don't have an address for Alexander Strange and I'm not sure the FreeBSD foundation can be a contributor. I thought they had to be individuals? >>>>> >>>>> tom >>>>> >>>>>> roger >>>>>> > From John.Coomes at oracle.com Fri Sep 16 14:58:04 2011 From: John.Coomes at oracle.com (John Coomes) Date: Fri, 16 Sep 2011 14:58:04 -0700 Subject: review request (XS) - hs23 - set hotspot version & build number Message-ID: <20083.50796.51431.997945@oracle.com> Hotspot is forking to start work on hs23. This is a trivial change to update the version & build numbers. http://cr.openjdk.java.net/~jcoomes/7091545-hs23/ -John From tom.rodriguez at oracle.com Fri Sep 16 15:17:51 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 15:17:51 -0700 Subject: review request (XS) - hs23 - set hotspot version & build number In-Reply-To: <20083.50796.51431.997945@oracle.com> References: <20083.50796.51431.997945@oracle.com> Message-ID: Looks good. tom On Sep 16, 2011, at 2:58 PM, John Coomes wrote: > Hotspot is forking to start work on hs23. This is a trivial change to > update the version & build numbers. > > http://cr.openjdk.java.net/~jcoomes/7091545-hs23/ > > -John From John.Coomes at oracle.com Fri Sep 16 18:13:08 2011 From: John.Coomes at oracle.com (John Coomes) Date: Fri, 16 Sep 2011 18:13:08 -0700 Subject: review request (XS) - hs23 - set hotspot version & build number In-Reply-To: References: <20083.50796.51431.997945@oracle.com> Message-ID: <20083.62500.600901.229434@oracle.com> Tom Rodriguez (tom.rodriguez at oracle.com) wrote: > Looks good. Thanks Tom and others for reviews. After some discussion, I've updated the webrev (same url, http://cr.openjdk.java.net/~jcoomes/7091545-hs23/) to set the initial build number to 01 instead of 00. Gory details: The procedure used in previous hs releases when taking a snapshot at the end of build n was: 1. bump the build number to n 2. add a tag for build number n 3. snapshot build n, generate binaries, run PIT ... build n+1 starts here with HS_BUILD_NUMBER=n ... With the above process, if we start at 0, the process is consistent for all the builds. If we start at 1, then that first build is different from the others - HS_BUILD_NUMBER is already n at the *start* of the build cycle, and can't be bumped at the end of the cycle. However, a quick poll was unanimous (3/3) that it's confusing to bump the build number at the end of the cycle; everyone preferred it to be bumped at the beginning. So the procedure when taking a snapshot at the end of build n will be: 1. add a tag for build number n 2. snapshot build n, generate binaries and run PIT 3. bump the build number to n+1 (this is not in the snapshot) ... build n+1 starts here with HS_BUILD_NUMBER=n+1 ... Given this procedure, the build number should start at 1. Whew. -John > tom > > On Sep 16, 2011, at 2:58 PM, John Coomes wrote: > > > Hotspot is forking to start work on hs23. This is a trivial change to > > update the version & build numbers. > > > > http://cr.openjdk.java.net/~jcoomes/7091545-hs23/ > > > > -John > From glewis at eyesbeyond.com Fri Sep 16 19:32:52 2011 From: glewis at eyesbeyond.com (Greg Lewis) Date: Fri, 16 Sep 2011 19:32:52 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> Message-ID: <20110917023252.GA14565@misty.eyesbeyond.com> On Fri, Sep 16, 2011 at 10:45:49AM -0700, Tom Rodriguez wrote: > On Sep 14, 2011, at 11:48 AM, roger hoover wrote: > > On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: > >> > >> I sent you separate mail privately about the contributors from the BSD > >> port side. Roger, can you please provide a list of the contributors from > >> the team at Apple? > > > > Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. > > This is the list I have: > > Kurt Miller > Greg Lewis > Jung-uk Kim > Christos Zoulas > Landon Fuller > The FreeBSD Foundation > Michael Franz > Roger Hoover > > I don't have an address for Alexander Strange and I'm not sure the > FreeBSD foundation can be a contributor. I thought they had to be > individuals? The FreeBSD Foundation is a legal entity with an OCA on file. I don't know anything about the contributor rules though. -- Greg Lewis Email : glewis at eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis at FreeBSD.org From tom.rodriguez at oracle.com Fri Sep 16 19:45:48 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Fri, 16 Sep 2011 19:45:48 -0700 Subject: Merging BSDPort into HotSpot mainline In-Reply-To: <20110917023252.GA14565@misty.eyesbeyond.com> References: <201108021234.30179.kurt@intricatesoftware.com> <201108031124.22918.kurt@intricatesoftware.com> <20110831153045.GA26498@misty.eyesbeyond.com> <201108311423.06276.kurt@intricatesoftware.com> <58D590B4-01DA-428A-9C3E-9A3D0181BD5D@oracle.com> <20110914184459.GA81847@misty.eyesbeyond.com> <98480CD8-4609-40EE-8306-0B52D7514503@oracle.com> <20110917023252.GA14565@misty.eyesbeyond.com> Message-ID: On Sep 16, 2011, at 7:32 PM, Greg Lewis wrote: > On Fri, Sep 16, 2011 at 10:45:49AM -0700, Tom Rodriguez wrote: >> On Sep 14, 2011, at 11:48 AM, roger hoover wrote: >>> On Sep 14, 2011, at 12:44 PM, Greg Lewis wrote: >>>> >>>> I sent you separate mail privately about the contributors from the BSD >>>> port side. Roger, can you please provide a list of the contributors from >>>> the team at Apple? >>> >>> Most (if not all) of the hotspot changes from Apple were via Alexander Strange and Roger Hoover. >> >> This is the list I have: >> >> Kurt Miller >> Greg Lewis >> Jung-uk Kim >> Christos Zoulas >> Landon Fuller >> The FreeBSD Foundation >> Michael Franz >> Roger Hoover >> >> I don't have an address for Alexander Strange and I'm not sure the >> FreeBSD foundation can be a contributor. I thought they had to be >> individuals? > > The FreeBSD Foundation is a legal entity with an OCA on file. I don't > know anything about the contributor rules though. That was my own confusion. It will be listed as a contributor. tom > > -- > Greg Lewis Email : glewis at eyesbeyond.com > Eyes Beyond Web : http://www.eyesbeyond.com > Information Technology FreeBSD : glewis at FreeBSD.org From john.coomes at oracle.com Sun Sep 18 00:06:22 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sun, 18 Sep 2011 07:06:22 +0000 Subject: hg: hsx/hotspot-main/hotspot: 7091545: hs23 - set hotspot version & build number Message-ID: <20110918070630.0A33D4778D@hg.openjdk.java.net> Changeset: 77e1a9153757 Author: jcoomes Date: 2011-09-16 21:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/77e1a9153757 7091545: hs23 - set hotspot version & build number Reviewed-by: tonyp, never, phh, jmasa ! make/hotspot_version From daniel.daugherty at oracle.com Tue Sep 20 13:44:49 2011 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Tue, 20 Sep 2011 20:44:49 +0000 Subject: hg: hsx/hsx22/hotspot: 7071904: 4/4 HotSpot: Full Debug Symbols Message-ID: <20110920204453.321C647829@hg.openjdk.java.net> Changeset: da0999c4b733 Author: dcubed Date: 2011-09-16 16:21 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/da0999c4b733 7071904: 4/4 HotSpot: Full Debug Symbols Summary: Add support for .debuginfo files for HSX libraries. Reviewed-by: poonam, dholmes, never ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/build_vm_def.sh ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile + make/solaris/makefiles/build_vm_def.sh ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/mapfile-vers ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make From john.coomes at oracle.com Wed Sep 21 02:37:12 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Wed, 21 Sep 2011 09:37:12 +0000 Subject: hg: hsx/hsx22/hotspot: 2 new changesets Message-ID: <20110921093720.3872947857@hg.openjdk.java.net> Changeset: cd3d4ec354fd Author: jcoomes Date: 2011-09-20 22:26 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/cd3d4ec354fd 7093108: Bump the hs22 build number to 07 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: f79fb21f3cad Author: jcoomes Date: 2011-09-20 22:26 -0700 URL: http://hg.openjdk.java.net/hsx/hsx22/hotspot/rev/f79fb21f3cad Added tag hs22-b07 for changeset cd3d4ec354fd ! .hgtags From robert.ottenhag at oracle.com Thu Sep 22 06:52:37 2011 From: robert.ottenhag at oracle.com (robert.ottenhag at oracle.com) Date: Thu, 22 Sep 2011 13:52:37 +0000 Subject: hg: hsx/hotspot-main/hotspot: 2 new changesets Message-ID: <20110922135242.9E0B6478BA@hg.openjdk.java.net> Changeset: da0999c4b733 Author: dcubed Date: 2011-09-16 16:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/da0999c4b733 7071904: 4/4 HotSpot: Full Debug Symbols Summary: Add support for .debuginfo files for HSX libraries. Reviewed-by: poonam, dholmes, never ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/build_vm_def.sh ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile + make/solaris/makefiles/build_vm_def.sh ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/mapfile-vers ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make Changeset: 86cbe939f0c7 Author: dcubed Date: 2011-09-19 12:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/86cbe939f0c7 Merge From hiyangxi at gmail.com Thu Sep 22 19:54:47 2011 From: hiyangxi at gmail.com (Xi Yang) Date: Fri, 23 Sep 2011 12:54:47 +1000 Subject: Why Nothing Matters: The Impact of Zeroing Message-ID: Hi all, We publish a paper ( http://users.cecs.anu.edu.au/~steveb/downloads/pdf/zero-oopsla-2011.pdf ) about zeroing initialization of JVM at OOPSLA11. We found that the cost of zeroing initialization is very high on modern x86 CMPs. By concurrently zeroing the nursery space with non-temporal instructions, we improve the performance by 3.2% on average and up to 9.3% on the newest sandybridge (i7-2600) machine across 19 benchmarks from DaCapo, SPECjvm98, and pjbb2005. The speedup is not that significant, however, compared with current zeroing approach in HotSpot, the design we proposed is more simple. If HotSpot developers are interested in the idea, you can implement it within 1 hour. One hour work leads to 3.2% speedup, not a bad deal, right? Here is the paper link and abstract: http://users.cecs.anu.edu.au/~steveb/downloads/pdf/zero-oopsla-2011.pdf Managed languages use memory safety to defend against inadvertent and malicious misuse of memory. Unmanaged native languages are increasingly integrating memory safety for the same reasons. A critical element of memory safety is initializing new memory before the program obtains it. Our experiments show that zero initialization is surprisingly expensive in a highly optimized managed runtime ? on average the direct cost of zeroing is 4% to 6% and up to 50% of total application time on a variety of modern processors. Zeroing incurs indirect costs as well, which include memory bandwidth consumption and cache displacement. Existing virtual machines (VMs) either: a) minimize direct costs by zeroing in large blocks, or b) minimize indirect costs by integrating zeroing into the allocation sequence to reduce cache displacement. This paper first describes and evaluates zero initialization costs and the two existing design points. Our microarchitectural analysis of prior designs inspires two better designs that exploit concurrency and non-temporal cache-bypassing instructions to reduce the direct and indirect costs simultaneously. We show that the best strategy is to adaptively choose between the two new designs based on CPU utilization. This approach improves over widely used hot-path zeroing by 3% on average and up to 15% on the newest Intel i7-2600 processor, without slowing down any of the benchmarks. These results indicate that zero initialization is a surprisingly important source of overhead in existing VMs and that our new software strategies are effective at reducing this overhead. These findings also invite other optimizations, including software elision of zeroing and microarchitectural support. Regards. From hiyangxi at gmail.com Thu Sep 22 20:05:23 2011 From: hiyangxi at gmail.com (Xi Yang) Date: Fri, 23 Sep 2011 13:05:23 +1000 Subject: Why Nothing Matters: The Impact of Zeroing In-Reply-To: References: Message-ID: On 23 September 2011 12:54, Xi Yang wrote: > Hi all, > > We publish a paper ( > http://users.cecs.anu.edu.au/~steveb/downloads/pdf/zero-oopsla-2011.pdf > ) about zeroing initialization of JVM at OOPSLA11. We found that the > cost of zeroing initialization is very high on modern x86 CMPs. By > concurrently zeroing the nursery space with non-temporal instructions, > we improve the performance by 3.2% on average and up to 9.3% on the > newest sandybridge (i7-2600) machine across 19 benchmarks from DaCapo, > SPECjvm98, and pjbb2005. > > The speedup is not that significant, however, compared with current > zeroing approach in HotSpot, the design we proposed is more simple. If > HotSpot developers are interested in the idea, you can implement it > within 1 hour. ?One hour work leads to 3.2% speedup, not a bad deal, > right? > > Sorry. I posted a old abstract. Here is the new one. Memory safety defends against inadvertent and malicious misuse of memory that may compromise program correctness and security. A critical element of memory safety is zero initialization. The direct cost of zero initialization is surprisingly high: up to 12.7%, with average costs ranging from 2.7 to 4.5% on a high performance virtual machine on IA32 architectures. Zero initialization also incurs indirect costs due to its memory bandwidth demands and cache displacement effects. Existing virtual machines either: a) minimize direct costs by zeroing in large blocks, or b) minimize indirect costs by zeroing in the allocation sequence, which reduces cache displacement and bandwidth. This paper evaluates the two widely used zero initialization designs, showing that they make different tradeoffs to achieve very similar performance. Our analysis inspires three better designs: (1) bulk zeroing with cache-bypassing (non-temporal) instructions to reduce the direct and indirect zeroing costs simultaneously, (2) concurrent non-temporal bulk zeroing that exploits parallel hardware to move work off the application?s critical path, and (3) adaptive zeroing, which dynamically chooses between (1) and (2) based on available hardware parallelism. The new software strategies offer speedups sometimes greater than the direct overhead, improving total performance by 3% on average. Our findings invite additional optimizations and microarchitectural support. Regards. > Here is the paper link and abstract: > > http://users.cecs.anu.edu.au/~steveb/downloads/pdf/zero-oopsla-2011.pdf > > Managed languages use memory safety to defend against inadvertent and > malicious misuse of memory. Unmanaged native languages are > increasingly integrating memory safety for the same reasons. A > critical element of memory safety is initializing new memory before > the program obtains it. Our experiments show that zero initialization > is surprisingly expensive in a highly optimized managed runtime ? on > average the direct cost of zeroing is 4% to 6% and up to 50% of total > application time on a variety of modern processors. Zeroing incurs > indirect costs as well, which include memory bandwidth consumption and > cache displacement. Existing virtual machines (VMs) either: a) > minimize direct costs by zeroing in large blocks, or b) minimize > indirect costs by integrating zeroing into the allocation sequence to > reduce cache displacement. > This paper first describes and evaluates zero initialization costs and > the two existing design points. Our microarchitectural analysis of > prior designs inspires two better designs that exploit concurrency and > non-temporal cache-bypassing instructions to reduce the direct and > indirect costs simultaneously. We show that the best strategy is to > adaptively choose between the two new designs based on CPU > utilization. This approach improves over widely used hot-path zeroing > by 3% on average and up to 15% on the newest Intel i7-2600 processor, > without slowing down any of the benchmarks. These results indicate > that zero initialization is a surprisingly important source of > overhead in existing VMs and that our new software strategies are > effective at reducing this overhead. These findings also invite other > optimizations, including software elision of zeroing and > microarchitectural support. > > > Regards. > From jesper.wilhelmsson at oracle.com Fri Sep 23 01:48:09 2011 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Fri, 23 Sep 2011 10:48:09 +0200 Subject: Why Nothing Matters: The Impact of Zeroing In-Reply-To: References: Message-ID: <4E7C47C9.6090009@oracle.com> Hi, This sounds interesting. Thank you for posting the paper here. I will have a look at the paper and get back to you once we have had the time to look it over and discuss this. /Jesper On 09/23/2011 04:54 AM, Xi Yang wrote: > Hi all, > > We publish a paper ( > http://users.cecs.anu.edu.au/~steveb/downloads/pdf/zero-oopsla-2011.pdf > ) about zeroing initialization of JVM at OOPSLA11. We found that the > cost of zeroing initialization is very high on modern x86 CMPs. By > concurrently zeroing the nursery space with non-temporal instructions, > we improve the performance by 3.2% on average and up to 9.3% on the > newest sandybridge (i7-2600) machine across 19 benchmarks from DaCapo, > SPECjvm98, and pjbb2005. > > The speedup is not that significant, however, compared with current > zeroing approach in HotSpot, the design we proposed is more simple. If > HotSpot developers are interested in the idea, you can implement it > within 1 hour. One hour work leads to 3.2% speedup, not a bad deal, > right? > > > Here is the paper link and abstract: > > http://users.cecs.anu.edu.au/~steveb/downloads/pdf/zero-oopsla-2011.pdf > > Managed languages use memory safety to defend against inadvertent and > malicious misuse of memory. Unmanaged native languages are > increasingly integrating memory safety for the same reasons. A > critical element of memory safety is initializing new memory before > the program obtains it. Our experiments show that zero initialization > is surprisingly expensive in a highly optimized managed runtime ? on > average the direct cost of zeroing is 4% to 6% and up to 50% of total > application time on a variety of modern processors. Zeroing incurs > indirect costs as well, which include memory bandwidth consumption and > cache displacement. Existing virtual machines (VMs) either: a) > minimize direct costs by zeroing in large blocks, or b) minimize > indirect costs by integrating zeroing into the allocation sequence to > reduce cache displacement. > This paper first describes and evaluates zero initialization costs and > the two existing design points. Our microarchitectural analysis of > prior designs inspires two better designs that exploit concurrency and > non-temporal cache-bypassing instructions to reduce the direct and > indirect costs simultaneously. We show that the best strategy is to > adaptively choose between the two new designs based on CPU > utilization. This approach improves over widely used hot-path zeroing > by 3% on average and up to 15% on the newest Intel i7-2600 processor, > without slowing down any of the benchmarks. These results indicate > that zero initialization is a surprisingly important source of > overhead in existing VMs and that our new software strategies are > effective at reducing this overhead. These findings also invite other > optimizations, including software elision of zeroing and > microarchitectural support. > > > Regards. From volker.simonis at gmail.com Wed Sep 28 09:17:38 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 28 Sep 2011 18:17:38 +0200 Subject: Request for review (S): Addon for 6561870 - SA build still produces "arg list too long" errors Message-ID: Unfortunately, the fix for "6561870: Long javac compile lines fail due to command line length issues (agent compiles?)" didn't entirely solved the problem with too long command lines. This is hopefully done by the following patch: http://www.sapjvm.com/vs/webrevs/arg_max_fix_for_sa_build/ Could somebody please be so kind to open a new BugID for the issue and review the patch. Thank you and best regards, Volker From vladimir.kozlov at oracle.com Wed Sep 28 09:24:45 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 28 Sep 2011 09:24:45 -0700 Subject: Request for review (S): Addon for 6561870 - SA build still produces "arg list too long" errors In-Reply-To: References: Message-ID: <4E834A4D.1040901@oracle.com> Looks good. Vladimir Volker Simonis wrote: > Unfortunately, the fix for "6561870: Long javac compile lines fail due > to command line length issues (agent compiles?)" didn't entirely > solved the problem with too long command lines. > This is hopefully done by the following patch: > > http://www.sapjvm.com/vs/webrevs/arg_max_fix_for_sa_build/ > > Could somebody please be so kind to open a new BugID for the issue and > review the patch. > > Thank you and best regards, > Volker From tom.rodriguez at oracle.com Wed Sep 28 09:38:30 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 28 Sep 2011 09:38:30 -0700 Subject: Request for review (S): Addon for 6561870 - SA build still produces "arg list too long" errors In-Reply-To: References: Message-ID: Looks good. I filed 7096016 and will push it. Thanks! tom On Sep 28, 2011, at 9:17 AM, Volker Simonis wrote: > Unfortunately, the fix for "6561870: Long javac compile lines fail due > to command line length issues (agent compiles?)" didn't entirely > solved the problem with too long command lines. > This is hopefully done by the following patch: > > http://www.sapjvm.com/vs/webrevs/arg_max_fix_for_sa_build/ > > Could somebody please be so kind to open a new BugID for the issue and > review the patch. > > Thank you and best regards, > Volker From volker.simonis at gmail.com Thu Sep 29 01:39:12 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 29 Sep 2011 10:39:12 +0200 Subject: Request for review (S): Addon for 6561870 - SA build still produces "arg list too long" errors In-Reply-To: References: Message-ID: Thank you for the fast reviews! Volker On Wed, Sep 28, 2011 at 6:38 PM, Tom Rodriguez wrote: > Looks good. ?I filed 7096016 and will push it. ?Thanks! > > tom > > On Sep 28, 2011, at 9:17 AM, Volker Simonis wrote: > >> Unfortunately, the fix for "6561870: Long javac compile lines fail due >> to command line length issues (agent compiles?)" didn't entirely >> solved the problem with too long command lines. >> This is hopefully done by the following patch: >> >> http://www.sapjvm.com/vs/webrevs/arg_max_fix_for_sa_build/ >> >> Could somebody please be so kind to open a new BugID for the issue and >> review the patch. >> >> Thank you and best regards, >> Volker > > From robert.ottenhag at oracle.com Thu Sep 29 08:24:57 2011 From: robert.ottenhag at oracle.com (robert.ottenhag at oracle.com) Date: Thu, 29 Sep 2011 15:24:57 +0000 Subject: hg: hsx/hotspot-main/hotspot: 7051189: Need to suppress info message if -xcheck:jni used with libjsig.so Message-ID: <20110929152504.98FC347A93@hg.openjdk.java.net> Changeset: 3607aac85aa9 Author: kevinw Date: 2011-09-22 16:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3607aac85aa9 7051189: Need to suppress info message if -xcheck:jni used with libjsig.so Reviewed-by: coleenp, minqi ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp + test/runtime/7051189/Xchecksig.sh From igor.veresov at oracle.com Fri Sep 30 16:24:16 2011 From: igor.veresov at oracle.com (igor.veresov at oracle.com) Date: Fri, 30 Sep 2011 23:24:16 +0000 Subject: hg: hsx/hotspot-main/hotspot: 10 new changesets Message-ID: <20110930232437.0956F47AF9@hg.openjdk.java.net> Changeset: 5cceda753a4a Author: iveresov Date: 2011-09-19 15:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5cceda753a4a 7091764: Tiered: enable aastore profiling Summary: Turn on aastore profiling Reviewed-by: jrose, twisti ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp Changeset: 075ea0ed9e7c Author: kvn Date: 2011-09-20 08:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/075ea0ed9e7c 7081842: assert(Compile::current()->unique() < (uint)MaxNodeLimit) failed: Node limit exceeded Summary: Add missing node limit check in IGVN optimizer Reviewed-by: iveresov, never ! make/linux/build.sh ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java ! src/share/vm/opto/phaseX.cpp Changeset: eda6988c0d81 Author: never Date: 2011-09-20 23:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/eda6988c0d81 7092236: java/util/EnumSet/EnumSetBash.java fails Reviewed-by: kvn, twisti, jrose ! src/share/vm/ci/ciEnv.cpp Changeset: f08d439fab8c Author: never Date: 2011-09-25 16:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f08d439fab8c 7089790: integrate bsd-port changes Reviewed-by: kvn, twisti, jrose Contributed-by: Kurt Miller , Greg Lewis , Jung-uk Kim , Christos Zoulas , Landon Fuller , The FreeBSD Foundation , Michael Franz , Roger Hoover , Alexander Strange ! agent/make/Makefile + agent/src/os/bsd/BsdDebuggerLocal.c + agent/src/os/bsd/Makefile + agent/src/os/bsd/StubDebuggerLocal.c + agent/src/os/bsd/elfmacros.h + agent/src/os/bsd/libproc.h + agent/src/os/bsd/libproc_impl.c + agent/src/os/bsd/libproc_impl.h + agent/src/os/bsd/mapfile + agent/src/os/bsd/ps_core.c + agent/src/os/bsd/ps_proc.c + agent/src/os/bsd/salibelf.c + agent/src/os/bsd/salibelf.h + agent/src/os/bsd/symtab.c + agent/src/os/bsd/symtab.h + agent/src/os/bsd/test.c + agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdOopHandle.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/SharedObject.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/amd64/BsdAMD64CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/amd64/BsdAMD64ThreadContext.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/x86/BsdX86CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/x86/BsdX86ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd/BsdSignals.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_x86/BsdSignals.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_x86/BsdX86JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java ! make/Makefile + make/bsd/Makefile + make/bsd/README + make/bsd/adlc_updater + make/bsd/build.sh + make/bsd/makefiles/adjust-mflags.sh + make/bsd/makefiles/adlc.make + make/bsd/makefiles/amd64.make + make/bsd/makefiles/arm.make + make/bsd/makefiles/build_vm_def.sh + make/bsd/makefiles/buildtree.make + make/bsd/makefiles/compiler1.make + make/bsd/makefiles/compiler2.make + make/bsd/makefiles/core.make + make/bsd/makefiles/cscope.make + make/bsd/makefiles/debug.make + make/bsd/makefiles/defs.make + make/bsd/makefiles/dtrace.make + make/bsd/makefiles/fastdebug.make + make/bsd/makefiles/gcc.make + make/bsd/makefiles/hp.make + make/bsd/makefiles/hp1.make + make/bsd/makefiles/i486.make + make/bsd/makefiles/ia64.make + make/bsd/makefiles/jsig.make + make/bsd/makefiles/jvmg.make + make/bsd/makefiles/jvmti.make + make/bsd/makefiles/launcher.make + make/bsd/makefiles/mapfile-vers-debug + make/bsd/makefiles/mapfile-vers-jsig + make/bsd/makefiles/mapfile-vers-product + make/bsd/makefiles/optimized.make + make/bsd/makefiles/ppc.make + make/bsd/makefiles/product.make + make/bsd/makefiles/profiled.make + make/bsd/makefiles/rules.make + make/bsd/makefiles/sa.make + make/bsd/makefiles/saproc.make + make/bsd/makefiles/shark.make + make/bsd/makefiles/sparc.make + make/bsd/makefiles/sparcWorks.make + make/bsd/makefiles/sparcv9.make + make/bsd/makefiles/tiered.make + make/bsd/makefiles/top.make + make/bsd/makefiles/vm.make + make/bsd/makefiles/zero.make + make/bsd/makefiles/zeroshark.make + make/bsd/platform_amd64 + make/bsd/platform_amd64.suncc + make/bsd/platform_i486 + make/bsd/platform_i486.suncc + make/bsd/platform_ia64 + make/bsd/platform_sparc + make/bsd/platform_sparcv9 + make/bsd/platform_zero.in ! make/cscope.make ! make/defs.make ! make/linux/makefiles/arm.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/ppc.make ! make/sa.files ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make ! src/cpu/x86/vm/bytes_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/copy_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/jni_x86.h ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/zero/vm/bytes_zero.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/cpu/zero/vm/interp_masm_zero.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/cpu/zero/vm/vm_version_zero.cpp + src/os/bsd/vm/attachListener_bsd.cpp + src/os/bsd/vm/c1_globals_bsd.hpp + src/os/bsd/vm/c2_globals_bsd.hpp + src/os/bsd/vm/chaitin_bsd.cpp + src/os/bsd/vm/decoder_bsd.cpp + src/os/bsd/vm/dtraceJSDT_bsd.cpp + src/os/bsd/vm/globals_bsd.hpp + src/os/bsd/vm/interfaceSupport_bsd.hpp + src/os/bsd/vm/jsig.c + src/os/bsd/vm/jvm_bsd.cpp + src/os/bsd/vm/jvm_bsd.h + src/os/bsd/vm/mutex_bsd.cpp + src/os/bsd/vm/mutex_bsd.inline.hpp + src/os/bsd/vm/osThread_bsd.cpp + src/os/bsd/vm/osThread_bsd.hpp + src/os/bsd/vm/os_bsd.cpp + src/os/bsd/vm/os_bsd.hpp + src/os/bsd/vm/os_bsd.inline.hpp + src/os/bsd/vm/os_share_bsd.hpp + src/os/bsd/vm/perfMemory_bsd.cpp + src/os/bsd/vm/stubRoutines_bsd.cpp + src/os/bsd/vm/threadCritical_bsd.cpp + src/os/bsd/vm/thread_bsd.inline.hpp + src/os/bsd/vm/vmError_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/launcher.script + src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/atomic_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/bsd_x86_32.ad + src/os_cpu/bsd_x86/vm/bsd_x86_32.s + src/os_cpu/bsd_x86/vm/bsd_x86_64.ad + src/os_cpu/bsd_x86/vm/bsd_x86_64.s + src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/copy_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/globals_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/os_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/prefetch_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/thread_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/vm_version_bsd_x86.cpp + src/os_cpu/bsd_zero/vm/assembler_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/atomic_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/globals_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/orderAccess_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/os_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/prefetch_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/thread_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/thread_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/vm_version_bsd_zero.cpp ! src/os_cpu/linux_zero/vm/globals_linux_zero.hpp ! src/share/vm/adlc/adlc.hpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oopsHierarchy.cpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/javaFrameAnchor.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/memprofiler.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/osThread.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/threadLocalStorage.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/accessFlags.cpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/bitMap.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/elfStringTable.cpp ! src/share/vm/utilities/elfStringTable.hpp ! src/share/vm/utilities/elfSymbolTable.cpp ! src/share/vm/utilities/elfSymbolTable.hpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/histogram.hpp ! src/share/vm/utilities/macros.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/preserveException.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/workgroup.hpp ! test/Makefile ! test/jprt.config ! test/runtime/6929067/Test6929067.sh Changeset: a92cdbac8b9e Author: kvn Date: 2011-09-26 10:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a92cdbac8b9e 7081933: Use zeroing elimination optimization for large array Summary: Don't zero new typeArray during runtime call if the allocation is followed by arraycopy into it. Reviewed-by: twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: cb315dc80374 Author: never Date: 2011-09-29 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cb315dc80374 7092278: "jmap -finalizerinfo" throws "sun.jvm.hotspot.utilities.AssertionFailure: invalid cp index 0 137" Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/runtime/vmSymbols.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 098acdf97f09 Author: never Date: 2011-09-29 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/098acdf97f09 7096016: SA build still produces "arg list too long" errors Reviewed-by: kvn, never Contributed-by: volker.simonis at gmail.com ! make/linux/makefiles/sa.make ! make/sa.files ! make/solaris/makefiles/sa.make ! make/windows/makefiles/sa.make Changeset: dc45ae774613 Author: iveresov Date: 2011-09-29 23:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/dc45ae774613 7096639: Tiered: Incorrect counter overflow handling for inlined methods Summary: Enable invocation events for inlinees Reviewed-by: kvn ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/runtime/globals.hpp Changeset: ae839d1e7d4c Author: roland Date: 2011-09-30 13:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ae839d1e7d4c 7096010: c2: running with +PrintOptoAssembly crashes the VM when $constanttablebase is used Summary: ADLC generates code to prepare the register string to be printed in a char array but then calls print without the char array as an argument. Reviewed-by: never ! src/share/vm/adlc/formssel.cpp Changeset: 5d871c1ff17c Author: iveresov Date: 2011-09-30 13:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5d871c1ff17c Merge ! make/Makefile ! make/linux/makefiles/defs.make ! make/solaris/makefiles/defs.make ! src/os/linux/vm/os_linux.cpp From john.coomes at oracle.com Fri Sep 30 17:24:42 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 01 Oct 2011 00:24:42 +0000 Subject: hg: hsx/hotspot-main: 4 new changesets Message-ID: <20111001002442.B772C47AFC@hg.openjdk.java.net> Changeset: b910aac18c77 Author: schien Date: 2011-09-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/b910aac18c77 Added tag jdk8-b04 for changeset 0b66a233bfb9 ! .hgtags Changeset: 28cf2aec4dd7 Author: schien Date: 2011-09-15 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/28cf2aec4dd7 Added tag jdk8-b05 for changeset b910aac18c77 ! .hgtags Changeset: 0db7ae9f2b10 Author: katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/0db7ae9f2b10 Added tag jdk8-b06 for changeset 28cf2aec4dd7 ! .hgtags Changeset: cf76aa4189e4 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/rev/cf76aa4189e4 Added tag jdk8-b07 for changeset 0db7ae9f2b10 ! .hgtags From john.coomes at oracle.com Fri Sep 30 17:24:50 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 01 Oct 2011 00:24:50 +0000 Subject: hg: hsx/hotspot-main/corba: 4 new changesets Message-ID: <20111001002454.37C3647AFD@hg.openjdk.java.net> Changeset: cc1b599b986a Author: schien Date: 2011-09-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/cc1b599b986a Added tag jdk8-b04 for changeset 60a68d688e24 ! .hgtags Changeset: 45c43dde7ba7 Author: schien Date: 2011-09-15 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/45c43dde7ba7 Added tag jdk8-b05 for changeset cc1b599b986a ! .hgtags Changeset: 3d61f0856f34 Author: katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/3d61f0856f34 Added tag jdk8-b06 for changeset 45c43dde7ba7 ! .hgtags Changeset: 0d52b1c87aa8 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/0d52b1c87aa8 Added tag jdk8-b07 for changeset 3d61f0856f34 ! .hgtags From john.coomes at oracle.com Fri Sep 30 17:25:02 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 01 Oct 2011 00:25:02 +0000 Subject: hg: hsx/hotspot-main/jaxp: 4 new changesets Message-ID: <20111001002502.5B5AF47AFE@hg.openjdk.java.net> Changeset: ff0a3d78e7a2 Author: schien Date: 2011-09-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/ff0a3d78e7a2 Added tag jdk8-b04 for changeset acbcadef0b21 ! .hgtags Changeset: d7b8192e7277 Author: schien Date: 2011-09-15 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/d7b8192e7277 Added tag jdk8-b05 for changeset ff0a3d78e7a2 ! .hgtags Changeset: c114306576dc Author: katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/c114306576dc Added tag jdk8-b06 for changeset d7b8192e7277 ! .hgtags Changeset: de4794dd69c4 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/de4794dd69c4 Added tag jdk8-b07 for changeset c114306576dc ! .hgtags From john.coomes at oracle.com Fri Sep 30 17:25:10 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 01 Oct 2011 00:25:10 +0000 Subject: hg: hsx/hotspot-main/jaxws: 4 new changesets Message-ID: <20111001002510.6E1D947AFF@hg.openjdk.java.net> Changeset: 7d5d91fddbce Author: schien Date: 2011-09-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/7d5d91fddbce Added tag jdk8-b04 for changeset 3f6f08163331 ! .hgtags Changeset: acffff22a946 Author: schien Date: 2011-09-15 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/acffff22a946 Added tag jdk8-b05 for changeset 7d5d91fddbce ! .hgtags Changeset: 134b0debf7b0 Author: katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/134b0debf7b0 Added tag jdk8-b06 for changeset acffff22a946 ! .hgtags Changeset: 1c9d4f59acf8 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/1c9d4f59acf8 Added tag jdk8-b07 for changeset 134b0debf7b0 ! .hgtags From john.coomes at oracle.com Fri Sep 30 17:41:13 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 01 Oct 2011 00:41:13 +0000 Subject: hg: hsx/hotspot-main/langtools: 16 new changesets Message-ID: <20111001004159.2E80347B02@hg.openjdk.java.net> Changeset: 5304c2a17d4b Author: schien Date: 2011-09-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/5304c2a17d4b Added tag jdk8-b04 for changeset 5df63fd8fa64 ! .hgtags Changeset: 4e754e4b0a52 Author: schien Date: 2011-09-15 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/4e754e4b0a52 Added tag jdk8-b05 for changeset 5304c2a17d4b ! .hgtags Changeset: b86277584776 Author: mcimadamore Date: 2011-08-31 16:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/b86277584776 7085024: internal error; cannot instantiate Foo Summary: Types.isConvertible does not handle erroneous types correctly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/7085024/T7085024.java + test/tools/javac/7085024/T7085024.out Changeset: d0257833498e Author: mcimadamore Date: 2011-08-31 16:15 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/d0257833498e 7079713: javac hangs when compiling a class that references a cyclically inherited class Summary: Types.membersClosure needs to handle pathological cases of cyclic inheritance Reviewed-by: jjg, jjh ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/7079713/TestCircularClassfile.java Changeset: f85d980faaf8 Author: jjg Date: 2011-08-31 15:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/f85d980faaf8 7074416: Regression: JSR199: javac doesn't unwrap clientcodewrapper objects Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/share/classes/javax/tools/JavaCompiler.java ! test/tools/javac/TryWithResources/UnusedResourcesTest.java ! test/tools/javac/diags/Example.java ! test/tools/javac/processing/errors/TestSuppression.java Changeset: 04f983e3e825 Author: ksrini Date: 2011-09-01 09:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/04f983e3e825 7073631: (javac) javac parser improvements for error position reporting Summary: JavacParser improvements for NetBeans, improved by LangTools. Reviewed-by: mcimadamore, jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! test/tools/javac/TryWithResources/BadTwr.out ! test/tools/javac/TryWithResources/DuplicateResourceDecl.out ! test/tools/javac/TryWithResources/ResourceInterface.out ! test/tools/javac/TryWithResources/TwrFlow.out ! test/tools/javac/TryWithResources/TwrLint.out ! test/tools/javac/TryWithResources/TwrOnNonResource.out ! test/tools/javac/diags/examples/EmptyCharLiteral.java + test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: a45d78d26450 Author: jjh Date: 2011-09-01 14:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a45d78d26450 7086071: tools/javac/7079713/TestCircularClassfile.java fails on windows Summary: delete file before renaming another file to it Reviewed-by: jjg ! test/tools/javac/7079713/TestCircularClassfile.java Changeset: 02b8381781ab Author: ksrini Date: 2011-09-02 07:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/02b8381781ab 7024096: Stack trace has invalid line numbers Reviewed-by: jjg, darcy Contributed-by: bruce.chapman.nz at gmail.com ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/jvm/T7024096.java Changeset: ec27e5befa53 Author: mcimadamore Date: 2011-09-02 17:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/ec27e5befa53 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper Summary: Missing override for toString() in ClientCodeUnwrapper.DiagnosticSourceUnwrapper Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java + test/tools/javac/api/7086261/T7086261.java Changeset: 1ee9f9a91e9c Author: jjg Date: 2011-09-09 17:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/1ee9f9a91e9c 7073508: Regression: NullPointerException at com.sun.tools.javac.code.Lint$AugmentVisitor.augment Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/annotations/T7043371.java + test/tools/javac/annotations/T7073477.java Changeset: 9aca3534ddf4 Author: lana Date: 2011-09-10 21:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/9aca3534ddf4 Merge Changeset: edd7d9bd32dd Author: jjg Date: 2011-09-12 11:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/edd7d9bd32dd 7068451: Regression: javac compiles fixed sources against previous, not current, version of generated sources Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java + test/tools/javac/file/T7068451.java Changeset: f1431cace56e Author: jjg Date: 2011-09-12 11:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/f1431cace56e Merge Changeset: d2422276f9da Author: lana Date: 2011-09-19 19:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/d2422276f9da Merge Changeset: 116980ecec5c Author: katleman Date: 2011-09-22 16:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/116980ecec5c Added tag jdk8-b06 for changeset d2422276f9da ! .hgtags Changeset: 9268bd271c6f Author: katleman Date: 2011-09-29 18:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/9268bd271c6f Added tag jdk8-b07 for changeset 116980ecec5c ! .hgtags From john.coomes at oracle.com Fri Sep 30 23:57:07 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 01 Oct 2011 06:57:07 +0000 Subject: hg: hsx/hsx23/hotspot: 18 new changesets Message-ID: <20111001065743.78FEF47B14@hg.openjdk.java.net> Changeset: 3f0cf875af83 Author: katleman Date: 2011-09-22 16:01 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/3f0cf875af83 Added tag jdk8-b06 for changeset 0db80d8e77fc ! .hgtags Changeset: 0663e7617095 Author: katleman Date: 2011-09-29 18:53 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/0663e7617095 Added tag jdk8-b07 for changeset 3f0cf875af83 ! .hgtags Changeset: 77e1a9153757 Author: jcoomes Date: 2011-09-16 21:35 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/77e1a9153757 7091545: hs23 - set hotspot version & build number Reviewed-by: tonyp, never, phh, jmasa ! make/hotspot_version Changeset: da0999c4b733 Author: dcubed Date: 2011-09-16 16:21 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/da0999c4b733 7071904: 4/4 HotSpot: Full Debug Symbols Summary: Add support for .debuginfo files for HSX libraries. Reviewed-by: poonam, dholmes, never ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/build_vm_def.sh ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile + make/solaris/makefiles/build_vm_def.sh ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/mapfile-vers ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make Changeset: 86cbe939f0c7 Author: dcubed Date: 2011-09-19 12:18 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/86cbe939f0c7 Merge Changeset: 3607aac85aa9 Author: kevinw Date: 2011-09-22 16:48 +0100 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/3607aac85aa9 7051189: Need to suppress info message if -xcheck:jni used with libjsig.so Reviewed-by: coleenp, minqi ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp + test/runtime/7051189/Xchecksig.sh Changeset: 5cceda753a4a Author: iveresov Date: 2011-09-19 15:21 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/5cceda753a4a 7091764: Tiered: enable aastore profiling Summary: Turn on aastore profiling Reviewed-by: jrose, twisti ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp Changeset: 075ea0ed9e7c Author: kvn Date: 2011-09-20 08:39 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/075ea0ed9e7c 7081842: assert(Compile::current()->unique() < (uint)MaxNodeLimit) failed: Node limit exceeded Summary: Add missing node limit check in IGVN optimizer Reviewed-by: iveresov, never ! make/linux/build.sh ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java ! src/share/vm/opto/phaseX.cpp Changeset: eda6988c0d81 Author: never Date: 2011-09-20 23:50 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/eda6988c0d81 7092236: java/util/EnumSet/EnumSetBash.java fails Reviewed-by: kvn, twisti, jrose ! src/share/vm/ci/ciEnv.cpp Changeset: f08d439fab8c Author: never Date: 2011-09-25 16:03 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/f08d439fab8c 7089790: integrate bsd-port changes Reviewed-by: kvn, twisti, jrose Contributed-by: Kurt Miller , Greg Lewis , Jung-uk Kim , Christos Zoulas , Landon Fuller , The FreeBSD Foundation , Michael Franz , Roger Hoover , Alexander Strange ! agent/make/Makefile + agent/src/os/bsd/BsdDebuggerLocal.c + agent/src/os/bsd/Makefile + agent/src/os/bsd/StubDebuggerLocal.c + agent/src/os/bsd/elfmacros.h + agent/src/os/bsd/libproc.h + agent/src/os/bsd/libproc_impl.c + agent/src/os/bsd/libproc_impl.h + agent/src/os/bsd/mapfile + agent/src/os/bsd/ps_core.c + agent/src/os/bsd/ps_proc.c + agent/src/os/bsd/salibelf.c + agent/src/os/bsd/salibelf.h + agent/src/os/bsd/symtab.c + agent/src/os/bsd/symtab.h + agent/src/os/bsd/test.c + agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdOopHandle.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/SharedObject.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/amd64/BsdAMD64CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/amd64/BsdAMD64ThreadContext.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/x86/BsdX86CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/x86/BsdX86ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd/BsdSignals.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_x86/BsdSignals.java + agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_x86/BsdX86JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java ! make/Makefile + make/bsd/Makefile + make/bsd/README + make/bsd/adlc_updater + make/bsd/build.sh + make/bsd/makefiles/adjust-mflags.sh + make/bsd/makefiles/adlc.make + make/bsd/makefiles/amd64.make + make/bsd/makefiles/arm.make + make/bsd/makefiles/build_vm_def.sh + make/bsd/makefiles/buildtree.make + make/bsd/makefiles/compiler1.make + make/bsd/makefiles/compiler2.make + make/bsd/makefiles/core.make + make/bsd/makefiles/cscope.make + make/bsd/makefiles/debug.make + make/bsd/makefiles/defs.make + make/bsd/makefiles/dtrace.make + make/bsd/makefiles/fastdebug.make + make/bsd/makefiles/gcc.make + make/bsd/makefiles/hp.make + make/bsd/makefiles/hp1.make + make/bsd/makefiles/i486.make + make/bsd/makefiles/ia64.make + make/bsd/makefiles/jsig.make + make/bsd/makefiles/jvmg.make + make/bsd/makefiles/jvmti.make + make/bsd/makefiles/launcher.make + make/bsd/makefiles/mapfile-vers-debug + make/bsd/makefiles/mapfile-vers-jsig + make/bsd/makefiles/mapfile-vers-product + make/bsd/makefiles/optimized.make + make/bsd/makefiles/ppc.make + make/bsd/makefiles/product.make + make/bsd/makefiles/profiled.make + make/bsd/makefiles/rules.make + make/bsd/makefiles/sa.make + make/bsd/makefiles/saproc.make + make/bsd/makefiles/shark.make + make/bsd/makefiles/sparc.make + make/bsd/makefiles/sparcWorks.make + make/bsd/makefiles/sparcv9.make + make/bsd/makefiles/tiered.make + make/bsd/makefiles/top.make + make/bsd/makefiles/vm.make + make/bsd/makefiles/zero.make + make/bsd/makefiles/zeroshark.make + make/bsd/platform_amd64 + make/bsd/platform_amd64.suncc + make/bsd/platform_i486 + make/bsd/platform_i486.suncc + make/bsd/platform_ia64 + make/bsd/platform_sparc + make/bsd/platform_sparcv9 + make/bsd/platform_zero.in ! make/cscope.make ! make/defs.make ! make/linux/makefiles/arm.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/ppc.make ! make/sa.files ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make ! src/cpu/x86/vm/bytes_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/copy_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/jni_x86.h ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/zero/vm/bytes_zero.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/cpu/zero/vm/interp_masm_zero.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/cpu/zero/vm/vm_version_zero.cpp + src/os/bsd/vm/attachListener_bsd.cpp + src/os/bsd/vm/c1_globals_bsd.hpp + src/os/bsd/vm/c2_globals_bsd.hpp + src/os/bsd/vm/chaitin_bsd.cpp + src/os/bsd/vm/decoder_bsd.cpp + src/os/bsd/vm/dtraceJSDT_bsd.cpp + src/os/bsd/vm/globals_bsd.hpp + src/os/bsd/vm/interfaceSupport_bsd.hpp + src/os/bsd/vm/jsig.c + src/os/bsd/vm/jvm_bsd.cpp + src/os/bsd/vm/jvm_bsd.h + src/os/bsd/vm/mutex_bsd.cpp + src/os/bsd/vm/mutex_bsd.inline.hpp + src/os/bsd/vm/osThread_bsd.cpp + src/os/bsd/vm/osThread_bsd.hpp + src/os/bsd/vm/os_bsd.cpp + src/os/bsd/vm/os_bsd.hpp + src/os/bsd/vm/os_bsd.inline.hpp + src/os/bsd/vm/os_share_bsd.hpp + src/os/bsd/vm/perfMemory_bsd.cpp + src/os/bsd/vm/stubRoutines_bsd.cpp + src/os/bsd/vm/threadCritical_bsd.cpp + src/os/bsd/vm/thread_bsd.inline.hpp + src/os/bsd/vm/vmError_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/launcher.script + src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/atomic_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/bsd_x86_32.ad + src/os_cpu/bsd_x86/vm/bsd_x86_32.s + src/os_cpu/bsd_x86/vm/bsd_x86_64.ad + src/os_cpu/bsd_x86/vm/bsd_x86_64.s + src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/copy_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/globals_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/os_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/prefetch_bsd_x86.inline.hpp + src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp + src/os_cpu/bsd_x86/vm/thread_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp + src/os_cpu/bsd_x86/vm/vm_version_bsd_x86.cpp + src/os_cpu/bsd_zero/vm/assembler_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/atomic_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/globals_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/orderAccess_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/os_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/prefetch_bsd_zero.inline.hpp + src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/thread_bsd_zero.cpp + src/os_cpu/bsd_zero/vm/thread_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp + src/os_cpu/bsd_zero/vm/vm_version_bsd_zero.cpp ! src/os_cpu/linux_zero/vm/globals_linux_zero.hpp ! src/share/vm/adlc/adlc.hpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oopsHierarchy.cpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/javaFrameAnchor.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/memprofiler.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/osThread.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/threadLocalStorage.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/accessFlags.cpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/bitMap.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/elfStringTable.cpp ! src/share/vm/utilities/elfStringTable.hpp ! src/share/vm/utilities/elfSymbolTable.cpp ! src/share/vm/utilities/elfSymbolTable.hpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/histogram.hpp ! src/share/vm/utilities/macros.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/preserveException.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/workgroup.hpp ! test/Makefile ! test/jprt.config ! test/runtime/6929067/Test6929067.sh Changeset: a92cdbac8b9e Author: kvn Date: 2011-09-26 10:24 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/a92cdbac8b9e 7081933: Use zeroing elimination optimization for large array Summary: Don't zero new typeArray during runtime call if the allocation is followed by arraycopy into it. Reviewed-by: twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: cb315dc80374 Author: never Date: 2011-09-29 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/cb315dc80374 7092278: "jmap -finalizerinfo" throws "sun.jvm.hotspot.utilities.AssertionFailure: invalid cp index 0 137" Reviewed-by: kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java + agent/src/share/classes/sun/jvm/hotspot/runtime/vmSymbols.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 098acdf97f09 Author: never Date: 2011-09-29 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/098acdf97f09 7096016: SA build still produces "arg list too long" errors Reviewed-by: kvn, never Contributed-by: volker.simonis at gmail.com ! make/linux/makefiles/sa.make ! make/sa.files ! make/solaris/makefiles/sa.make ! make/windows/makefiles/sa.make Changeset: dc45ae774613 Author: iveresov Date: 2011-09-29 23:09 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/dc45ae774613 7096639: Tiered: Incorrect counter overflow handling for inlined methods Summary: Enable invocation events for inlinees Reviewed-by: kvn ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/runtime/globals.hpp Changeset: ae839d1e7d4c Author: roland Date: 2011-09-30 13:47 +0200 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/ae839d1e7d4c 7096010: c2: running with +PrintOptoAssembly crashes the VM when $constanttablebase is used Summary: ADLC generates code to prepare the register string to be printed in a char array but then calls print without the char array as an argument. Reviewed-by: never ! src/share/vm/adlc/formssel.cpp Changeset: 5d871c1ff17c Author: iveresov Date: 2011-09-30 13:48 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/5d871c1ff17c Merge ! make/Makefile ! make/linux/makefiles/defs.make ! make/solaris/makefiles/defs.make ! src/os/linux/vm/os_linux.cpp Changeset: da883b9e6d37 Author: jcoomes Date: 2011-09-30 18:27 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/da883b9e6d37 Merge ! .hgtags - agent/src/os/solaris/dbx/Makefile - agent/src/os/solaris/dbx/README - agent/src/os/solaris/dbx/README-commands.txt - agent/src/os/solaris/dbx/helloWorld.cpp - agent/src/os/solaris/dbx/proc_service_2.h - agent/src/os/solaris/dbx/shell_imp.h - agent/src/os/solaris/dbx/svc_agent_dbx.cpp - agent/src/os/solaris/dbx/svc_agent_dbx.hpp - agent/src/os/win32/BasicList.hpp - agent/src/os/win32/Buffer.cpp - agent/src/os/win32/Buffer.hpp - agent/src/os/win32/Dispatcher.cpp - agent/src/os/win32/Dispatcher.hpp - agent/src/os/win32/Handler.hpp - agent/src/os/win32/IOBuf.cpp - agent/src/os/win32/IOBuf.hpp - agent/src/os/win32/LockableList.hpp - agent/src/os/win32/Makefile - agent/src/os/win32/Message.hpp - agent/src/os/win32/Monitor.cpp - agent/src/os/win32/Monitor.hpp - agent/src/os/win32/README-commands.txt - agent/src/os/win32/README.txt - agent/src/os/win32/Reaper.cpp - agent/src/os/win32/Reaper.hpp - agent/src/os/win32/SwDbgSrv.cpp - agent/src/os/win32/SwDbgSrv.dsp - agent/src/os/win32/SwDbgSrv.dsw - agent/src/os/win32/SwDbgSub.cpp - agent/src/os/win32/SwDbgSub.dsp - agent/src/os/win32/initWinsock.cpp - agent/src/os/win32/initWinsock.hpp - agent/src/os/win32/ioUtils.cpp - agent/src/os/win32/ioUtils.hpp - agent/src/os/win32/isNT4.cpp - agent/src/os/win32/isNT4.hpp - agent/src/os/win32/libInfo.cpp - agent/src/os/win32/libInfo.hpp - agent/src/os/win32/nt4internals.cpp - agent/src/os/win32/nt4internals.hpp - agent/src/os/win32/ports.h - agent/src/os/win32/procList.cpp - agent/src/os/win32/procList.hpp - agent/src/os/win32/serverLists.cpp - agent/src/os/win32/serverLists.hpp - agent/src/os/win32/toolHelp.cpp - agent/src/os/win32/toolHelp.hpp - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxOopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/sparc/DbxSPARCThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/x86/DbxX86ThreadFactory.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/AddressDataSource.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/DLL.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/TestHelloWorld.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugInfoBuilder.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32CDebugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntry.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32LDTEntryConstants.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32OopHandle.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Thread.java - agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32ThreadContext.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64RegisterMap.java - make/solaris/makefiles/mapfile-vers-nonproduct - src/share/vm/runtime/reflectionCompat.hpp Changeset: 49ed7eacfd16 Author: jcoomes Date: 2011-09-30 18:27 -0700 URL: http://hg.openjdk.java.net/hsx/hsx23/hotspot/rev/49ed7eacfd16 Added tag hs23-b01 for changeset da883b9e6d37 ! .hgtags