Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Sep 13 17:05:21 PDT 2011


Thank you, Tom

I will add the comment.

Vladimir

Tom Rodriguez wrote:
> The method_comparator changes should include a comment indicating that this was done to avoid a problem with older Microsoft compilers.  Otherwise it looks good.
> 
> tom
> 
> On Sep 13, 2011, at 4:31 PM, Vladimir Kozlov wrote:
> 
>> http://cr.openjdk.java.net/~kvn/7090259/webrev
>>
>> 7090259: Fix hotspot sources to build with old compilers
>>
>> Fixed warnings which prevent building VM with old compilers. Used non-template method_comparator() in sort_methods() since vs2003 generates incorrect optimized code for it. Added -xwe compilation flag. Tested with 5.7, 5.8 and 5.10 Sun C++.
>>
>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since Tony fixed it already there.
>>
>> Thanks,
>> Vladimir
> 


More information about the hotspot-dev mailing list