Request for reviews (S): 7090259: Fix hotspot sources to build with old compilers

Bengt Rutisson bengt.rutisson at oracle.com
Wed Sep 14 00:36:14 PDT 2011


Hi again,

> Also, how long will we be supporting vs2003? I was under the 
> impression that we had switched to vs2010 even for JDK6. Clearly I was 
> wrong. Does that mean that we will keep vs2003 for the duration of 
> JDK6 and thus implicitly have that as a build requirement for JDK7 as 
> long as we are using the express model?

I realized that I did know about vs2003 being the compiler for JDK6. 
Sorry for the noise.

I am still interested in understanding what templates to avoid with vs2003.

Thanks
Bengt

>
>
> Bengt
>
> On 2011-09-14 01:31, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/7090259/webrev
>>
>> 7090259: Fix hotspot sources to build with old compilers
>>
>> Fixed warnings which prevent building VM with old compilers. Used 
>> non-template method_comparator() in sort_methods() since vs2003 
>> generates incorrect optimized code for it. Added -xwe compilation 
>> flag. Tested with 5.7, 5.8 and 5.10 Sun C++.
>>
>> I will remove g1ErgoVerbose.hpp changes and push to hotspot-gc since 
>> Tony fixed it already there.
>>
>> Thanks,
>> Vladimir
>



More information about the hotspot-dev mailing list