Merging BSDPort into HotSpot mainline

[Tom Rodriguez]

>>> 
>>>>> src/os_cpu/bsd_x86/vm/bsd_x86_32.s:
>>>>> src/os_cpu/bsd_x86/vm/bsd_x86_64.s:
>>>>> 
>>>>> + #ifdef __APPLE__
>>>>> +         .align  4
>>>>> + #else
>>>>>      .align  16
>>>>> + #endif
>>>>> 
>>>>> Maybe we should use a ALIGN macro instead.
>>>> 
>>>> Maybe.  I'm not sure I even understand the purpose of the change.  It seems pretty spurious.
>>> 
>>> IIRC, Apple's assembler .align directive takes a power of two -- i.e., .align 4^2
>> 
>> Ok.  Why isn't it just using p2align which appears to have exactly the same meaning?
> 
> I don't see any reason not to use p2align. I believe the original intent (3+ years ago, my memory is hazy) was only to call out the Apple changes more explicitly.
> 
>> And why is the second one needed since the next function starts with p2align 4?  
> 
> Ah -- I hadn't seen the context. Then yes, it's spurious. The duplicate may be a merge artifact, and other instances could simply be replaced.
> 
>> Why would BSD want 16^2 alignment anyway?
> 
> Apple is unique in its handling of .align.

I realized that afterwards.  I'll shift the code to use p2align uniformly since that will do the right thing everywhere.

tom

> 
> Cheers,
> -landonf
>