Code review request: 7191124 Optimized build is broken due to inconsistent use of DEBUG_ONLY and NOT_PRODUCT macros in NMT

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Aug 14 10:24:18 PDT 2012


We have defined format INTPTR_FORMAT for printing addresses, use it instead of 
%lx and remove cast:

+     err_msg("Should not reach here, pointer addr = [%lx], flags = [%x]",
+            (unsigned long)cur_vm->addr(), cur_vm->flags()));

Vladimir

Zhengyu Gu wrote:
> When I changed MemTracker::print_tracker_stats() method from DEBUG_ONLY 
> to NOT_PRODUCT, I did not properly update all references, which caused 
> the build failure.  Please review the fix.
> 
> 
> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7191124
> Webrev: http://cr.openjdk.java.net/~zgu/7191124/webrev.00/
> 
> Thanks,
> 
> -Zhengyu


More information about the hotspot-dev mailing list