RFR (S): 7192916: Hotspot development launcher should use DYLD_LIBRARY_PATH on OS X

David Holmes david.holmes at oracle.com
Wed Aug 22 01:05:13 PDT 2012


On 22/08/2012 5:57 PM, Staffan Larsen wrote:
>
> On 22 aug 2012, at 03:10, David Holmes<David.Holmes at oracle.com>  wrote:
>
>> On 21/08/2012 11:57 PM, Staffan Larsen wrote:
>>> I prefer the earlier version since it's easier to read. New version with correct indentation:
>>>
>>> http://cr.openjdk.java.net/~sla/7192916/webrev.01/
>>
>> Copyright year needs updating.
>
> According to Mark, we don't need to bother with that.

We always have for hotspot. I'm yet to see these automagic sweeps that 
are supposed to happen. Seems to me that given all our files are 
immediately available to the OpenJDK community then they must contain 
correct copyright information for that copyright to be effective. It was 
different when files only went public at GA.

Cheers,
David

>> Shouldn't this:
>>
>> 131         DYLD_LIBRARY_PATH="$SBP:$LD_LIBRARY_PATH"
>>
>> be using  $DYLD_LIBRARY_PATH ?
>
> Oh yes, absolutely. I'll fix and submit with that change.
>
> Thanks!
> /Staffan
>


More information about the hotspot-dev mailing list