Request for reviews (XS): 7194612: api/java_lang/invoke/MethodHandles/Lookup/index.html#ExceptionsTests[findVirtualNSME] fails w/ -esa

[Christian Thalinger]

On Aug 28, 2012, at 4:54 PM, David Holmes <David.Holmes at oracle.com> wrote:

> On 29/08/2012 3:47 AM, Christian Thalinger wrote:
>> [This is a patch from John Rose.]
>> 
>> http://cr.openjdk.java.net/~twisti/7194612
>> 
>> 7194612: api/java_lang/invoke/MethodHandles/Lookup/index.html#ExceptionsTests[findVirtualNSME] fails w/ -esa
>> Reviewed-by:
>> 
>> The assert checks for a valid reference kind before method resolution
>> throws the expected NoSuchMethodException.
>> 
>> src/share/classes/java/lang/invoke/MemberName.java
> 
> Why are hotspot developers reviewing Java class changes? Are core-libs also reviewing to ensure the Java code follows the right style/conventions?

It's changes to code strongly coupled to the JVM.  All JSR 292 Java code was written by JVM developers.  And I'm not aware of any style/conventions.

I will send the review request to core-libs next time as well.

-- Chris

> 
> David
>