Code review request: 7188594 Print statistic collected by NMT with VM flag
Zhengyu Gu
zhengyu.gu at oracle.com
Wed Aug 29 17:21:43 PDT 2012
Current PrintNMTStatistics is a diagnostic flag, you mean I should
change to 'product'?
Thanks,
-Zhengyu
On 8/29/2012 4:34 PM, Vladimir Kozlov wrote:
> About changes.
>
> You need to duplicate code in java.cpp in #else version of
> print_statistics() since you can collect this date in product VM. And
> move warning message to arguments.cpp (and switch off flag if NMT is
> off):
>
> if (!MemTracker::is_on() && PrintNMTStatistics) {
> warning(err_msg("Native memory tracking is off due to ",
> MemTracker::reason()));
> PrintNMTStatistics = false;
> }
>
> Vladimir
>
> Vladimir Kozlov wrote:
>> Hi, Zhengyu
>>
>> Could you give an example of output? I thought you need more changes
>> for this.
>>
>> thanks,
>> Vladimir
>>
>> Zhengyu Gu wrote:
>>> This is a simple RFE, that allows VM to dump collected native memory
>>>
>>> tracking data before exits.
>>>
>>> CR: http://bugs.sun.com/view_bug.do?bug_id=7188594
>>> Webrev: http://cr.openjdk.java.net/~zgu/7188594/webrev.00/
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
More information about the hotspot-dev
mailing list