Code review request: 7188594 Print statistic collected by NMT with VM flag

[Vladimir Kozlov]

Diagnostic flags are accessible in product VM with -XX:+UnlockDiagnosticVMOptions. So I am asking to add print NMT 
statistics for product VM since this statistics can be collected in product VM (NativeMemoryTracking is product flag). 
Right?

Vladimir

On 8/29/12 5:21 PM, Zhengyu Gu wrote:
> Current PrintNMTStatistics is a diagnostic flag, you mean I should change to 'product'?
>
> Thanks,
>
> -Zhengyu
>
> On 8/29/2012 4:34 PM, Vladimir Kozlov wrote:
>> About changes.
>>
>> You need to duplicate code in java.cpp in #else version of print_statistics() since you can collect this date in
>> product VM. And move warning message to arguments.cpp (and switch off flag if NMT is off):
>>
>> if (!MemTracker::is_on() && PrintNMTStatistics) {
>> warning(err_msg("Native memory tracking is off due to ", MemTracker::reason()));
>> PrintNMTStatistics = false;
>> }
>>
>> Vladimir
>>
>> Vladimir Kozlov wrote:
>>> Hi, Zhengyu
>>>
>>> Could you give an example of output? I thought you need more changes for this.
>>>
>>> thanks,
>>> Vladimir
>>>
>>> Zhengyu Gu wrote:
>>>> This is a simple RFE, that allows VM to dump collected native memory
>>>>
>>>> tracking data before exits.
>>>>
>>>> CR: http://bugs.sun.com/view_bug.do?bug_id=7188594
>>>> Webrev: http://cr.openjdk.java.net/~zgu/7188594/webrev.00/
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>>