RFR(S): Fix generation of malformed options for Projectcreator

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Tue Dec 4 03:44:56 PST 2012


I was hoping to never have to look at nmake-files again...

Your changes looks good. I have not verified by building vcproj-files 
though.
Ship it!
/Jesper


On 4/12/12 12:05 PM, Nils Eliasson wrote:
> Still missing reviews.
>
> //N
>
> Nils Eliasson skrev 2012-11-23 14:04:
>> Slight change. Moving placement of escaping tokens for a more 
>> enjoyable experience.
>>
>> http://cr.openjdk.java.net/~neliasso/8003934/webrev.02/
>>
>> //N
>>
>> Nils Eliasson skrev 2012-11-23 09:39:
>>> Preferably reviewed by someone with a little nmake experience.
>>>
>>> This fixes a bug which causes visual studio to throw errors when 
>>> trying to build hotspot.
>>>
>>> make/windows/projectfiles/common/Make sets up some options that is 
>>> passed as a string to ProjectCreator.java. That string gets 
>>> unmatched pairs of escaped quotation marks around the hotspot 
>>> release version. After closer examination that happens when a number 
>>> of vars and escaped quotation marks are appended together on a multi 
>>> line string append.
>>>
>>> This fixes removes unnecessary (and potentially bad) quotation 
>>> marks, simplifies the option creation and creates the options with 
>>> escaping characters on the same line.
>>>
>>> http://cr.openjdk.java.net/~neliasso/8003934/webrev.01/
>>>
>>> Thanks,
>>> Nils Eliasson
>>
>



More information about the hotspot-dev mailing list