RFR: Some build fixes for gcc4.7

[David Holmes]

On 7/12/2012 9:40 AM, Coleen Phillimore wrote:
>
> The changes to binaryTreeDictionary.cpp are already in the hotspot-gc
> repository and will/have been pushed up to main already. They should
> already be in hotspot-comp.

Unfortunately there has been a bit of a lag between the two sets of 
fixes. :(

> Which compiler complains about the library_call.cpp changes? I have an
> unstable ubuntu 12.10 system in order to run with gcc 4.7.2 and this
> file compiles fine for me as is.

Even thought it presently compiles fine it is obviously "wrong" and 
should be fixed IMHO.

Cheers,
David

> Thanks,
> Coleen
>
>
> On 12/06/2012 03:24 PM, Roman Kennke wrote:
>> I posted part of this before in hotspot-gc-dev, without any reply yet.
>> (http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2012-November/005327.html)
>>
>>
>>
>> In any case, here is a more complete patch relating to build failures
>> with GCC 4.7. It's basically:
>>
>> - Some more this-> qualifiers in binaryTreeDictionary.cpp (other such
>> qualifiers have been added before, those here probably slipped through
>> because they're only in asserts and compiled in debug builds.
>> - In library_call.cpp some return false should really be return NULL.
>> Also improves consistency in this code (other return statements in the
>> same method correctly return NULL).
>>
>>
>> Ok to go in?
>>
>> http://cr.openjdk.java.net/~rkennke/gcc47/webrev.00/
>>
>> Regards,
>> Roman
>>
>>
>