RFR (M) #3 CR 8003985: Support @Contended annotation

Aleksey Shipilev aleksey.shipilev at oracle.com
Tue Dec 11 13:30:09 PST 2012


On 12/11/2012 02:44 AM, John Rose wrote:
> This is good.  I have some comments on it.

Ok, this is the updated webrev fixing most of John's comments:
  http://shipilev.net/pub/jdk/hotspot/contended/webrev-7/

Changes are:
  - ClassFileParser::_is_contended is gone
  - merged "privileged" machinery from John's patch into ClassFileParser
  - FieldInfo::type -> FieldInfo::allocation_type
  - two JVM options: -XX:+EnableContendedOnBCP, and
-XX:-EnableContendedOnCP added, so that @Contended is no-op for
non-privileged classes until you flip the switch

Testing:
  - built and tested on Linux x86_64
  - Test8003985 works with -XX:+EnableContendedOnCP
  - JPRT build is OK on most platforms, testing undergoing

John, can you confirm it looks ok for you? Otherwise, I'll make more
changes tomorrow.

-Aleksey.


More information about the hotspot-dev mailing list