Review request for: JDK-8004728 Add hotspot support for parameter reflection

[David Holmes]

Hi Erik,

On 12/12/2012 9:18 AM, Eric McCorkle wrote:
> Apologies if this has already come across the list; it appears that it
> didn't get through for some reason.
>
> Please review the implementation of the following new feature:
> https://jbs.oracle.com/bugs/browse/JDK-8004728
>
>
> The open webrev is here:
> http://oklahoma.us.oracle.com/~cphillim/webrev/8004728/

Neither of the links above are available to non-Oracle OpenJDK community 
members. Please transfer the webrev to cr.openjdk.java.net - thanks.

The bug is available at:

http://bugs.sun.com/view_bug.do?bug_id=8004728

but contains no useful information.

> Summary:
>
> This is the VM side of the implementation of method parameter
> reflection.  The implementation has been tested by building and running
> regression tests with javac hardwired to produce classfiles containing
> MethodParameters attributes.

Just a superficial comment after a quick skim, we tend not to use types 
like u4 in general code. So for example in jvm.cpp and 
reflection.hpp/cpp we would not use it there.

I assume no space is allocated for method parameter information if none 
is needed?

> It will be further tested as part of the testing for the Reflection API
> side of the implementation of this feature.
>
> The specification of the feature is attached to the new feature request
> above.

The Jira attachment is not available outside of Oracle. Please provide a 
link to a publicly accessible document.

Thanks,
David

>
> Thanks,
> Eric