Request for review 8004883: NPG: clean up anonymous class fix
Coleen Phillimore
coleen.phillimore at oracle.com
Wed Dec 12 07:58:27 PST 2012
I'll revert the library_call change because it was contributed by
someone else. I didn't realize there was a bug already, thanks David.
Coleen
On 12/11/2012 9:18 PM, David Holmes wrote:
> On 12/12/2012 9:13 AM, Coleen Phillimore wrote:
>>
>> On 12/11/2012 06:12 PM, Stefan Karlsson wrote:
>>> Looks good. Thanks for doing this as a separate cleanup.
>>>
>>> Did you need these changes to get it to compile?
>>> http://cr.openjdk.java.net/~coleenp/8004883/src/share/vm/opto/library_call.cpp.udiff.html
>>>
>>>
>>
>> Yes, thanks!
>
> There is already a bug for that issue being worked on by Christian:
>
> https://jbs.oracle.com/bugs/browse/JDK-8004898
>
> Came in via a separate report on the compiler list
>
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2012-December/009116.html
>
>
> David
> -----
>
>> Coleen
>>>
>>> StefanK
>>>
>>> On 12/11/12 11:17 PM, Coleen Phillimore wrote:
>>>> Summary: Add klass_holder() to return either mirror or class_loader
>>>> depending on if the class is anonymous or not.
>>>>
>>>> Add code cleanup requested by John Rose and StefanK.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8004883/
>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8004883 (just
>>>> filed, might not show up yet).
>>>>
>>>> Ran nashorn tests again.
>>>>
>>>> Thanks,
>>>> Coleen
>>>>
>>>>
>>>>
>>>
>>
More information about the hotspot-dev
mailing list