RFR (M) #3 CR 8003985: Support @Contended annotation

[Coleen Phillimore]

Alexey,

Thank you for not increasing field space.   I had an additional 
comment.  Can you make the printing code from 4116-4142 be a function 
call?   The function parseClassFile is now 1190 lines long, but you 
don't want to make it worse if you don't have to. This badly needs 
refactoring in the future.   This function does too much.

Thanks,
Coleen

On 12/12/2012 3:00 PM, John Rose wrote:
> On Dec 12, 2012, at 7:08 AM, Aleksey Shipilev wrote:
>
>> he updated version is here:
>>   http://shipilev.net/pub/jdk/hotspot/contended/webrev-8/
>>
>> Testing:
>>   - built and tested on Linux x86_64
>>   - Test8003985 passes on Linux x86_64
>>   - JPRT is acting corky today, will try to submit a job later
>>
>> Meanwhile, please take a look at the code.
> It's good.  Ship it!
>
> — John
>
> P.S. Your test is the fifth jtreg test to use the hack of grabbing the private field Unsafe.theUnsafe.  If there is an alternative to that, we should use it.  In particular, if jtreg allows test classes to be loaded on the boot class path, then the public method Unsafe.getUnsafe can be used, and that would be much cleaner.
>