FW: RFR (S): memory handling improvements

David Holmes david.holmes at oracle.com
Wed Dec 12 18:48:06 PST 2012


On 13/12/2012 2:39 AM, Vitaly Davidovich wrote:
> Why is the sys_classpath copied in the first place? Is there a chance it's
> modified while this code runs? Otherwise I don't see a reason for it, but I
> probably missed something.

That was my immediate reaction too - why the strdup? :) I don't see a 
reason for it either.

I can't comment on the GC code.

David
------

> Thanks
>
> Sent from my phone
> On Dec 12, 2012 11:30 AM, "Lindenmaier, Goetz"<goetz.lindenmaier at sap.com>
> wrote:
>
> Hi,
>
>
> =>  Sorry, now I fixed the link to the webrev.
>
> I found two fixes for memory handling in our (SAP) hotspot code and want
> to share this with you:
> http://cr.openjdk.java.net/~goetz/webrevs/webrev-mem/
>
> In classLoader.cpp there is a memory leak, easy to be fixed.
>
> In parNewGeneration we allocate the overflow list elements
> on an arena. This is faster to allocate and no free is necessary.  It
> performed
> better with our VM than malloc/free.
>
> I propose to change openJDK accordingly.
>
> Best regards,
>    Goetz Lindenmaier


More information about the hotspot-dev mailing list