Review request (S): 8005002: Crash because of a raw oop in ClassLoaderData::add_dependency

[Coleen Phillimore]

On 12/13/2012 5:28 AM, David Holmes wrote:
> Hi Stefan,
>
> On 13/12/2012 6:16 PM, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8005002/webrev.00/
>>
>> This is a fix for a crash seen the nightly comp testing in the test:
>> vm/mlvm/indy/stress/gc/lotsOfCallSites
>>
>> We have a raw oop while calling out to an allocation function that might
>> block for GC. If a GC enters, it might move the Object but will not
>> update the oop. Make sure that we wrap the oop in a handle before
>> calling the allocation function.
>
> Looks good to me.
>
> I guess CHECK_UNHANDLED_OOPS never got this one :(

Since CHECK_UNHANDLED_OOPs only works on solaris (the operator 
overloading turned out too hard to get to compile on linux), nobody 
probably ran it.   This option needs an overhaul.  I filed a bug on it.

Coleen

>
> Thanks,
> David
>
>> StefanK