Code review request: JDK-8005048,NMT: #loaded classes needs to just show the # defined classes

[Zhengyu Gu]

Thanks for review.

On 12/17/2012 3:53 PM, Coleen Phillimore wrote:
>
> Zhengyu,
> This looks good.  I have a couple of comments:
>
> http://cr.openjdk.java.net/~zgu/8005048/webrev.00/src/share/vm/services/memTrackWorker.cpp.udiff.html 
>
>
> Looks like number_of_classes is still a 'long' in the declaration of 
> the function at_sync_point() instead of jint.
>
Yes, I missed here and a few other places. I will change them to "int"

> instanceKlass.*
>
> I think the number of classes might be generally useful and not using 
> lots of space in code or footprint, so I don't think it is worth 
> having it conditionalized with INCLUDE_NMT.
>
I will consult embedded team on this.

Thanks,

-Zhengyu

> Thanks,
> Coleen
>
>
> On 12/17/2012 03:11 PM, Zhengyu Gu wrote:
>> Current NMT implementation reports number of loaded classes at query 
>> time, but number of defined classes is what is expected.
>>
>> This changset reflects two major changes:
>>
>> 1. It counts number of defined classes vs. number of loaded classes
>> 2. It counts number of defined classes for each generation, vs. 
>> counts at query time. In this way, the number of defined classes that 
>> NMT reports, should match the corresponding class metadata data. As 
>> the result, the data should be more accurate.
>>
>>
>> Webrev: http://cr.openjdk.java.net/~zgu/8005048/webrev.00/
>>
>>
>> Thanks,
>>
>> -Zhengyu
>