Code review request: CR 7141259 Native stack is missing in hs_err

Keith McGuigan keith.mcguigan at oracle.com
Thu Feb 2 08:28:54 PST 2012



On 2/2/2012 11:11 AM, Zhengyu Gu wrote:

> Please review
> Webrev: http://cr.openjdk.java.net/~zgu/7141259/webrev.00/

In Decoder::can_decode_C_frame_in_vm(), the 'single_threaded' variable 
is uninitialized.

Instead of checking and rechecking that variable for lock/unlock, use 
the MutexLockerEx with NULL if you're single-threaded (if you can), i.e.:

MutexLockerEx locker(_single_threaded ? _decoder_lock : NULL);

It's simpler and safer.

--
- Keith


More information about the hotspot-dev mailing list