RFR (S): 7143766: add ALT_JDK_IMAGE_DIR and improve test_jdk

[Christian Thalinger]

On Feb 9, 2012, at 9:43 AM, David Holmes wrote:

> On 9/02/2012 6:37 PM, Christian Thalinger wrote:
>> 
>> On Feb 9, 2012, at 3:32 AM, David Holmes wrote:
>> 
>>> Hi Christian,
>>> 
>>> On 8/02/2012 11:50 PM, Christian Thalinger wrote:
>>>> http://cr.openjdk.java.net/~twisti/7143766/
>>>> 
>>>> 7143766: add ALT_JDK_IMAGE_DIR and improve test_jdk
>>>> Reviewed-by:
>>>> 
>>>> I'd like to add the possibility to specify JDK_IMAGE_DIR via
>>>> ALT_JDK_IMAGE_DIR.
>>> 
>>> There's no need to add this, you can just set JDK_IMAGE_DIR
>> 
>> That's correct but only when you specify it on the command line not when you set it as env variable:
> 
> Also correct. :)
> 
> Seems a minor change and likely short-lived given the impending build changes in the pipeline. So okay by me.

Yeah, I hope not :-(  Thanks for the review.

-- Chris

> 
> David
> -----
> 
>> $ make help JDK_IMAGE_DIR=/foo | grep JDK_IMAGE_DIR
>> Makefile:401: target `/Xusage.txt' given more than once in the same rule.
>>   ALT_JDK_IMAGE_DIR - Directory to place JDK to copy
>>         JDK_IMAGE_DIR=/foo
>> 
>> $ JDK_IMAGE_DIR=/foo make help | grep JDK_IMAGE_DIR
>> Makefile:401: target `/Xusage.txt' given more than once in the same rule.
>>   ALT_JDK_IMAGE_DIR - Directory to place JDK to copy
>>         JDK_IMAGE_DIR=/Users/twisti/build/mlvm/hotspot/build/jdk-bsd-amd64
>> 
>> I guess my examples weren't good chosen.
>> 
>> -- Chris
>> 
>>> 
>>>> The changes for test_jdk make sure that the right VM is tested.  This
>>>> might not be the case when you are doing 64-bit builds on Solaris,
>>>> export the VM and do a test_jdk:
>>> 
>>> Hmmm. Not sure that launching the VM four times for a normal 32-bit build is really something to add. But then I don't think any regular build process (JDK control build, JPRT) actually uses the target you modified.
>>> 
>>> David
>>> -----
>>> 
>>>> $ make test_jdk LP64=1
>>>> INFO: no objcopy cmd found so cannot create .debuginfo files.
>>>> /export/twisti/build/hsx/hotspot-comp/hotspot/build/jdk-solaris/bin/java -server -version
>>>> java version "1.8.0-ea"
>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b24)
>>>> Java HotSpot(TM) Server VM (build 23.0-b12, mixed mode)
>>>> 
>>>> What you actually want is to run the just-built 64-bit VM, like:
>>>> 
>>>> $ make test_jdk LP64=1
>>>> INFO: no objcopy cmd found so cannot create .debuginfo files.
>>>> /export/twisti/build/hsx/hotspot-comp/hotspot/build/jdk-solaris/bin/java -d64 -server -Xinternalversion
>>>> Java HotSpot(TM) 64-Bit Server VM (23.0-b15-internal-jvmg) for solaris-amd64 JRE (1.8.0), built on Feb  8 2012 04:26:02 by "ct232829" with Sun Studio 12u1
>>>> /export/twisti/build/hsx/hotspot-comp/hotspot/build/jdk-solaris/bin/java -d64 -server -version
>>>> java version "1.8.0-ea"
>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b24)
>>>> Java HotSpot(TM) 64-Bit Server VM (build 23.0-b15-internal-jvmg, mixed mode)
>>>> 
>>>> I also added printing -Xinternalversion to test_jdk.  This makes it
>>>> easier to verify the installed VM is the one you just built (and want
>>>> to test).
>>>> 
>>>> make/Makefile
>>>> make/bsd/makefiles/defs.make
>>>> make/defs.make
>>>> 
>>