RFR (S): 7125793: MAC: test_gamma should always work

[Daniel D. Daugherty]

On 1/10/12 2:05 PM, James Melvin wrote:
> Hi Dan,
>
> Final webrev to reflect your comments...
>
> http://cr.openjdk.java.net/~jmelvin/7125793/webrev.02
>
> Minor changes this round:
>
>   make/bsd/makefiles/buildtree.make   # Fail gracefully on Apple BOOTDIR
>   make/bsd/makefiles/launcher.make    # Link with framework only on Mac
>   src/os/bsd/vm/os_bsd.cpp            # Just spelling fix

Thumbs up on the current version.

To close the loop on one of my earlier comments:

$ ls -l binaries/solsparc/jre/lib/sparc/hotspot
lrwxrwxrwx   1 nobody   nobody         6 Apr  1  2009 
binaries/solsparc/jre/lib/sparc/hotspot -> client

This symlink exists in JDK1.3.1, but I didn't find it in JDK1.4.0.

> Lastly, I wanted to reply to John Coomes comments earlier about the
> test_gamma script simplification. Although I also value economy of
> expression, in this case I think the use of more advanced shell
> constructs increases the time for fresh eyes to decipher. Given
> performance and such is not an issue, I'd prefer to keep the simpler
> version I'm proposing with this change on Mac OS X, to make it easier on
> future maintenance. This should be a model for the other platforms when
> we reconcile. I've attached the before and after copies should there be
> further comments on the simplified short script.

The attachments didn't come through because your e-mail went
through the OpenJDK list servers.

Just to be clear: I vote for the newer version. It is more
straight forward and has comments.

Dan


>
> Thanks,
>
> Jim
>
>
> On 1/9/12 6:37 PM, Daniel D. Daugherty wrote:
>> On 1/7/12 9:38 AM, James Melvin wrote:
>>> WEBREV:
>>> http://cr.openjdk.java.net/~jmelvin/7125793/webrev.01
>>
>> make/bsd/Makefile
>> No comments.
>>
>> make/bsd/makefiles/buildtree.make
>> No comments.
>>
>> make/bsd/makefiles/defs.make
>> Thanks for fixing this one for BSD platforms.
>>
>> make/bsd/makefiles/launcher.make
>> line 60: typo: 'inadvertenly' -> 'inadvertently'
>>
>> Sorry I missed this in my first review, but the addition
>> of '-framework CoreFoundation' to LFLAGS_LAUNCHER is
>> probably MacOS X specific. I think:
>>
>> ifeq ($(OS_VENDOR), Darwin)
>> else
>> endif
>>
>> will work in launcher.make also.
>>
>> make/bsd/makefiles/vm.make
>> No comments.
>>
>> src/os/bsd/vm/os_bsd.cpp
>> line 2544: typo: 'overriden' -> 'overridden'
>> line 2588: typo: 'overriden' -> 'overridden'
>>
>> Looks like old code line 2576 depended on the 'hotspot'
>> symlink to refer to either 'client' or 'server' or whatever
>> JVM you wanted to run. I'm fairly certain that the 'hotspot'
>> symlink was retired; I'm just not sure when.
>>
>> src/os/posix/launcher/java_md.c
>> No comments.
>>
>> Dan
>>
>>