Code and Design Feedback request: 7114376: tune system dictionary size

[Vitaly Davidovich]

Hi Karen,

Do you think it's worthwhile to assert that _sdgeneration is within array
bounds inside calculate_system dictionary_size? Precaution against a bad
change later on that would do the initial read outside the bounds.

Also, it seems that you can declare the prime sizes array as a static const
array inside the same calculate size function since it's only used there as
far as I can see.  You can then initialize it there without specifying size
and can compute its length via sizeof(array)/sizeof(array[0]) and don't
need the size DEFINE.  Not sure if that's against hotspot guidelines though.

Vitaly

Sent from my phone
On Jan 29, 2012 10:14 PM, "Karen Kinnear" <karen.kinnear at oracle.com> wrote:

> Final review please -
>
> I reduced this to just add the command-line flag
> -XX:PredictedLoadedClassCount=#
> and left the dynamic resizing for later.
>
> webrev: http://cr.openjdk.java.net/~acorn/7114376.02/webrev/
>
> Testing:
> Manual testing of command-line options, CDS, scimark.
> In parallel: JPRT, nsk, benchmarks
>
> thanks,
> Karen
>
> p.s. the following files did not change between webrev.01 and webrev.02
> agent/...
> globals.hpp
> vmStructs.cpp
>
> On Jan 27, 2012, at 6:13 PM, Karen Kinnear wrote:
>
> > Dan & David -
> >
> > Thank you both for the detailed reviews.
> >
> > I will make the changes suggested - but I will put the code changes on
> hold. I think
> > the best approach right now is to just add the command-line flag and
> then after
> > we get the permanent generation changes, rethink the loaded class cache
> storage
> > options - and do a whole lot more measurements than I am able to do in
> this timeframe -
> > even thanks to the help I have had.
> >
> > Details below,
> > thanks,
> > Karen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20120130/a3bcc2ec/attachment.html