Review request (S): 7140882 (Was: Re: Patch to fix build breakage with GCC 4.7)

[Deepak Bhole]

* Paul Hohensee <paul.hohensee at oracle.com> [2012-01-30 09:07]:
> Deepak, let me know if you'd like Author status on the HSX project.
> 

Hi Paul,

I have only posted a handful of patches to HS (probably 2-3). I usually
post for JDK. But if few is enough for HS author status.. sure! No
worries if not. I am happy as long as the fix goes in :)

Cheers,
Deepak

> Paul
> 
> On 1/30/12 7:17 AM, Bengt Rutisson wrote:
> >
> >Robert,
> >
> >On 2012-01-30 11:11, Robert Ottenhag wrote:
> >>Yes, I also agree on the fix (that s/false/NULL/ follows the
> >>rest of each function's fail control logic)
> >>
> >>Bengt, please create a bug and do a quick follow up post for
> >>proper bug review. There should be no problem pushing it through
> >>hotspot-rt at this point.
> >
> >I filed:
> >
> >7140882 Don't return booleans from methods returning pointers
> >http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7140882
> >
> >The push job is now in the queue.
> >
> >Deepak, I saw that you are an "author" for the JDK projects, but
> >not for the HSX project. Thus, I can't create the changeset as
> >your user. Instead I list you as "Contributed-by". That field only
> >supports email addresses. Here is what the changeset will look
> >like:
> >
> >changeset:   3021:f457154eee8b
> >tag:         tip
> >user:        brutisso
> >date:        Mon Jan 30 12:36:49 2012 +0100
> >files:       src/share/vm/oops/constantPoolOop.cpp
> >src/share/vm/opto/loopnode.cpp
> >description:
> >7140882: Don't return booleans from methods returning pointers
> >Summary: Changed "return false" to "return NULL"
> >Reviewed-by: dholmes, rottenha
> >Contributed-by: dbhole at redhat.com
> >
> >Bengt
> >
> >>
> >>/Robert
> >>
> >>On 01/30/2012 09:01 AM, Bengt Rutisson wrote:
> >>>
> >>>Hi Deepak and David,
> >>>
> >>>Looks good to me too. I can commit the fix, but since the
> >>>changes are to runtime code it might be best to push it
> >>>through the runtime repository, right?
> >>>
> >>>I am not sure about the state of hotspot-rt at the moment. Is
> >>>it open for hs23 bug fixes? Can I go ahead an push there? I
> >>>can also push it through the hotspot-gc repository if that is
> >>>ok.
> >>>
> >>>Bengt
> >>>
> >>>
> >>>
> >>>
> >>>On 2012-01-30 05:55, David Holmes wrote:
> >>>>Hi Deepak,
> >>>>
> >>>>Fix looks good to me. So you have my "approval" as a
> >>>>Reviewer but will need someone else to commit it for you -
> >>>>sorry.
> >>>>
> >>>>David
> >>>>
> >>>>On 28/01/2012 7:45 AM, Deepak Bhole wrote:
> >>>>>Hi,
> >>>>>
> >>>>>HotSpot currently fails to build with GCC 4.7 due to 2
> >>>>>points where it
> >>>>>is using boolean rather than NULL. GCC 4.6 treated it as a warning --
> >>>>>4.7 treats it as an error.
> >>>>>
> >>>>>Attached patch fixes the issue and makes it build again.
> >>>>>
> >>>>>Please feel free to commit if OK, or let me know if it needs re-work.
> >>>>>
> >>>>>Cheers,
> >>>>>Deepak
> >>>
> >>
> >>
> >