Code and Design Feedback request: 7114376: tune system dictionary size

[Daniel D. Daugherty]

On 1/30/12 11:35 AM, Karen Kinnear wrote:
> David et al,
>
> Latest webrev:
> http://cr.openjdk.java.net/~acorn/7114376.03/webrev/

Thumbs up!
Only naming suggestions and nits. Feel free to ignore.

agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java
     No comments.

agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java
     No comments.

src/share/vm/classfile/dictionary.cpp
     No comments.

src/share/vm/classfile/systemDictionary.hpp
     Now that these constants are all in the enum, it is more clear
     that your naming style is different than the existing stuff:

  539   enum Constants {
  540     _loader_constraint_size = 107,                     // number 
of entries in constraint table
  541     _resolution_error_size  = 107,                     // number 
of entries in resolution error table
  542     _invoke_method_size     = 139,                     // number 
of entries in invoke method table
  543     _nof_buckets            = 1009,                    // number 
of buckets in hash table for placeholders
  544     _olddefaultsdsize       = 1009,                    // backward 
compat for system dictionary size
  545     _primearraysize         = 8,                       // array of 
primes for system dictionary size
  546     _averagedepthgoal       = 3                        // goal for 
lookup length
  547   };

     _olddefaultsdsize => _old_default_sdsize
     _primearraysize   => _prime_array_size
     _averagedepthgoal => _average_depth_goal

     Of course, feel free to say "no more renaming!".

src/share/vm/classfile/systemDictionary.cpp
     nit line 68: one space of on '=' alignment
     nit line 69: can you indent those numbers? Inside the "System..." by
         two blanks would be great.

src/share/vm/runtime/globals.hpp
     No comments.

src/share/vm/runtime/vmStructs.cpp
     No comments.

src/share/vm/utilities/hashtable.hpp
     No comments.